Re: [PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

2017-06-17 Thread Pavel Machek
Hi! > > > This is quite a lot of boilerplate for that. Would it make sense to > > > provide helper function at least for this? > > > > Yes. I've been thinking of having helper functions for notifiers and > > sub-notifiers. Most of the receiver drivers are implementing exactly the > > same thing

Re: [PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

2017-06-17 Thread Pavel Machek
Hi! > > This is quite a lot of boilerplate for that. Would it make sense to > > provide helper function at least for this? > > Yes. I've been thinking of having helper functions for notifiers and > sub-notifiers. Most of the receiver drivers are implementing exactly the > same thing but with

Re: [PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

2017-06-17 Thread Pavel Machek
Hi! > These types devices aren't directly related to the sensor, but are > nevertheless handled by the smiapp driver due to the relationship of these > component to the main part of the camera module --- the sensor. > > Additionally, for the async sub-device registration to work, the notifier >

Re: [PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

2017-06-17 Thread Pavel Machek
Hi! > > > These types devices aren't directly related to the sensor, but are > > > nevertheless handled by the smiapp driver due to the relationship of these > > > component to the main part of the camera module --- the sensor. > > > > > > Additionally, for the async sub-device registration to

Re: [PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

2017-06-16 Thread Pavel Machek
Hi! > > > These types devices aren't directly related to the sensor, but are > > > nevertheless handled by the smiapp driver due to the relationship of these > > > component to the main part of the camera module --- the sensor. > > > > > > Additionally, for the async sub-device registration to

Re: [PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

2017-06-16 Thread Sakari Ailus
Hi Pavel, On Fri, Jun 16, 2017 at 02:42:42PM +0200, Pavel Machek wrote: > Hi! > > > These types devices aren't directly related to the sensor, but are > > nevertheless handled by the smiapp driver due to the relationship of these > > component to the main part of the camera module --- the

Re: [PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

2017-06-16 Thread Pavel Machek
Hi! > These types devices aren't directly related to the sensor, but are > nevertheless handled by the smiapp driver due to the relationship of these > component to the main part of the camera module --- the sensor. > > Additionally, for the async sub-device registration to work, the notifier >

Re: [PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

2017-06-16 Thread Sakari Ailus
Hi Pavel, On Fri, Jun 16, 2017 at 02:07:13PM +0200, Pavel Machek wrote: > Hi! > > > These types devices aren't directly related to the sensor, but are > > nevertheless handled by the smiapp driver due to the relationship of these > > component to the main part of the camera module --- the

Re: [PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

2017-06-16 Thread Pavel Machek
Hi! > These types devices aren't directly related to the sensor, but are > nevertheless handled by the smiapp driver due to the relationship of these > component to the main part of the camera module --- the sensor. > > Additionally, for the async sub-device registration to work, the notifier >

Re: [PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

2017-06-14 Thread kbuild test robot
Hi Sakari, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20170614] [cannot apply to robh/for-next v4.12-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

2017-06-14 Thread Sakari Ailus
These types devices aren't directly related to the sensor, but are nevertheless handled by the smiapp driver due to the relationship of these component to the main part of the camera module --- the sensor. Additionally, for the async sub-device registration to work, the notifier containing