Re: Adding a control for Sensor Orientation

2009-02-17 Thread Adam Baker
On Tuesday 17 February 2009, Hans Verkuil wrote: snip The tentative conclusion was that putting it in the v4l2_input struct was a good idea. I'm not sure I'd go as far as to call it even a tentative conclusion. I think the biggest stumbling block for now is how to handle Olivier Lorin's

Re: Adding a control for Sensor Orientation

2009-02-16 Thread Hans de Goede
kilg...@banach.math.auburn.edu wrote: huge snip Therefore, 1. Everyone seems to agree that the kernel module itself is not going to do things like rotate or flip data even if a given supported device always needs that done. However, this decision has a consequence: 2. Therefore, the

Re: Adding a control for Sensor Orientation

2009-02-16 Thread Hans de Goede
Hans Verkuil wrote: On Monday 16 February 2009 05:04:40 Trent Piepho wrote: On Sun, 15 Feb 2009, Mauro Carvalho Chehab wrote: On Sun, 15 Feb 2009 10:29:03 +0100 Hans de Goede hdego...@redhat.com wrote: I think we should also be able to detect 90 and 270 degree rotations. Or at the very

Re: Adding a control for Sensor Orientation

2009-02-16 Thread Hans Verkuil
kilg...@banach.math.auburn.edu wrote: huge snip Therefore, 1. Everyone seems to agree that the kernel module itself is not going to do things like rotate or flip data even if a given supported device always needs that done. However, this decision has a consequence: 2. Therefore,

Re: Adding a control for Sensor Orientation

2009-02-16 Thread Hans Verkuil
Hans Verkuil wrote: On Monday 16 February 2009 05:04:40 Trent Piepho wrote: On Sun, 15 Feb 2009, Mauro Carvalho Chehab wrote: On Sun, 15 Feb 2009 10:29:03 +0100 Hans de Goede hdego...@redhat.com wrote: I think we should also be able to detect 90 and 270 degree rotations. Or at the very

Re: Adding a control for Sensor Orientation

2009-02-16 Thread Hans de Goede
Hans Verkuil wrote: Hans Verkuil wrote: On Monday 16 February 2009 05:04:40 Trent Piepho wrote: On Sun, 15 Feb 2009, Mauro Carvalho Chehab wrote: On Sun, 15 Feb 2009 10:29:03 +0100 Hans de Goede hdego...@redhat.com wrote: I think we should also be able to detect 90 and 270 degree

Re: Adding a control for Sensor Orientation

2009-02-16 Thread Mauro Carvalho Chehab
On Mon, 16 Feb 2009 10:44:03 +0100 Hans de Goede hdego...@redhat.com wrote: I've discussed this with Laurent Pinchart (and other webcam driver authors) and the conclusion was that having a table of USB-ID's + DMI strings in the driver, and design an API to tell userspace to sensor is

Re: Adding a control for Sensor Orientation

2009-02-16 Thread Hans de Goede
Mauro Carvalho Chehab wrote: On Mon, 16 Feb 2009 10:44:03 +0100 Hans de Goede hdego...@redhat.com wrote: I've discussed this with Laurent Pinchart (and other webcam driver authors) and the conclusion was that having a table of USB-ID's + DMI strings in the driver, and design an API to tell

Re: Adding a control for Sensor Orientation

2009-02-16 Thread Mauro Carvalho Chehab
On Mon, 16 Feb 2009 13:19:47 +0100 Hans de Goede hdego...@redhat.com wrote: Hans, Mauro Carvalho Chehab wrote: On Mon, 16 Feb 2009 10:44:03 +0100 Hans de Goede hdego...@redhat.com wrote: I've discussed this with Laurent Pinchart (and other webcam driver authors) and the

Re: Adding a control for Sensor Orientation

2009-02-16 Thread Hans de Goede
Mauro Carvalho Chehab wrote: On Mon, 16 Feb 2009 13:19:47 +0100 Hans de Goede hdego...@redhat.com wrote: Hans, Mauro Carvalho Chehab wrote: On Mon, 16 Feb 2009 10:44:03 +0100 Hans de Goede hdego...@redhat.com wrote: I've discussed this with Laurent Pinchart (and other webcam driver

Re: Adding a control for Sensor Orientation

2009-02-16 Thread Trent Piepho
On Mon, 16 Feb 2009, Hans Verkuil wrote: If you want to add two bits with mount information, feel free. But don't abuse them for pivot information. If you want that, then add another two bits for the rotation: Ok, this seems good. But if we want to distinguish between static sensor

Re: Adding a control for Sensor Orientation

2009-02-16 Thread Hans Verkuil
On Tuesday 17 February 2009 03:00:34 kilg...@banach.math.auburn.edu wrote: On Mon, 16 Feb 2009, Adam Baker wrote: Lots of snipping below so I hope I get the attributions correct. On Monday 16 February 2009, Hans Verkuil wrote: We are talking about a core change, so some careful thought

Re: Adding a control for Sensor Orientation

2009-02-15 Thread Hans de Goede
kilg...@banach.math.auburn.edu wrote: On Sat, 14 Feb 2009, Hans Verkuil wrote: On Saturday 14 February 2009 22:55:39 Hans de Goede wrote: Adam Baker wrote: Hi all, Hans Verkuil put forward a convincing argument that sensor orientation shouldn't be part of the buffer flags as then it

Re: Adding a control for Sensor Orientation

2009-02-15 Thread Hans de Goede
Trent Piepho wrote: On Sun, 15 Feb 2009, Hans de Goede wrote: Hans Verkuil wrote: On Sunday 15 February 2009 10:08:04 Hans de Goede wrote: kilg...@banach.math.auburn.edu wrote: On Sat, 14 Feb 2009, Hans Verkuil wrote: On Saturday 14 February 2009 22:55:39 Hans de Goede wrote: Adam Baker

Re: Adding a control for Sensor Orientation

2009-02-15 Thread Trent Piepho
On Sun, 15 Feb 2009, Hans de Goede wrote: Trent Piepho wrote: On Sun, 15 Feb 2009, Hans de Goede wrote: Hans Verkuil wrote: On Sunday 15 February 2009 10:08:04 Hans de Goede wrote: kilg...@banach.math.auburn.edu wrote: On Sat, 14 Feb 2009, Hans Verkuil wrote: On Saturday 14 February

Re: Adding a control for Sensor Orientation

2009-02-15 Thread Mauro Carvalho Chehab
On Sun, 15 Feb 2009 10:29:03 +0100 Hans de Goede hdego...@redhat.com wrote: I think we should also be able to detect 90 and 270 degree rotations. Or at the very least prepare for it. It's a safe bet to assume that webcams will arrive that can detect portrait vs landscape orientation.

Re: Adding a control for Sensor Orientation

2009-02-15 Thread hermann pitton
Hi guys, Am Sonntag, den 15.02.2009, 19:46 -0600 schrieb kilg...@banach.math.auburn.edu: On Sun, 15 Feb 2009, Trent Piepho wrote: On Sun, 15 Feb 2009, Hans de Goede wrote: Trent Piepho wrote: On Sun, 15 Feb 2009, Hans de Goede wrote: Hans Verkuil wrote: On Sunday 15 February 2009

Re: Adding a control for Sensor Orientation

2009-02-15 Thread Trent Piepho
On Sun, 15 Feb 2009 kilg...@banach.math.auburn.edu wrote: On Sun, 15 Feb 2009, Trent Piepho wrote: On Sun, 15 Feb 2009, Hans de Goede wrote: I think we should also be able to detect 90 and 270 degree rotations. Or at the very least prepare for it. It's a safe bet to assume that webcams

Re: Adding a control for Sensor Orientation

2009-02-15 Thread Trent Piepho
On Sun, 15 Feb 2009, Mauro Carvalho Chehab wrote: On Sun, 15 Feb 2009 10:29:03 +0100 Hans de Goede hdego...@redhat.com wrote: I think we should also be able to detect 90 and 270 degree rotations. Or at the very least prepare for it. It's a safe bet to assume that webcams will arrive

Re: Adding a control for Sensor Orientation

2009-02-15 Thread Hans Verkuil
On Monday 16 February 2009 05:04:40 Trent Piepho wrote: On Sun, 15 Feb 2009, Mauro Carvalho Chehab wrote: On Sun, 15 Feb 2009 10:29:03 +0100 Hans de Goede hdego...@redhat.com wrote: I think we should also be able to detect 90 and 270 degree rotations. Or at the very least prepare

Adding a control for Sensor Orientation

2009-02-14 Thread Adam Baker
Hi all, Hans Verkuil put forward a convincing argument that sensor orientation shouldn't be part of the buffer flags as then it would be unavailable to clients that use read() so it looks like implementing a read only control is the only appropriate option. It seems that Sensor Orientation is