Re: [PATCH] Support HVR-1200 analog video as a clone of HVR-1500. Tested, composite and s-video inputs.

[adding kernel mailing lists missed from my reply] Thank you, yes I think I cribbed too much from the 1500. I think the tuner part is not necessary: I have no analog over-the-air signal so I cannot test it, hence I have removed the tuner element from the patch (below). I have tested DVB-T

Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and flash properties

On Mon, Sep 18, 2017 at 4:56 PM, Sakari Ailus wrote: > Hi Rob, > > > Rob Herring wrote: >> >> On Mon, Sep 11, 2017 at 11:00:04AM +0300, Sakari Ailus wrote: >>> >>> Document optional lens-focus and flash properties for the smiapp driver. >>> >>> Signed-off-by: Sakari

[PATCH] ov9655: fix potential integer overflow

Add suffix ULL to constant 1 rather than casting the result of the operation in order to avoid a potential integer overflow. This constant is used in a context that expects an expression of type u64. Addresses-Coverity-ID: 1324146 Signed-off-by: Gustavo A. R. Silva

[PATCH] siano: fix a potential integer overflow

Add suffix ULL to constant 65535 in order to avoid a potential integer overflow. This constant is used in a context that expects an expression of type u64. Addresses-Coverity-ID: 1056806 Signed-off-by: Gustavo A. R. Silva --- drivers/media/common/siano/smsdvb-main.c | 2

Re: [RESEND PATCH v2 4/6] dt: bindings: as3645a: Improve label documentation, DT example

Hi Pavel, On 09/18/2017 10:54 PM, Pavel Machek wrote: > On Mon 2017-09-18 17:49:23, Sakari Ailus wrote: >> Hi Pavel, >> >> On Mon, Sep 18, 2017 at 12:56:55PM +0200, Pavel Machek wrote: >>> Hi! >>> Specify the exact label used if the label property is omitted in DT, as well as use label

Re: [PATCH v13 18/25] v4l: fwnode: Add a helper function to obtain device / integer references

Hi Sakari, I'm slowly starting to understand this. The example helped a lot. But I still have some questions, see below. On 09/15/2017 04:17 PM, Sakari Ailus wrote: > v4l2_fwnode_reference_parse_int_prop() will find an fwnode such that under > the device's own fwnode, it will follow child

Re: [PATCH 5/6] [media] go7007: Use common error handling code in go7007_snd_init()

On Mon, Sep 18, 2017 at 03:58:37PM +0200, SF Markus Elfring wrote: > diff --git a/drivers/media/usb/go7007/snd-go7007.c > b/drivers/media/usb/go7007/snd-go7007.c > index 68e421bf38e1..7ae4d03ed3f7 100644 > --- a/drivers/media/usb/go7007/snd-go7007.c > +++ b/drivers/media/usb/go7007/snd-go7007.c >

Re: [PATCH v5 3/3] media: ov7670: Add the s_power operation

Hi Wenyou, On Tue, Sep 19, 2017 at 08:45:09AM +0800, Wenyou Yang wrote: > Add the s_power operation which is responsible for manipulating the > power dowm mode through the PWDN pin and the reset operation through > the RESET pin. This is still broken: accessing controls through the sub-device

Re: [PATCH v13 18/25] v4l: fwnode: Add a helper function to obtain device / integer references

On 09/19/17 10:45, Sakari Ailus wrote: > Hi Hans, > > Thank you for the review. > > On Tue, Sep 19, 2017 at 10:31:41AM +0200, Hans Verkuil wrote: >> Hi Sakari, >> >> I'm slowly starting to understand this. The example helped a lot. But I >> still have >> some questions, see below. >> >> On

[GIT PULL FOR v4.15] cec: doc fixes, cec-gpio driver

This adds two CEC documentation fixes and the new cec-gpio driver. Regards, Hans The following changes since commit 9a45bf28bc39ff6ed45a008f7201289c8e9e60a6: media: max2175: Propagate the real error on devm_clk_get() failure (2017-08-27 18:14:11 -0400) are available in the git

Re: [PATCH v13 14/25] v4l: async: Allow binding notifiers to sub-devices

On 09/15/2017 04:17 PM, Sakari Ailus wrote: > Registering a notifier has required the knowledge of struct v4l2_device > for the reason that sub-devices generally are registered to the > v4l2_device (as well as the media device, also available through > v4l2_device). > > This information is not

Re: [PATCH v13 17/25] v4l: fwnode: Add a helper function for parsing generic references

On 09/15/2017 04:17 PM, Sakari Ailus wrote: > Add function v4l2_fwnode_reference_parse() for parsing them as async > sub-devices. This can be done on e.g. flash or lens async sub-devices that > are not part of but are associated with a sensor. > > Signed-off-by: Sakari Ailus

Re: [PATCH 4/6] [media] go7007: Use common error handling code in s2250_probe()

On Mon, Sep 18, 2017 at 03:57:21PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 18 Sep 2017 13:50:45 +0200 > > Adjust jump targets so that a bit of exception handling can be better > reused at the end of this function. > > This refactoring

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

On 09/19/17 11:20, Sergei Shtylyov wrote: > Hello! > > On 9/19/2017 10:33 AM, Hans Verkuil wrote: > >> From: Hans Verkuil >> >> Document the cec clock binding. >> >> Signed-off-by: Hans Verkuil >> Acked-by: Rob Herring >> --- >>

Re: [PATCH v13 05/25] v4l: fwnode: Support generic parsing of graph endpoints in a device

On 09/19/2017 10:20 AM, Sakari Ailus wrote: > Hi Hans, > > Thank you for the review. > > On Tue, Sep 19, 2017 at 10:03:27AM +0200, Hans Verkuil wrote: >> On 09/15/2017 04:17 PM, Sakari Ailus wrote: >>> Add two functions for parsing devices graph endpoints: >>>

Re: [PATCH v13 02/25] v4l: async: Remove re-probing support

Hi Sakari, (CC'ing Mike Turquette) Thank you for the patch. On Friday, 15 September 2017 17:17:01 EEST Sakari Ailus wrote: > Remove V4L2 async re-probing support. The re-probing support has been > there to support cases where the sub-devices require resources provided by > the main driver's

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

Hello! On 9/19/2017 10:33 AM, Hans Verkuil wrote: From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt |

Re: [PATCH v13 05/25] v4l: fwnode: Support generic parsing of graph endpoints in a device

Hi Hans, Thank you for the review. On Tue, Sep 19, 2017 at 10:03:27AM +0200, Hans Verkuil wrote: > On 09/15/2017 04:17 PM, Sakari Ailus wrote: > > Add two functions for parsing devices graph endpoints: > > v4l2_async_notifier_parse_fwnode_endpoints and > >

Re: [PATCH v13 05/25] v4l: fwnode: Support generic parsing of graph endpoints in a device

Hi Hans, On Tuesday, 19 September 2017 11:40:14 EEST Hans Verkuil wrote: > On 09/19/2017 10:20 AM, Sakari Ailus wrote: > > On Tue, Sep 19, 2017 at 10:03:27AM +0200, Hans Verkuil wrote: > >> On 09/15/2017 04:17 PM, Sakari Ailus wrote: > >>> Add two functions for parsing devices graph endpoints: >

[PATCH] [media] staging: atomisp: use clock framework for camera clocks

The Atom ISP driver initializes and configures PMC clocks which are already handled by the clock framework. Remove all legacy vlv2_platform_clock stuff and move to the clk API to avoid conflicts, e.g. with audio machine drivers enabling the MCLK for external codecs Tested-by: Carlo Caione

Re: [PATCH v13 05/25] v4l: fwnode: Support generic parsing of graph endpoints in a device

Hi Hans, On Tue, Sep 19, 2017 at 10:40:14AM +0200, Hans Verkuil wrote: > On 09/19/2017 10:20 AM, Sakari Ailus wrote: > > Hi Hans, > > > > Thank you for the review. > > > > On Tue, Sep 19, 2017 at 10:03:27AM +0200, Hans Verkuil wrote: > >> On 09/15/2017 04:17 PM, Sakari Ailus wrote: ... > >>>

Re: [PATCH v13 18/25] v4l: fwnode: Add a helper function to obtain device / integer references

Hi Hans, On Tue, Sep 19, 2017 at 11:21:50AM +0200, Hans Verkuil wrote: > On 09/19/17 10:45, Sakari Ailus wrote: > > Hi Hans, > > > > Thank you for the review. > > > > On Tue, Sep 19, 2017 at 10:31:41AM +0200, Hans Verkuil wrote: > >> Hi Sakari, > >> > >> I'm slowly starting to understand this.

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

On 9/19/2017 1:35 PM, Hans Verkuil wrote: From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4

Re: [PATCH v13 05/25] v4l: fwnode: Support generic parsing of graph endpoints in a device

Hi Laurent, On Tue, Sep 19, 2017 at 12:30:34PM +0300, Laurent Pinchart wrote: > Hi Hans, > > On Tuesday, 19 September 2017 11:40:14 EEST Hans Verkuil wrote: > > On 09/19/2017 10:20 AM, Sakari Ailus wrote: > > > On Tue, Sep 19, 2017 at 10:03:27AM +0200, Hans Verkuil wrote: > > >> On 09/15/2017

Re: [PATCH v13 17/25] v4l: fwnode: Add a helper function for parsing generic references

Hi Sakari, Thank you for the patch. On Friday, 15 September 2017 17:17:16 EEST Sakari Ailus wrote: > Add function v4l2_fwnode_reference_parse() for parsing them as async > sub-devices. This can be done on e.g. flash or lens async sub-devices that > are not part of but are associated with a

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

On 09/19/2017 01:59 PM, Hans Verkuil wrote: From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4

Re: [PATCH v13 07/25] rcar-vin: Use generic parser for parsing fwnode endpoints

Hi Laurent, On Tue, Sep 19, 2017 at 02:53:16PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Friday, 15 September 2017 17:17:06 EEST Sakari Ailus wrote: > > Instead of using driver implementation, use > > Same comment as for patch 06/25. Will fix. > > >

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

Marc Gonzalez writes: > On 18/09/2017 17:33, Måns Rullgård wrote: > >> Marc Gonzalez writes: >> >>> diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig >>> index d9ce8ff55d0c..f84923289964 100644 >>> --- a/drivers/media/rc/Kconfig >>> +++

Re: [PATCH v2 3/4] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

Hi Hans. Thanks for the response. On 19 September 2017 at 11:20, Hans Verkuil wrote: > On 09/19/17 11:50, Dave Stevenson wrote: >> Hi Eric. >> >> Thanks for the review. >> >> On 18 September 2017 at 19:18, Eric Anholt wrote: >>> Dave Stevenson

Re: [PATCH v13 11/25] v4l: async: Introduce helpers for calling async ops callbacks

Hi Sakari, Thank you for the patch. On Friday, 15 September 2017 17:17:10 EEST Sakari Ailus wrote: > Add three helper functions to call async operations callbacks. Besides > simplifying callbacks, this allows async notifiers to have no ops set, > i.e. it can be left NULL. > > Signed-off-by:

Re: [PATCH v13 21/25] smiapp: Add support for flash and lens devices

Hi Laurent, On Tue, Sep 19, 2017 at 03:08:25PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Friday, 15 September 2017 17:17:20 EEST Sakari Ailus wrote: > > Parse async sub-devices by using > > v4l2_subdev_fwnode_reference_parse_sensor_common(). > > > > These

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

Marc Gonzalez writes: > On 18/09/2017 17:33, Måns Rullgård wrote: > >> What have you changed compared to my original code? > > I forgot to mention one change you may not approve of, so we should > probably discuss it. > > Your driver supported an optional DT

Re: [PATCH v13 06/25] omap3isp: Use generic parser for parsing fwnode endpoints

Hi Laurent, Thanks for the review! On Tue, Sep 19, 2017 at 02:40:29PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Friday, 15 September 2017 17:17:05 EEST Sakari Ailus wrote: > > Instead of using driver implementation, use > > Did you mean s/using driver

Re: [PATCH v2 3/4] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

Hi Eric. Thanks for the review. On 18 September 2017 at 19:18, Eric Anholt wrote: > Dave Stevenson writes: >> diff --git a/drivers/media/platform/bcm2835/bcm2835-unicam.c >> b/drivers/media/platform/bcm2835/bcm2835-unicam.c >> new file mode

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

On 09/19/17 11:35, Sergei Shtylyov wrote: > On 9/19/2017 12:29 PM, Hans Verkuil wrote: > From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring ---

Re: [PATCH v13 01/25] v4l: fwnode: Move KernelDoc documentation to the header

Hi Sakari, Thank you for the patch. On Friday, 15 September 2017 17:17:00 EEST Sakari Ailus wrote: > In V4L2 the practice is to have the KernelDoc documentation in the header > and not in .c source code files. This consequently makes the V4L2 fwnode > function documentation part of the Media

Re: [PATCH v13 01/25] v4l: fwnode: Move KernelDoc documentation to the header

Hi Sakari, On Tuesday, 19 September 2017 14:10:37 EEST Sakari Ailus wrote: > On Tue, Sep 19, 2017 at 01:48:27PM +0300, Laurent Pinchart wrote: > > On Friday, 15 September 2017 17:17:00 EEST Sakari Ailus wrote: > >> In V4L2 the practice is to have the KernelDoc documentation in the > >> header and

Re: [PATCH v13 01/25] v4l: fwnode: Move KernelDoc documentation to the header

Hi Hans, On Tue, Sep 19, 2017 at 01:04:36PM +0200, Hans Verkuil wrote: > On 09/19/17 12:48, Laurent Pinchart wrote: > > Hi Sakari, > > > > Thank you for the patch. > > > > On Friday, 15 September 2017 17:17:00 EEST Sakari Ailus wrote: > >> In V4L2 the practice is to have the KernelDoc

Re: [PATCH v13 05/25] v4l: fwnode: Support generic parsing of graph endpoints in a device

Hi Laurent, On Tue, Sep 19, 2017 at 02:35:01PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. Thanks for the review! > > On Friday, 15 September 2017 17:17:04 EEST Sakari Ailus wrote: > > Add two functions for parsing devices graph endpoints: > >

Re: [PATCH v13 15/25] dt: bindings: Add a binding for flash LED devices associated to a sensor

Hi Laurent, On Tue, Sep 19, 2017 at 03:12:42PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Friday, 15 September 2017 17:17:14 EEST Sakari Ailus wrote: > > Camera flash drivers (and LEDs) are separate from the sensor devices in > > DT. In order to make an

Re: [PATCH] media: default for RC_CORE should be n

On Fri, Sep 8, 2017 at 6:39 PM, Stephen Hemminger wrote: > The Linus policy on Kconfig is that the default should be no > for all new devices. I.e the user rebuild a new kernel from an > old config should not by default get a larger kernel. > > Fixes: b4c184e506a4

Re: [PATCH v4] [DVB][FRONTEND] Added a new ioctl for optimizing frontend property set operation

Em Mon, 18 Sep 2017 05:35:45 -0400 Satendra Singh Thakur escreveu: > Hello Mr Chehab, > It seems that there is a mismatch among tab spacing > in local patch on my PC, the patch in email > and the patch in lkml site. > This is causing alignment problem. Even if I fix

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

On 9/19/2017 12:29 PM, Hans Verkuil wrote: From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

On 9/19/2017 1:07 PM, Hans Verkuil wrote: From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4

Re: [PATCH v2 3/4] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

On 09/19/17 11:50, Dave Stevenson wrote: > Hi Eric. > > Thanks for the review. > > On 18 September 2017 at 19:18, Eric Anholt wrote: >> Dave Stevenson writes: >>> diff --git a/drivers/media/platform/bcm2835/bcm2835-unicam.c >>>

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

On 09/19/17 12:15, Sergei Shtylyov wrote: > On 9/19/2017 1:07 PM, Hans Verkuil wrote: > >> From: Hans Verkuil >> >> Document the cec clock binding. >> >> Signed-off-by: Hans Verkuil >> Acked-by: Rob Herring

Re: [PATCH v13 01/25] v4l: fwnode: Move KernelDoc documentation to the header

Hi Hans, On Tuesday, 19 September 2017 14:04:36 EEST Hans Verkuil wrote: > On 09/19/17 12:48, Laurent Pinchart wrote: > > On Friday, 15 September 2017 17:17:00 EEST Sakari Ailus wrote: > >> In V4L2 the practice is to have the KernelDoc documentation in the header > >> and not in .c source code

Re: [PATCH v13 01/25] v4l: fwnode: Move KernelDoc documentation to the header

Hi Laurent, On Tue, Sep 19, 2017 at 02:14:39PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Tuesday, 19 September 2017 14:10:37 EEST Sakari Ailus wrote: > > On Tue, Sep 19, 2017 at 01:48:27PM +0300, Laurent Pinchart wrote: > > > On Friday, 15 September 2017 17:17:00 EEST Sakari Ailus

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

On 19/09/2017 11:48, Måns Rullgård wrote: > Did you test the NEC32 variant? I don't have anything that produces > such codes. I don't have a NEC32 IR remote control either. IIUC, NEC32 means 16-bit address and 16-bit command. I checked the RTL with a HW engineer. The HW block translates the

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

On 18/09/2017 17:33, Måns Rullgård wrote: > What have you changed compared to my original code? I forgot to mention one change you may not approve of, so we should probably discuss it. Your driver supported an optional DT property "linux,rc-map-name" to override the RC_MAP_EMPTY map. Since the

Re: [PATCH v13 07/25] rcar-vin: Use generic parser for parsing fwnode endpoints

Hi Sakari, Thank you for the patch. On Friday, 15 September 2017 17:17:06 EEST Sakari Ailus wrote: > Instead of using driver implementation, use Same comment as for patch 06/25. > v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints > of the device. > > Signed-off-by:

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

Marc Gonzalez writes: > On 19/09/2017 11:48, Måns Rullgård wrote: > >> Did you test the NEC32 variant? I don't have anything that produces >> such codes. > > I don't have a NEC32 IR remote control either. > > IIUC, NEC32 means 16-bit address and 16-bit command. >

Re: [PATCH v13 05/25] v4l: fwnode: Support generic parsing of graph endpoints in a device

On 09/19/17 12:00, Sakari Ailus wrote: > Hi Hans, > > On Tue, Sep 19, 2017 at 10:40:14AM +0200, Hans Verkuil wrote: >> On 09/19/2017 10:20 AM, Sakari Ailus wrote: >>> Hi Hans, >>> >>> Thank you for the review. >>> >>> On Tue, Sep 19, 2017 at 10:03:27AM +0200, Hans Verkuil wrote: On

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

On 09/19/17 12:42, Sergei Shtylyov wrote: > On 9/19/2017 1:35 PM, Hans Verkuil wrote: > From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring

Re: [PATCH v13 01/25] v4l: fwnode: Move KernelDoc documentation to the header

Hi Laurent, On Tue, Sep 19, 2017 at 01:48:27PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Friday, 15 September 2017 17:17:00 EEST Sakari Ailus wrote: > > In V4L2 the practice is to have the KernelDoc documentation in the header > > and not in .c source code

Re: [PATCH v13 06/25] omap3isp: Use generic parser for parsing fwnode endpoints

Hi Sakari, Thank you for the patch. On Friday, 15 September 2017 17:17:05 EEST Sakari Ailus wrote: > Instead of using driver implementation, use Did you mean s/using driver implementation/using a driver implementation/ (or perhaps "custom driver implementation") ? >

Re: [PATCH v13 09/25] omap3isp: Print the name of the entity where no source pads could be found

Hi Sakari, Thank you for the patch. On Friday, 15 September 2017 17:17:08 EEST Sakari Ailus wrote: > If no source pads are found in an entity, print the name of the entity. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil >

Re: [PATCH v13 08/25] omap3isp: Fix check for our own sub-devices

Hi Sakari, Thank you for the patch. On Friday, 15 September 2017 17:17:07 EEST Sakari Ailus wrote: > We only want to link sub-devices that were bound to the async notifier the > isp driver registered but there may be other sub-devices in the > v4l2_device as well. Check for the correct async

Re: [PATCH v13 21/25] smiapp: Add support for flash and lens devices

Hi Sakari, Thank you for the patch. On Friday, 15 September 2017 17:17:20 EEST Sakari Ailus wrote: > Parse async sub-devices by using > v4l2_subdev_fwnode_reference_parse_sensor_common(). > > These types devices aren't directly related to the sensor, but are > nevertheless handled by the smiapp

Re: [PATCH v13 15/25] dt: bindings: Add a binding for flash LED devices associated to a sensor

Hi Sakari, Thank you for the patch. On Friday, 15 September 2017 17:17:14 EEST Sakari Ailus wrote: > Camera flash drivers (and LEDs) are separate from the sensor devices in > DT. In order to make an association between the two, provide the > association information to the software. > >

Re: [PATCH v13 05/25] v4l: fwnode: Support generic parsing of graph endpoints in a device

Hi Sakari, On Tuesday, 19 September 2017 15:11:32 EEST Sakari Ailus wrote: > On Tue, Sep 19, 2017 at 02:35:01PM +0300, Laurent Pinchart wrote: > > On Friday, 15 September 2017 17:17:04 EEST Sakari Ailus wrote: > >> Add two functions for parsing devices graph endpoints: > >>

Re: [PATCH v13 01/25] v4l: fwnode: Move KernelDoc documentation to the header

On 09/19/17 12:48, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Friday, 15 September 2017 17:17:00 EEST Sakari Ailus wrote: >> In V4L2 the practice is to have the KernelDoc documentation in the header >> and not in .c source code files. This consequently makes the

Re: [PATCH v13 05/25] v4l: fwnode: Support generic parsing of graph endpoints in a device

Hi Sakari, Thank you for the patch. On Friday, 15 September 2017 17:17:04 EEST Sakari Ailus wrote: > Add two functions for parsing devices graph endpoints: > v4l2_async_notifier_parse_fwnode_endpoints and > v4l2_async_notifier_parse_fwnode_endpoints_by_port. The former iterates > over all

Re: [PATCH v13 12/25] v4l: async: Register sub-devices before calling bound callback

Hi Sakari, Thank you for the patch. On Friday, 15 September 2017 17:17:11 EEST Sakari Ailus wrote: > Register the sub-device before calling the notifier's bound callback. > Doing this the other way around is problematic as the struct v4l2_device > has not assigned for the sub-device yet and may

Re: [PATCH v13 13/25] v4l: async: Allow async notifier register call succeed with no subdevs

Hi Sakari, Thank you for the patch. On Friday, 15 September 2017 17:17:12 EEST Sakari Ailus wrote: > The information on how many async sub-devices would be bindable to a > notifier is typically dependent on information from platform firmware and > it's not driver's business to be aware of that.

Re: [PATCH v13 11/25] v4l: async: Introduce helpers for calling async ops callbacks

Hi Laurent, On Tue, Sep 19, 2017 at 03:01:14PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Friday, 15 September 2017 17:17:10 EEST Sakari Ailus wrote: > > Add three helper functions to call async operations callbacks. Besides > > simplifying callbacks, this

[PATCH] Fix for hanging si2168 in PCTV 292e, making the code match

[re-sending as plain text] Fix for hanging si2168 in PCTV 292e USB, making the code match the comment. Using firmware v4.0.11 the 292e would work once and then hang on subsequent attempts to view DVB channels, until physically unplugged and plugged back in. With this patch, the warm state

Re: [PATCH v13 21/25] smiapp: Add support for flash and lens devices

Hi Sakari, On Tuesday, 19 September 2017 15:20:34 EEST Sakari Ailus wrote: > On Tue, Sep 19, 2017 at 03:08:25PM +0300, Laurent Pinchart wrote: > > On Friday, 15 September 2017 17:17:20 EEST Sakari Ailus wrote: > >> Parse async sub-devices by using > >>

[PATCH v5] [DVB][FRONTEND] Modified the code related to FE_SET_PROPERTY ioctl

-Since all the properties in the func dtv_property_process_set are 4 bytes, We have added 2 new arguments u32 cmd and u32 data; in place of older argument struct dtv_property *tvp. -We have removed property validation in function dtv_property_process_set because most of the frontend drivers in

Re: [PATCH v13 06/25] omap3isp: Use generic parser for parsing fwnode endpoints

Hi Sakari, On Tuesday, 19 September 2017 15:43:26 EEST Sakari Ailus wrote: > On Tue, Sep 19, 2017 at 02:40:29PM +0300, Laurent Pinchart wrote: > > > @@ -2256,7 +2210,9 @@ static int isp_probe(struct platform_device *pdev) > > > > > > if (ret) > > > > > > return ret; > > > > > > -

Re: [PATCH v13 17/25] v4l: fwnode: Add a helper function for parsing generic references

Hi Laurent, On Tue, Sep 19, 2017 at 03:19:59PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Friday, 15 September 2017 17:17:16 EEST Sakari Ailus wrote: > > Add function v4l2_fwnode_reference_parse() for parsing them as async > > sub-devices. This can be done

[PATCH 5/6] media: dvb_frontend: better document the -EPERM condition

Two readonly ioctls can't be allowed if the frontend device is opened in read only mode. Explain why. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_frontend.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git

[PATCH 2/6] media: dvb_frontend: cleanup ioctl handling logic

Currently, there are two handlers for ioctls: - dvb_frontend_ioctl_properties() - dvb_frontend_ioctl_legacy() Despite their names, both handles non-legacy DVB ioctls. Besides that, there's no reason why to not handle all ioctls on a single handler function. So, merge them into a single

[PATCH 4/6] media: dvb_frontend.h: fix alignment at the cache properties

There are too much tabs on several properties, for no good reason. That sounds confusing while reading the struct, so adjust them. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_frontend.h | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH 6/6] media: dvb_frontend: fix return values for FE_SET_PROPERTY

There are several problems with regards to the return of FE_SET_PROPERTY. The original idea were to return per-property return codes via tvp->result field, and to return an updated set of values. However, that never worked. What's actually implemented is: - the FE_SET_PROPERTY implementation

[PATCH 1/6] media: dvb_frontend: cleanup dvb_frontend_ioctl_properties()

Use a switch() on this function, just like on other ioctl handlers and handle parameters inside each part of the switch. That makes it easier to integrate with the already existing ioctl handler function. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 3/6] media: dvb_frontend: get rid of proprierty cache's state

In the past, I guess the idea was to use state in order to allow an autofush logic. However, in the current code, it is used only for debug messages, on a poor man's solution, as there's already a debug message to indicate when the properties got flushed. So, just get rid of it for good.

[PATCH 2/3] [media] tc358743: Increase FIFO level to 300.

The existing fixed value of 16 worked for UYVY 720P60 over 2 lanes at 594MHz, or UYVY 1080P60 over 4 lanes. (RGB888 1080P60 needs 6 lanes at 594MHz). It doesn't allow for lower resolutions to work as the FIFO underflows. Using a value of 300 works for all resolutions down to VGA60, and the

[PATCH 1/3] [media] tc358743: Correct clock mode reported in g_mbus_config

Support for non-continuous clock had previously been added via device tree, but a comment and the value reported by g_mbus_config still stated that it wasn't supported. Remove the comment, and return the correct value in g_mbus_config. Signed-off-by: Dave Stevenson

[PATCH 0/3] [media] tc358743: Support for a wider range of inputs

Three minor changes to the TC358743 HDMI to CSI2 bridge chip driver. - Correct the clock mode reported via g_mbus_config to match that set. - Increase the FIFO level to allow resolutions lower than 720P60 to work. - Add settings for a new link frequency of 972Mbit/s. This allows 1080P50 UYVY to

[PATCH 3/3] [media] tc358743: Add support for 972Mbit/s link freq.

Adds register setups for running the CSI lanes at 972Mbit/s, which allows 1080P50 UYVY down 2 lanes. Signed-off-by: Dave Stevenson --- drivers/media/i2c/tc358743.c | 47 +++- 1 file changed, 33 insertions(+), 14

Re: [PATCH v13 17/25] v4l: fwnode: Add a helper function for parsing generic references

Hi Sakari, On Tuesday, 19 September 2017 16:04:53 EEST Sakari Ailus wrote: > On Tue, Sep 19, 2017 at 03:19:59PM +0300, Laurent Pinchart wrote: > > On Friday, 15 September 2017 17:17:16 EEST Sakari Ailus wrote: > > > Add function v4l2_fwnode_reference_parse() for parsing them as async > > >

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

+ Rob & Mark for the DT bindings question. On 19/09/2017 14:21, Måns Rullgård wrote: > Marc Gonzalez writes: > >> On 18/09/2017 17:33, Måns Rullgård wrote: >> >>> What have you changed compared to my original code? >> >> I forgot to mention one change you may not approve of, so we should >>

Re: [PATCH v13 14/25] v4l: async: Allow binding notifiers to sub-devices

Hi Sakari, Thank you for the patch. On Friday, 15 September 2017 17:17:13 EEST Sakari Ailus wrote: > Registering a notifier has required the knowledge of struct v4l2_device > for the reason that sub-devices generally are registered to the > v4l2_device (as well as the media device, also

Re: [PATCH v13 11/25] v4l: async: Introduce helpers for calling async ops callbacks

Hi Sakari, On Tuesday, 19 September 2017 15:13:11 EEST Sakari Ailus wrote: > On Tue, Sep 19, 2017 at 03:01:14PM +0300, Laurent Pinchart wrote: > > On Friday, 15 September 2017 17:17:10 EEST Sakari Ailus wrote: > >> Add three helper functions to call async operations callbacks. Besides > >>

Re: [PATCH v13 06/25] omap3isp: Use generic parser for parsing fwnode endpoints

On Tue, Sep 19, 2017 at 02:40:29PM +0300, Laurent Pinchart wrote: > > @@ -2256,7 +2210,9 @@ static int isp_probe(struct platform_device *pdev) > > if (ret) > > return ret; > > > > - ret = isp_fwnodes_parse(>dev, >notifier); > > + ret =

Re: [PATCH v13 13/25] v4l: async: Allow async notifier register call succeed with no subdevs

Hi Sakari, On Tuesday, 19 September 2017 15:04:43 EEST Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Friday, 15 September 2017 17:17:12 EEST Sakari Ailus wrote: > > The information on how many async sub-devices would be bindable to a > > notifier is typically

Re: [PATCH v2] media: ov13858: Fix 4224x3136 video flickering at some vblanks

On Tue, Sep 19, 2017 at 01:32:27PM +0900, Tomasz Figa wrote: > Hi Chiranjeevi, > > On Tue, Sep 19, 2017 at 7:47 AM, Chiranjeevi Rapolu > wrote: > > Previously, with crop (0, 0), (4255, 3167), VTS < 0xC9E was resulting in > > blank > > frames sometimes. This

[PATCHv2 2/2] drm: adv7511/33: add HDMI CEC support

From: Hans Verkuil Add support for HDMI CEC to the drm adv7511/adv7533 drivers. The CEC registers that we need to use are identical for both drivers, but they appear at different offsets in the register map. Signed-off-by: Hans Verkuil ---

[PATCHv2 0/2] drm/bridge/adv7511: add CEC support

From: Hans Verkuil I should have posted this a month ago, but I completely forgot about it. Apologies for that. This patch series adds CEC support to the drm adv7511/adv7533 drivers. I have tested this with the Qualcomm Dragonboard C410 (adv7533 based) and the Renesas

[PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH v13 05/25] v4l: fwnode: Support generic parsing of graph endpoints in a device

On 09/15/2017 04:17 PM, Sakari Ailus wrote: > Add two functions for parsing devices graph endpoints: > v4l2_async_notifier_parse_fwnode_endpoints and > v4l2_async_notifier_parse_fwnode_endpoints_by_port. The former iterates > over all endpoints whereas the latter only iterates over the endpoints

Re: [PATCH 2/3] [media] tc358743: Increase FIFO level to 300.

Em Tue, 19 Sep 2017 17:24:45 +0200 Philipp Zabel escreveu: > Hi Dave, > > On Tue, 2017-09-19 at 14:08 +0100, Dave Stevenson wrote: > > The existing fixed value of 16 worked for UYVY 720P60 over > > 2 lanes at 594MHz, or UYVY 1080P60 over 4 lanes. (RGB888 > > 1080P60

Re: [PATCH v4 2/4] ARM: dts: exynos: Add clean name of compatible.

On Wed, Sep 13, 2017 at 08:41:53PM +0900, Hoegeun Kwon wrote: > Exynos 5250 and 5420 have different hardware rotation limits. However, > currently it uses only one compatible - "exynos5-gsc". Since we have > to distinguish between these two, we add different compatible. > > Signed-off-by: Hoegeun

Re: [PATCH v1 1/3] media: vsp1: Prevent resuming DRM pipelines

Hi Kieran, On Monday, 18 September 2017 03:04:13 EEST Kieran Bingham wrote: > On 15/09/17 17:58, Laurent Pinchart wrote: > > On Friday, 15 September 2017 19:42:05 EEST Kieran Bingham wrote: > >> DRM pipelines utilising the VSP must stop all frame processing as part > >> of the suspend operation

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

On 18/09/2017 17:33, Måns Rullgård wrote: > Marc Gonzalez writes: > >> diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig >> index d9ce8ff55d0c..f84923289964 100644 >> --- a/drivers/media/rc/Kconfig >> +++ b/drivers/media/rc/Kconfig >> @@ -469,6 +469,11 @@ config IR_SIR >>

Re: [PATCH v13 18/25] v4l: fwnode: Add a helper function to obtain device / integer references

Hi Hans, Thank you for the review. On Tue, Sep 19, 2017 at 10:31:41AM +0200, Hans Verkuil wrote: > Hi Sakari, > > I'm slowly starting to understand this. The example helped a lot. But I still > have > some questions, see below. > > On 09/15/2017 04:17 PM, Sakari Ailus wrote: > >

Re: [PATCH v13 06/25] omap3isp: Use generic parser for parsing fwnode endpoints

Hi Laurent, On Tue, Sep 19, 2017 at 03:46:18PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Tuesday, 19 September 2017 15:43:26 EEST Sakari Ailus wrote: > > On Tue, Sep 19, 2017 at 02:40:29PM +0300, Laurent Pinchart wrote: > > > > @@ -2256,7 +2210,9 @@ static int isp_probe(struct

Re: [PATCH v13 11/25] v4l: async: Introduce helpers for calling async ops callbacks

Hi Laurent, On Tue, Sep 19, 2017 at 03:43:48PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Tuesday, 19 September 2017 15:13:11 EEST Sakari Ailus wrote: > > On Tue, Sep 19, 2017 at 03:01:14PM +0300, Laurent Pinchart wrote: > > > On Friday, 15 September 2017 17:17:10 EEST Sakari Ailus

Re: [PATCH v13 06/25] omap3isp: Use generic parser for parsing fwnode endpoints

Hi Sakari, On Tuesday, 19 September 2017 17:47:22 EEST Sakari Ailus wrote: > On Tue, Sep 19, 2017 at 03:46:18PM +0300, Laurent Pinchart wrote: > > On Tuesday, 19 September 2017 15:43:26 EEST Sakari Ailus wrote: > >> On Tue, Sep 19, 2017 at 02:40:29PM +0300, Laurent Pinchart wrote: > @@

  1   2   >