Re: [PATCH v4 2/5] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-07-19 Thread m7aalton
Hello and thanks for the comments Mauro... One quick comment: On Tue, 2010-07-06 at 04:34 +0200, ext Mauro Carvalho Chehab wrote: + core-rx_frequency = + bands[core-band].bottom_frequency + + freq * 50; + +

Re: [PATCH v4 1/5] V4L2: Add seek spacing and FM RX class.

2010-07-19 Thread m7aalton
Hello. On Tue, 2010-07-06 at 04:03 +0200, ext Mauro Carvalho Chehab wrote: Em 04-06-2010 07:34, Matti J. Aaltonen escreveu: + +#define V4L2_CID_FM_RX_BAND (V4L2_CID_FM_TX_CLASS_BASE + 1) +enum v4l2_fm_rx_band { + V4L2_FM_BAND_OTHER = 0, +

Re: [RFC/PATCH 05/10] media: Reference count and power handling

2010-07-19 Thread Sakari Ailus
Hi Hans, And thanks for the comments! Hans Verkuil wrote: ... +/* + * Apply use count change to an entity and change power state based on + * new use count. + */ +static int media_entity_power_apply_one(struct media_entity *entity, int change) +{ +int ret = 0; + +if

Re: [RFC/PATCH 05/10] media: Reference count and power handling

2010-07-19 Thread Hans Verkuil
Hi Hans, And thanks for the comments! Hans Verkuil wrote: ... +/* + * Apply use count change to an entity and change power state based on + * new use count. + */ +static int media_entity_power_apply_one(struct media_entity *entity, int change) +{ + int ret = 0; + + if

Re: [RFC/PATCH 05/10] media: Reference count and power handling

2010-07-19 Thread Sakari Ailus
Hans Verkuil wrote: Hi Hans, And thanks for the comments! Hans Verkuil wrote: ... +/* + * Apply use count change to an entity and change power state based on + * new use count. + */ +static int media_entity_power_apply_one(struct media_entity *entity, int change) +{ + int ret = 0;

Re: [RFC/PATCH 02/10] media: Media device

2010-07-19 Thread Laurent Pinchart
Hi Murali, On Sunday 18 July 2010 17:32:24 Muralidharan Karicheri wrote: Hi Laurent, +++ b/Documentation/media-framework.txt @@ -0,0 +1,68 @@ +Linux kernel media framework + + snip I felt more details needed in this media-framework.txt for

Re: [RFC/PATCH 03/10] media: Entities, pads and links

2010-07-19 Thread Laurent Pinchart
Hi Hans, Thanks for the review. On Sunday 18 July 2010 13:53:51 Hans Verkuil wrote: On Wednesday 14 July 2010 15:30:12 Laurent Pinchart wrote: [snip] +Links have flags that describe the link capabilities and state. + + MEDIA_LINK_FLAG_ACTIVE indicates that the link is active and can

Re: Bugreport for libv4l: error out on webcam: error parsing JPEG header: Bogus jpeg format

2010-07-19 Thread Hans de Goede
Hi, On 07/15/2010 09:30 PM, Yuri wrote: I use Logitech QuickCam Deluxe on FreeBSD-8.1. It shows the image for a while but after 20sec-5min it errors out with the message from libv4l, see below. Could this be a bug in libv4l or it maybe it should be passed some tolerance to errors option?

Re: [RFC/PATCH 03/10] media: Entities, pads and links

2010-07-19 Thread Hans Verkuil
Hi Hans, Thanks for the review. On Sunday 18 July 2010 13:53:51 Hans Verkuil wrote: On Wednesday 14 July 2010 15:30:12 Laurent Pinchart wrote: [snip] +Links have flags that describe the link capabilities and state. + + MEDIA_LINK_FLAG_ACTIVE indicates that the link is active and

Re: Twinhan DTV Ter-CI (3030 mantis)

2010-07-19 Thread Niklas Claesson
Hi again, I ran scan with a input file, and I've activated debug on zl10353. Syslog is attached. nik...@niklas-desktop:~/.dvbt$ scan se-Malmo_Jagersro scanning se-Malmo_Jagersro using '/dev/dvb/adapter0/frontend0' and '/dev/dvb/adapter0/demux0' initial transponder 57000 0 3 9 3 1 3 0 tune

Re: Bugreport for libv4l: error out on webcam: error parsing JPEG header: Bogus jpeg format

2010-07-19 Thread Yuri
On 07/19/2010 05:22, Hans de Goede wrote: This is not really a bug in libv4l, but more of a problem with error tolerance in the application you are using. However many apps don't handle any kind of errors all that well. So the latest libv4l will retry (get a new frame) jpeg decompression

[PATCH 1/1] VIDEO: ivtvfb, remove unneeded NULL test

2010-07-19 Thread Jiri Slaby
Stanse found that in ivtvfb_callback_cleanup and ivtvfb_callback_init there are unneeded tests for itv being NULL. But itv is initialized as container_of with non-zero offset in those functions, so it is never NULL (even if v4l2_dev is). This was found because itv is dereferenced earlier than the

[cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2010-07-19 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Mon Jul 19 19:00:18 CEST 2010 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 14993:9652f85e688a git master:

Re: [PATCH 1/1] VIDEO: ivtvfb, remove unneeded NULL test

2010-07-19 Thread Andy Walls
On Mon, 2010-07-19 at 19:39 +0200, Jiri Slaby wrote: Stanse found that in ivtvfb_callback_cleanup and ivtvfb_callback_init there are unneeded tests for itv being NULL. But itv is initialized as container_of with non-zero offset in those functions, so it is never NULL (even if v4l2_dev is).

Re: Bugreport for libv4l: error out on webcam: error parsing JPEG header: Bogus jpeg format

2010-07-19 Thread Hans de Goede
Hi, On 07/19/2010 06:53 PM, Yuri wrote: On 07/19/2010 05:22, Hans de Goede wrote: This is not really a bug in libv4l, but more of a problem with error tolerance in the application you are using. However many apps don't handle any kind of errors all that well. So the latest libv4l will retry

Re: [PATCH 4/4] drivers/media/video: Remove dead CONFIG_OLPC_X0_1

2010-07-19 Thread Jonathan Corbet
On Wed, 14 Jul 2010 15:21:48 +0200 Christian Dietrich qy03f...@stud.informatik.uni-erlangen.de wrote: CONFIG_OLPC_X0_1 doesn't exist in Kconfig and is never defined anywhere else, therefore removing all references for it from the source code. That symbol is, needless to say, an OLPC thing;

[PATCH 00/17] cx23885: Add CX23885 integrated IR controller Rx support

2010-07-19 Thread Andy Walls
This is a respin of a patch series that has been rotting away in an hg repo of mine for 6 months. I needed the IO pin configuration fixes to start on CX23888 IR Tx support. Since Kenney Phillis reported that he had no problems with the entire set for his HVR-1250, I've ported them all forward.

[PATCH 01/17] cx23885: Return -ENXIO on slave nack

2010-07-19 Thread Andy Walls
From: Jean Delvare kh...@linux-fr.org Documentation/i2c/fault-codes says that i2c adapter drivers should return -ENXIO when no slave acks an address byte. Signed-off-by: Jean Delvare kh...@linux-fr.org Signed-off-by: Andy Walls awa...@md.metrocast.net ---

[PATCH 02/17] cx23885: Check for slave nack on all transactions

2010-07-19 Thread Andy Walls
From: Jean Delvare kh...@linux-fr.org Don't just check for nacks on zero-length transactions. Check on other transactions too. Signed-off-by: Jean Delvare kh...@linux-fr.org Signed-off-by: Andy Walls awa...@md.metrocast.net --- drivers/media/video/cx23885/cx23885-i2c.c |8 1 files

[PATCH 05/17] cx23885: Add correct detection of the HVR-1250 model 79501

2010-07-19 Thread Andy Walls
The offset in the eeprom data for the 79501 version of the HVR-1250 is at 0xc0 vs. the standard 0x80. Signed-off-by: Andy Walls awa...@md.metrocast.net --- drivers/media/video/cx23885/cx23885-cards.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git

[PATCH 03/17] cx23885: i2c_wait_done returns 0 or 1, don't check for 0 return value

2010-07-19 Thread Andy Walls
From: Jean Delvare kh...@linux-fr.org Function i2c_wait_done() never returns negative values, so there is no point in checking for them. Signed-off-by: Jean Delvare kh...@linux-fr.org Signed-off-by: Andy Walls awa...@md.metrocast.net --- drivers/media/video/cx23885/cx23885-i2c.c | 15

[PATCH 06/17] cx23885: Add a VIDIOC_LOG_STATUS ioctl function for analog video devices

2010-07-19 Thread Andy Walls
Add a simple log_status function for raw analog video capture device nodes, to provide insight into the state of the CX2388[578] A/V decoder core. Signed-off-by: Andy Walls awa...@md.metrocast.net --- drivers/media/video/cx23885/cx23885-video.c | 16 1 files changed, 16

[PATCH 04/17] cx25840: Make cx25840 i2c register read transactions atomic

2010-07-19 Thread Andy Walls
There was a small window between writing the cx25840 register address over the i2c bus and reading the register contents back from the cx25840 device that the i2c adapter lock was released. This change ensures the adapter lock is not released until the register read is done. Signed-off-by: Andy

[PATCH 07/17] v4l2_subdev: Add s_io_pin_config to v4l2_subdev_core_ops

2010-07-19 Thread Andy Walls
Add a method to v4l2_sudev_core_ops to allow bridge drivers to manage what signal pads/functions are routed out to multiplexed IO pins on a pin by pin basis. The interface also allows specifying initial output settings for pins and disabling an IO pin altogether. Signed-off-by: Andy Walls

[PATCH 08/17] cx25840: Add s_io_pin_config core subdev ops for the CX2388[578]

2010-07-19 Thread Andy Walls
Add s_io_pin_config core subdev op for the CX2388[578] AV cores. This is complete for IR_RX, IR_TX, GPIOs 16,19-23, and IRQ_N. It likely needs work for the I2S signal direction. Signed-off-by: Andy Walls awa...@md.metrocast.net --- drivers/media/video/cx25840/cx25840-core.c | 153

[PATCH 09/17] v4l2_subdev, cx23885: Differentiate IR carrier sense and I/O pin inversion

2010-07-19 Thread Andy Walls
There is a distinction on IR Tx for the CX2388[578] chips of carrier sense inversion (space is a carrier burst and mark is no burst) and I/O pin level inversion (0 is high output level, 1 is low output level). Allow the caller to set these parameters distinctly as v4l2_subdevice IR parameters.

[PATCH 10/17] cx23885: For CX23888 IR, configure the IO pin mux IR pins explcitly

2010-07-19 Thread Andy Walls
Explicitly configure the IR Tx and IR Rx pins to be driven by the IR Rx and Tx pads from the AV core for CX23888 IR. For the HVR-1850 and HVR-1290 configure the IR Tx level inversion, so the Tx LED is off when idle. Signed-off-by: Andy Walls awa...@md.metrocast.net ---

[PATCH 11/17] v4l2_subdev: Move interrupt_service_routine ptr to v4l2_subdev_core_ops

2010-07-19 Thread Andy Walls
The CX2584x and related cores are multifunction subdevices with a number of internal blocks that act as interrupt sources. Move the v4L2_subdev interrupt_service_routine callback from v4l_subdev_ir_ops to v4l2_subdev_core_ops, as the video and audio blocks of a CX2584x and related cores can

[PATCH 12/17] cx25840: Add support for CX2388[57] A/V core integrated IR controllers

2010-07-19 Thread Andy Walls
This patch is primarily a port of the integrated IR controller code in cx23885/cx23888-ir.c. Right now, only the CX2388[57] AV core will really try to set up IR. This IR support, by design, still requires the bridge driver to do final IO pin mux configuration and setup of the IR controller

[PATCH 13/17] cx23885: Add a v4l2_subdev group id for the CX2388[578] integrated AV core

2010-07-19 Thread Andy Walls
Signed-off-by: Andy Walls awa...@md.metrocast.net --- drivers/media/video/cx23885/cx23885-cards.c |5 - drivers/media/video/cx23885/cx23885.h |3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/cx23885/cx23885-cards.c

[PATCH 14/17] cx23885: Add preliminary IR Rx support for the HVR-1250 and TeVii S470

2010-07-19 Thread Andy Walls
Add initial IR Rx support using the intergrated IR controller in the A/V core of the CX23885 bridge chip. This initial support is flawed in that I2C transactions should not be performed in a hard irq context. That will be fixed in a follow on patch. The TeVii S470 support is reported to

[PATCH 15/17] cx23885: Protect PCI interrupt mask manipulations with a spinlock

2010-07-19 Thread Andy Walls
This patch encapsulates access to the PCI_INT_MSK register and dev-pci_irqmask variable and protects them with a spinlock. This is needed because both the hard IRQ handler and a workhandler will need to manipulate the mask to disable the AV_CORE interrupt. Signed-off-by: Andy Walls

[PATCH 16/17] cx23885: Move AV Core irq handling to a work handler

2010-07-19 Thread Andy Walls
Interrupts from the AV Core are best handled by a workqueue handler since many I2C transactions are required to service the AV Core interrupt. The AV_CORE PCI interrupt is disabled by the IRQ handler and reenabled when the work handler is finished. Signed-off-by: Andy Walls

[PATCH 17/17] cx23885: Require user to explicitly enable CX2388[57] IR via module param

2010-07-19 Thread Andy Walls
The CX23885 IR controller was reported to cause an interrupt storm on a TeVii S470 card, but was reported fine on an HVR-1250. Keep integrated IR disabled by default on CX2388[57] based cards to avoid a bad user experience in the general case. Signed-off-by: Andy Walls awa...@md.metrocast.net