[PATCH 2/8] dvb-frontends: ves1820: fix potential integer overflow

Cast state->config->xin to u64 in order to avoid a potential integer overflow. This variable is being used in a context that expects an expression of type u64. Addresses-Coverity-ID: 200604 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedo

Re: [PATCH 8/8] platform: vivid-cec: fix potential integer overflow in vivid_cec_pin_adap_events

Quoting Hans Verkuil <hverk...@xs4all.nl>: On 01/30/2018 09:51 AM, Gustavo A. R. Silva wrote: Hi Hans, Quoting Hans Verkuil <hverk...@xs4all.nl>: Hi Gustavo, On 01/30/2018 01:33 AM, Gustavo A. R. Silva wrote: Cast len to const u64 in order to avoid a potential inte

Re: [PATCH 8/8] platform: vivid-cec: fix potential integer overflow in vivid_cec_pin_adap_events

Quoting Hans Verkuil : [...] What happens if you do: ((u64)CEC_TIM_START_BIT_TOTAL + I think that forces everything else in the expression to be evaluated as u64. Well, in this case the operator precedence takes place and the expression len * 10 *

Re: [PATCH 8/8] platform: vivid-cec: fix potential integer overflow in vivid_cec_pin_adap_events

Quoting Hans Verkuil <hverk...@xs4all.nl>: On 01/30/18 12:43, Gustavo A. R. Silva wrote: Quoting Hans Verkuil <hverk...@xs4all.nl>: [...] What happens if you do: ((u64)CEC_TIM_START_BIT_TOTAL + I think that forces everything else in the expression to be evaluated as

[PATCH v2 5/8] pci: cx88-input: use 64-bit arithmetic instead of 32-bit

ted using 32-bit arithmetic. Addresses-Coverity-ID: 1392628 Addresses-Coverity-ID: 1392630 Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- Changes in v2: - Update subject and changelog to better reflect the proposed code changes. - Add suffix LL to constant instead o

[PATCH v2 0/8] use 64-bit arithmetic instead of 32-bit

and changelog to better reflect the proposed code changes. - Add suffix ULL and LL to constants instead of casting variables. - Extend the proposed code changes to other similar cases that had not previously been considered in v1 of this patchset. Gustavo A. R. Silva (8): rtl2832: use 64-bit

[PATCH v2 1/8] rtl2832: use 64-bit arithmetic instead of 32-bit in rtl2832_set_frontend

ing 32-bit arithmetic. Addresses-Coverity-ID: 1271223 Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- Changes in v2: - Update subject and changelog to better reflect the proposed code changes. - Add suffix ULL to constant instead of casting a variable. drivers/media/d

[PATCH v2 2/8] dvb-frontends: ves1820: use 64-bit arithmetic instead of 32-bit

being evaluated using 32-bit arithmetic. Addresses-Coverity-ID: 200604 Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- Changes in v2: - Update subject and changelog to better reflect the proposed code changes. - Add suffix ULL to constant instead of casting a variable. drive

[PATCH v2 3/8] i2c: max2175: use 64-bit arithmetic instead of 32-bit

using 32-bit arithmetic. Addresses-Coverity-ID: 1446589 Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- Changes in v2: - Update subject and changelog to better reflect the proposed code changes. - Add suffix LL to constant instead of casting a variable. drivers/media/i2c/m

[PATCH v2 4/8] i2c: ov9650: use 64-bit arithmetic instead of 32-bit

onger needed. Addresses-Coverity-ID: 1324146 ("Unintentional integer overflow") Fixes: 84a15ded76ec ("[media] V4L: Add driver for OV9650/52 image sensors") Fixes: 79211c8ed19c ("remove abs64()") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- Changes

Re: [PATCH v3 4/8] i2c: ov9650: use 64-bit arithmetic instead of 32-bit

Hi Sakari, On 02/07/2018 03:59 PM, Sakari Ailus wrote: Hi Gustavo, On Tue, Feb 06, 2018 at 10:47:50AM -0600, Gustavo A. R. Silva wrote: Add suffix ULL to constants 1 and 100 in order to give the compiler complete information about the proper arithmetic to use. Notice

[PATCH v3 7/8] platform: sh_veu: use 64-bit arithmetic instead of 32-bit

l integer overflow") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- Changes in v2: - Update subject and changelog to better reflect the proposed code changes. - Move the expression (((dma_addr_t)left * veu->vfmt_out.fmt->depth) >> 3) at the end in or

[PATCH v3 8/8] platform: vivid-cec: use 64-bit arithmetic instead of 32-bit

evaluated using 32-bit arithmetic. Also, remove unnecessary parentheses and add a code comment to make it clear what is the reason of the code change. Addresses-Coverity-ID: 1454996 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> -

Re: [PATCH v2 8/8] platform: vivid-cec: use 64-bit arithmetic instead of 32-bit

Quoting Hans Verkuil <hverk...@xs4all.nl>: On 02/05/18 22:54, Gustavo A. R. Silva wrote: Hi Hans, Quoting Hans Verkuil <hverk...@xs4all.nl>: On 02/05/2018 09:36 PM, Gustavo A. R. Silva wrote: Add suffix ULL to constant 10 in order to give the compiler complete information abou

[PATCH v3 0/8] use 64-bit arithmetic instead of 32-bit

nges in v3: - Mention the specific Coverity report in all commit messages. Gustavo A. R. Silva (8): rtl2832: use 64-bit arithmetic instead of 32-bit in rtl2832_set_frontend dvb-frontends: ves1820: use 64-bit arithmetic instead of 32-bit i2c: max2175: use 64-bit arithmetic instead of 32

[PATCH v3 1/8] rtl2832: use 64-bit arithmetic instead of 32-bit in rtl2832_set_frontend

ing 32-bit arithmetic. Addresses-Coverity-ID: 1271223 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- Changes in v2: - Update subject and changelog to better reflect the proposed code changes. - Add suffix ULL to constant instead

[PATCH v3 3/8] i2c: max2175: use 64-bit arithmetic instead of 32-bit

using 32-bit arithmetic. Addresses-Coverity-ID: 1446589 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- Changes in v2: - Update subject and changelog to better reflect the proposed code changes. - Add suffix LL to constant in

[PATCH v3 2/8] dvb-frontends: ves1820: use 64-bit arithmetic instead of 32-bit

being evaluated using 32-bit arithmetic. Addresses-Coverity-ID: 200604 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- Changes in v2: - Update subject and changelog to better reflect the proposed code changes. - Add suffix ULL to const

[PATCH v3 4/8] i2c: ov9650: use 64-bit arithmetic instead of 32-bit

onger needed. Addresses-Coverity-ID: 1324146 ("Unintentional integer overflow") Fixes: 84a15ded76ec ("[media] V4L: Add driver for OV9650/52 image sensors") Fixes: 79211c8ed19c ("remove abs64()") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- Changes

[PATCH v3 6/8] rockchip/rga: use 64-bit arithmetic instead of 32-bit

intentional integer overflow") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- Changes in v2: - Update subject and changelog to better reflect the proposed code change. Changes in v3: - Mention the specific Coverity report in the commit message. drivers/media/platform/

[PATCH v3 5/8] pci: cx88-input: use 64-bit arithmetic instead of 32-bit

ted using 32-bit arithmetic. Addresses-Coverity-ID: 1392628 ("Unintentional integer overflow") Addresses-Coverity-ID: 1392630 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- Changes in v2: - Update subject and changelog t

Re: [PATCH v2 8/8] platform: vivid-cec: use 64-bit arithmetic instead of 32-bit

Hi Hans, Quoting Hans Verkuil <hverk...@xs4all.nl>: On 02/05/2018 09:36 PM, Gustavo A. R. Silva wrote: Add suffix ULL to constant 10 in order to give the compiler complete information about the proper arithmetic to use. Notice that this constant is used in a context that expects an expr

Re: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR

Hi all, I was just wondering about the status of this patch. Thanks -- Gustavo On 01/24/2018 06:14 PM, Steve Longerbeam wrote: Acked-by: Steve Longerbeam <steve_longerb...@mentor.com> On 01/23/2018 04:43 PM, Gustavo A. R. Silva wrote: Fix inconsistent IS_ERR and P

[PATCH v2 6/8] rockchip/rga: use 64-bit arithmetic instead of 32-bit

ed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- Changes in v2: - Update subject and changelog to better reflect the proposed code change. drivers/media/platform/rockchip/rga/rga-buf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/rock

[PATCH v2 8/8] platform: vivid-cec: use 64-bit arithmetic instead of 32-bit

evaluated using 32-bit arithmetic. Also, remove unnecessary parentheses and add a code comment to make it clear what is the reason of the code change. Addresses-Coverity-ID: 1454996 Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- Changes in v2: - Update subject and changelog to

[PATCH v2 7/8] platform: sh_veu: use 64-bit arithmetic instead of 32-bit

arithmetic. Also, move the expression (((dma_addr_t)left * veu->vfmt_out.fmt->depth) >> 3) at the end in order to avoid a line wrapping checkpatch.pl warning. Addresses-Coverity-ID: 1056807 Addresses-Coverity-ID: 1056808 Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com>

Re: [PATCH v3 4/8] i2c: ov9650: use 64-bit arithmetic instead of 32-bit

On 02/15/2018 07:52 AM, Hans Verkuil wrote: On 08/02/18 17:39, Gustavo A. R. Silva wrote: Hi Sakari, On 02/07/2018 03:59 PM, Sakari Ailus wrote: Hi Gustavo, On Tue, Feb 06, 2018 at 10:47:50AM -0600, Gustavo A. R. Silva wrote: Add suffix ULL to constants 1 and 100 in order to give

Re: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR

Hi Philipp, On 02/19/2018 08:23 AM, Philipp Zabel wrote: Hi Gustavo, On Wed, 2018-02-14 at 14:57 -0600, Gustavo A. R. Silva wrote: Hi all, I was just wondering about the status of this patch. It is en route as commit dcd71a9292b1 ("staging: imx-media-vdic: fix inconsistent I

[PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR

Fix inconsistent IS_ERR and PTR_ERR in vdic_get_ipu_resources. The proper pointer to be passed as argument is ch. This issue was detected with the help of Coccinelle. Fixes: 0b2e9e7947e7 ("media: staging/imx: remove confusing IS_ERR_OR_NULL usage") Signed-off-by: Gustavo A. R. S

[PATCH] ov13858: Use false for boolean value

Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/i2c/ov13858.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH] venus: hfi: use true for boolean values

Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/platform/qcom/venus/hfi_msgs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe. The proper pointer to be passed as argument is pinctrl instead of priv->vdev. This issue was detected with the help of Coccinelle. Fixes: 52e17089d185 ("media: imx: Don't initialize vars that won't be used") Signed-off-by: Gustav

[PATCH] staging: media: davinci_vpfe: fix spin_lock/unlock imbalance

rk") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe/dm365_resize

[PATCH 11/11] vsp1_rwpf: fix potential Spectre variant 1

ported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/platform/vsp1/vsp1_rwpf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/vsp1/vsp1_rwpf.c b/drivers/media/platform/vsp1/vsp1_rw

[PATCH 01/11] media: tm6000: fix potential Spectre variant 1

ported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/usb/tm6000/tm6000-video.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/usb/tm6000/tm6000-video.c b/drivers/media/usb/tm6000/tm

[PATCH 04/11] marvell-ccic: mcam-core: fix potential Spectre variant 1

c: sta...@vger.kernel.org Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/platform/marvell-ccic/mcam-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/marvell-ccic/mcam

[PATCH 06/11] rcar-v4l2: fix potential Spectre variant 1

el.org Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.

[PATCH 08/11] sh_vou: fix potential Spectre variant 1

y: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/platform/sh_vou.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/sh_vou.c b/drivers/media/platform/sh_vou.c index 4dccf29..58d8645 10

[PATCH 09/11] vimc-debayer: fix potential Spectre variant 1

=2 Cc: sta...@vger.kernel.org Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/platform/vimc/vimc-debayer.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/v

[PATCH 10/11] vivid-sdr-cap: fix potential Spectre variant 1

c: sta...@vger.kernel.org Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/platform/vivid/vivid-sdr-cap.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/platform/vivid/vivid-sdr-cap.

[PATCH 03/11] fsl-viu: fix potential Spectre variant 1

penter <dan.carpen...@oracle.com> Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/platform/fsl-viu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/fsl-viu.c b/drivers/media/platform/fsl-viu.c index e4151

[PATCH 02/11] exynos4-is: mipi-csis: fix potential Spectre variant 1

c: sta...@vger.kernel.org Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/platform/exynos4-is/mipi-csis.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4

[PATCH 00/11] fix potential Spectre variant 1 issues

the speculation on the first load and not worry if it can be completed with a dependent load/store [1]. [1] https://marc.info/?l=linux-kernel=152449131114778=2 Thanks Gustavo A. R. Silva (11): media: tm6000: fix potential Spectre variant 1 exynos4-is: mipi-csis: fix potential Spectre variant

Re: [PATCH 00/11] fix potential Spectre variant 1 issues

Hi, Please, drop this series. Further analysis is required as it seems all these are False Positives. Sorry for the noise. Thanks -- Gustavo On 04/23/2018 12:37 PM, Gustavo A. R. Silva wrote: This patchset aims to fix various media platform and media usb cases where we have user controlled

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

On 04/23/2018 02:17 PM, Mauro Carvalho Chehab wrote: Em Mon, 23 Apr 2018 14:11:02 -0500 "Gustavo A. R. Silva" <gust...@embeddedor.com> escreveu: On 04/23/2018 01:24 PM, Mauro Carvalho Chehab wrote: Em Mon, 23 Apr 2018 12:38:03 -0500 "Gustavo A. R. Silva" <gus

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

On 04/23/2018 01:24 PM, Mauro Carvalho Chehab wrote: Em Mon, 23 Apr 2018 12:38:03 -0500 "Gustavo A. R. Silva" <gust...@embeddedor.com> escreveu: f->index can be controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerabili

[PATCH] omap3isp: ispstat: fix potential NULL pointer dereference

y: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/platform/omap3isp/ispstat.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/omap3isp/ispstat.c b/drivers/media/platform/omap3isp/ispstat.c index 0b31f6c..549c7ab 100644 ---

[PATCH 05/11] omap_vout: fix potential Spectre variant 1

-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/platform/omap/omap_vout.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_

[PATCH 07/11] rcar_drif: fix potential Spectre variant 1

ported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/platform/rcar_drif.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/rcar_drif.c b/drivers/media/platform/rcar_dr

Re: [PATCH 3/3] media: i2c: tvp5150: Use parentheses for sizeof

Hi, On 04/02/2018 02:59 PM, Nasser Afshin wrote: This patch resolves a checkpatch.pl warning It would be nice if you explicitly mention the warning. Thanks. -- Gustavo Signed-off-by: Nasser Afshin --- drivers/media/i2c/tvp5150.c | 2 +- 1 file changed, 1

<    1   2