Re: [PATCH 2/3] media: v4l2-fwnode: cleanup functions that parse endpoints

2018-10-05 Thread Mauro Carvalho Chehab
Em Fri, 5 Oct 2018 11:01:18 +0300 Sakari Ailus escreveu: > Hi Mauro, > > Feel free to ignore the comments on the first patch regarding the functions > below. There are other issues there though. > > On Thu, Oct 04, 2018 at 06:13:47PM -0400, Mauro Carvalho Chehab wrote: &g

[PATCH 2/3] media: v4l2-fwnode: cleanup functions that parse endpoints

2018-10-04 Thread Mauro Carvalho Chehab
There is already a typedef for the parse endpoint function. However, instead of using it, it is redefined at the C file (and on one of the function headers). Replace them by the function typedef, in order to cleanup several related coding style warnings. Signed-off-by: Mauro Carvalho Chehab

[PATCH 1/3] media: v4l2-core: cleanup coding style at V4L2 async/fwnode

2018-10-04 Thread Mauro Carvalho Chehab
/media/v4l2-core/v4l2-async.c drivers/media/v4l2-core/v4l2-fwnode.c and then manually adjusting the style where needed. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/v4l2-core/v4l2-async.c | 45 --- drivers/media/v4l2-core/v4l2-fwnode.c | 185 +++--- include

[PATCH 3/3] media: v4l2-fwnode: simplify v4l2_fwnode_reference_parse_int_props() call

2018-10-04 Thread Mauro Carvalho Chehab
some coding style issues. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/v4l2-core/v4l2-fwnode.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c index a7c2487154a4

[PATCH 0/3] Coding style cleanups after the fwnode patchset

2018-10-04 Thread Mauro Carvalho Chehab
API, I opted to keep it as-is - for now. Mauro Carvalho Chehab (3): media: v4l2-core: cleanup coding style at V4L2 async/fwnode media: v4l2-fwnode: cleanup functions that parse endpoints media: v4l2-fwnode: simplify v4l2_fwnode_reference_parse_int_props() call drivers/media/v4l2-core/v4l2-async.c |

Re: [GIT PULL FOR v4.20] Various fixes

2018-10-04 Thread Mauro Carvalho Chehab
Em Mon, 1 Oct 2018 11:56:22 +0200 Hans Verkuil escreveu: > The following changes since commit 4158757395b300b6eb308fc20b96d1d231484413: > > media: davinci: Fix implicit enum conversion warning (2018-09-24 09:43:13 > -0400) > > are available in the Git repository at: > >

Re: [PATCH] MAINTAINERS: Remove stale file entry for the Atmel ISI driver

2018-10-04 Thread Mauro Carvalho Chehab
Em Tue, 2 Oct 2018 08:35:47 +0200 Ludovic Desroches escreveu: > On Mon, Oct 01, 2018 at 01:51:01PM -0300, Mauro Carvalho Chehab wrote: > > Em Sun, 30 Sep 2018 02:40:35 -0700 > > Joe Perches escreveu: > > > > > On Sun, 2018-09-30 at 06:30 -0300, Mauro Carvalho

[PATCH v5] media: docs: add glossary.rst with common terms used at V4L2 spec

2018-10-04 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab Add a glossary of terms used within the media userspace API documentation, as several concepts are complex enough to cause misunderstandings. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/media_uapi.rst| 3 + Documentation/media/uapi

Re: [PATCH v3] media: docs: add glossary.rst with common terms used at V4L2 spec

2018-10-04 Thread Mauro Carvalho Chehab
Em Thu, 4 Oct 2018 10:27:06 -0300 Mauro Carvalho Chehab escreveu: > > > + For V4L2 hardware, this is also known as V4L2 main driver. > > > > Do we use the term V4L2 main driver in the V4L2 spec ? > > Right now, I don't think we use, but this is something tha

Re: [PATCH v3] media: docs: add glossary.rst with common terms used at V4L2 spec

2018-10-04 Thread Mauro Carvalho Chehab
Em Thu, 04 Oct 2018 14:41:30 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > (CC'ing Kieran) > > Thank you for the patch. > > On Tuesday, 25 September 2018 22:14:51 EEST Mauro Carvalho Chehab wrote: > > From: Mauro Carvalho Chehab > > > > Add a

Re: [PATCH v4] media: docs: add glossary.rst with common terms used at V4L2 spec

2018-10-04 Thread Mauro Carvalho Chehab
Em Thu, 4 Oct 2018 13:11:12 +0200 Hans Verkuil escreveu: > On 10/04/18 12:58, Mauro Carvalho Chehab wrote: > > From: Mauro Carvalho Chehab > > > > Add a glossary of terms used within the media userspace API > > documentation, as several concepts

[PATCH v4] media: docs: add glossary.rst with common terms used at V4L2 spec

2018-10-04 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab Add a glossary of terms used within the media userspace API documentation, as several concepts are complex enough to cause misunderstandings. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/media_uapi.rst| 3 + Documentation/media/uapi

Re: [PATCH v3] media: docs: add glossary.rst with common terms used at V4L2 spec

2018-10-04 Thread Mauro Carvalho Chehab
Em Mon, 1 Oct 2018 17:20:26 +0200 Hans Verkuil escreveu: > On 09/25/2018 09:14 PM, Mauro Carvalho Chehab wrote: > > From: Mauro Carvalho Chehab > > > > Add a glossary of terms used within the media userspace API > > documentation, as several concepts

Re: [PATCH] MAINTAINERS: Remove stale file entry for the Atmel ISI driver

2018-10-01 Thread Mauro Carvalho Chehab
Em Sun, 30 Sep 2018 02:40:35 -0700 Joe Perches escreveu: > On Sun, 2018-09-30 at 06:30 -0300, Mauro Carvalho Chehab wrote: > > Em Sun, 30 Sep 2018 09:54:48 +0300 > > Laurent Pinchart escreveu: > > > > > include/media/atmel-isi got removed three years ago with

Re: [PATCH] MAINTAINERS: Remove stale file entry for the Atmel ISI driver

2018-09-30 Thread Mauro Carvalho Chehab
Em Sun, 30 Sep 2018 09:54:48 +0300 Laurent Pinchart escreveu: > include/media/atmel-isi got removed three years ago without the > MAINTAINERS file being updated. Remove the stale entry. > > Fixes: 40a78f36fc92 ("[media] v4l: atmel-isi: Remove support for platform > data") > Reported-by: Joe

Re: [PATCH 03/13] v4l2-mc: switch it to use the new approach to setup pipelines

2018-09-27 Thread Mauro Carvalho Chehab
Em Wed, 26 Sep 2018 17:44:53 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Wednesday, 1 August 2018 18:55:05 EEST Mauro Carvalho Chehab wrote: > > Instead of relying on a static map for pids, use the new sig_type > > "ta

Re: [PATCH 02/13] media: v4l2: taint pads with the signal types for consumer devices

2018-09-27 Thread Mauro Carvalho Chehab
nesday, 1 August 2018 18:55:04 EEST Mauro Carvalho Chehab wrote: > > Consumer devices are provided with a wide diferent range of types > > supported by the same driver, allowing different configutations. > > > > In order to make easier to setup media controller links,

Re: [ANN] Draft Agenda for the media summit on Thursday Oct 25th in Edinburgh

2018-09-26 Thread Mauro Carvalho Chehab
Em Mon, 24 Sep 2018 19:41:13 +0200 Hans Verkuil escreveu: > On 09/24/2018 07:12 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 24 Sep 2018 16:42:13 +0200 > > Hans Verkuil escreveu: > > > >> Hi all, > >> > >> We are organizing a media mini-s

[PATCH v3] media: docs: add glossary.rst with common terms used at V4L2 spec

2018-09-25 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab Add a glossary of terms used within the media userspace API documentation, as several concepts are complex enough to cause misunderstandings. Signed-off-by: Mauro Carvalho Chehab --- v3: - Add SPDX header and dual-license the glossary - Make glossary generic

[PATCH v2] media: docs: add glossary.rst with common terms used at V4L2 spec

2018-09-25 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab Add a glossary of terms for V4L2, as several concepts are complex enough to cause misunderstandings. Signed-off-by: Mauro Carvalho Chehab --- v2.: Did some changes based on Sakari's feedback. Documentation/media/media_uapi.rst| 2 + Documentation/media

Re: [PATCH 1/3] media: add glossary.rst with common terms used at V4L2 spec

2018-09-25 Thread Mauro Carvalho Chehab
Em Tue, 25 Sep 2018 16:03:57 +0300 Sakari Ailus escreveu: > Hi Mauro, > > Thanks for the set! A few quick comments below, mainly additions and language. > > On Tue, Sep 25, 2018 at 09:06:51AM -0300, Mauro Carvalho Chehab wrote: > > From: Mauro Carvalho Chehab > >

[PATCH 1/3] media: add glossary.rst with common terms used at V4L2 spec

2018-09-25 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab Add a glossary of terms for V4L2, as several concepts are complex enough to cause misunderstandings. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/glossary.rst | 108 ++ Documentation/media/uapi/v4l/v4l2.rst | 1

[PATCH 3/3] media: open.rst: remove the minor number range

2018-09-25 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab minor numbers use to range between 0 to 255, but that was changed a long time ago. While it still applies when CONFIG_VIDEO_FIXED_MINOR_RANGES, when the minor number is dynamically allocated, this may not be true. In any case, this is not relevant, as udev will take

[PATCH 2/3] media: open.rst: better document device node naming

2018-09-25 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab Right now, only kAPI documentation describes the device naming. However, such description is needed at the uAPI too. Add it, and describe how to get an unique identify for a given device. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab

[PATCH 0/3] Add a glossary and fix some issues at open.rst docs

2018-09-25 Thread Mauro Carvalho Chehab
related to it. Mauro Carvalho Chehab (3): media: add glossary.rst with common terms used at V4L2 spec media: open.rst: better document device node naming media: open.rst: remove the minor number range Documentation/media/uapi/v4l/glossary.rst | 108 ++ Documentation/media

Re: [ANN] Draft Agenda for the media summit on Thursday Oct 25th in Edinburgh

2018-09-24 Thread Mauro Carvalho Chehab
Em Mon, 24 Sep 2018 19:41:13 +0200 Hans Verkuil escreveu: > On 09/24/2018 07:12 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 24 Sep 2018 16:42:13 +0200 > > Hans Verkuil escreveu: > > > >> Hi all, > >> > >> We are organizing a media mini-s

Re: [ANN] Draft Agenda for the media summit on Thursday Oct 25th in Edinburgh

2018-09-24 Thread Mauro Carvalho Chehab
Em Mon, 24 Sep 2018 14:12:36 -0300 Mauro Carvalho Chehab escreveu: > Em Mon, 24 Sep 2018 16:42:13 +0200 > Hans Verkuil escreveu: > > > Hi all, > > > > We are organizing a media mini-summit on Thursday October 25th in > > Edinburgh, Edinburgh International C

Re: [ANN] Draft Agenda for the media summit on Thursday Oct 25th in Edinburgh

2018-09-24 Thread Mauro Carvalho Chehab
r of attendees for us. > > Name of the room for the summit: TBD I'll get the room name with the event organizers and post it later on this thread. > > Currently known attendees (please add/remove names as needed): > > Sakari Ailus > Mauro Carvalho Chehab > Ezequiel Gar

Re: 4.18 regression: dvb-usb-v2: General Protection Fault shortly after boot

2018-09-22 Thread Mauro Carvalho Chehab
Em Thu, 20 Sep 2018 00:07:09 -0400 Dan Ziemba escreveu: > I reported this on bugzilla also a few days ago, but I'm not sure if > that is actually the right place to report, so copying to the mailing > list... I saw a report on BZ, but haven't time yet to dig into it. Those days, it is usually

Re: [PATCH 5/6] media: isp: fix a warning about a wrong struct initializer

2018-09-20 Thread Mauro Carvalho Chehab
omap3isp: ...". > > > > On Wednesday, 8 August 2018 17:52:55 EEST Mauro Carvalho Chehab wrote: > > > As sparse complains: > > > drivers/media/platform/omap3isp/isp.c:303:39: warning: Using plain > > > integer > > > > > > as NULL po

[RFP] Key signing party at the media summit

2018-09-19 Thread Mauro Carvalho Chehab
As we're now using signed tags for media pull request, let's reserve some space for a key signing party. Regards, Mauro

Re: [PATCH v2 00/14] Better handle pads for tuning/decoder part of the devices

2018-09-15 Thread Mauro Carvalho Chehab
Em Sat, 15 Sep 2018 17:14:15 -0300 Mauro Carvalho Chehab escreveu: > At PC consumer devices, it is very common that the bridge same driver > to be attached to different types of tuners and demods. We need a way > for the Kernel to properly identify what kind of signal is provided by e

[PATCH v2 08/14] media: msp3400: declare its own pads

2018-09-15 Thread Mauro Carvalho Chehab
As we don't need anymore to share pad numbers with similar drivers, use its own pad definition instead of a global model. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/msp3400-driver.c | 8 drivers/media/i2c/msp3400-driver.h | 8 +++- 2 files

[PATCH v2 14/14] media: v4l2-mc: get rid of global pad indexes

2018-09-15 Thread Mauro Carvalho Chehab
Carvalho Chehab --- drivers/media/v4l2-core/tuner-core.c | 49 +- include/media/v4l2-mc.h | 76 2 files changed, 48 insertions(+), 77 deletions(-) diff --git a/drivers/media/v4l2-core/tuner-core.c b/drivers/media/v4l2-core/tuner-core.c

[PATCH v2 04/14] media: v4l2-mc: add print messages when media graph fails

2018-09-15 Thread Mauro Carvalho Chehab
It is not trivial to debug troubles at media graph build. So, add print messages to help debug what's happening, in the case of an error occurs. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/v4l2-core/v4l2-mc.c | 80 +++ 1 file changed, 61 insertions(+), 19

[PATCH v2 13/14] media: mxl111sf: declare its own pads

2018-09-15 Thread Mauro Carvalho Chehab
As we don't need anymore to share pad numbers with similar drivers, use its own pad definition instead of a global model. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/dvb-usb-v2/mxl111sf.c | 10 +- drivers/media/usb/dvb-usb-v2/mxl111sf.h | 8

[PATCH v2 10/14] media: tvp5150: declare its own pads

2018-09-15 Thread Mauro Carvalho Chehab
As we don't need anymore to share pad numbers with similar drivers, use its own pad definition instead of a global model. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/tvp5150.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions

[PATCH v2 09/14] media: saa7115: declare its own pads

2018-09-15 Thread Mauro Carvalho Chehab
As we don't need anymore to share pad numbers with similar drivers, use its own pad definition instead of a global model. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/saa7115.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff

[PATCH v2 02/14] media: v4l2: taint pads with the signal types for consumer devices

2018-09-15 Thread Mauro Carvalho Chehab
the signal it carries is actually the same as the normal video output. The difference happens at the video/VBI interface: - for VBI, only the hidden lines are streamed; - for video, the stream is usually cropped to hide the vbi lines. Acked-by: Hans Verkuil Signed-off-by: Maur

[PATCH v2 00/14] Better handle pads for tuning/decoder part of the devices

2018-09-15 Thread Mauro Carvalho Chehab
ult of such tests, I opted to use just one type for all analog signals. - Added a patch to provide some info if something gets wrong while creating the links. Mauro Carvalho Chehab (14): media: v4l2: remove VBI output pad media: v4l2: taint pads with the signal types for consumer devices v4l2-

[PATCH v2 12/14] media: saa7134: declare its own pads

2018-09-15 Thread Mauro Carvalho Chehab
As we don't need anymore to share pad numbers with similar drivers, use its own pad definition instead of a global model. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/saa7134/saa7134-core.c | 10 +- drivers/media/pci/saa7134/saa7134.h | 8

[PATCH v2 01/14] media: v4l2: remove VBI output pad

2018-09-15 Thread Mauro Carvalho Chehab
The signal there is the same as the video output (well, except for sliced VBI, but let's simplify the model and ignore it, at least for now - as it is routed together with raw VBI). Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/au8522_decoder.c | 1

[PATCH v2 06/14] media: au0828: use signals instead of hardcoding a pad number

2018-09-15 Thread Mauro Carvalho Chehab
When creating the audio link, use pad signals, instead of hardcoding using the pad index number. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/au0828/au0828-core.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/media

[PATCH v2 03/14] v4l2-mc: switch it to use the new approach to setup pipelines

2018-09-15 Thread Mauro Carvalho Chehab
Instead of relying on a static map for pids, use the new sig_type "taint" type to setup the pipelines with the same tipe between different entities. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- drivers/media/media-entity.c | 26 +++ drivers/media/v4l2

[PATCH v2 07/14] media: au8522: declare its own pads

2018-09-15 Thread Mauro Carvalho Chehab
As we don't need anymore to share pad numbers with similar drivers, use its own pad definition instead of a global model. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/au8522_decoder.c | 12 ++-- drivers/media/dvb-frontends/au8522_priv.h

[PATCH v2 11/14] media: si2157: declare its own pads

2018-09-15 Thread Mauro Carvalho Chehab
As we don't need anymore to share pad numbers with similar drivers, use its own pad definition instead of a global model. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- drivers/media/tuners/si2157.c | 15 --- drivers/media/tuners/si2157_priv.h | 9

[PATCH v2 05/14] media: dvb: use signals to discover pads

2018-09-15 Thread Mauro Carvalho Chehab
On tuner pads, multiple signals are present. Be sure to get the right PAD by using them. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvbdev.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/media/dvb

Re: [RFC] media-ctl: rework and merge mc_nextgen_test features

2018-09-15 Thread Mauro Carvalho Chehab
Em Sat, 15 Sep 2018 10:31:07 +0200 Hans Verkuil escreveu: > Hi Laurent, Mauro, > > We currently have two competing utilities for controlling media devices: > media-ctl and mc_nextgen_test, each with features that the other doesn't > have. That's obviously not good. Hi Hans, My goal with this

Re: [PATCH 0/4] em28xx: solve several issues pointed by v4l2-compliance

2018-09-14 Thread Mauro Carvalho Chehab
Em Fri, 14 Sep 2018 15:22:30 -0300 Mauro Carvalho Chehab escreveu: > There are several non-compliance issues on em28xx. Fix those that > I can hit with a simple grabber board like Terratec AV 350. > > I also tested it with a WinTV USB2. There, I got several other compliants &

Re: [PATCH v2 7/7] [media] tvp5150: add s_power callback

2018-09-14 Thread Mauro Carvalho Chehab
Em Fri, 14 Sep 2018 20:20:46 +0200 Marco Felsch escreveu: > Hi Sakari, > > On 18-09-14 16:23, Sakari Ailus wrote: > > Hi Marco, > > > > On Mon, Aug 13, 2018 at 11:25:08AM +0200, Marco Felsch wrote: > > > Don't en-/disable the interrupts during s_stream because someone can > > > disable the

[PATCH 2/4] media: em28xx: use a default format if TRY_FMT fails

2018-09-14 Thread Mauro Carvalho Chehab
-archive.com/linux-media@vger.kernel.org/msg56550.html Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/em28xx/em28xx-video.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c index

[PATCH 0/4] em28xx: solve several issues pointed by v4l2-compliance

2018-09-14 Thread Mauro Carvalho Chehab
some non-trivial changes. So, for now, let's do just the ones that aren't related to msp3400. Mauro Carvalho Chehab (4): media: em28xx: fix handler for vidioc_s_input() media: em28xx: use a default format if TRY_FMT fails media: em28xx: fix input name for Terratec AV 350 media: em28xx: make

[PATCH 4/4] media: em28xx: make v4l2-compliance happier by starting sequence on zero

2018-09-14 Thread Mauro Carvalho Chehab
The v4l2-compliance tool complains if a video doesn't start with a zero sequence number. While this shouldn't cause any real problem for apps, let's make it happier, in order to better check the v4l2-compliance differences before and after patchsets. Signed-off-by: Mauro Carvalho Chehab

[PATCH 3/4] media: em28xx: fix input name for Terratec AV 350

2018-09-14 Thread Mauro Carvalho Chehab
Instead of using a register value, use an AMUX name, as otherwise VIDIOC_G_AUDIO would fail. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/em28xx/em28xx-cards.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b

[PATCH 1/4] media: em28xx: fix handler for vidioc_s_input()

2018-09-14 Thread Mauro Carvalho Chehab
The a->index is not the name of the internal amux entry, but, instead a value from zero to the maximum number of audio inputs. As the actual available inputs depend on each board, build it dynamically. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/em28xx/em28xx-cards.c |

Re: [PATCH v2 0/7] TVP5150 fixes and new features

2018-09-14 Thread Mauro Carvalho Chehab
Em Fri, 14 Sep 2018 10:43:03 +0200 Marco Felsch escreveu: > Hi, > > since I sent this series I only got feedback from Rob. I'm doing some tests on it. If everything gets ok, I'll likely merge it today. > > Regards, > Marco > > On 18-08-13 11:25, Marco Felsch wrote: > > Hi, > > > > this is

[PATCH] tvp5150: avoid going past array on v4l2_querymenu()

2018-09-13 Thread Mauro Carvalho Chehab
1790c0 R14: 0002 R15: [ 279.840515] The buggy address belongs to the variable: [ 279.840535] tvp5150_test_patterns+0x10/0xe360 [tvp5150] Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/tvp5150.c | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [PATCH v2] staging: cedrus: Fix checkpatch issues

2018-09-13 Thread Mauro Carvalho Chehab
Em Thu, 13 Sep 2018 16:40:47 +0200 Maxime Ripard escreveu: > --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c > @@ -82,10 +82,7 @@ static struct cedrus_format *cedrus_find_format(u32 > pixelformat, u32 directions, > static bool

Re: [PATCH] staging: cedrus: Fix checkpatch issues

2018-09-13 Thread Mauro Carvalho Chehab
Em Thu, 13 Sep 2018 11:30:23 +0200 Maxime Ripard escreveu: > Checkpatch, when used with --strict, reports a number of issues on the > cedrus driver. > > Fix those warnings, except for a few, minor, lines too long warnings. > > Signed-off-by: Maxime Ripard > --- >

[PATCH 2/3 v2] media: replace strcpy() by strscpy()

2018-09-10 Thread Mauro Carvalho Chehab
The strcpy() function is being deprecated upstream. Replace it by the safer strscpy(). Signed-off-by: Mauro Carvalho Chehab -- v2: removed the changes at the imon driver. There, the is a debugfs node with a store function using DEVICE_ATTR() passing a char * buf without any sizing information

Re: [PATCH 2/3] media: replace strcpy() by strscpy()

2018-09-10 Thread Mauro Carvalho Chehab
Em Mon, 10 Sep 2018 16:48:47 -0300 Mauro Carvalho Chehab escreveu: > Em Mon, 10 Sep 2018 09:16:35 -0700 > Kees Cook escreveu: > > > On Mon, Sep 10, 2018 at 5:19 AM, Mauro Carvalho Chehab > > wrote: > > > The strcpy() function is being deprecated upstream.

Re: [PATCH 2/3] media: replace strcpy() by strscpy()

2018-09-10 Thread Mauro Carvalho Chehab
Em Mon, 10 Sep 2018 09:16:35 -0700 Kees Cook escreveu: > On Mon, Sep 10, 2018 at 5:19 AM, Mauro Carvalho Chehab > wrote: > > The strcpy() function is being deprecated upstream. Replace > > it by the safer strscpy(). > > Did you verify that all the destination

Re: [PATCH 3/3] media: replace strncpy() by strscpy()

2018-09-10 Thread Mauro Carvalho Chehab
Em Mon, 10 Sep 2018 09:18:05 -0700 Kees Cook escreveu: > On Mon, Sep 10, 2018 at 5:19 AM, Mauro Carvalho Chehab > wrote: > > The strncpy() function is being deprecated upstream. Replace > > it by the safer strscpy(). > > This one I'm quite concerned about. This cou

[PATCH 2/3] media: replace strcpy() by strscpy()

2018-09-10 Thread Mauro Carvalho Chehab
The strcpy() function is being deprecated upstream. Replace it by the safer strscpy(). Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/saa7146/saa7146_video.c | 2 +- drivers/media/dvb-core/dvb_frontend.c | 2 +- drivers/media/dvb-frontends/mt312.c | 9

[PATCH 0/3] Use only strscpy() for string copy

2018-09-10 Thread Mauro Carvalho Chehab
. On all cases, all the core and drivers are doing are filling some var with a name. So, we can switch all such functions by strscpy(). Mauro Carvalho Chehab (3): media: use strscpy() instead of strlcpy() media: replace strcpy() by strscpy() media: replace strncpy() by strscpy() drivers

[PATCH 3/3] media: replace strncpy() by strscpy()

2018-09-10 Thread Mauro Carvalho Chehab
The strncpy() function is being deprecated upstream. Replace it by the safer strscpy(). Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/as102_fe.c | 2 +- drivers/media/dvb-frontends/dib7000p.c | 3 ++- drivers/media/dvb-frontends/dib8000.c

Re: [PATCH] vicodec: change codec license to LGPL

2018-09-02 Thread Mauro Carvalho Chehab
Em Sun, 2 Sep 2018 12:37:04 +0200 Hans Verkuil escreveu: > The FWHT codec can also be used by userspace utilities and libraries, but > since the current license is GPL and not LGPL it is not possible to include > it in e.g. gstreamer, since LGPL is required for that. > > Change the license of

Re: [GIT PULL FOR v4.20] Add Request API for the topic branch

2018-08-31 Thread Mauro Carvalho Chehab
Em Fri, 31 Aug 2018 12:31:02 -0300 Mauro Carvalho Chehab escreveu: > Em Thu, 30 Aug 2018 12:40:38 +0200 > Hans Verkuil escreveu: > > > Hi Mauro, > > > > This is a pull request to add the Request API v18 as a topic branch. > > > > Note that this doe

Re: [GIT PULL FOR v4.20] Add Request API for the topic branch

2018-08-31 Thread Mauro Carvalho Chehab
Em Thu, 30 Aug 2018 12:40:38 +0200 Hans Verkuil escreveu: > Hi Mauro, > > This is a pull request to add the Request API v18 as a topic branch. > > Note that this does not yet include the follow-up patches: > > https://www.mail-archive.com/linux-media@vger.kernel.org/msg134630.html > > Those

Re: [PATCH v3 1/2] media: dt-bindings: bind nokia,n900-ir to generic pwm-ir-tx driver

2018-08-29 Thread Mauro Carvalho Chehab
Em Fri, 13 Jul 2018 13:22:29 +0100 Sean Young escreveu: > The generic pwm-ir-tx driver should work for the Nokia n900. > > Compile tested only. It would be good to have some tests... > > Cc: Rob Herring > Cc: Ivaylo Dimitrov > Cc: Pali Rohár > Cc: Pavel Machek > Cc: Timo Kokkonen > Cc:

Re: [RFC] Request API questions

2018-08-17 Thread Mauro Carvalho Chehab
Em Fri, 17 Aug 2018 12:09:40 +0200 Hans Verkuil escreveu: > On 17/08/18 12:02, Tomasz Figa wrote: > > On Thu, Aug 16, 2018 at 8:15 PM Mauro Carvalho Chehab > > wrote: > >> > >> Em Thu, 16 Aug 2018 12:25:25 +0200 > >> Hans Verkuil escreveu: &g

[RFP] Media Summit: Complex cameras

2018-08-16 Thread Mauro Carvalho Chehab
I expect that we could have something to discuss there about complex cameras. So, I'd reserve a 50 mins slot for it. The idea is to discuss about the undergoing work with complex camera development is happening. As we're working to merge request API, another topic for discussion is how to add

Re: [RFC] Request API questions

2018-08-16 Thread Mauro Carvalho Chehab
Em Thu, 16 Aug 2018 12:25:25 +0200 Hans Verkuil escreveu: > Laurent raised a few API issues/questions in his review of the documentation. > > I've consolidated those in this RFC. I would like to know what others think > and if I should make changes. > > 1) Should you be allowed to set controls

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-08-16 Thread Mauro Carvalho Chehab
Em Thu, 16 Aug 2018 11:58:09 +0200 Hans Verkuil escreveu: > >> This is set by the user when > >> calling > >> + :ref:`ioctl VIDIOC_QBUF ` and ignored by other ioctls. > > > > Shouldn't other ioctls return an error when V4L2_BUF_FLAG_REQUEST_FD is set > > ? > > Should they? I'd like to

Re: [PATCHv18 19/35] vb2: store userspace data in vb2_v4l2_buffer

2018-08-15 Thread Mauro Carvalho Chehab
Em Wed, 15 Aug 2018 13:54:53 +0200 Hans Verkuil escreveu: > On 14/08/18 21:47, Mauro Carvalho Chehab wrote: > > Em Tue, 14 Aug 2018 16:20:31 +0200 > > Hans Verkuil escreveu: > > > > >> diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c >

Re: [RFC] Request API and V4L2 capabilities

2018-08-15 Thread Mauro Carvalho Chehab
Em Sat, 4 Aug 2018 15:50:04 +0200 Hans Verkuil escreveu: > Hi all, > > While the Request API patch series addresses all the core API issues, there > are some high-level considerations as well: > > 1) How can the application tell that the Request API is supported and for >which buffer types

Re: [PATCHv18 18/35] videobuf2-v4l2: replace if by switch in __fill_vb2_buffer()

2018-08-15 Thread Mauro Carvalho Chehab
Em Tue, 14 Aug 2018 16:20:30 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Replace 'if' statements by a switch in __fill_vb2_buffer() > in preparation of the next patch. > > No other changes. > > Signed-off-by: Hans Verkuil Reviewed-by: Mauro Carvalho Ch

Re: [PATCHv18 00/35] Request API

2018-08-14 Thread Mauro Carvalho Chehab
Em Tue, 14 Aug 2018 17:01:07 -0300 Mauro Carvalho Chehab escreveu: > > > > Besides all the review comments I also fixed a bug. See: > > https://www.mail-archive.com/linux-media@vger.kernel.org/msg134311.html > > I'll look on it right now. Sorry, I meant

Re: [PATCHv18 00/35] Request API

2018-08-14 Thread Mauro Carvalho Chehab
Em Tue, 14 Aug 2018 16:20:12 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Hi all, > > This is version 18 of the Request API series. The intention is that > this will become a topic branch in preparation of merging this for > 4.20 together with the cedrus staging driver. > > I

Re: [PATCHv18 31/35] v4l2-mem2mem: add vb2_m2m_request_queue

2018-08-14 Thread Mauro Carvalho Chehab
Instead this helper function will do that when the request is actually > queued. > > Signed-off-by: Hans Verkuil Reviewed-by: Mauro Carvalho Chehab > --- > drivers/media/v4l2-core/v4l2-mem2mem.c | 63 ++ > include/media/v4l2-mem2mem.h |

Re: [PATCHv18 28/35] videobuf2-v4l2: add vb2_request_queue/validate helpers

2018-08-14 Thread Mauro Carvalho Chehab
queue helper function queues all buffer > objects in the validated request. Reviewed-by: Mauro Carvalho Chehab > > Signed-off-by: Hans Verkuil > --- > .../media/common/videobuf2/videobuf2-v4l2.c | 51 +++ > include/media/videobuf2-v4l2.h|

Re: [PATCHv18 24/35] videobuf2-core: embed media_request_object

2018-08-14 Thread Mauro Carvalho Chehab
Em Tue, 14 Aug 2018 16:20:36 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Make vb2_buffer a request object. > > Signed-off-by: Hans Verkuil I had already sent a reviewed-by to this. Anyway: Reviewed-by: Mauro Carvalho Chehab > --- > include/media/videobuf2

Re: [PATCHv18 21/35] vb2: drop VB2_BUF_STATE_PREPARED, use bool prepared/synced instead

2018-08-14 Thread Mauro Carvalho Chehab
ut more a property of the > buffer. So make new 'prepared' and 'synced' bools instead to remember > whether the buffer is prepared and/or synced or not. > > V4L2_BUF_FLAG_PREPARED is only set if the buffer is both synced and > prepared and in the DEQUEUED state. > > Signed-off-by: Han

Re: [PATCHv18 19/35] vb2: store userspace data in vb2_v4l2_buffer

2018-08-14 Thread Mauro Carvalho Chehab
Em Tue, 14 Aug 2018 16:20:31 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > The userspace-provided plane data needs to be stored in > vb2_v4l2_buffer. Currently this information is applied by > __fill_vb2_buffer() which is called by the core prepare_buf > and qbuf functions, but when

Re: [PATCHv18 17/35] videobuf2-v4l2: move __fill_v4l2_buffer() function

2018-08-14 Thread Mauro Carvalho Chehab
Em Tue, 14 Aug 2018 16:20:29 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Move the __fill_v4l2_buffer() to before the vb2_queue_or_prepare_buf() > function to prepare for the next two patches. > > No other changes. > > Signed-off-by: Hans Verkuil Reviewed-b

Re: [PATCHv18 16/35] v4l2-ctrls: add v4l2_ctrl_request_hdl_find/put/ctrl_find functions

2018-08-14 Thread Mauro Carvalho Chehab
return res; > > Signed-off-by: Hans Verkuil Reviewed-by: Mauro Carvalho Chehab > --- > drivers/media/v4l2-core/v4l2-ctrls.c | 25 ++ > include/media/v4l2-ctrls.h | 49 +++- > 2 files changed, 73 insertions(+), 1 deletion(-) > >

Re: [PATCHv18 15/35] v4l2-ctrls: support g/s_ext_ctrls for requests

2018-08-14 Thread Mauro Carvalho Chehab
; > Signed-off-by: Hans Verkuil Reviewed-by: Mauro Carvalho Chehab > --- > drivers/media/platform/omap3isp/ispvideo.c | 2 +- > drivers/media/v4l2-core/v4l2-ctrls.c | 138 +++-- > drivers/media/v4l2-core/v4l2-ioctl.c | 12 +- > driver

Re: [PATCHv18 14/35] v4l2-ctrls: add core request support

2018-08-14 Thread Mauro Carvalho Chehab
mal when dealing with large compound and/or array controls. > > For the initial 'stateless codec' use-case the current implementation is > sufficient. > > Signed-off-by: Hans Verkuil Reviewed-by: Mauro Carvalho Chehab > --- > drivers/media/v4l2-core/v4l2-ctrls.c | 336

Re: [PATCHv18 08/35] v4l2-dev: lock req_queue_mutex

2018-08-14 Thread Mauro Carvalho Chehab
f-by: Sakari Ailus I didn't test this patch series with sparse yet. When merging on a topic branch, I'll let you know if it applies cleanly. Anyway: Reviewed-by: Mauro Carvalho Chehab > --- > drivers/media/v4l2-core/v4l2-dev.c | 18 -- > drivers/media/v4l2-core/v4l2-

Re: [PATCHv18 03/35] media-request: implement media requests

2018-08-14 Thread Mauro Carvalho Chehab
> objects in the request are completed (or unbound), then the request > fd will signal an exception (poll). > > Signed-off-by: Hans Verkuil > Co-developed-by: Sakari Ailus > Signed-off-by: Sakari Ailus > Co-developed-by: Laurent Pinchart > Co-developed-by: Alexandr

Re: [PATCHv18 02/35] uapi/linux/media.h: add request API

2018-08-14 Thread Mauro Carvalho Chehab
request to the driver and to re-initialize the > request. > > Signed-off-by: Hans Verkuil > Acked-by: Sakari Ailus > Reviewed-by: Laurent Pinchart Reviewed-by: Mauro Carvalho Chehab > --- > include/uapi/linux/media.h | 8 > 1 file changed, 8 insertions(+) &

Re: [PATCHv18 01/35] Documentation: v4l: document request API

2018-08-14 Thread Mauro Carvalho Chehab
need to push the no-invariant-sections upstream before merging this there. With that: Reviewed-by: Mauro Carvalho Chehab > > Signed-off-by: Alexandre Courbot > Signed-off-by: Hans Verkuil > --- > .../media/uapi/mediactl/media-controller.rst | 1 + > .../media/uapi/mediactl/media-funcs

Re: [BUG, RFC] media: Wrong module gets acquired

2018-08-14 Thread Mauro Carvalho Chehab
Em Tue, 14 Aug 2018 11:35:01 +0300 Sakari Ailus escreveu: > Hi Pert, > > On Mon, Aug 13, 2018 at 06:33:12PM +0200, petrcve...@gmail.com wrote: > > From: Petr Cvek > > > > When transferring a media sensor driver from the soc_camera I've found > > the controller module can get removed (which

Re: [PATCHv17 08/34] v4l2-dev: lock req_queue_mutex

2018-08-14 Thread Mauro Carvalho Chehab
Em Tue, 14 Aug 2018 14:00:16 +0200 Hans Verkuil escreveu: > On 09/08/18 22:03, Mauro Carvalho Chehab wrote: > > Em Sat, 4 Aug 2018 14:45:00 +0200 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> We need to serialize streamon/o

Re: [PATCHv17 02/34] uapi/linux/media.h: add request API

2018-08-14 Thread Mauro Carvalho Chehab
Em Tue, 14 Aug 2018 11:57:48 +0200 Hans Verkuil escreveu: > On 14/08/18 10:46, Mauro Carvalho Chehab wrote: > > Em Fri, 10 Aug 2018 09:21:59 +0200 > > Hans Verkuil escreveu: > > > >> On 08/09/2018 07:53 PM, Mauro Carvalho Chehab wrote: > >>> Em

Re: [PATCHv17 01/34] Documentation: v4l: document request API

2018-08-14 Thread Mauro Carvalho Chehab
Em Tue, 14 Aug 2018 11:51:30 +0200 Hans Verkuil escreveu: > On 14/08/18 10:48, Mauro Carvalho Chehab wrote: > > Em Tue, 14 Aug 2018 09:57:27 +0200 > > Hans Verkuil escreveu: > > > >> On 09/08/18 19:43, Mauro Carvalho Chehab wrote: > >>>> dif

Re: Using big platform driver as foundation to implement TV driver framework in Linux

2018-08-14 Thread Mauro Carvalho Chehab
Hi Jesse, Em Mon, 13 Aug 2018 01:32:45 + Jesse Huang (黃建興) escreveu: > Hi Mchehab, > Hi Linux-Media, > > MTK/MStar try to move TV SOC proprietary driver framework to Linux TV driver. > > But, we also need to share/re-use driver code to non-OS which is a size > limitation low cost system.

Re: [PATCHv17 19/34] vb2: drop VB2_BUF_STATE_PREPARED, use bool prepared/synced instead

2018-08-14 Thread Mauro Carvalho Chehab
Em Tue, 14 Aug 2018 10:58:59 +0200 Hans Verkuil escreveu: > On 13/08/18 13:30, Mauro Carvalho Chehab wrote: > > Em Sat, 4 Aug 2018 14:45:11 +0200 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> The PREPARED state becomes a p

Re: [PATCHv17 05/34] media-request: add media_request_get_by_fd

2018-08-14 Thread Mauro Carvalho Chehab
Em Fri, 10 Aug 2018 09:32:53 +0200 Hans Verkuil escreveu: > On 08/09/2018 09:55 PM, Mauro Carvalho Chehab wrote: > > Em Sat, 4 Aug 2018 14:44:57 +0200 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> Add media_request

Re: [PATCHv17 14/34] v4l2-ctrls: add core request support

2018-08-14 Thread Mauro Carvalho Chehab
Em Tue, 14 Aug 2018 10:34:47 +0200 Hans Verkuil escreveu: > >> +void v4l2_ctrl_request_setup(struct media_request *req, > >> + struct v4l2_ctrl_handler *main_hdl) > >> +{ > >> + struct media_request_object *obj; > >> + struct v4l2_ctrl_handler *hdl; > >> + struct

<    1   2   3   4   5   6   7   8   9   10   >