Re: [PATCH v2 1/3] staging: greybus: light: fix memory leak in v4l2 register

2017-08-10 Thread Rui Miguel Silva
Hi, On Thu, Aug 10, 2017 at 04:56:50PM +0300, Sakari Ailus wrote: > Hi Hans, > > On Thu, Aug 10, 2017 at 03:02:46PM +0200, Hans Verkuil wrote: > > > @@ -534,25 +534,20 @@ static int gb_lights_light_v4l2_register(struct > > > gb_light *light) > > > { > > > struct gb_connection *connection =

Re: [PATCH v2 2/3] v4l2-flash-led-class: Create separate sub-devices for indicators

2017-08-09 Thread Rui Miguel Silva
4 +- > drivers/media/v4l2-core/v4l2-flash-led-class.c | 113 > +++-- > drivers/staging/greybus/light.c | 23 +++-- For greybus/light: Reviewed-by: Rui Miguel Silva <rmf...@gmail.com> --- Cheers, Rui

Re: [PATCH 1/2] staging: greybus: light: Don't leak memory for no gain

2017-07-27 Thread Rui Miguel Silva
Hi, On Wed, Jul 26, 2017 at 08:32:08PM +0200, Pavel Machek wrote: > Hi! > > > On Tue, Jul 25, 2017 at 02:30:31PM +0200, Johan Hovold wrote: > > > [ +CC: Rui and Greg ] > > > > Thanks Johan. I only got this because of you. > > > > > return ret; > > > > } > > > > > > And while it's fine

Re: [PATCH 1/2] staging: greybus: light: Don't leak memory for no gain

2017-07-26 Thread Rui Miguel Silva
Hi, On Tue, Jul 25, 2017 at 02:30:31PM +0200, Johan Hovold wrote: > [ +CC: Rui and Greg ] Thanks Johan. I only got this because of you. > > On Tue, Jul 18, 2017 at 09:41:06PM +0300, Sakari Ailus wrote: > > Memory for struct v4l2_flash_config is allocated in > > gb_lights_light_v4l2_register()

Re: [PATCH v2 1/3] staging: greybus: light: fix memory leak in v4l2 register

2017-08-09 Thread Rui Miguel Silva
Hi Sakari, On Wed, Aug 09, 2017 at 06:36:59PM +0300, Sakari Ailus wrote: > Hi Rui, > > On Wed, Aug 09, 2017 at 02:20:02PM +0100, Rui Miguel Silva wrote: > > Hi Sakari, > > On Wed, Aug 09, 2017 at 02:15:53PM +0300, Sakari Ailus wrote: > > > From: Rui Miguel Silva <

Re: [PATCH v2 1/3] staging: greybus: light: fix memory leak in v4l2 register

2017-08-09 Thread Rui Miguel Silva
Hi Sakari, On Wed, Aug 09, 2017 at 02:15:53PM +0300, Sakari Ailus wrote: > From: Rui Miguel Silva <rmf...@gmail.com> > > We are allocating memory for the v4l2 flash configuration structure and > leak it in the normal path. Just use the stack for this as we do not > use it out

[PATCH v6 0/2] media: Introduce Omnivision OV2680 driver

2018-05-09 Thread Rui Miguel Silva
cluster Cheers, Rui Rui Miguel Silva (2): media: ov2680: dt: Add bindings for OV2680 media: ov2680: Add Omnivision OV2680 sensor driver .../devicetree/bindings/media/i2c/ov2680.txt | 46 + drivers/media/i2c/Kconfig | 12 + drivers/media/i2c/Makefile

[PATCH v6 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-05-09 Thread Rui Miguel Silva
auto/manual gain, - gain, - horizontal/vertical flip, - test pattern menu. Supported resolution are only: QUXGA, 720P, UXGA. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/media/i2c/Kconfig | 12 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov26

[PATCH v6 1/2] media: ov2680: dt: Add bindings for OV2680

2018-05-09 Thread Rui Miguel Silva
Add device tree binding documentation for the OV2680 camera sensor. CC: devicet...@vger.kernel.org Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- .../devicetree/bindings/media/i2c/ov2680.txt | 46 +++ 1 file changed, 46 insertions(+) create mode 100644 Documen

Re: [PATCH v3 07/14] media: dt-bindings: add bindings for i.MX7 media driver

2018-05-09 Thread Rui Miguel Silva
Hi Philipp, Thanks for the review. On Tue 08 May 2018 at 14:30, Philipp Zabel wrote: On Mon, 2018-05-07 at 17:21 +0100, Rui Miguel Silva wrote: Add bindings documentation for i.MX7 media drivers. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- .../devicetree/bindings/medi

Re: [PATCH v3 12/14] ARM: dts: imx7s-warp: add ov2680 sensor node

2018-05-09 Thread Rui Miguel Silva
Hi Fabio, On Tue 08 May 2018 at 13:28, Fabio Estevam wrote: Hi Rui, On Mon, May 7, 2018 at 1:21 PM, Rui Miguel Silva <rui.si...@linaro.org> wrote: + reg_peri_3p15v: regulator-peri-3p15v { + compatible = "regulator-fixed"; + regulator-name =

Re: [PATCH 0/4] media: ov2680: follow up from initial version

2018-05-09 Thread Rui Miguel Silva
Hi Sakari, On Tue 08 May 2018 at 20:03, Sakari Ailus wrote: Hi, On Mon, May 07, 2018 at 04:56:51PM +0100, Rui Miguel Silva wrote: Sorry I have Out-of-Office some part of last week, I had v6 of the original series ready but since I have received the notification from patchwork that the v5

Re: [PATCH v3 10/14] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2018-05-09 Thread Rui Miguel Silva
Hi Philipp, Thanks. On Wed 09 May 2018 at 08:53, Philipp Zabel wrote: On Mon, 2018-05-07 at 17:21 +0100, Rui Miguel Silva wrote: This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture

Re: [PATCH v3 13/14] media: imx7.rst: add documentation for i.MX7 media driver

2018-05-09 Thread Rui Miguel Silva
Hi Randy, On Tue 08 May 2018 at 17:24, Randy Dunlap wrote: Hi, I have a few editing suggestions below... Thank you very much for this. I will incorporate this in the next version. --- Cheers, Rui On 05/07/2018 09:21 AM, Rui Miguel Silva wrote: Add rst document to describe

[PATCH 4/4] media: ov2680: add regulators to supply control

2018-05-07 Thread Rui Miguel Silva
Add the code to control the regulators for the analogue and digital power supplies. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/media/i2c/ov2680.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/media/i2c/ov2680.c b/d

[PATCH 1/4] media: ov2680: dt: add voltage supplies as required

2018-05-07 Thread Rui Miguel Silva
The ov2680 needs to control 3 regulators for the voltage supplies and that was missing by the first description, added their description and example here. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- Documentation/devicetree/bindings/media/i2c/ov2680.txt | 8 +++-

[PATCH 2/4] media: ov2680: dt: rename gpio to reset and fix polarity

2018-05-07 Thread Rui Miguel Silva
-by: Rui Miguel Silva <rui.si...@linaro.org> --- Documentation/devicetree/bindings/media/i2c/ov2680.txt | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/media/i2c/ov2680.txt b/Documentation/devicetree/bindings/media/i2c/ov26

[PATCH 0/4] media: ov2680: follow up from initial version

2018-05-07 Thread Rui Miguel Silva
polarity and naming. Cheers, Rui Rui Miguel Silva (4): media: ov2680: dt: add voltage supplies as required media: ov2680: dt: rename gpio to reset and fix polarity media: ov2680: rename powerdown gpio and fix polarity media: ov2680: add regulators to supply control .../devicetree/bindings

[PATCH 3/4] media: ov2680: rename powerdown gpio and fix polarity

2018-05-07 Thread Rui Miguel Silva
Rename the power control gpio to reset, since it is the same, and fix the polarity code since this gpio is active at low and not at high as controlled before. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/media/i2c/ov2680.c | 20 ++-- 1 file chang

[PATCH v3 07/14] media: dt-bindings: add bindings for i.MX7 media driver

2018-05-07 Thread Rui Miguel Silva
Add bindings documentation for i.MX7 media drivers. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- .../devicetree/bindings/media/imx7.txt| 152 ++ 1 file changed, 152 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/imx7.txt

[PATCH v3 13/14] media: imx7.rst: add documentation for i.MX7 media driver

2018-05-07 Thread Rui Miguel Silva
Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- Documentation/media/v4l-drivers/imx7.rst | 157 ++ Documentation/media/v4l-d

[PATCH v3 14/14] media: staging/imx: add i.MX7 entries to TODO file

2018-05-07 Thread Rui Miguel Silva
Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5

[PATCH v3 11/14] ARM: dts: imx7s: add capture subsystem

2018-05-07 Thread Rui Miguel Silva
Add media capture subsystem device to i.MX7 definitions. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- arch/arm/boot/dts/imx7s.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index 0bae41f2944c..058e0c

[PATCH v3 12/14] ARM: dts: imx7s-warp: add ov2680 sensor node

2018-05-07 Thread Rui Miguel Silva
Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete the camera data path for this system. Add the needed regulator to the analog voltage supply. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- arch/arm/boot/dts/imx7s-warp.dt

Re: [PATCH v2 08/15] media: dt-bindings: add bindings for i.MX7 media driver

2018-05-07 Thread Rui Miguel Silva
Hi Rob, Thanks for the review and sorry for the late reply. Meanwhile I have send v3 of this series with some of yours comments incorporated. On Fri 27 Apr 2018 at 19:06, Rob Herring wrote: On Mon, Apr 23, 2018 at 02:47:43PM +0100, Rui Miguel Silva wrote: Add bindings documentation

[PATCH v3 05/14] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2018-05-07 Thread Rui Miguel Silva
Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1154 2 files changed

[PATCH v3 06/14] media: staging/imx: add imx7 capture subsystem

2018-05-07 Thread Rui Miguel Silva
Add imx7 capture subsystem to imx-media core to allow the use some of the existing modules for i.MX5/6 with i.MX7 SoC. Since i.MX7 does not have an IPU, add driver data with unset ipu_present flag that change some runtime behaviors. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.

[PATCH v3 02/14] media: staging/imx7: add imx7 CSI subdev driver

2018-05-07 Thread Rui Miguel Silva
This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/staging/media/imx/Kconfig |9 +- drivers/staging/media/imx/Makefile |2 + drivers/staging/media/imx/imx7

[PATCH v3 10/14] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2018-05-07 Thread Rui Miguel Silva
This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Also add the pin control related with the mipi_csi in that board. Signed-off-by: Rui Miguel Silva

[PATCH v3 00/14] media: staging/imx7: add i.MX7 media driver

2018-05-07 Thread Rui Miguel Silva
rted) test Scaling: OK (Not Supported) Codec ioctls: test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls: test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK (Not Supported)

[PATCH v3 03/14] clk: imx7d: fix mipi dphy div parent

2018-05-07 Thread Rui Miguel Silva
Fixes: 8f6d8094b215 ("ARM: imx: add imx7d clk tree support") Cc: linux-...@vger.kernel.org Acked-by: Dong Aisheng <aisheng.d...@nxp.com> Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/clk/imx/clk-imx7d.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[PATCH v3 09/14] ARM: dts: imx7s: add multiplexer controls

2018-05-07 Thread Rui Miguel Silva
The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register and mask. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- arch/arm/boot/dts/imx7s.dtsi | 8 +++-

[PATCH v3 04/14] clk: imx7d: reset parent for mipi csi root

2018-05-07 Thread Rui Miguel Silva
awn...@kernel.org> Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/clk/imx/clk-imx7d.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c index f7f4db2e6fa6..27877d05faa2 100644 --- a/drivers/clk/imx/clk-imx7d.c +

[PATCH v3 08/14] ARM: dts: imx7s: add mipi phy power domain

2018-05-07 Thread Rui Miguel Silva
Add power domain index 0 related with mipi-phy to imx7s. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- arch/arm/boot/dts/imx7s.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index 4d42335c0dee..67450a

[PATCH v3 01/14] media: staging/imx: add support to media dev for no IPU systems

2018-05-07 Thread Rui Miguel Silva
Some i.MX SoC do not have IPU, like the i.MX7, add to the the media device infrastructure support to be used in this type of systems that do not have internal subdevices besides the CSI. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/staging/media/imx/imx-media-dev.c

Re: [PATCH 0/4] media: ov2680: follow up from initial version

2018-05-08 Thread Rui Miguel Silva
Ola Fabio, On Tue 08 May 2018 at 13:29, Fabio Estevam wrote: Hi Rui, On Mon, May 7, 2018 at 12:56 PM, Rui Miguel Silva <rui.si...@linaro.org> wrote: Sorry I have Out-of-Office some part of last week, I had v6 of the original series ready but since I have received the notificatio

Re: [PATCH v4 06/12] media: dt-bindings: add bindings for i.MX7 media driver

2018-05-18 Thread Rui Miguel Silva
Hi Sakari, Thanks for the review. On Fri 18 May 2018 at 06:58, Sakari Ailus wrote: Hi Rui, On Thu, May 17, 2018 at 01:50:27PM +0100, Rui Miguel Silva wrote: Add bindings documentation for i.MX7 media drivers. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- .../devicetree/bi

Re: [PATCH v4 03/12] clk: imx7d: fix mipi dphy div parent

2018-05-18 Thread Rui Miguel Silva
Hi Stephen, On Thu 17 May 2018 at 18:05, Stephen Boyd wrote: Quoting Rui Miguel Silva (2018-05-17 05:50:24) Fix the mipi dphy root divider to mipi_dphy_pre_div, this would remove a orphan clock and set the correct parent. before: cat clk_orphan_summary enable

[PATCH v5 02/12] media: staging/imx7: add imx7 CSI subdev driver

2018-05-18 Thread Rui Miguel Silva
This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/staging/media/imx/Kconfig |9 +- drivers/staging/media/imx/Makefile |2 + drivers/staging/media/imx/imx7

[PATCH v5 01/12] media: staging/imx: refactor imx media device probe

2018-05-18 Thread Rui Miguel Silva
not have). Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/staging/media/imx/Makefile| 1 + .../staging/media/imx/imx-media-dev-common.c | 102 ++ drivers/staging/media/imx/imx-media-dev.c | 89 --- .../staging/media/imx/imx

[PATCH v5 05/12] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2018-05-18 Thread Rui Miguel Silva
Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1154 2 files changed

[PATCH v5 03/12] clk: imx7d: fix mipi dphy div parent

2018-05-18 Thread Rui Miguel Silva
Fixes: 8f6d8094b215 ("ARM: imx: add imx7d clk tree support") Acked-by: Dong Aisheng <aisheng.d...@nxp.com> Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/clk/imx/clk-imx7d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v5 04/12] clk: imx7d: reset parent for mipi csi root

2018-05-18 Thread Rui Miguel Silva
ed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/clk/imx/clk-imx7d.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c index f7f4db2e6fa6..27877d05faa2 100644 --- a/drivers/clk/imx/clk-imx7d.c +++ b/drivers/clk/imx/clk-imx7d

[PATCH v5 06/12] media: dt-bindings: add bindings for i.MX7 media driver

2018-05-18 Thread Rui Miguel Silva
Add bindings documentation for i.MX7 media drivers. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- .../devicetree/bindings/media/imx7.txt| 125 ++ 1 file changed, 125 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/imx7.txt

[PATCH v5 00/12] media: staging/imx7: add i.MX7 media driver

2018-05-18 Thread Rui Miguel Silva
Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls: test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK (Not Supported) test VIDIOC_EXPBUF: OK (Not Supported) Total: 267, Succeeded: 257, Failed: 10, Warnings: 0 Rui Miguel Silva (12): media: staging/imx: re

[PATCH v5 08/12] ARM: dts: imx7s: add multiplexer controls

2018-05-18 Thread Rui Miguel Silva
The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register and mask. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> Reviewed-by: Philipp Zabel <p.za...@pengutronix.de&g

[PATCH v5 09/12] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2018-05-18 Thread Rui Miguel Silva
This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Also add the pin control related with the mipi_csi in that board. Signed-off-by: Rui Miguel Silva

[PATCH v5 12/12] media: staging/imx: add i.MX7 entries to TODO file

2018-05-18 Thread Rui Miguel Silva
Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5

[PATCH v5 10/12] ARM: dts: imx7s-warp: add ov2680 sensor node

2018-05-18 Thread Rui Miguel Silva
Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete the camera data path for this system. Add the needed regulator to the analog voltage supply, the port and endpoints in mipi_csi node and the pinctrl for the reset gpio. Signed-off-by: Rui Miguel Silva <rui

[PATCH v5 07/12] ARM: dts: imx7s: add mipi phy power domain

2018-05-18 Thread Rui Miguel Silva
Add power domain index 0 related with mipi-phy to imx7s. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- arch/arm/boot/dts/imx7s.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index 4d42335c0dee..67450a

[PATCH v5 11/12] media: imx7.rst: add documentation for i.MX7 media driver

2018-05-18 Thread Rui Miguel Silva
Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- Documentation/media/v4l-drivers/imx7.rst | 157 ++ Documentation/media/v4l-d

[PATCH v4 10/12] ARM: dts: imx7s-warp: add ov2680 sensor node

2018-05-17 Thread Rui Miguel Silva
Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete the camera data path for this system. Add the needed regulator to the analog voltage supply, the port and endpoints in mipi_csi node and the pinctrl for the reset gpio. Signed-off-by: Rui Miguel Silva <rui

[PATCH v4 04/12] clk: imx7d: reset parent for mipi csi root

2018-05-17 Thread Rui Miguel Silva
awn...@kernel.org> Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/clk/imx/clk-imx7d.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c index f7f4db2e6fa6..27877d05faa2 100644 --- a/drivers/clk/imx/clk-imx7d.c +

[PATCH v4 07/12] ARM: dts: imx7s: add mipi phy power domain

2018-05-17 Thread Rui Miguel Silva
Add power domain index 0 related with mipi-phy to imx7s. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- arch/arm/boot/dts/imx7s.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index 4d42335c0dee..67450a

[PATCH v4 02/12] media: staging/imx7: add imx7 CSI subdev driver

2018-05-17 Thread Rui Miguel Silva
This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/staging/media/imx/Kconfig |9 +- drivers/staging/media/imx/Makefile |2 + drivers/staging/media/imx/imx7

[PATCH v4 05/12] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2018-05-17 Thread Rui Miguel Silva
Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1154 2 files changed

[PATCH v4 00/12] media: staging/imx7: add i.MX7 media driver

2018-05-17 Thread Rui Miguel Silva
pported) test Scaling: OK (Not Supported) Codec ioctls: test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls: test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK (No

[PATCH v4 01/12] media: staging/imx: refactor imx media device probe

2018-05-17 Thread Rui Miguel Silva
not). Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/staging/media/imx/Makefile| 1 + .../staging/media/imx/imx-media-dev-common.c | 102 ++ drivers/staging/media/imx/imx-media-dev.c | 89 --- .../staging/media/imx/imx

[PATCH v4 06/12] media: dt-bindings: add bindings for i.MX7 media driver

2018-05-17 Thread Rui Miguel Silva
Add bindings documentation for i.MX7 media drivers. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- .../devicetree/bindings/media/imx7.txt| 145 ++ 1 file changed, 145 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/imx7.txt

[PATCH v4 08/12] ARM: dts: imx7s: add multiplexer controls

2018-05-17 Thread Rui Miguel Silva
The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register and mask. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> Reviewed-by: Philipp Zabel <p.za...@pengutronix.de&g

[PATCH v4 09/12] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2018-05-17 Thread Rui Miguel Silva
This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Also add the pin control related with the mipi_csi in that board. Signed-off-by: Rui Miguel Silva

[PATCH v4 03/12] clk: imx7d: fix mipi dphy div parent

2018-05-17 Thread Rui Miguel Silva
Fixes: 8f6d8094b215 ("ARM: imx: add imx7d clk tree support") Cc: linux-...@vger.kernel.org Acked-by: Dong Aisheng <aisheng.d...@nxp.com> Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/clk/imx/clk-imx7d.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[PATCH v4 11/12] media: imx7.rst: add documentation for i.MX7 media driver

2018-05-17 Thread Rui Miguel Silva
Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- .../devicetree/bindings/media/imx7.txt| 20 --- Documentation/media/v4l-drivers/imx7.rst

[PATCH v4 12/12] media: staging/imx: add i.MX7 entries to TODO file

2018-05-17 Thread Rui Miguel Silva
Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5

[PATCH v6 02/13] media: staging/imx: rearrange group id to take in account IPU

2018-05-22 Thread Rui Miguel Silva
with IPU have internal subdevices. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/staging/media/imx/imx-ic-common.c | 6 ++--- drivers/staging/media/imx/imx-ic-prp.c| 14 +-- drivers/staging/media/imx/imx-media-csi.c | 6 ++--- drivers/staging/media/i

[PATCH v6 03/13] media: staging/imx7: add imx7 CSI subdev driver

2018-05-22 Thread Rui Miguel Silva
This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/staging/media/imx/Kconfig |9 +- drivers/staging/media/imx/Makefile |2 + drivers/staging/media/imx/imx7

[PATCH v6 04/13] clk: imx7d: fix mipi dphy div parent

2018-05-22 Thread Rui Miguel Silva
Fixes: 8f6d8094b215 ("ARM: imx: add imx7d clk tree support") Acked-by: Dong Aisheng <aisheng.d...@nxp.com> Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/clk/imx/clk-imx7d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v6 07/13] media: dt-bindings: add bindings for i.MX7 media driver

2018-05-22 Thread Rui Miguel Silva
Add bindings documentation for i.MX7 media drivers. The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- .../devicetree/bindings/media/imx7-csi.txt| 44 ++ .../bindings/media/imx7-mipi-csi2.txt

[PATCH v6 08/13] ARM: dts: imx7s: add mipi phy power domain

2018-05-22 Thread Rui Miguel Silva
Add power domain index 0 related with mipi-phy to imx7s. While at it rename pcie power-domain node to remove pgc prefix. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- arch/arm/boot/dts/imx7s.dtsi | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ar

[PATCH v6 06/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2018-05-22 Thread Rui Miguel Silva
Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1134 2 files changed

[PATCH v6 05/13] clk: imx7d: reset parent for mipi csi root

2018-05-22 Thread Rui Miguel Silva
ed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/clk/imx/clk-imx7d.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c index f7f4db2e6fa6..27877d05faa2 100644 --- a/drivers/clk/imx/clk-imx7d.c +++ b/drivers/clk/imx/clk-imx7d

[PATCH v6 01/13] media: staging/imx: refactor imx media device probe

2018-05-22 Thread Rui Miguel Silva
Refactor and move media device initialization code to a new common module, so it can be used by other devices, this will allow for example a near to introduce imx7 CSI driver, to use this media device. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/staging/media/imx/Ma

[PATCH v6 00/13] media: staging/imx7: add i.MX7 media driver

2018-05-22 Thread Rui Miguel Silva
Not Supported) test Scaling: OK (Not Supported) Codec ioctls: test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls: test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK (Not S

Re: [PATCH v4 06/12] media: dt-bindings: add bindings for i.MX7 media driver

2018-05-22 Thread Rui Miguel Silva
Hi Sakari, On Fri 18 May 2018 at 22:13, Sakari Ailus wrote: On Fri, May 18, 2018 at 09:27:58AM +0100, Rui Miguel Silva wrote: > > +endpoint node > > +- > > + > > +- data-lanes: (required) an array specifying active > > physical > > M

[PATCH v6 12/13] media: imx7.rst: add documentation for i.MX7 media driver

2018-05-22 Thread Rui Miguel Silva
Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- Documentation/media/v4l-drivers/imx7.rst | 157 ++ Documentation/media/v4l-d

[PATCH v6 09/13] ARM: dts: imx7s: add multiplexer controls

2018-05-22 Thread Rui Miguel Silva
The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register and mask. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> Reviewed-by: Philipp Zabel <p.za...@pengutronix.de&g

[PATCH v6 13/13] media: staging/imx: add i.MX7 entries to TODO file

2018-05-22 Thread Rui Miguel Silva
Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5

[PATCH v6 11/13] ARM: dts: imx7s-warp: add ov2680 sensor node

2018-05-22 Thread Rui Miguel Silva
Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete the camera data path for this system. Add the needed regulator to the analog voltage supply, the port and endpoints in mipi_csi node and the pinctrl for the reset gpio. Signed-off-by: Rui Miguel Silva <rui

[PATCH v6 10/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2018-05-22 Thread Rui Miguel Silva
This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- arch/arm/boot/dts/imx7s-warp.dt

Re: [PATCH v2] media: video-mux: fix compliance failures

2018-05-24 Thread Rui Miguel Silva
Hi, On Wed 23 May 2018 at 09:24, Philipp Zabel wrote: Limit frame sizes to the [1, 65536] interval, media bus formats to the available list of formats, and initialize pad and try formats. Reported-by: Rui Miguel Silva <rui.si...@linaro.org> Signed-off-by: Philipp Zabel <p.za...@pengu

Re: [PATCH v6 1/2] media: ov2680: dt: Add bindings for OV2680

2018-05-18 Thread Rui Miguel Silva
Hi Rob, On Fri 18 May 2018 at 14:18, Rob Herring wrote: On Wed, May 09, 2018 at 03:31:58PM +0100, Rui Miguel Silva wrote: Add device tree binding documentation for the OV2680 camera sensor. CC: devicet...@vger.kernel.org Signed-off-by: Rui Miguel Silva <rui.si...@linaro.

Re: [PATCH v5 01/12] media: staging/imx: refactor imx media device probe

2018-05-18 Thread Rui Miguel Silva
Hi Philipp, Thanks for the quick review. On Fri 18 May 2018 at 10:32, Philipp Zabel wrote: Hi Rui, thank you for refactoring, I think this is much better than having the pretend capture-subsytem device in the DT. I would like to get rid of the ipu_present flag, if it can be done

Re: [PATCH v5 06/12] media: dt-bindings: add bindings for i.MX7 media driver

2018-05-18 Thread Rui Miguel Silva
Hi Rob, Thanks for your review, this and the other ones. On Fri 18 May 2018 at 16:49, Rob Herring wrote: On Fri, May 18, 2018 at 10:28:00AM +0100, Rui Miguel Silva wrote: Add bindings documentation for i.MX7 media drivers. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.

Re: [PATCH v5 08/12] ARM: dts: imx7s: add multiplexer controls

2018-05-18 Thread Rui Miguel Silva
Hi Rob, On Fri 18 May 2018 at 16:51, Rob Herring wrote: On Fri, May 18, 2018 at 10:28:02AM +0100, Rui Miguel Silva wrote: The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register

Re: [PATCH v5 07/12] ARM: dts: imx7s: add mipi phy power domain

2018-05-18 Thread Rui Miguel Silva
Hi Rob, On Fri 18 May 2018 at 16:50, Rob Herring wrote: On Fri, May 18, 2018 at 10:28:01AM +0100, Rui Miguel Silva wrote: Add power domain index 0 related with mipi-phy to imx7s. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- arch/arm/boot/dts/imx7s.dtsi | 6 ++ 1 file c

[PATCH v7 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-07-03 Thread Rui Miguel Silva
auto/manual gain, - gain, - horizontal/vertical flip, - test pattern menu. Supported resolution are only: QUXGA, 720P, UXGA. Signed-off-by: Rui Miguel Silva --- drivers/media/i2c/Kconfig | 12 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov2680.c |

[PATCH v7 0/2] media: Introduce Omnivision OV2680 driver

2018-07-03 Thread Rui Miguel Silva
ze from a list - check v4l2_ctrl_new_std return in _init - fix gain manual value in auto_cluster Cheers, Rui Rui Miguel Silva (2): media: ov2680: dt: Add bindings for OV2680 media: ov2680: Add Omnivision OV2680 sensor driver .../devicetree/bindings/media/i2c/ov2680.txt | 46 +

[PATCH v7 1/2] media: ov2680: dt: Add bindings for OV2680

2018-07-03 Thread Rui Miguel Silva
Add device tree binding documentation for the OV2680 camera sensor. CC: devicet...@vger.kernel.org Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/i2c/ov2680.txt | 46 +++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH 1/2] media: ov2680: dt: Add bindings for OV2680

2018-02-22 Thread Rui Miguel Silva
Add device tree binding documentation for the OV5640 camera sensor. CC: devicet...@vger.kernel.org Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- .../devicetree/bindings/media/i2c/ov2680.txt | 34 ++ 1 file changed, 34 insertions(+) create mode

[PATCH 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-02-22 Thread Rui Miguel Silva
auto/manual gain, - gain, - horizontal/vertical flip, - test pattern menu. Supported resolution are only: QUXGA, 720P, UXGA. Signed-off-by: Rui Miguel Silva <rui.si...@linaro.org> --- drivers/media/i2c/Kconfig | 13 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov26

[PATCH 0/2] media: Introduce Omnivision OV2680 driver

2018-02-22 Thread Rui Miguel Silva
Add driver and bindings for the OV2680 2 megapixel CMOS 1/5" sensor, which has a single MIPI lane interface and output format of 10-bit Raw RGB. Features supported are described in PATCH 2/2. Cheers, Rui Rui Miguel Silva (2): media: ov2680: dt: Add bindings for OV2680 media: ov2680

Re: [PATCH 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-02-23 Thread Rui Miguel Silva
Hi Sakari, Thanks for your review. On Fri 23 Feb 2018 at 07:50, Sakari Ailus wrote: Hi Rui, On Thu, Feb 22, 2018 at 10:23:38AM +, Rui Miguel Silva wrote: This patch adds V4L2 sub-device driver for OV2680 image sensor. The OV2680 is a 1/5" CMOS color sensor from Omnivision. Sup

Re: [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680

2018-02-23 Thread Rui Miguel Silva
Hi Fabio, On Thu 22 Feb 2018 at 11:31, Fabio Estevam wrote: On Thu, Feb 22, 2018 at 7:23 AM, Rui Miguel Silva <rmf...@gmail.com> wrote: Add device tree binding documentation for the OV5640 camera sensor. s/OV5640/OV2680 Thanks for notice this ;). --- Cheers, Rui

Re: [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680

2018-02-23 Thread Rui Miguel Silva
Hi Sakari, Thanks for the review. On Thu 22 Feb 2018 at 10:59, Sakari Ailus wrote: Hi Rui, Thanks for the patchset. Could you use "dt: bindings: " prefix in the subject? Sure, no problem. On Thu, Feb 22, 2018 at 10:23:37AM +, Rui Miguel Silva wrote: Add device tr

Re: [PATCH v6 07/13] media: dt-bindings: add bindings for i.MX7 media driver

2018-08-02 Thread Rui Miguel Silva
Hi Sakari, Thanks for the review. I will take this in account when preparing the v7, all your comments bellow look reasonable to me. --- Cheers, Rui On Thu 02 Aug 2018 at 14:00, Sakari Ailus wrote: Hi Rui, On Tue, May 22, 2018 at 03:52:39PM +0100, Rui Miguel Silva wrote: Add

Re: [PATCH v6 00/13] media: staging/imx7: add i.MX7 media driver

2018-08-02 Thread Rui Miguel Silva
Hi Hans, On Thu 02 Aug 2018 at 13:37, Hans Verkuil wrote: Hi Rui, On 05/22/18 16:52, Rui Miguel Silva wrote: Hi, This series introduces the Media driver to work with the i.MX7 SoC. it uses the already existing imx media core drivers but since the i.MX7, contrary to i.MX5/6, do not have

[PATCH] media: ov2680: Add Omnivision OV2680 maintainer

2018-07-27 Thread Rui Miguel Silva
Add myself as maintainer of the Omnivision OV2680 sensor driver. Signed-off-by: Rui Miguel Silva --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0fe4228f78cb..a9d296277676 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10463,6

Re: [PATCH v7 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-07-27 Thread Rui Miguel Silva
Hi Sakari, On Wed 25 Jul 2018 at 15:11, Sakari Ailus wrote: On Tue, Jul 03, 2018 at 03:08:03PM +0100, Rui Miguel Silva wrote: This patch adds V4L2 sub-device driver for OV2680 image sensor. The OV2680 is a 1/5" CMOS color sensor from Omnivision. Supports output format: 10-bit Ra

[PATCH v7 10/12] media: imx7.rst: add documentation for i.MX7 media driver

2018-08-10 Thread Rui Miguel Silva
Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva --- Documentation/media/v4l-drivers/imx7.rst | 157 ++ Documentation/media/v4l-drivers/index.rst | 1 + 2 files

[PATCH v7 11/12] media: staging/imx: add i.MX7 entries to TODO file

2018-08-10 Thread Rui Miguel Silva
Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5ca5324 100644 --- a/drivers

  1   2   3   >