Re: [RFC] V4L2 unified low-level decoder API

Hi, On Fri, May 19, 2017 at 1:08 AM, Hugues FRUCHET wrote: > Before merging this work Hans would like to have feedback from peers, in > order to be sure that this is inline with other SoC vendors drivers > expectations. > > Thomasz, Pawel, could you give your view

Re: [PATCH v4 2/4] [media] videobuf2: return -EPIPE from DQBUF after the last buffer

Hi, On Wed, Mar 25, 2015 at 2:46 AM, Philipp Zabel p.za...@pengutronix.de wrote: If the last buffer was dequeued from a capture queue, let poll return immediately and let DQBUF return -EPIPE to signal there will no more buffers to dequeue until STREAMOFF. The driver signals the last buffer by

Re: [PATCH v4 1/4] [media] videodev2: Add V4L2_BUF_FLAG_LAST

Hi, Thanks for working on this! On Wed, Mar 25, 2015 at 2:46 AM, Philipp Zabel p.za...@pengutronix.de wrote: From: Peter Seiderer ps.rep...@gmx.net This v4l2_buffer flag can be used by drivers to mark a capture buffer as the last generated buffer, for example after a V4L2_DEC_CMD_STOP

Re: [PATCH v3 0/5] Signalling last decoded frame by V4L2_BUF_FLAG_LAST and -EPIPE

Hi, On Tue, Apr 7, 2015 at 11:44 PM, Kamil Debski k.deb...@samsung.com wrote: Hi, From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Tuesday, March 17, 2015 5:09 PM On 03/17/2015 11:46 AM, Philipp Zabel wrote: Hi, Am Freitag, den 06.03.2015, 11:18 +0100 schrieb Philipp Zabel: At

Re: coda: not generating EOS event

Hi Philipp, On Thu, Jan 22, 2015 at 11:58 PM, Philipp Zabel p.za...@pengutronix.de wrote: Hi, Are you planning to pour the workshop's codec API document into a V4L2 documentation patch? Yes, definitely, I am a bit delayed, but will do this eventually, this is in progress. Sorry for the

Re: [REVIEWv7 PATCH 04/12] vb2: don't free alloc context if it is ERR_PTR

On Tue, Nov 18, 2014 at 9:51 PM, Hans Verkuil hverk...@xs4all.nl wrote: From: Hans Verkuil hans.verk...@cisco.com Don't try to free a pointer containing an ERR_PTR(). Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com -- Best regards, Pawel Osciak

Re: [REVIEWv7 PATCH 05/12] vb2-dma-sg: add allocation context to dma-sg

hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [REVIEWv7 PATCH 09/12] vb2-vmalloc: add support for dmabuf exports

hansv...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core/videobuf2-vmalloc.c | 171 1 file changed, 171 insertions(+) diff --git a/drivers/media/v4l2-core/videobuf2-vmalloc.c b/drivers/media/v4l2-core/videobuf2-vmalloc.c index

Re: [REVIEWv7 PATCH 01/12] videobuf2-core.h: improve documentation

Acked-by: Pawel Osciak pa...@osciak.com --- include/media/videobuf2-core.h | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h index 6ef2d01..70ace7c 100644 --- a/include/media

Re: [REVIEWv7 PATCH 12/12] vb2: use dma_map_sg_attrs to prevent unnecessary sync

. The reverse is true for dma_unmap_sg, buf_finish and the finish memop. To prevent unnecessary syncs we ask dma_(un)map_sg to skip the sync. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 24

Re: [RFCv6 PATCH 08/16] vb2-vmalloc: add support for dmabuf exports

related */ + struct dma_buf_attachment *db_attach; Unused? -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFCv6 PATCH 10/16] vim2m: support expbuf

On Mon, Nov 10, 2014 at 8:49 PM, Hans Verkuil hverk...@xs4all.nl wrote: From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reviewed-by: Pawel Osciak pa...@osciak.com --- drivers/media/platform/vim2m.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [RFCv6 PATCH 09/16] vivid: enable vb2_expbuf support.

Reviewed-by: Pawel Osciak pa...@osciak.com --- drivers/media/platform/vivid/vivid-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/vivid/vivid-core.c b/drivers/media/platform/vivid/vivid-core.c index 2c61a62..7de8d9d 100644 --- a/drivers/media

Re: [RFCv6 PATCH 11/16] vb2: use dma_map_sg_attrs to prevent unnecessary sync

, sgt-orig_nents, dma_dir); + /* Mapping to the client with new direction */ + ret = dma_map_sg(db_attach-dev, sgt-sgl, sgt-orig_nents, +dma_dir); Do we need this chunk? -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe

Re: [RFCv6 PATCH 02/16] vb2: replace 'write' by 'dma_dir'

value anyway it is now replaced by the correct dma_dir value which is unambiguous. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

Re: [RFCv6 PATCH 03/16] vb2: add dma_dir to the alloc memop.

On Mon, Nov 10, 2014 at 8:49 PM, Hans Verkuil hverk...@xs4all.nl wrote: From: Hans Verkuil hans.verk...@cisco.com This is needed for the next patch where the dma-sg alloc memop needs to know the dma_dir. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa

Re: [RFCv6 PATCH 04/16] vb2-dma-sg: add allocation context to dma-sg

; + + return conf; +} +EXPORT_SYMBOL_GPL(vb2_dma_sg_init_ctx); + +void vb2_dma_sg_cleanup_ctx(void *alloc_ctx) +{ + if (!IS_ERR_OR_NULL(alloc_ctx)) I would prefer not doing this, it's very weird and would really just be a programming bug. -- Best regards, Pawel Osciak

Re: [RFCv6 PATCH 06/16] vb2-dma-sg: add dmabuf import support

On Mon, Nov 10, 2014 at 8:49 PM, Hans Verkuil hverk...@xs4all.nl wrote: From: Hans Verkuil hans.verk...@cisco.com Add support for importing dmabuf to videobuf2-dma-sg. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com -- Best regards, Pawel Osciak

Re: [RFCv6 PATCH 07/16] vb2-dma-sg: add support for dmabuf exports

On Mon, Nov 10, 2014 at 8:49 PM, Hans Verkuil hverk...@xs4all.nl wrote: From: Hans Verkuil hansv...@cisco.com Add DMABUF export support to vb2-dma-sg. Signed-off-by: Hans Verkuil hansv...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com -- Best regards, Pawel Osciak -- To unsubscribe from

Re: [RFCv5 PATCH 02/15] vb2-dma-sg: add allocation context to dma-sg

); } +void *vb2_dma_sg_init_ctx(struct device *dev); +void vb2_dma_sg_cleanup_ctx(void *alloc_ctx); + extern const struct vb2_mem_ops vb2_dma_sg_memops; #endif -- 2.1.1 -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

Re: [RFCv5 PATCH 03/15] vb2-dma-sg: move dma_(un)map_sg here

-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [RFCv5 PATCH 04/15] vb2-dma-sg: add dmabuf import support

, + .unmap_dmabuf = vb2_dma_sg_unmap_dmabuf, + .attach_dmabuf = vb2_dma_sg_attach_dmabuf, + .detach_dmabuf = vb2_dma_sg_detach_dmabuf, .cookie = vb2_dma_sg_cookie, }; EXPORT_SYMBOL_GPL(vb2_dma_sg_memops); -- 2.1.1 -- Best regards, Pawel Osciak

Re: [RFCv5 PATCH 04/15] vb2-dma-sg: add dmabuf import support

On Sat, Nov 8, 2014 at 7:20 PM, Pawel Osciak pa...@osciak.com wrote: Hi Hans, Thank you for the patch. On Fri, Nov 7, 2014 at 5:50 PM, Hans Verkuil hverk...@xs4all.nl wrote: From: Hans Verkuil hans.verk...@cisco.com Add support for dmabuf to vb2-dma-sg. importing dmabuf into videobuf2-dma

Re: [RFCv5 PATCH 05/15] vb2-dma-sg: add get_dmabuf

vb2_dma_sg_buf *buf = dbuf-priv; + + return buf-vaddr + pgnum * PAGE_SIZE; As opposed to contig, which assigns vaddr on alloc(), vaddr can very well be NULL here for sg. -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

Re: [RFCv5 PATCH 07/15] vb2: replace 'write' by 'dma_dir'

the dma_dir value anyway it is now replaced by the correct dma_dir value which is unambiguous. Do we need the first patch adding write then? Maybe we could squash somehow and redo the series please? -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: RFC: vb2: replace alloc_ctx by struct device * in vb2_queue

and I don't see and need for anything else. The last option would make it impossible to have different allocation contexts for different planes, but that might be something that Samsumg needs. Regards, Hans -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line

Re: [RFC PATCH 06/12] vb2-dma-sg: add dmabuf import support

they are copied from dma-contig, but I think we should remove them. Others include detach, create attachment, etc. -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [RFCv2 PATCH 10/14] vb2: add 'new_cookies' flag

. Perhaps I'm missing something, but couldn't we just dma_map_sg on allocation/get in dma-sg and unmap on put? -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [RFCv2 PATCH 02/14] vb2-dma-sg: add allocation context to dma-sg

. -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFCv2 PATCH 03/14] vb2-dma-sg: add prepare/finish memops

we alloc (or get) and put a buffer, while prepare and finish should only sync. -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v3 2/2] V4L: uvcvideo: Add support for pan/tilt speed controls

On Thu, Sep 4, 2014 at 4:40 AM, Vincent Palatin vpala...@chromium.org wrote: Map V4L2_CID_TILT_SPEED and V4L2_CID_PAN_SPEED to the standard UVC CT_PANTILT_RELATIVE_CONTROL terminal control request. Tested by plugging a Logitech ConferenceCam C3000e USB camera and controlling pan/tilt from the

Re: [PATCH v2 1/2] [media] V4L: Add camera pan/tilt speed controls

On Sat, Aug 16, 2014 at 4:08 AM, Vincent Palatin vpala...@chromium.org wrote: The V4L2_CID_PAN_SPEED and V4L2_CID_TILT_SPEED controls allow to move the camera by setting its rotation speed around its axis. Signed-off-by: Vincent Palatin vpala...@chromium.org Reviewed-by: Pawel Osciak posc

Re: [PATCH 2/2] V4L: uvcvideo: Add support for pan/tilt speed controls

the userspace using the VIDIOC_S_CTRL ioctl. Verified that it can pan and tilt at the same time in both directions. Signed-off-by: Vincent Palatin vpala...@chromium.org Reviewed-by: Pawel Osciak posc...@chromium.org Change-Id: I7b70b228e5c0126683f5f0be34ffd2807f5783dc --- drivers/media/usb/uvc

Re: [ANNOUNCE] Linux Kernel Media mini-summit on Oct, 16-17 in Düsseldorf, Germany

Hi Philipp, On Fri, Aug 22, 2014 at 10:09 PM, Philipp Zabel p.za...@pengutronix.de wrote: - Helping userspace to use mem2mem devices; clarification of encoder/decoder handling, clarification of format/size setting in case of dependencies between input and output formats, possibly broad

Re: [PATCH] videobuf2-core: modify the num of users

; } return false; -- 1.7.9.5 -- Thanks, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] [media] V4L: Add camera pan/tilt speed controls

On Thu, Aug 7, 2014 at 12:10 AM, Vincent Palatin vpala...@chromium.org wrote: On Sun, Aug 3, 2014 at 10:52 PM, Pawel Osciak posc...@chromium.org wrote: This looks good to me in general (with one comment below). I don't think we can easily implement current V4L2 pan and tilt controls

Re: [PATCH for v3.17] videobuf2-core: add comments before the WARN_ON

to the videobuf2-core.h header that explains what drivers are supposed to do in these situations. That should help point developers in the right direction if they see these warnings. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core

Re: [PATCH/RFC v2 1/2] v4l: vb2: Don't return POLLERR during transient buffer underruns

underruns during streaming are not treated specially anymore and just result in poll() blocking until the next event. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core

Re: [PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag

Hi Laurent, Thanks for the patch. Did you test this to work in fileio mode? Looks like it should, but would like to make sure. Thanks, Pawel On Thu, Jun 5, 2014 at 9:23 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: When a fatal error occurs that render the device unusable, the

Re: [PATCH 2/2] v4l: s5p-mfc: Limit enum_fmt to output formats of current version

Hi Kamil, I like the solution as well. Two suggestions to consider below. On Fri, May 16, 2014 at 9:03 PM, Kamil Debski k.deb...@samsung.com wrote: MFC versions support a different set of formats, this specially applies to the raw YUV formats. This patch changes enum_fmt, so that it only

Re: [PATCH] [media] s5p-mfc: Add a control for IVF format for VP8 encoder

...@chromium.org; arunkk.sams...@gmail.com Subject: [PATCH] [media] s5p-mfc: Add a control for IVF format for VP8 encoder From: Pawel Osciak posc...@chromium.org Add a control to enable/disable IVF output stream format for VP8 encode. Set the IVF format output to disabled as default

Re: [PATCH 3/3] [media] s5p-mfc: Don't allocate codec buffers on STREAMON.

Hi Kamil, On Fri, May 9, 2014 at 1:22 AM, Kamil Debski k.deb...@samsung.com wrote: Hi, From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] On Behalf Of Arun Kumar K Sent: Friday, March 21, 2014 9:37 AM From: Pawel Osciak posc...@chromium.org Currently, we allocate private codec buffers

Re: [REVIEWv2 PATCH 04/13] vb2: use correct prefix

the function name in addition to the vb2: prefix. Superfluous prefixes elsewhere in the code have been removed. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core/videobuf2-core.c | 133 +++ 1 file

Re: [REVIEWv2 PATCH 02/13] vb2: fix handling of data_offset and v4l2_plane.reserved[]

-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core/videobuf2-core.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index

Re: [REVIEWv2 PATCH 06/13] vb2: set timestamp when using write()

if V4L2_BUF_FLAG_TIMESTAMP_COPY is set. Nobody else is able to provide this information with the write() operation. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core/videobuf2-core.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [REVIEWv2 PATCH 07/13] vb2: reject output buffers with V4L2_FIELD_ALTERNATE

it is. +*/ + dprintk(1, the field is incorrectly set to ALTERNATE for an output buffer\n); + return -EINVAL; + } vb-state = VB2_BUF_STATE_PREPARING; vb-v4l2_buf.timestamp.tv_sec = 0; -- 1.9.1 -- Best regards, Pawel Osciak -- To unsubscribe from

Re: [REVIEWv2 PATCH 04/13] vb2: use correct prefix

-- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [REVIEWv2 PATCH 09/13] vb2: add vb2_fileio_is_active and check it more often

were created... Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core/videobuf2-core.c | 39 include/media/videobuf2-core.h | 17 ++ 2 files changed, 41 insertions

Re: [REVIEWv2 PATCH 10/13] vb2: set v4l2_buffer.bytesused to 0 for mp buffers

...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core/videobuf2-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index 08152dd..ef7ef82 100644 --- a/drivers/media/v4l2

Re: [REVIEWv2 PATCH 10/13] vb2: set v4l2_buffer.bytesused to 0 for mp buffers

Ah, alas, Sakari is right. This should not be needed, since we memcpy vb-v4l2_buf to this, also overwriting bytesused. On Thu, Apr 10, 2014 at 10:08 AM, Pawel Osciak pa...@osciak.com wrote: On Mon, Apr 7, 2014 at 10:11 PM, Hans Verkuil hverk...@xs4all.nl wrote: From: Hans Verkuil hans.verk

Re: [REVIEWv2 PATCH 12/13] vb2: start messages with a lower-case for consistency.

of the messages. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core/videobuf2-core.c | 58 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2

Re: [REVIEW PATCH 03/11] vb2: if bytesused is 0, then fill with output buffer length

the buffer length instead. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core/videobuf2-core.c | 32 +++- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2

Re: [REVIEW PATCH 04/11] vb2: use correct prefix

-- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [REVIEW PATCH 03/11] vb2: if bytesused is 0, then fill with output buffer length

On Mon, Apr 7, 2014 at 4:39 PM, Hans Verkuil hverk...@xs4all.nl wrote: On 04/07/2014 09:20 AM, Pawel Osciak wrote: I'm thinking, that if we are doing this, perhaps we should just update the API to allow this case, i.e. say that if the bytesused is not set With 'not set' you mean 'is 0', right

Re: [REVIEW PATCH 05/11] vb2: move __qbuf_mmap before __qbuf_userptr

these memory models are implemented: first mmap, then userptr, then dmabuf. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core/videobuf2-core.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions

Re: [REVIEW PATCH 06/11] vb2: set timestamp when using write()

) + v4l2_get_timestamp(fileio-b.timestamp); ret = vb2_internal_qbuf(q, fileio-b); dprintk(5, file io: vb2_internal_qbuf result: %d\n, ret); if (ret) -- 1.9.0 -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line

Re: [REVIEW PATCH 07/11] vb2: reject output buffers with V4L2_FIELD_ALTERNATE

. +*/ + return -EINVAL; + } vb-state = VB2_BUF_STATE_PREPARING; vb-v4l2_buf.timestamp.tv_sec = 0; -- 1.9.0 -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: [REVIEW PATCH 08/11] vb2: simplify a confusing condition.

On Tue, Mar 11, 2014 at 6:20 AM, Hans Verkuil hverk...@xs4all.nl wrote: From: Hans Verkuil hans.verk...@cisco.com q-start_streaming_called is always true, so the WARN_ON check against it being false can be dropped. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa

Re: videobuf2-vmalloc suspect for corrupted data

in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

Re: [REVIEW PATCH 01/11] vb2: stop_streaming should return void

; This has been updated to just call mutex_lock(). The stop_streaming op expects this to really stop streaming and I very much doubt this will work reliably if stop_streaming just returns without really stopping the DMA. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak

Re: [REVIEW PATCH 02/11] vb2: fix handling of data_offset and v4l2_plane.reserved[]

, plane); ret = -EINVAL; -- 1.9.0 -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [REVIEW PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

, buffer, plane); return 0; -- 1.9.0 -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [REVIEWv3 PATCH 01/17] vb2: Check if there are buffers before streamon

to a situation where if he calls close() before calling streamoff() the device is kept streaming. Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core/videobuf2

Re: [REVIEWv3 PATCH 03/17] vb2: fix PREPARE_BUF regression

by removing callback). Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core/videobuf2-core.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

Re: [RFCv2 PATCH 01/10] vb2: add debugging code to check for unbalanced ops.

with buf_queue(). I know later patches in this series will require it, but at this point it's not true. Perhaps we should move this to the 8th patch or after it? I don't feel too strong about this though. One more nit inline. But in general: Acked-by: Pawel Osciak pa...@osciak.com On Thu, Feb 6, 2014

Re: [RFCv3 PATCH 02/10] vb2: change result code of buf_finish to void.

Thanks! vb2 parts: Acked-by: Pawel Osciak pa...@osciak.com others: Reviewed-by: Pawel Osciak pa...@osciak.com On Thu, Feb 13, 2014 at 6:40 PM, Hans Verkuil hverk...@xs4all.nl wrote: From: Hans Verkuil hans.verk...@cisco.com The buf_finish op should always work, so change the return type

Re: [RFCv3 PATCH 03/10] vb2: add note that buf_finish can be called with !vb2_is_streaming()

Thanks Hans. Acked-by: Pawel Osciak pa...@osciak.com On Thu, Feb 13, 2014 at 6:40 PM, Hans Verkuil hverk...@xs4all.nl wrote: From: Hans Verkuil hans.verk...@cisco.com Drivers need to be aware that buf_finish can be called when there is no streaming going on, so make a note of that. Also

Re: [RFCv3 PATCH 04/10] vb2: call buf_finish from __dqbuf

will not be called and any driver cleanup will not happen. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core/videobuf2-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2

Re: [RFCv3 PATCH 05/10] vb2: fix buf_init/buf_cleanup call sequences

? VB2_BUF_STATE_DEQUEUED : VB2_BUF_STATE_PREPARED; -- 1.8.4.rc3 -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFCv3 PATCH 07/10] vb2: rename queued_count to owned_by_drv_count

. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core/videobuf2-core.c | 10 +- include/media/videobuf2-core.h | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/media/v4l2

Re: [RFCv3 PATCH 06/10] vb2: fix read/write regression

vb2_queue *q, char __user *data, size_ fileio-q_count += 1; if (fileio-index q-num_buffers) fileio-index++; + fileio-buf_index = fileio-index; } /* -- 1.8.4.rc3 -- Best regards, Pawel Osciak

Re: [RFCv3 PATCH 08/10] vb2: only call start_streaming if sufficient buffers are queued

retry_start_streaming:1; + unsigned intstart_streaming_called:1; struct vb2_fileio_data *fileio; -- 1.8.4.rc3 -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [PATCH] CHROMIUM: s5p-mfc: add controls to set vp8 enc profile

Hi Arun, On Mon, Dec 9, 2013 at 10:16 PM, Arun Kumar K arun...@samsung.com wrote: Add v4l2 controls to set desired profile for VP8 encoder. Acceptable levels for VP8 encoder are 0: Version 0 1: Version 1 2: Version 2 3: Version 3 Signed-off-by: Pawel Osciak posc...@chromium.org Sorry

Re: [media-workshop] Kernel Summit Media Mini-summit attendees on Oct 23 in Edinburgh

Mauro Carvalho Chehab m.che...@samsung.com Michael Krufky mkru...@kernellabs.com Oliver Schinagl oliver+l...@schinagl.nl Pawel Osciak posc...@chromium.org Peter Senna Tschudin peter.se...@gmail.com Ricardo Ribalda Delgado ricardo.riba...@gmail.com

Re: [PATCH] [media] videobuf2-core: call __setup_offsets only for mmap memory type

Thanks Philipp. Acked-by: Pawel Osciak pa...@osciak.com On Thu, Sep 19, 2013 at 5:30 PM, Philipp Zabel p.za...@pengutronix.de wrote: Hi Pawel, Am Donnerstag, den 19.09.2013, 16:54 +0900 schrieb Pawel Osciak: On Thu, Sep 19, 2013 at 4:37 PM, Philipp Zabel p.za...@pengutronix.de wrote

Re: [PATCH] [media] videobuf2-core: call __setup_offsets only for mmap memory type

); + if (memory == V4L2_MEMORY_MMAP) + __setup_offsets(q, buffer); dprintk(1, Allocated %d buffers, %d plane(s) each\n, buffer, num_planes); -- 1.8.4.rc3 -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v1 16/19] v4l: Add encoding camera controls.

On Tue, Sep 10, 2013 at 6:17 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Mon 9 September 2013 11:09:57 Sylwester Nawrocki wrote: On 09/09/2013 11:00 AM, Kamil Debski wrote: [...] We have QP controls separately for H264, H263 and MPEG4. Why is that? Which one should I use for VP8?

Re: [PATCH v1 16/19] v4l: Add encoding camera controls.

On Mon, Sep 9, 2013 at 4:52 PM, Hans Verkuil hverk...@xs4all.nl wrote: On 09/09/2013 05:48 AM, Pawel Osciak wrote: Hi Hans, Thanks for the comments, one question inline. On Fri, Aug 30, 2013 at 3:48 PM, Hans Verkuil hverk...@xs4all.nl wrote: On 08/30/2013 04:17 AM, Pawel Osciak wrote: Add

Re: [PATCH v1 16/19] v4l: Add encoding camera controls.

Hi Hans, Thanks for the comments, one question inline. On Fri, Aug 30, 2013 at 3:48 PM, Hans Verkuil hverk...@xs4all.nl wrote: On 08/30/2013 04:17 AM, Pawel Osciak wrote: Add defines for controls found in UVC 1.5 encoding cameras. Signed-off-by: Pawel Osciak posc...@chromium.org

Re: [media-workshop] Agenda for the Edinburgh mini-summit

On Fri, Sep 6, 2013 at 10:45 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Hugues, On Thursday 05 September 2013 13:37:49 Hugues FRUCHET wrote: Hi Mauro, For floating point issue, we have not encountered such issue while integrating various codec (currently H264,

[PATCH v1 04/19] uvcvideo: Create separate debugfs entries for each streaming interface.

Add interface number to debugfs entry name to be able to create separate entries for each streaming interface for devices exposing more than one, instead of failing to create more than one. Signed-off-by: Pawel Osciak posc...@chromium.org --- drivers/media/usb/uvc/uvc_debugfs.c | 3 ++- 1 file

[PATCH v1 12/19] uvcvideo: Reorganize next buffer handling.

Move getting the first buffer from the current queue to a uvc_queue function and out of the USB completion handler. Signed-off-by: Pawel Osciak posc...@chromium.org --- drivers/media/usb/uvc/uvc_isight.c | 6 -- drivers/media/usb/uvc/uvc_queue.c | 14 ++ drivers/media/usb/uvc

[PATCH v1 10/19] uvcvideo: Support UVC 1.5 runtime control property.

UVC 1.5 introduces the concept of runtime controls, which can be set during streaming. Non-runtime controls can only be changed while device is idle. Signed-off-by: Pawel Osciak posc...@chromium.org --- drivers/media/usb/uvc/uvc_ctrl.c | 45 +--- drivers/media

[PATCH v1 16/19] v4l: Add encoding camera controls.

Add defines for controls found in UVC 1.5 encoding cameras. Signed-off-by: Pawel Osciak posc...@chromium.org --- drivers/media/v4l2-core/v4l2-ctrls.c | 29 + include/uapi/linux/v4l2-controls.h | 31 +++ 2 files changed, 60 insertions

[PATCH v1 11/19] uvcvideo: Support V4L2_CTRL_TYPE_BITMASK controls.

Signed-off-by: Pawel Osciak posc...@chromium.org --- drivers/media/usb/uvc/uvc_ctrl.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index b0a19b9..a0493d6 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c

[PATCH v1 00/19] UVC 1.5 VP8 support for uvcvideo

, Pawel Osciak Pawel Osciak (19): uvcvideo: Add UVC query tracing. uvcvideo: Return 0 when setting probe control succeeds. uvcvideo: Add support for multiple chains with common roots. uvcvideo: Create separate debugfs entries for each streaming interface. uvcvideo

[PATCH v1 08/19] uvcvideo: Add UVC1.5 VP8 format support.

Add detection and parsing of VP8 format and frame descriptors and reorganize format parsing code. Signed-off-by: Pawel Osciak posc...@chromium.org --- drivers/media/usb/uvc/uvc_driver.c | 120 - drivers/media/usb/uvc/uvcvideo.h | 4 +- include/uapi/linux

[PATCH v1 17/19] uvcvideo: Add UVC 1.5 Encoding Unit controls.

These controls allow modifying encoding parameters. Signed-off-by: Pawel Osciak posc...@chromium.org --- drivers/media/usb/uvc/uvc_ctrl.c | 445 +++ include/uapi/linux/usb/video.h | 23 ++ 2 files changed, 468 insertions(+) diff --git a/drivers/media/usb

[PATCH v1 15/19] uvcvideo: Add support for VP8 special frame flags.

Signed-off-by: Pawel Osciak posc...@chromium.org --- drivers/media/usb/uvc/uvc_video.c | 18 +- drivers/media/usb/uvc/uvcvideo.h | 10 ++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c

[PATCH v1 03/19] uvcvideo: Add support for multiple chains with common roots.

extract control locking into __uvc_ctrl_{lock,unlock} functions. Signed-off-by: Pawel Osciak posc...@chromium.org --- drivers/media/usb/uvc/uvc_ctrl.c | 70 - drivers/media/usb/uvc/uvc_driver.c | 210 + drivers/media/usb/uvc/uvc_entity.c | 15

[PATCH v1 07/19] uvcvideo: Unify error reporting during format descriptor parsing.

Add common error handling paths for format parsing failures. Signed-off-by: Pawel Osciak posc...@chromium.org --- drivers/media/usb/uvc/uvc_driver.c | 35 ++- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_driver.c b

[PATCH v1 14/19] v4l: Add v4l2_buffer flags for VP8-specific special frames.

Add bits for previous, golden and altref frame types. Signed-off-by: Pawel Osciak posc...@chromium.org --- include/uapi/linux/videodev2.h | 4 1 file changed, 4 insertions(+) diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index 437f1b0..c011ee0 100644

[PATCH v1 02/19] uvcvideo: Return 0 when setting probe control succeeds.

Return 0 instead of returning size of the probe control on successful set. Signed-off-by: Pawel Osciak posc...@chromium.org --- drivers/media/usb/uvc/uvc_video.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c index

[PATCH v1 13/19] uvcvideo: Unify UVC payload header parsing.

Create a separate function for parsing UVC payload headers and extract code from other functions into it. Store the parsed values in a header struct. Signed-off-by: Pawel Osciak posc...@chromium.org --- drivers/media/usb/uvc/uvc_video.c | 270 +++--- drivers/media

[PATCH v1 09/19] uvcvideo: Reorganize uvc_{get,set}_le_value.

Signed-off-by: Pawel Osciak posc...@chromium.org --- drivers/media/usb/uvc/uvc_ctrl.c | 62 1 file changed, 37 insertions(+), 25 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index 72d6724..d735c88 100644

[PATCH v1 01/19] uvcvideo: Add UVC query tracing.

Add a new trace argument enabling UVC query details and contents logging. Signed-off-by: Pawel Osciak posc...@chromium.org --- drivers/media/usb/uvc/uvc_video.c | 45 +-- drivers/media/usb/uvc/uvcvideo.h | 9 2 files changed, 38 insertions(+), 16

[PATCH v1 05/19] uvcvideo: Add support for UVC1.5 PC control.

Add support for UVC 1.5 Probe Commit control. Signed-off-by: Pawel Osciak posc...@chromium.org --- drivers/media/usb/uvc/uvc_video.c | 52 --- include/uapi/linux/usb/video.h| 7 ++ 2 files changed, 55 insertions(+), 4 deletions(-) diff --git

[PATCH v1 18/19] v4l: Add V4L2_PIX_FMT_VP8_SIMULCAST format.

on the camera capabilities. Signed-off-by: Pawel Osciak posc...@chromium.org --- include/uapi/linux/videodev2.h | 4 1 file changed, 4 insertions(+) diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index c011ee0..8b0d4ad 100644 --- a/include/uapi/linux/videodev2.h +++ b

[PATCH v1 06/19] uvcvideo: Recognize UVC 1.5 encoding units.

Add encoding unit definitions and descriptor parsing code and allow them to be added to chains. Signed-off-by: Pawel Osciak posc...@chromium.org --- drivers/media/usb/uvc/uvc_ctrl.c | 37 ++--- drivers/media/usb/uvc/uvc_driver.c | 67

Re: [PATCH] [media] v4l2: mem2mem: save irq flags correctly

John, thanks for the patch. On Thu, May 23, 2013 at 5:41 PM, John Sheu s...@google.com wrote: Save flags correctly when taking spinlocks in v4l2_m2m_try_schedule. Signed-off-by: John Sheu s...@google.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core/v4l2-mem2mem.c

  1   2   3   4   >