Re: [PATCHv2 1/3] phy: Add exynos-simple-phy driver

2014-05-07 Thread Tomasz Stanislawski
and register (or its offset) attribute to the PHY node. However, there was a very strong opposition from DT maintainers to adding any bit related configuration to DT. The current solution was designed to be a trade-off between being generic and being accepted :). Regards, Tomasz Stanislawski

Re: [PATCH 0/2] Add support for sii9234 chip

2014-05-05 Thread Tomasz Stanislawski
On 05/04/2014 01:17 AM, Greg KH wrote: On Fri, Apr 11, 2014 at 01:48:28PM +0200, Tomasz Stanislawski wrote: Hi everyone, This patchset adds support for sii9234 HD Mobile Link Bridge. The chip is used to convert HDMI signal into MHL. The driver enables HDMI output on Trats and Trats2

Re: [PATCHv2 1/3] phy: Add exynos-simple-phy driver

2014-04-30 Thread Tomasz Stanislawski
Hi Rahul, I will prepare we v3 version. Do you want me to add your patches for exynos5?50 to the patchset? Regards, Tomasz Stanislawski On 04/30/2014 08:37 AM, Rahul Sharma wrote: Hi Tomasz, I have tested your patches for exynos5250 and 5420. Works fine. Are you planning to post v3? If you

[PATCHv2 0/4] drm: exynos: update/fixes to HDMI driver

2014-04-15 Thread Tomasz Stanislawski
Hi everyone, This patchset adds 4 fixes/updates to EXYNOS DRM driver for HDMI subsystem. All comments are welcome. Regards, Tomasz Stanislawski Changelog: v2: * fix check with gpio_is_valid() * use U32_MAX instead of ULONG_MAX to be 64-bit-friendly * use hdmi_driver_data as hdmi's compatile

[PATCHv2 1/4] drm: exynos: hdmi: simplify extracting hpd-gpio from DT

2014-04-15 Thread Tomasz Stanislawski
This patch eliminates redundant checks while retrieving HPD gpio from DT during HDMI's probe(). Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com --- drivers/gpu/drm/exynos/exynos_hdmi.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm

[PATCHv2 2/4] drm: exynos: mixer: fix using usleep() in atomic context

2014-04-15 Thread Tomasz Stanislawski
This patch fixes calling usleep_range() after taking reg_slock using spin_lock_irqsave(). The mdelay() is used instead. Waiting in atomic context is not the best idea in general. Hopefully, waiting occurs only when Video Processor fails to reset correctly. Signed-off-by: Tomasz Stanislawski

[PATCHv2 3/4] drm: exynos: add compatibles for HDMI and Mixer chips and exynos4210 SoC

2014-04-15 Thread Tomasz Stanislawski
This patch add proper compatibles for Mixer and HDMI chip available on exynos4210 SoCs. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com --- drivers/gpu/drm/exynos/exynos_hdmi.c |7 +++ drivers/gpu/drm/exynos/exynos_mixer.c |3 +++ 2 files changed, 10 insertions(+) diff

[PATCHv2 4/4] drm: exynos: hdmi: add support for pixel clock limitation

2014-04-15 Thread Tomasz Stanislawski
Adds support for limitation of maximal pixel clock of HDMI signal. This feature is needed on boards that contains lines or bridges with frequency limitations. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com --- .../devicetree/bindings/video/exynos_hdmi.txt |4 drivers

Re: [PATCHv2 4/4] drm: exynos: hdmi: add support for pixel clock limitation

2014-04-15 Thread Tomasz Stanislawski
On 04/15/2014 11:42 AM, Rahul Sharma wrote: Hi Tomasz, On 15 April 2014 14:57, Tomasz Stanislawski t.stanisl...@samsung.com wrote: Adds support for limitation of maximal pixel clock of HDMI signal. This feature is needed on boards that contains lines or bridges with frequency limitations

Re: [PATCHv2 4/4] drm: exynos: hdmi: add support for pixel clock limitation

2014-04-15 Thread Tomasz Stanislawski
On 04/15/2014 03:42 PM, Rahul Sharma wrote: On 15 April 2014 18:41, Tomasz Stanislawski t.stanisl...@samsung.com wrote: On 04/15/2014 11:42 AM, Rahul Sharma wrote: Hi Tomasz, On 15 April 2014 14:57, Tomasz Stanislawski t.stanisl...@samsung.com wrote: Adds support for limitation of maximal

[PATCH 4/4] drm: exynos: hdmi: add support for pixel clock limitation

2014-04-14 Thread Tomasz Stanislawski
Adds support for limitation of maximal pixel clock of HDMI signal. This feature is needed on boards that contains lines or bridges with frequency limitations. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com --- .../devicetree/bindings/video/exynos_hdmi.txt |4 drivers

[PATCH 1/4] drm: exynos: hdmi: simplify extracting hpd-gpio from DT

2014-04-14 Thread Tomasz Stanislawski
This patch eliminates redundant checks while retrieving HPD gpio from DT during HDMI's probe(). Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com --- drivers/gpu/drm/exynos/exynos_hdmi.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 0/4] drm: exynos: update/fixes to HDMI driver

2014-04-14 Thread Tomasz Stanislawski
Hi everyone, This patchset adds 4 fixes/updates to EXYNOS DRM driver for HDMI subsystem. All comments are welcome. Regards, Tomasz Stanislawski Tomasz Stanislawski (4): drm: exynos: hdmi: simplify extracting hpd-gpio from DT drm: exynos: mixer: fix using usleep() in atomic context drm

[PATCH 3/4] drm: exynos: add compatibles for HDMI and Mixer chips and exynos4210 SoC

2014-04-14 Thread Tomasz Stanislawski
This patch add proper compatibles for Mixer and HDMI chip available on exynos4210 SoCs. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com --- drivers/gpu/drm/exynos/exynos_hdmi.c |3 +++ drivers/gpu/drm/exynos/exynos_mixer.c |3 +++ 2 files changed, 6 insertions(+) diff --git

[PATCH 2/4] drm: exynos: mixer: fix using usleep() in atomic context

2014-04-14 Thread Tomasz Stanislawski
This patch fixes calling usleep_range() after taking reg_slock using spin_lock_irqsave(). The mdelay() is used instead. Waiting in atomic context is not the best idea in general. Hopefully, waiting occurs only when Video Processor fails to reset correctly. Signed-off-by: Tomasz Stanislawski

Re: [PATCH 1/4] drm: exynos: hdmi: simplify extracting hpd-gpio from DT

2014-04-14 Thread Tomasz Stanislawski
On 04/14/2014 05:00 PM, Tomasz Stanislawski wrote: This patch eliminates redundant checks while retrieving HPD gpio from DT during HDMI's probe(). Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com --- drivers/gpu/drm/exynos/exynos_hdmi.c | 13 - 1 file changed, 4

[PATCH 1/2] misc: add sii9234 driver

2014-04-11 Thread Tomasz Stanislawski
Add driver for HDMI bridge using MHL connection. Contains refactored code for MHL driver developed by: Adam Hampson ahamp...@sta.samsung.com Erik Gilling konk...@android.com Shankar Bandal shanka...@samsung.com Dharam Kumar dharam...@samsung.com Signed-off-by: Tomasz Stanislawski t.stanisl

[PATCH 2/2] arm: dts: trats2: add SiI9234 node

2014-04-11 Thread Tomasz Stanislawski
This patch adds configuration of SiI9234 bridge to Trats2 board. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com --- arch/arm/boot/dts/exynos4412-trats2.dts | 43 +++ 1 file changed, 43 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts

[PATCH 0/2] Add support for sii9234 chip

2014-04-11 Thread Tomasz Stanislawski
/media/platform/s5p-tv/sii9234_drv.c could be safely removed. All comments are welcome. Regards, Tomasz Stanislawski References: [1] https://github.com/junpei0824/SC02C-linux/tree/master-jelly-cm-aokp/drivers/media/video/mhl Tomasz Stanislawski (2): misc: add sii9234 driver arm: dts: trats2

Re: [REVIEWv2 PATCH 02/13] vb2: fix handling of data_offset and v4l2_plane.reserved[]

2014-04-11 Thread Tomasz Stanislawski
plane and data_offset = luma_size for chroma offset. The check: - if (planes[plane].length planes[plane].data_offset + - q-plane_sizes[plane]) { assured that the logical plane does not overflow the dmabuf. Am I wrong? Regards, Tomasz Stanislawski

Re: [REVIEWv3 PATCH 09/13] vb2: add vb2_fileio_is_active and check it more often

2014-04-11 Thread Tomasz Stanislawski
reason). Why? I expect that there is no sane use case for using mmap() and expbuf in read/write mode but why forbidding this. Could you provide a reason? Regard, Tomasz Stanislawski In addition drivers should be able to check for this in queue_setup() to return an error if an attempt is made

Re: [REVIEWv2 PATCH 02/13] vb2: fix handling of data_offset and v4l2_plane.reserved[]

2014-04-11 Thread Tomasz Stanislawski
On 04/11/2014 03:03 PM, Hans Verkuil wrote: On 04/11/2014 02:48 PM, Tomasz Stanislawski wrote: On 04/07/2014 03:11 PM, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com The videobuf2-core did not zero the 'planes' array in __qbuf_userptr() and __qbuf_dmabuf(). That's now memset

Re: [PATCHv2 2/3] drm: exynos: hdmi: use hdmiphy as PHY

2014-04-09 Thread Tomasz Stanislawski
is not used as far as I know. Regards, Tomasz Stanislawski On 04/09/2014 12:30 PM, Andrzej Hajda wrote: Hi Tomasz, On 04/08/2014 04:37 PM, Tomasz Stanislawski wrote: The HDMIPHY (physical interface) is controlled by a single bit in a power controller's regiter. It was implemented as clock

Re: [PATCHv2 1/3] phy: Add exynos-simple-phy driver

2014-04-09 Thread Tomasz Stanislawski
Hi Rahul, On 04/09/2014 11:12 AM, Rahul Sharma wrote: Hi Tomasz, On 9 April 2014 14:07, Andrzej Hajda a.ha...@samsung.com wrote: Hi Tomasz, On 04/08/2014 04:37 PM, Tomasz Stanislawski wrote: Add exynos-simple-phy driver to support a single register PHY interfaces present on Exynos4 SoC

[PATCHv2 3/3] s5p-tv: hdmi: use hdmiphy as PHY

2014-04-08 Thread Tomasz Stanislawski
The HDMIPHY (physical interface) is controlled by a single bit in a power controller's regiter. It was implemented as clock. It was a simple but effective hack. This patch makes S5P-HDMI driver to control HDMIPHY via PHY interface. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com

[PATCHv2 2/3] drm: exynos: hdmi: use hdmiphy as PHY

2014-04-08 Thread Tomasz Stanislawski
The HDMIPHY (physical interface) is controlled by a single bit in a power controller's regiter. It was implemented as clock. It was a simple but effective hack. This patch makes HDMI driver to control HDMIPHY via PHY interface. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com

[PATCHv2 1/3] phy: Add exynos-simple-phy driver

2014-04-08 Thread Tomasz Stanislawski
Add exynos-simple-phy driver to support a single register PHY interfaces present on Exynos4 SoC. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com --- .../devicetree/bindings/phy/samsung-phy.txt| 24 +++ drivers/phy/Kconfig|5 + drivers/phy

[PATCHv2 0/3] phy: Add exynos-simple-phy driver

2014-04-08 Thread Tomasz Stanislawski
/focus=28648 * create a dedicated power domain for hdmiphy Regards, Tomasz Stanislawski Changelog: v2: * rename to exynos-simple-phy * fix usage of devm_ioremap() * add documentation for DT bindings * add patches to client drivers v1: initial version Tomasz

Re: DMABUF doesn't work when frame size not equal to the size of GPU bo

2013-12-30 Thread Tomasz Stanislawski
Hi Chuanbo Weng, I suspect that the problem might be caused by difference between size of DMABUF object and buffer size in V4L2. What is the content of v4l2_format returned by VIDIOC_G_FMT? What is the content of V4l2_buffer structure passed by VIDIOC_QBUF? Regards, Tomasz Stanislawski On 12/31

Re: [RFC v3] [RFC] v4l2: Support for multiple selections

2013-12-19 Thread Tomasz Stanislawski
, Tomasz Stanislawski t.stanisl...@samsung.com wrote: Hi Ricardo, Sorry for a late reply. I've been 'offline' for the last two weeks. Please refer to the comments below. [snip] As I said. Changes of rectangle n may trigger changes in rectangle n+1 and so on. So activation of rectangle B

Re: [RFC v3] [RFC] v4l2: Support for multiple selections

2013-12-19 Thread Tomasz Stanislawski
Hi Ricardo, On 12/10/2013 10:46 AM, Ricardo Ribalda Delgado wrote: Hello Tomasz and Hans On Thu, Nov 14, 2013 at 4:40 PM, Tomasz Stanislawski t.stanisl...@samsung.com wrote: Hi Hans, On 11/14/2013 11:18 AM, Hans Verkuil wrote: Hi Tomasz, On 11/12/13 15:54, Tomasz Stanislawski wrote

Re: [RFC v3] [RFC] v4l2: Support for multiple selections

2013-12-19 Thread Tomasz Stanislawski
cluster), not by making properties larger. As I said, there are multiple way to handle atomic configuration. Using control API is one of them. Quite nice BTW :) Regards, Tomasz Stanislawski -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [RFC v3] [RFC] v4l2: Support for multiple selections

2013-11-14 Thread Tomasz Stanislawski
Hi Hans, On 11/14/2013 11:18 AM, Hans Verkuil wrote: Hi Tomasz, On 11/12/13 15:54, Tomasz Stanislawski wrote: Hi Ricardo, Sorry for a late reply. I've been 'offline' for the last two weeks. Please refer to the comments below. [snip] As I said. Changes of rectangle n may trigger

Re: [RFC v3] [RFC] v4l2: Support for multiple selections

2013-11-12 Thread Tomasz Stanislawski
, 2013 at 12:31 PM, Tomasz Stanislawski t.stanisl...@samsung.com wrote: Hi Ricardo, I am the designer of selection API. I hope I can help you a little. I think that there are two issues mixed in 'Mulitple selections' topic. Firstly, you described that you program a piece of hardware

Re: [RFC v3] [RFC] v4l2: Support for multiple selections

2013-10-24 Thread Tomasz Stanislawski
or v4l2_ext_rect. This way one can avoid introducting v4l2_selection::rectangles field. I hope you find this comments useful. Regards, Tomasz Stanislawski -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 5/7] phy: Add driver for Exynos DP PHY

2013-10-24 Thread Tomasz Stanislawski
may help to avoid code duplication. Regards, Tomasz Stanislawski On 10/16/2013 06:28 PM, Kishon Vijay Abraham I wrote: From: Jingoo Han jg1@samsung.com Add a PHY provider driver for the Samsung Exynos SoC Display Port PHY. Signed-off-by: Jingoo Han jg1@samsung.com Reviewed

Re: Fwd: [PATCH 3/6] [media] s5p-mfc: add support for VIDIOC_{G,S}_CROP to encoder

2013-10-17 Thread Tomasz Stanislawski
= V4L2_SEL_TGT_CROP }) ioctl(capture, VIDIOC_S_SELECTION, struct v4l2_selection { .type = V4L2_BUF_TYPE_VIDEO_OUTPUT, .target = V4L2_SEL_TGT_COMPOSE }) is still undefined and application should not use them. I hope you find this information useful. Regards, Tomasz Stanislawski

Re: [PATCH v5 2/4] media: s5p-tv: Restore vpll clock rate

2013-09-25 Thread Tomasz Stanislawski
Hi, As you can see sdo, hdmi and mixer are saparate drivers that are parts of s5p-tv drivers set. Could you rename commit name to 'media: s5p-tv: sdo: Restore vpll clock rate after streamoff' On 09/21/2013 05:00 PM, Mateusz Krawczuk wrote: Restore vpll clock rate if start stream fail or stream

Re: [PATCH v5 3/4] media: s5p-tv: Fix sdo driver to work with CCF

2013-09-25 Thread Tomasz Stanislawski
Rename to 'media: s5p-tv: sdo: integrate with CCF' On 09/21/2013 05:00 PM, Mateusz Krawczuk wrote: Replace clk_enable by clock_enable_prepare and clk_disable with clk_disable_unprepare. Clock prepare is required by Clock Common Framework, and old clock driver didn`t support it. Without it

Re: [PATCH v5 4/4] media: s5p-tv: Fix mixer driver to work with CCF

2013-09-25 Thread Tomasz Stanislawski
it Common Clock Framework prints a warning. Signed-off-by: Mateusz Krawczuk m.krawc...@partner.samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Tomasz Stanislawski t.stanisl...@samsung.com --- drivers/media/platform/s5p-tv/mixer_drv.c | 34

Re: [PATCH v5 4/4] media: s5p-tv: Fix mixer driver to work with CCF

2013-09-25 Thread Tomasz Stanislawski
On 09/23/2013 02:44 PM, Sylwester Nawrocki wrote: On 21/09/13 17:00, Mateusz Krawczuk wrote: Replace clk_enable by clock_enable_prepare and clk_disable with clk_disable_unprepare. Clock prepare is required by Clock Common Framework, and old clock driver didn`t support it. Without it Common

Re: [PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

2013-09-24 Thread Tomasz Stanislawski
Hi, On 09/23/2013 05:48 PM, Bartlomiej Zolnierkiewicz wrote: Hi Tomasz, On Monday, September 23, 2013 04:50:01 PM Tomasz Stanislawski wrote: Hello, May I ask what is the rationale for this patch? To reduce a few lines of code? This patch makes source code more generic-like and easier

Re: [PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

2013-09-24 Thread Tomasz Stanislawski
On 09/23/2013 07:44 PM, Joe Perches wrote: On Mon, 2013-09-23 at 17:48 +0200, Bartlomiej Zolnierkiewicz wrote: On Monday, September 23, 2013 04:50:01 PM Tomasz Stanislawski wrote: May I ask what is the rationale for this patch? To reduce a few lines of code? This patch makes source code more

Re: [PATCH v5 1/4] media: s5p-tv: Replace mxr_ macro by default dev_

2013-09-23 Thread Tomasz Stanislawski
Hello, May I ask what is the rationale for this patch? To reduce a few lines of code? Or to give up possibility of changing message format in just one place? I could see migrating from mxr_* to pr_* could seen as the fix, but not this. Waiting for reply, Tomasz Stanislawski On 09/21/2013 05:00

Re: Question: interaction between selection API, ENUM_FRAMESIZES and S_FMT?

2013-07-02 Thread Tomasz Stanislawski
that the changes are dramatic but fixing issues with pipeline configuration is worth it. What do you think about the proposed idea? Regards, Tomasz Stanislawski [1] http://www.spinics.net/lists/linux-media/msg34541.html -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: [REVIEW PATCH 0/6] s5p-tv: replace dv_preset by dv_timings

2013-03-20 Thread Tomasz Stanislawski
Hi everyone, After successful testing (after applying use cap instead of 0 fix), please add: Tested-by: Tomasz Stanislawski t.stanisl...@samsung.com Acked-by: Tomasz Stanislawski t.stanisl...@samsung.com to the commit log. Regards, Tomasz Stanislawski On 03/18/2013 03:24 PM, Hans Verkuil wrote

Re: [RFC PATCH 00/18] Remove DV_PRESET API

2013-03-01 Thread Tomasz Stanislawski
-by: Tomasz Stanislawski t.stanisl...@samsung.com to all s5p-tv related patches. I tested following features: a) v4l2-ctl --list-dv-timings Result: got 10 timings entries as expected b) v4l2-ctl --get-dv-timings-cap Result: got timings caps. The was minor issue. Minimal with is 720 not 640. c

Re: [RFC PATCH 09/18] s5p-tv: add dv_timings support for hdmi.

2013-03-01 Thread Tomasz Stanislawski
Hi Hans, Please refer to the comments below. On 02/16/2013 10:28 AM, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com This just adds dv_timings support without modifying existing dv_preset support. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Tomasz Stanislawski

Re: [RFC PATCH 10/18] s5p-tv: add dv_timings support for hdmiphy.

2013-03-01 Thread Tomasz Stanislawski
() between the preset and timings code. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Tomasz Stanislawski t.stanisl...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-tv/hdmiphy_drv.c | 48 ++- 1 file changed, 39

Re: [RFC PATCH 11/18] s5p-tv: remove dv_preset support from mixer_video.

2013-03-01 Thread Tomasz Stanislawski
to remove the dv_preset API altogether (s5p-tv being the last user of this code). Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Tomasz Stanislawski t.stanisl...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-tv/mixer_video.c | 68

Re: [PATCH 0/9] [media] s5p-tv: Checkpatch Fixes and cleanup

2012-12-03 Thread Tomasz Stanislawski
integrated with clk_prepare/unprepare stuff. Regards, Tomasz Stanislawski Hi Tomasz, Any comments on this series? Regards, Sachin Sachin Kamat (9): [media] s5p-tv: Add missing braces around sizeof in sdo_drv.c [media] s5p-tv: Add missing braces around sizeof

Re: [PATCH 1/1] [media] s5p-tv: Use devm_gpio_request in sii9234_drv.c

2012-11-15 Thread Tomasz Stanislawski
On 11/16/2012 05:55 AM, Sachin Kamat wrote: devm_gpio_request is a device managed function and will make error handling and cleanup a bit simpler. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Acked-by: Tomasz Stanislawski t.stanisl...@samsung.com --- drivers/media/platform/s5p-tv

Re: [PATCH 27/26] v4l: vb2: Set data_offset to 0 for single-plane buffers

2012-11-08 Thread Tomasz Stanislawski
it is pretty intuitive. For DMABUF capture devices data_offset maybe used to inform a driver to capture the image at some offset inside the DMABUF buffer. BTW. Should {} be added after if (V4L2_TYPE_IS_OUTPUT(b-type)) to avoid 'interesting' behavior? :) Regards, Tomasz Stanislawski -- To unsubscribe

Re: [PATCHv10 21/26] v4l: vb2-dma-contig: add reference counting for a device from allocator context

2012-10-12 Thread Tomasz Stanislawski
Hi Laurent, Thank your your review. On 10/11/2012 11:49 PM, Laurent Pinchart wrote: Hi Tomasz, Thanks for the patch. On Wednesday 10 October 2012 16:46:40 Tomasz Stanislawski wrote: This patch adds taking reference to the device for MMAP buffers. Such buffers, may be exported using

Re: [PATCHv10 22/26] v4l: vb2-dma-contig: fail if user ptr buffer is not correctly aligned

2012-10-12 Thread Tomasz Stanislawski
Hi Laurent, Thank you for the review. Please refer to the comments below. On 10/11/2012 11:36 PM, Laurent Pinchart wrote: Hi Tomasz, Thanks for the patch. On Wednesday 10 October 2012 16:46:41 Tomasz Stanislawski wrote: From: Marek Szyprowski m.szyprow...@samsung.com The DMA transfer

Re: [PATCHv10 23/26] v4l: vb2-dma-contig: align buffer size to PAGE_SIZE

2012-10-12 Thread Tomasz Stanislawski
Hi Laurent, On 10/11/2012 11:31 PM, Laurent Pinchart wrote: Hi Tomasz, On Wednesday 10 October 2012 16:46:42 Tomasz Stanislawski wrote: Most operations on DMA and DMABUF framework need page aligned buffers. The comment is a bit misleading, the buffer is already page-aligned (unless I'm

Re: [PATCHv9 19/25] v4l: vb2: add buffer exporting via dmabuf

2012-10-10 Thread Tomasz Stanislawski
On 10/06/2012 02:22 PM, Hans Verkuil wrote: On Tue October 2 2012 16:27:30 Tomasz Stanislawski wrote: This patch adds extension to videobuf2-core. It allow to export a mmap buffer as a file descriptor. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park

[PATCHv10 00/26] Integration of videobuf2 with DMABUF

2012-10-10 Thread Tomasz Stanislawski
MEMORY_DMABUF v4l: vb2-dma-contig: add support for dma_buf importing Tomasz Stanislawski (16): Documentation: media: description of DMABUF importing in V4L2 v4l: vb2-dma-contig: remove reference of alloc_ctx from a buffer v4l: vb2-dma-contig: add support for scatterlist in userptr mode v4l

[PATCHv10 01/26] v4l: Add DMABUF as a memory type

2012-10-10 Thread Tomasz Stanislawski
From: Sumit Semwal sumit.sem...@ti.com Adds DMABUF memory type to v4l framework. Also adds the related file descriptor in v4l2_plane and v4l2_buffer. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com [original work in the PoC for buffer sharing] Signed-off-by: Sumit Semwal sumit.sem

[PATCHv10 02/26] Documentation: media: description of DMABUF importing in V4L2

2012-10-10 Thread Tomasz Stanislawski
This patch adds description and usage examples for importing DMABUF file descriptor in V4L2. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: linux-...@vger.kernel.org --- Documentation/DocBook/media/v4l/compat.xml

[PATCHv10 03/26] v4l: vb2: add support for shared buffer (dma_buf)

2012-10-10 Thread Tomasz Stanislawski
outside of V4L2. [A sample allocator of dma-buf shared buffer is given at [1]] [1]: Rob Clark's DRM: https://github.com/robclark/kernel-omap4/commits/drmplane-dmabuf Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com [original work in the PoC for buffer sharing] Signed-off-by: Sumit

[PATCHv10 04/26] v4l: vb: remove warnings about MEMORY_DMABUF

2012-10-10 Thread Tomasz Stanislawski
From: Sumit Semwal sumit.sem...@ti.com Adding DMABUF memory type causes videobuf to complain about not using it in some switch cases. This patch removes these warnings. Signed-off-by: Sumit Semwal sumit.sem...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hans

[PATCHv10 05/26] v4l: vb2-dma-contig: shorten vb2_dma_contig prefix to vb2_dc

2012-10-10 Thread Tomasz Stanislawski
From: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 36 1 file changed, 18 insertions(+), 18

[PATCHv10 06/26] v4l: vb2-dma-contig: remove reference of alloc_ctx from a buffer

2012-10-10 Thread Tomasz Stanislawski
This patch removes a reference to alloc_ctx from an instance of a DMA contiguous buffer. It helps to avoid a risk of a dangling pointer if the context is released while the buffer is still valid. Moreover it removes one dereference step while accessing a device structure. Signed-off-by: Tomasz

[PATCHv10 07/26] v4l: vb2-dma-contig: reorder functions

2012-10-10 Thread Tomasz Stanislawski
From: Laurent Pinchart laurent.pinch...@ideasonboard.com Group functions by buffer type. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 92 ++-- 1 file

[PATCHv10 08/26] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-10-10 Thread Tomasz Stanislawski
...@samsung.com. Kind thanks for bug reports from Laurent Pinchart laurent.pinch...@ideasonboard.com and Seung-Woo Kim sw0312@samsung.com. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Laurent Pinchart laurent.pinch

[PATCHv10 09/26] v4l: vb2: add prepare/finish callbacks to allocators

2012-10-10 Thread Tomasz Stanislawski
From: Marek Szyprowski m.szyprow...@samsung.com This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by:

[PATCHv10 10/26] v4l: vb2-dma-contig: add prepare/finish to dma-contig allocator

2012-10-10 Thread Tomasz Stanislawski
From: Marek Szyprowski m.szyprow...@samsung.com Add prepare/finish callbacks to vb2-dma-contig allocator. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hans Verkuil hans.verk...@cisco.com ---

[PATCHv10 11/26] v4l: vb2-dma-contig: add support for dma_buf importing

2012-10-10 Thread Tomasz Stanislawski
sumit.sem...@linaro.org [author of the original patch] Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com [integration with refactored dma-contig allocator] Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/v4l2-core/Kconfig|1

[PATCHv10 12/26] v4l: vb2-vmalloc: add support for dmabuf importing

2012-10-10 Thread Tomasz Stanislawski
This patch adds support for importing DMABUF files for vmalloc allocator in Videobuf2. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hans Verkuil hans.verk

[PATCHv10 13/26] v4l: vivi: support for dmabuf importing

2012-10-10 Thread Tomasz Stanislawski
This patch enhances VIVI driver with a support for importing a buffer from DMABUF file descriptors. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/platform/vivi.c

[PATCHv10 15/26] v4l: s5p-fimc: support for dmabuf importing

2012-10-10 Thread Tomasz Stanislawski
This patch enhances s5p-fimc with support for DMABUF importing via V4L2_MEMORY_DMABUF memory type. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Sylwester Nawrocki s.nawro...@samsung.com Acked-by: Hans Verkuil

[PATCHv10 16/26] v4l: vb2-dma-contig: let mmap method to use dma_mmap_coherent call

2012-10-10 Thread Tomasz Stanislawski
...@samsung.com Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 28 +++-- drivers/media/v4l2-core/videobuf2

[PATCHv10 17/26] Documentation: media: description of DMABUF exporting in V4L2

2012-10-10 Thread Tomasz Stanislawski
This patch adds description and usage examples for exporting DMABUF file descriptor in V4L2. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: linux-...@vger.kernel.org --- Documentation/DocBook/media/v4l/compat.xml

[PATCHv10 18/26] v4l: add buffer exporting via dmabuf

2012-10-10 Thread Tomasz Stanislawski
This patch adds extension to V4L2 api. It allow to export a mmap buffer as file descriptor. New ioctl VIDIOC_EXPBUF is added. It takes a buffer offset used by mmap and return a file descriptor on success. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park

[PATCHv10 19/26] v4l: vb2: add buffer exporting via dmabuf

2012-10-10 Thread Tomasz Stanislawski
This patch adds extension to videobuf2-core. It allow to export a mmap buffer as a file descriptor. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hans

[PATCHv10 20/26] v4l: vb2-dma-contig: add support for DMABUF exporting

2012-10-10 Thread Tomasz Stanislawski
This patch adds support for exporting a dma-contig buffer using DMABUF interface. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/videobuf2-dma-contig.c

[PATCHv10 21/26] v4l: vb2-dma-contig: add reference counting for a device from allocator context

2012-10-10 Thread Tomasz Stanislawski
descriptor(s). The device pointer kept in a buffer must be valid for the whole buffer's lifetime. Therefore MMAP buffers should take a reference to the device to avoid risk of dangling pointers. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Acked-by: Hans Verkuil hans.verk

[PATCHv10 22/26] v4l: vb2-dma-contig: fail if user ptr buffer is not correctly aligned

2012-10-10 Thread Tomasz Stanislawski
From: Marek Szyprowski m.szyprow...@samsung.com The DMA transfer must be aligned to a specific value. If userptr is not aligned to DMA requirements then unexpected corruptions of the memory may occur before or after a buffer. To prevent such situations, all unligned userptr buffers are rejected

[PATCHv10 23/26] v4l: vb2-dma-contig: align buffer size to PAGE_SIZE

2012-10-10 Thread Tomasz Stanislawski
Most operations on DMA and DMABUF framework need page aligned buffers. This fix guarantees this requirement for vb2-dma-contig buffers. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com --- drivers/media/v4l2-core/videobuf2-dma-contig.c |3 +++ 1 file changed, 3 insertions(+) diff

[PATCHv10 24/26] v4l: s5p-fimc: support for dmabuf exporting

2012-10-10 Thread Tomasz Stanislawski
This patch enhances s5p-fimc with support for DMABUF exporting via VIDIOC_EXPBUF ioctl. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: Sylwester Nawrocki s.nawro...@samsung.com Acked-by: Hans Verkuil hans.verk...@cisco.com

[PATCHv10 25/26] v4l: s5p-tv: mixer: support for dmabuf exporting

2012-10-10 Thread Tomasz Stanislawski
This patch enhances s5p-tv with support for DMABUF exporting via VIDIOC_EXPBUF ioctl. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/platform/s5p-tv/mixer_video.c

[PATCHv10 26/26] v4l: s5p-mfc: support for dmabuf exporting

2012-10-10 Thread Tomasz Stanislawski
This patch enhances s5p-mfc with support for DMABUF exporting via VIDIOC_EXPBUF ioctl. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: Kamil Debski k.deb...@samsung.com Acked-by: Hans Verkuil hans.verk...@cisco.com

Test application for DMABUF support in V4L2

2012-10-10 Thread Tomasz Stanislawski
is not supported. Please let us know if you have any further questions. Regards, Tomasz Stanislawski /* * V4L2 VIVI + FIMC + DMABUF sharing Test Application * * This application is used to test DMABUF sharing between VIVI and FIMC * device. * * Authors: * Tomasz Stanislawski t.stanisl...@samsung.com

Re: [PATCHv9 18/25] v4l: add buffer exporting via dmabuf

2012-10-08 Thread Tomasz Stanislawski
Hi Hans, On 10/07/2012 04:17 PM, Hans Verkuil wrote: On Sun October 7 2012 15:38:30 Laurent Pinchart wrote: Hi Hans, On Friday 05 October 2012 10:55:40 Hans Verkuil wrote: On Tue October 2 2012 16:27:29 Tomasz Stanislawski wrote: This patch adds extension to V4L2 api. It allow to export

Re: [PATCHv9 18/25] v4l: add buffer exporting via dmabuf

2012-10-08 Thread Tomasz Stanislawski
Hi Hans, On 10/08/2012 11:54 AM, Hans Verkuil wrote: On Mon October 8 2012 11:40:37 Tomasz Stanislawski wrote: Hi Hans, On 10/07/2012 04:17 PM, Hans Verkuil wrote: On Sun October 7 2012 15:38:30 Laurent Pinchart wrote: Hi Hans, On Friday 05 October 2012 10:55:40 Hans Verkuil wrote

[GIT PULL FOR v3.7] media: s5p-hdmi: add HPD GPIO to platform data

2012-10-05 Thread Tomasz Stanislawski
-for3.7 for you to fetch changes up to b26bab928dd6f6e1d5613b68fa6fea1d29c9005e: media: s5p-hdmi: add HPD GPIO to platform data (2012-10-05 14:53:05 +0200) Tomasz Stanislawski (1): media: s5p-hdmi: add HPD GPIO to platform data

[PATCHv9 00/25] Integration of videobuf2 with DMABUF

2012-10-02 Thread Tomasz Stanislawski
-dma-contig: fail if user ptr buffer is not correctly aligned Sumit Semwal (4): v4l: Add DMABUF as a memory type v4l: vb2: add support for shared buffer (dma_buf) v4l: vb: remove warnings about MEMORY_DMABUF v4l: vb2-dma-contig: add support for dma_buf importing Tomasz Stanislawski (15

[PATCHv9 01/25] v4l: Add DMABUF as a memory type

2012-10-02 Thread Tomasz Stanislawski
From: Sumit Semwal sumit.sem...@ti.com Adds DMABUF memory type to v4l framework. Also adds the related file descriptor in v4l2_plane and v4l2_buffer. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com [original work in the PoC for buffer sharing] Signed-off-by: Sumit Semwal sumit.sem

[PATCHv9 02/25] Documentation: media: description of DMABUF importing in V4L2

2012-10-02 Thread Tomasz Stanislawski
This patch adds description and usage examples for importing DMABUF file descriptor in V4L2. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: linux-...@vger.kernel.org --- Documentation/DocBook/media/v4l/compat.xml

[PATCHv9 03/25] v4l: vb2: add support for shared buffer (dma_buf)

2012-10-02 Thread Tomasz Stanislawski
outside of V4L2. [A sample allocator of dma-buf shared buffer is given at [1]] [1]: Rob Clark's DRM: https://github.com/robclark/kernel-omap4/commits/drmplane-dmabuf Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com [original work in the PoC for buffer sharing] Signed-off-by: Sumit

[PATCHv9 04/25] v4l: vb: remove warnings about MEMORY_DMABUF

2012-10-02 Thread Tomasz Stanislawski
From: Sumit Semwal sumit.sem...@ti.com Adding DMABUF memory type causes videobuf to complain about not using it in some switch cases. This patch removes these warnings. Signed-off-by: Sumit Semwal sumit.sem...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com ---

[PATCHv9 05/25] v4l: vb2-dma-contig: shorten vb2_dma_contig prefix to vb2_dc

2012-10-02 Thread Tomasz Stanislawski
From: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/videobuf2-dma-contig.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git

[PATCHv9 06/25] v4l: vb2-dma-contig: remove reference of alloc_ctx from a buffer

2012-10-02 Thread Tomasz Stanislawski
This patch removes a reference to alloc_ctx from an instance of a DMA contiguous buffer. It helps to avoid a risk of a dangling pointer if the context is released while the buffer is still valid. Moreover it removes one dereference step while accessing a device structure. Signed-off-by: Tomasz

[PATCHv9 07/25] v4l: vb2-dma-contig: reorder functions

2012-10-02 Thread Tomasz Stanislawski
From: Laurent Pinchart laurent.pinch...@ideasonboard.com Group functions by buffer type. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/videobuf2-dma-contig.c | 92 1 file changed, 54 insertions(+), 38 deletions(-) diff

[PATCHv9 08/25] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-10-02 Thread Tomasz Stanislawski
...@samsung.com. Kind thanks for bug reports from Laurent Pinchart laurent.pinch...@ideasonboard.com and Seung-Woo Kim sw0312@samsung.com. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Laurent Pinchart laurent.pinch

[PATCHv9 09/25] v4l: vb2: add prepare/finish callbacks to allocators

2012-10-02 Thread Tomasz Stanislawski
From: Marek Szyprowski m.szyprow...@samsung.com This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com ---

[PATCHv9 10/25] v4l: vb2-dma-contig: add prepare/finish to dma-contig allocator

2012-10-02 Thread Tomasz Stanislawski
From: Marek Szyprowski m.szyprow...@samsung.com Add prepare/finish callbacks to vb2-dma-contig allocator. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/videobuf2-dma-contig.c | 24

[PATCHv9 11/25] v4l: vb2-dma-contig: add support for dma_buf importing

2012-10-02 Thread Tomasz Stanislawski
sumit.sem...@linaro.org [author of the original patch] Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com [integration with refactored dma-contig allocator] Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/Kconfig|1

[PATCHv9 12/25] v4l: vb2-vmalloc: add support for dmabuf importing

2012-10-02 Thread Tomasz Stanislawski
This patch adds support for importing DMABUF files for vmalloc allocator in Videobuf2. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/videobuf2

  1   2   3   4   5   >