Hi Adam,
thanks for testing
On Mon, Dec 03, 2018 at 10:28:04AM -0600, Adam Ford wrote:
> On Thu, Nov 29, 2018 at 8:49 AM Jacopo Mondi
> wrote:
> >
> > The MIPI clock generation tree uses the MIPI_DIV divider to generate both
> > the
> > MIPI SCALER CLOCK
the MIPI_DIV selection value depend on the subsampling mode used by the
currently applied image mode.
Tested with:
172x144 320x240, 640x480, 1024x756, 1024x768, 1280x720, 1920x1080 in YUYV mode
at 10, 15, 20, and 30 FPS with MIPI CSI-2 2 lanes mode.
Signed-off-by: Jacopo Mondi
---
Maxime,
this patch
)
please report the results. Same for all other interested ones :)
Thanks
j
Jacopo Mondi (2):
media: i2c: ov5640: Fix set format regression
media: ov5640: make MIPI clock depend on mode
drivers/media/i2c/ov5640.c | 110 ++---
1 file changed, 54 insertions
:
[fmt:UYVY8_2X8/640x480@1/30 field:none colorspace:srgb xfer:srgb ...]
With this patch applied:
[fmt:UYVY8_2X8/1024x768@1/30 field:none colorspace:srgb xfer:srgb ...]
Fixes: 6949d864776e ("media: ov5640: do not change mode if format or frame
interval is unchanged")
Signed-off-by: Jacopo Mondi
--
Hi Maxime,
On Tue, Nov 20, 2018 at 10:48:39AM +0100, Maxime Ripard wrote:
> Hi Jacopo,
>
> On Wed, Nov 14, 2018 at 08:48:47PM +0100, jacopo mondi wrote:
> > On Tue, Nov 13, 2018 at 02:03:15PM +0100, Maxime Ripard wrote:
> > > The clock structure for the PCLK is quite obsc
Hi Sakari,
On Wed, Nov 14, 2018 at 09:40:50AM +0200, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Wed, Nov 14, 2018 at 01:25:11AM +0100, jacopo mondi wrote:
> > On Mon, Oct 29, 2018 at 03:22:54PM -0700, Yong Zhi wrote:
> > > Hi,
> > >
> > > This series adds su
Hi Maxime,
many thanks for re-sending this updated version
On Tue, Nov 13, 2018 at 02:03:15PM +0100, Maxime Ripard wrote:
> The clock structure for the PCLK is quite obscure in the documentation, and
> was hardcoded through the bytes array of each and every mode.
>
> This is troublesome, since
On Mon, Oct 29, 2018 at 03:22:54PM -0700, Yong Zhi wrote:
> Hi,
>
> This series adds support for the Intel IPU3 (Image Processing Unit)
> ImgU which is essentially a modern memory-to-memory ISP. It implements
> raw Bayer to YUV image format conversion as well as a large number of
> other pixel
0, ov7670, and ov772x drivers. I have these devices
> so these patches are tested with real devices.
>
For the ov772x part:
Acked-by: Jacopo Mondi
Thanks
j
> Akinobu Mita (7):
> media: mt9m111: support log_status ioctl and event interface
> media: mt9m111: add V4L2_CID_C
Hi Jean-Michel,
On Fri, Nov 02, 2018 at 09:09:42AM +0100, Jean-Michel Hautbois wrote:
> Hi Steve,
>
> Le mer. 31 oct. 2018 à 22:52, Steve Longerbeam a
> écrit :
> >
> > Hi Jean-Michel,
> >
> > We've done some work with another FPD-Link de-serializer (ds90ux940) and
> > IIRC we had some trouble
On Tue, Oct 30, 2018 at 05:35:23PM -0300, Mauro Carvalho Chehab wrote:
> Em Tue, 30 Oct 2018 21:28:57 +0100
> jacopo mondi escreveu:
>
> > Hi Mauro,
> >
> > On Tue, Oct 30, 2018 at 09:14:09AM -0300, Mauro Carvalho Chehab wrote:
> > > Em Tue, 30 Oct 2018 01:21:3
Hi Mauro,
On Tue, Oct 30, 2018 at 09:14:09AM -0300, Mauro Carvalho Chehab wrote:
> Em Tue, 30 Oct 2018 01:21:34 +0200
> Sakari Ailus escreveu:
>
> > The SoC camera framework has been obsolete for some time and it is no
> > longer functional. A few drivers have been converted to the V4L2
> >
Hi Mauro, Hans, Sakari,
On Fri, Oct 19, 2018 at 03:58:51PM +0300, Sakari Ailus wrote:
> Hi Hans, Mauro,
>
> On Fri, Oct 19, 2018 at 02:39:27PM +0200, Hans Verkuil wrote:
> > On 10/19/18 14:31, Mauro Carvalho Chehab wrote:
> > > Em Fri, 19 Oct 2018 13:45:32 +0200
> > > Hans Verkuil escreveu:
> >
Hi Sam,
some comments and questions.
I still hope we find a way to merge our changes, but I need to
understand something before.
On Wed, Oct 17, 2018 at 10:31:48AM -0700, Sam Bobrowicz wrote:
> Remove the PLL settings from the register blobs and
> calculate them based on required clocks. This
Hello Maxime,
On Thu, Oct 18, 2018 at 11:29:12AM +0200, Maxime Ripard wrote:
> Hi Jacopo,
>
> Thanks for reviewing this patch
>
> On Tue, Oct 16, 2018 at 06:54:50PM +0200, jacopo mondi wrote:
> > > +static unsigned long ov5640_compute_sys_clk(s
Hi Maxime,
On Thu, Oct 18, 2018 at 11:15:50AM +0200, Maxime Ripard wrote:
> On Wed, Oct 17, 2018 at 09:37:17PM +0200, Jacopo Mondi wrote:
> > Check that the PLL1 output frequency does not exceed the maximum allowed
> > 1GHz
> > frequency.
> >
> > Signed-off-by: J
On Thu, Oct 18, 2018 at 11:31:52AM +0200, Maxime Ripard wrote:
> On Wed, Oct 17, 2018 at 09:51:43PM +0200, jacopo mondi wrote:
> > Hello Sam and Maxime (and other ov5640-ers :)
> >
> > On Wed, Oct 17, 2018 at 10:54:01AM -0700, Sam Bobrowicz wrote:
> > > Hello Maxim
s
j
>
> Thanks,
> Sam
>
> Additional notes below.
>
> On Tue, Oct 16, 2018 at 9:54 AM jacopo mondi wrote:
> >
> > Hello Maxime,
> >a few comments I have collected while testing the series.
> >
> > Please see below.
> >
> > On Thu,
Modify the MIPI clock tree calculation procedure.
The implemented function receives the total bandwidth required in bytes
and calculate the sample rate and the MIPI clock rate accordingly.
Tested with capture at 1080p, 720p, VGA and QVGA.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c
Check that the PLL1 output frequency does not exceed the maximum allowed 1GHz
frequency.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov5640.c | 23 +++
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640
framerates,
and hopefully improve mode settings and configuration \o/.
I'll try to look into Sam's series next, and see if conflicts with this, or
those can be merged together.
A lot of interesting stuff happening on this driver!
Thanks
j
Jacopo Mondi (2):
media: ov5640: Add check for PLL1
Hello Maxime,
a few comments I have collected while testing the series.
Please see below.
On Thu, Oct 11, 2018 at 11:20:56AM +0200, Maxime Ripard wrote:
> The clock structure for the PCLK is quite obscure in the documentation, and
> was hardcoded through the bytes array of each and every
Hello Maxime,
On Thu, Oct 11, 2018 at 11:20:55AM +0200, Maxime Ripard wrote:
> Hi,
>
> Here is a "small" series that mostly cleans up the ov5640 driver code,
> slowly getting rid of the big data array for more understandable code
> (hopefully).
>
> The biggest addition would be the clock rate
but one item at the time to avoid getting lost in too many
pending changes as it happened recently :)
Thanks
j
[1]
media: ov5640: Do not restore format at power up
Do not force restoring the last applied capture format during sensor power
up
as it will be re-set at s_stream time
Hi Sam,
thanks for the patch, I see the same issue you reported, but I
think this patch can be improved.
(expanding the Cc list to all people involved in recent ov5640
developemts, not just for this patch, but for the whole series to look
at. Copying names from another series cover letter,
Hi Sam,
On Mon, Oct 08, 2018 at 11:48:00PM -0700, Sam Bobrowicz wrote:
> Light frequency was not properly returned when in auto
> mode and the detected frequency was 60Hz. Fix this.
>
> Signed-off-by: Sam Bobrowicz
This is indeed a bugfix
Acked-by: Jacopo Mondi
Thanks
j
>
ree. I found it is required
when the sensor control handler is add to the receiver driver control
handler, and thus g_voltaile_ctrl can be called when the sensor is
powered off.
Please add my:
Acked-by: Jacopo Mondi
Thanks
j
> ---
> drivers/media/i2c/ov5640.c | 7 +++
> 1 file
sel->r.left = 0;
> > - sel->r.top = 0;
> > - sel->r.width = VGA_WIDTH;
> > - sel->r.height = VGA_HEIGHT;
> > - return 0;
> > case V4L2_SEL_TGT_CROP:
> > sel->r = priv->frame;
>
Hi Sakari,
thanks for handling this
On Sun, Sep 16, 2018 at 02:02:30AM +0300, Sakari Ailus wrote:
> Hi Jacopo, Hugues,
>
> On Fri, Sep 14, 2018 at 06:07:12PM +0200, jacopo mondi wrote:
> > Hi Sakari,
> >
> > On Tue, Sep 11, 2018 at 03:48:16PM +0200, Hugues Fruc
Hi Sakari,
On Tue, Sep 11, 2018 at 03:48:16PM +0200, Hugues Fruchet wrote:
> This patch serie fixes some problems around exposure & gain in OV5640 driver.
As you offered to collect this series and my CSI-2 fixes I have just
re-sent, you might be interested in this branch:
git://jmondi.org/linux
# v4l2-ctl -d /dev/video4 --set-ctrl=auto_exposure=0
# v4l2-ctl -d /dev/video4 --set-ctrl=gain_automatic=1
# v4l2-ctl --get-ctrl "exposure" --get-ctrl "gain" -d /dev/video4
exposure: 885
gain: 46
(Finger on the sensor)
# v4l2-ctl --get-ctrl "exposure" --get-ctrl "g
egister 0x300e[7:5] discrepancy between implementation
and sensor manual (thanks Loic)
v2 -> v3:
- patch [2/2] was originally sent in a different series, compared to v2 it
removes entries from the blob array instead of adding more.
Jacopo Mondi (2):
media: ov5640: Re-work MIPI startup sequen
From: Jacopo Mondi
As of:
commit 476dec012f4c ("media: ov5640: Add horizontal and vertical totals")
the timings parameters gets programmed separately from the static register
values array.
When changing capture mode, the vertical and horizontal totals gets
From: Jacopo Mondi
Rework the MIPI interface startup sequence with the following changes:
- Remove MIPI bus initialization from the initial settings blob
- At set_power(1) time power up MIPI Tx/Rx and set data and clock lanes in
LP11 during 'sleep' and 'idle' with MIPI clock in non-continuous
Hello Loic,
On Thu, Sep 06, 2018 at 10:13:53AM +0200, Loic Poulain wrote:
> On 6 September 2018 at 09:48, jacopo mondi wrote:
> > Hello Loic,
> >thanks for looking into this
> >
> > On Tue, Sep 04, 2018 at 07:22:50PM +0200, Loic Poulain wrote:
> >>
Hi Sakari,
On Mon, Aug 27, 2018 at 12:29:55PM +0300, Sakari Ailus wrote:
> Use the media bus types instead of the fwnode bus types internally. This
> is the interface to the drivers as well, making the use of the fwnode bus
> types more localised to the V4L2 fwnode framework.
>
So basically now
Hi Sakari,
On Mon, Aug 27, 2018 at 12:29:44PM +0300, Sakari Ailus wrote:
> Instead of allocating the V4L2 fwnode endpoint in
> v4l2_fwnode_endpoint_alloc_parse, let the caller to do this. This allows
> setting default parameters for the endpoint which is a very common need
> for drivers.
>
>
HI Laurent,
On Thu, Sep 06, 2018 at 08:08:50PM +0300, Laurent Pinchart wrote:
> Hello,
>
> On Tuesday, 14 August 2018 18:45:25 EEST jacopo mondi wrote:
> > On Tue, Aug 07, 2018 at 08:53:23AM +, Hugues FRUCHET wrote:
> > > Hi Jacopo,
> > >
> > > In ser
Hello Loic,
On Thu, Sep 06, 2018 at 10:13:53AM +0200, Loic Poulain wrote:
> On 6 September 2018 at 09:48, jacopo mondi wrote:
> > Hello Loic,
> >thanks for looking into this
> >
> > On Tue, Sep 04, 2018 at 07:22:50PM +0200, Loic Poulain wrote:
> >>
Hello Loic,
thanks for looking into this
On Tue, Sep 04, 2018 at 07:22:50PM +0200, Loic Poulain wrote:
> Hi Jacopo,
>
> > - ret = ov5640_mod_reg(sensor, OV5640_REG_MIPI_CTRL00, BIT(5),
> > -on ? 0 : BIT(5));
> > - if (ret)
> > - return ret;
Hi Philipp,
On Fri, Aug 10, 2018 at 05:18:22PM +0200, Philipp Zabel wrote:
> Add a V4L2 mem-to-mem scaler/CSC driver for the Pixel Pipeline (PXP)
> version found on i.MX6ULL SoCs. A similar variant is used on i.MX7D.
>
> Since this driver only uses the legacy pipeline, it should be reasonably
>
Hello Loic,
On Tue, Aug 28, 2018 at 05:08:07PM +0200, Loic Poulain wrote:
> On 15 August 2018 at 12:28, Jacopo Mondi wrote:
> > Hello ov5640 people,
> >this driver has received a lot of attention recently, and this series
> > aims
> > to fix the CSI-2 interface
On Tue, Aug 28, 2018 at 02:57:11PM +0200, jacopo mondi wrote:
> Hi Hugues,
>thanks for the patch
>
> On Thu, Aug 16, 2018 at 11:46:53AM +0200, Hugues Fruchet wrote:
> > fixes: 6949d864776e ("media: ov5640: do not change mode if format or frame
> > interval is
Hi Hugues,
thanks for the patch
On Thu, Aug 16, 2018 at 11:46:53AM +0200, Hugues Fruchet wrote:
> fixes: 6949d864776e ("media: ov5640: do not change mode if format or frame
> interval is unchanged").
>
> Symptom was fuzzy image because of JPEG default format
> not being changed according to
Hi Hugues,
one more comment on this patch..
On Mon, Aug 13, 2018 at 12:19:46PM +0200, Hugues Fruchet wrote:
> Mode setting depends on last mode set, in particular
> because of exposure calculation when downscale mode
> change between subsampling and scaling.
> At stream on the last mode was
Hi Hugues,
On Thu, Aug 16, 2018 at 03:07:54PM +, Hugues FRUCHET wrote:
> Hi Jacopo,
>
> On 08/16/2018 12:10 PM, jacopo mondi wrote:
> > Hi Hugues,
> > thanks for the patch
> >
> > On Mon, Aug 13, 2018 at 12:19:46PM +0200, Hugues Fruchet wrote:
> >
Hi Petr,
On Wed, Aug 15, 2018 at 03:35:39PM +0200, Petr Cvek wrote:
> BTW from the v1 discussion:
>
> Dne 10.8.2018 v 09:32 jacopo mondi napsal(a):
> > When I've been recently doing the same for ov772x and other sensor
> > driver I've been suggested to first copy the driver i
Hi Hugues,
thanks for the patch
On Mon, Aug 13, 2018 at 12:19:46PM +0200, Hugues Fruchet wrote:
> Mode setting depends on last mode set, in particular
> because of exposure calculation when downscale mode
> change between subsampling and scaling.
> At stream on the last mode was wrongly set
From: Jacopo Mondi
As of:
commit 476dec012f4c ("media: ov5640: Add horizontal and vertical totals")
the timings parameters gets programmed separately from the static register
values array.
When changing capture mode, the vertical and horizontal totals gets
From: Jacopo Mondi
Rework the MIPI interface startup sequence with the following changes:
- Remove MIPI bus initialization from the initial settings blob
- At set_power(1) time power up MIPI Tx/Rx and set data and clock lanes in
LP11 during 'sleep' and 'idle' with MIPI clock in non-continuous
removes entries from the blob array instead of adding more.
Jacopo Mondi (2):
media: ov5640: Re-work MIPI startup sequence
media: ov5640: Fix timings setup code
drivers/media/i2c/ov5640.c | 141 +
1 file changed, 92 insertions(+), 49 deletions(-)
--
2.7.4
Hi Steve,
On Tue, Aug 14, 2018 at 04:53:26PM -0700, Steve Longerbeam wrote:
>
>
> On 08/14/2018 10:38 AM, jacopo mondi wrote:
> >Hi Steve,
> >
> >On Tue, Aug 14, 2018 at 09:51:04AM -0700, Steve Longerbeam wrote:
> >>Hi Jacopo,
> >>
> >>
&
Hi Steve,
On Tue, Aug 14, 2018 at 09:51:04AM -0700, Steve Longerbeam wrote:
> Hi Jacopo,
>
>
> On 08/14/2018 08:35 AM, jacopo mondi wrote:
> >Hi Steve,
> >sorry for resurecting this.
> >
> >
> >>>I'm sorry I'm not sur I'm following. Does thi
est my 5 patches serie on your side ?
I did. I re-based the series on top of my MIPI and timings fixes and
it actually solves the exposure issues I didn't know I had :)
I'll comment on v2 as well as soon as I'll get an answer from Steve on
the CSI-2 issue.
Thanks
j
>
> Best regards,
>
Hi Hugues,
I'll reply to your v2 series shortly, but let me point out one
thing before.
+steve
On Tue, Aug 07, 2018 at 08:53:53AM +, Hugues FRUCHET wrote:
> Hi Jacopo,
>
> Thanks for this patch, when testing on my side I don't see special
> regression or enhancement with that fix,
Hi Steve,
sorry for resurecting this.
On Mon, Jul 16, 2018 at 09:26:13AM -0700, Steve Longerbeam wrote:
>
>
> On 07/16/2018 01:29 AM, jacopo mondi wrote:
> >Hi Steve,
> >thanks for keep testing it
> >
> >On Sat, Jul 14, 2018 at 01:02:32PM -0700, Steve Lo
Hi Petr,
On Sun, Aug 12, 2018 at 03:13:39PM +0200, Petr Cvek wrote:
> Dne 10.8.2018 v 09:51 jacopo mondi napsal(a):
> > Hi Petr,
> >
> > On Thu, Aug 09, 2018 at 03:39:48AM +0200, petrcve...@gmail.com wrote:
> >> From: Petr Cvek
> >>
> >> T
Hi Sakari,
thanks for this nice rework
On Mon, Jul 23, 2018 at 04:46:45PM +0300, Sakari Ailus wrote:
> Hello everyone,
>
> I've long thought the V4L2 fwnode framework requires some work (it's buggy
> and it does not adequately serve common needs). This set should address in
> particular these
Hi Petr,
On Thu, Aug 09, 2018 at 03:39:48AM +0200, petrcve...@gmail.com wrote:
> From: Petr Cvek
>
> This patch removes the dependency on an obsoleted soc_camera from ov9640
> driver and changes the code to be a standalone v4l2 async subdevice.
> It also adds GPIO allocations for power and reset
Hi Petr,
thanks for the patches,
On Thu, Aug 09, 2018 at 03:39:45AM +0200, petrcve...@gmail.com wrote:
> From: Petr Cvek
>
> Initial part of ov9640 transition from soc_camera subsystem to a standalone
> v4l2 subdevice.
>
> Signed-off-by: Petr Cvek
> ---
> drivers/media/i2c/{soc_camera =>
the function call by testing for the right symbol.
Fixes: aab7ed1c ("media: i2c: Add driver for Aptina MT9V111")
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/mt9v111.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c
Hi Mauro,
On Sun, Aug 05, 2018 at 10:55:43AM -0300, Mauro Carvalho Chehab wrote:
> Em Sun, 5 Aug 2018 12:09:23 +0200
> jacopo mondi escreveu:
>
> > Hi Hans,
> >
> > On Sun, Aug 05, 2018 at 11:59:33AM +0200, Hans Verkuil wrote:
> > > On 08/05/2018 11:36 AM, jac
'v4l2_subdev_get_try_format';
Fixes: aab7ed1c ("media: i2c: Add driver for Aptina MT9V111")
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 82af974..422c586 100644
---
Hi Hans,
On Sun, Aug 05, 2018 at 11:59:33AM +0200, Hans Verkuil wrote:
> On 08/05/2018 11:36 AM, jacopo mondi wrote:
> > On Sun, Aug 05, 2018 at 01:14:58AM +0800, kbuild test robot wrote:
> >> tree: git://git.ragnatech.se/linux media-tree
> >> head: 12f336c88090f
On Sun, Aug 05, 2018 at 01:14:58AM +0800, kbuild test robot wrote:
> tree: git://git.ragnatech.se/linux media-tree
> head: 12f336c88090fb8004736fd4329184326a49673b
> commit: aab7ed1c392703604fbdc5bd5005dfb61a0b32f9 [273/382] media: i2c: Add
> driver for Aptina MT9V111
> config:
-order the cleanup path to respect the operation inverse
order.
Fixes: aab7ed1c "media: i2c: Add driver for Aptina MT9V111"
Reported-by: Dan Carpenter
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/mt9v111.c | 41 +
1 file changed, 13 inserti
Hi Dan,
thanks for noticing this,
On Tue, Jul 31, 2018 at 09:35:54PM +0300, Dan Carpenter wrote:
> Hello Jacopo Mondi,
>
> The patch aab7ed1c3927: "media: i2c: Add driver for Aptina MT9V111"
> from Jul 25, 2018, leads to the following static checker warning:
>
>
Hi Jasmin,
On Sat, Jul 28, 2018 at 03:54:49PM +0200, Jasmin J. wrote:
> From: Jasmin Jessich
>
> This fixes the "'idx' may be used uninitialized in this function"
> warning.
>
> Cc: Jacopo Mondi
> Signed-off-by: Jasmin Jessich
Thanks for the patch
Acked
Hi Sakari,
On Mon, Jul 30, 2018 at 10:26:27AM +0300, Sakari Ailus wrote:
> While this isn't a bug, initialise the variable to quash the warning.
>
> Reported-by: Stephen Rothwell
> Signed-off-by: Sakari Ailus
> ---
> drivers/media/i2c/mt9v111.c | 2 +-
> 1 file changed, 1 insertion(+), 1
- Move MAINTAINERS modifications to bindings patch
- Fix resolution in bindings document
- Drop dependency on OF
- Drop subdev 'open' function in favour of pad operation init_cfg and use a
default configuration to initialize the sensor
- Turn off power if sensor identification fails
Jacopo Mondi
From: Jacopo Mondi
Add documentation for Aptina MT9V111 image sensor.
Reviewed-by: Rob Herring
Signed-off-by: Jacopo Mondi
---
.../bindings/media/i2c/aptina,mt9v111.txt | 46 ++
MAINTAINERS| 8
2 files changed, 54
From: Jacopo Mondi
Add V4L2 sensor driver for Aptina MT9V111 CMOS image sensor.
The MT9V111 is a 1/4-Inch CMOS image sensor based on MT9V011 with an
integrated Image Flow Processor.
Reviewed-by: Kieran Bingham
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/Kconfig | 11 +
drivers
te that I re-added the 'Add support for STD ioctls
> > on subdev nodes'
> > patch. It really is needed.
> >
> > Regards,
> >
> > Hans
> >
>
> > Jacopo Mondi (9):
> > sh: defconfig: migor: Update defconfig
> > sh: defconf
Hi again,
On Wed, Jul 18, 2018 at 01:19:03PM +0200, Jacopo Mondi wrote:
> As of:
> commit bf4a4b518c20 ("media: ov5640: Don't force the auto exposure state at
> start time") auto-exposure got disabled before programming new capture modes
> to
> the sensor. Unfortunatel
feedback on.
[1/1] has already received several acks on the mailing list, but never a
formal Reviewed-by or Tested-by, while [2/2] is new.
Thanks
j
Jacopo Mondi (2):
media: ov5640: Fix timings setup code
media: ov5640: Fix auto-exposure disabling
drivers/media/i2c/ov5640.c | 75
ode_direct() or ov5640_set_mode_exposure_calc() have been
executed.
Fixes: bf4a4b518c20 ("media: ov5640: Don't force the auto exposure state at
start time")
Signed-off-by: Jacopo Mondi
---
Is it worth doing with auto-gain what we're doing with auto-exposure? Cache the
value and then r
_load_regs() function.
Fixes: 476dec012f4c ("media: ov5640: Add horizontal and vertical totals")
Signed-off-by: Samuel Bobrowicz
Signed-off-by: Maxime Ripard
Signed-off-by: Jacopo Mondi
---
This fix has been circulating around for quite some time now, in Maxime clock
tree patches, in
> >>
> >>Pardon the late reply, see below.
> >>
> >>On 07/11/2018 12:21 AM, jacopo mondi wrote:
> >>>Hi Steve,
> >>>
> >>>On Tue, Jul 10, 2018 at 02:10:54PM -0700, Steve Longerbeam wrote:
> >>>>Hi Jacopo,
>
b
> ycbcr:601 quantization:full-range]
>
> Steve
>
> On 07/10/2018 11:36 AM, Jacopo Mondi wrote:
> >Hello,
> >this series fixes capture operations on i.MX6Q platforms (and possible
> > other
> >platforms reported not working) using MIPI CSI-2 interface.
&g
: f22996db44e2 ("media: ov5640: add support of DVP parallel interface")
Reported-by: Jagan Teki
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov5640.c | 91 --
1 file changed, 71 insertions(+), 20 deletions(-)
diff --git a/drivers/media/i2c/
23 ("media: ov5640: Add horizontal and vertical totals")
Signed-off-by: Samuel Bobrowicz
Signed-off-by: Maxime Ripard
[re-introduce timing parameters in initial configuration blob]
Signed-off-by: Jacopo Mondi
---
Compared to Maxime's and Sam's original version, this one re-introduces
ture works for you too.
Thanks
j
On Tue, Jul 10, 2018 at 09:33:31AM +0200, jacopo mondi wrote:
> Hi Steve,
>thanks for testing!
>
> On Mon, Jul 09, 2018 at 02:52:09PM -0700, Steve Longerbeam wrote:
> > Hi Jacopo,
> >
> > I tested this patch on the i.MX6Q Sabr
testing
platform too. For more details, please refer to the v1 cover letter:
https://www.mail-archive.com/linux-media@vger.kernel.org/msg133352.html
Thanks
j
Jacopo Mondi (1):
media: i2c: ov5640: Re-work MIPI startup sequence
Samuel Bobrowicz (1):
media: ov5640: Fix timings setup code
ck.
Intersting that the module was not starting up properly on other
(all?) i.MX6Q platforms, not only on Engicam's one. I didn't get this
initially.
Ok, so that's a step forward, but not enough probably. I'll keep
looking into this and get back!
Thanks
j
>
> Steve
>
>
> On 07/06/201
From: Jacopo Mondi
Rework the MIPI interface startup sequence with the following changes:
- Remove MIPI bus initialization from the initial settings blob
- At set_power(1) time power up MIPI Tx/Rx and set data and clock lanes in
LP11 during 'sleep' and 'idle' with MIPI clock in non-continuous
for the patches...
Just out of curiosity, have you ever been able to get images in 1280x720
and 1920x1080 mode? I assume so if you're able to switch between two
subsampling modes...
> Steve, do you have more insight to share with us on this code ?
>
> On 07/04/2018 04:38 PM, jacopo mo
Hi Hugues,
On Wed, Jul 04, 2018 at 02:58:41PM +0200, Hugues Fruchet wrote:
> ov5640_set_mode_exposure_calc() is checking binning value but
> binning value read is buggy and binning value set is done
> after calling ov5640_set_mode_exposure_calc(), fix all of this.
The ov5640_binning_on()
Hi Rui,
sorry, I'm a bit late, you're already at v7 and I don't want to
slow down inclusion with a few minor comments.
Please bear with me and see below...
On Tue, Jul 03, 2018 at 03:08:02PM +0100, Rui Miguel Silva wrote:
> Add device tree binding documentation for the OV2680 camera sensor.
>
From: Jacopo Mondi
Now that data and clock lanes start in LP11 no need to issue a start/stop
sequence at power on time to 'coax the lanes in LP11 state'.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov5640.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/media
es in LP00 instead of LP11 prevents the receiver to detect when
to exit from high-speed mode.
Thanks
j
Jacopo Mondi (2):
media: i2c: ov5640: Re-work MIPI start sequence
media: i2c: ov5640: Remove start/stop sequence
drivers/media/i2c/ov5640.c | 40 ++
From: Jacopo Mondi
Change the MIPI CSI-2 interface startup sequence to the following:
Initialization:
0x3019 = 0x70 : Lane1, Lane2 and clock in LP11 when in 'sleep mode'
0x300e = 0x58 : 2 lanes mode, power down TX and RX, MIPI CSI-2 off
0x4800 = 0x20 : Gate clock when not transmitting, LP00
Hi ov5640 people,
I'm happy to finally jump on the bandwagon...
I had a few days to test the sensor driver (on 2 platforms) and unfortunately
this series breaks MIPI capture for me as well..
On Fri, Jun 01, 2018 at 04:05:58PM -0700, Sam Bobrowicz wrote:
> >> On May 21, 2018, at 12:39 AM,
x was already applied to non-soc_camera version of ov772x
> driver in the commit commit a024ee14cd36 ("media: ov772x: correct setting
> of banding filter")
This driver is aimed for removal, but until it's there, as per the
patch you mentioned:
Acked-by: Jacopo Mondi
Thanks
j
&
is initialized with auto-exposure control, auto white balancing and flickering
control disabled.
Tested VGA, QVGA QQVGA resolutions at 5, 10, 15 and 30 frame per second.
Thanks
j
Jacopo Mondi (2):
dt-bindings: media: i2c: Document MT9V111 bindings
media: i2c: Add driver for Aptina MT9V111
Add documentation for Aptina MT9V111 image sensor.
Signed-off-by: Jacopo Mondi
---
.../bindings/media/i2c/aptina,mt9v111.txt | 46 ++
1 file changed, 46 insertions(+)
create mode 100644
Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.txt
diff --git
Add V4L2 sensor driver for Aptina MT9V111 CMOS image sensor.
The MT9V111 is a 1/4-Inch CMOS image sensor based on MT9V011 with an
integrated Image Flow Processor.
Signed-off-by: Jacopo Mondi
---
MAINTAINERS |8 +
drivers/media/i2c/Kconfig | 12 +
drivers/media/i2c
Hi Mauro,
On Mon, Jun 04, 2018 at 10:33:03AM -0300, Mauro Carvalho Chehab wrote:
> Hi all,
[snip]
> 4.1 Physical Attendees
> ==
>
> Tomasz Figa
> Mauro Carvalho Chehab
> Kieran Bingham
> Laurent Pinchart
> Niklas Söderlund
> Zheng, Jian Xu Zheng
>
> Anywone else?
The just parsed endpoint fwnode has to be put after use.
Currently this is done only in error handling path. Fix that by putting node
unconditionally after use.
Fixes: 01b8444828fc ("media: v4l2: i2c: ov7670: Implement OF mbus
configuration")
Signed-off-by: Jacopo Mondi
---
drivers
hard to find this
platforms around and testing would be awesome if somebody happens to have
one of these.
Thanks
j
[1] https://patchwork.linuxtv.org/patch/49318/
https://patchwork.linuxtv.org/patch/49317/
https://patchwork.linuxtv.org/patch/49312/
Jacopo Mondi (5):
media: i2c: Copy
source names, as
commit c2f9b05fd5c1 ("media: arch: sh: ecovec: Use new renesas-ceu camera
driver")
already updated it to the new ceu driver name for all SH7724 boards (possibly
breaking kfr2r09 before this commit).
Compile tested only.
Signed-off-by: Jacopo Mondi <jacopo+rene.
1 - 100 of 537 matches
Mail list logo
