Re: [PATCH 1/4] [media] dvb-frontends/stv0367: initial DDB DVBv5 stats, implement ucblocks

2017-06-21 Thread Antti Palosaari
On 06/20/2017 08:45 PM, Daniel Scheller wrote: From: Daniel Scheller This adds the basics to stv0367ddb_get_frontend() to be able to properly provide signal statistics in DVBv5 format. Also adds UCB readout and provides those values. Signed-off-by: Daniel Scheller

Re: LinuxTV V3 vs. V4 API doc inconsistency, V4 probably wrong

2017-06-21 Thread Thierry Lelegard
Hi Mauro, First of all, there's no Linux DVB API v4. It was skipped, because there was a proposal for a v4, with was never adopted. Alright, whatever, you have understood it was the post-V3 API, S2API, you name it. You should assign it a version number by the way. Thanks for reviewing

[PATCH RESEND 5/7] [media] media: s3c-camif: Use MEDIA_REVISON instead of KERNEL_VERSION

2017-06-21 Thread Johannes Thumshirn
Use MEDIA_REVISON instead of KERNEL_VERSION to encode the driver version. Signed-off-by: Johannes Thumshirn --- drivers/media/platform/s3c-camif/camif-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s3c-camif/camif-core.c

[PATCH RESEND 6/7] [media] media: bcm2048: use MEDIA_REVISION isntead of KERNEL_VERSION

2017-06-21 Thread Johannes Thumshirn
Use MEDIA_REVISION isntead of KERNEL_VERSION to encode the bcm2048 driver version. Signed-off-by: Johannes Thumshirn --- drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH RESEND 3/7] [media] media: document the use of MEDIA_REVISION instead of KERNEL_VERSION

2017-06-21 Thread Johannes Thumshirn
Update the documentation to introduce the use of MEDIA_REVISON instead of KERNEL_VERSION for the verison triplets of a media drivers hardware revision or driver version. Signed-off-by: Johannes Thumshirn --- Documentation/media/uapi/cec/cec-ioc-adap-g-caps.rst| 2 +-

[PATCH RESEND 2/7] video: fbdev: don't use KERNEL_VERSION macro for MEDIA_REVISION

2017-06-21 Thread Johannes Thumshirn
Don't use the KERNEL_VERSION() macro for the v4l2 capabilities, use MEDIA_REVISION instead. Signed-off-by: Johannes Thumshirn --- drivers/video/fbdev/matrox/matroxfb_base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 2/2] media/uapi/v4l: clarify cropcap/crop/selection behavior

2017-06-21 Thread Sakari Ailus
On Mon, Jun 19, 2017 at 03:49:10PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Unfortunately the use of 'type' was inconsistent for multiplanar > buffer types. Starting with 4.14 both the normal and _MPLANE variants > are allowed, thus making it possible to write

[PATCH RESEND 7/7] staging/atomisp: use MEDIA_VERSION instead of KERNEL_VERSION

2017-06-21 Thread Johannes Thumshirn
Use MEDIA_VERSION instead of KERNEL_VERSION to encode the driver version of the Atom ISP driver. Signed-off-by: Johannes Thumshirn --- drivers/staging/media/atomisp/include/linux/atomisp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION abuse in media

2017-06-21 Thread Johannes Thumshirn
Currently the media subsystem has a very creative abuse of the KERNEL_VERSION macro to encode an arbitrary version triplet for media drivers and device hardware revisions. This series introduces a new macro called MEDIA_REVISION which encodes a version triplet like KERNEL_VERSION does, but

Re: [PATCH v2 1/6] [media] s5p-jpeg: Reset the Codec before doing a soft reset

2017-06-21 Thread Andrzej Pietrasiewicz
Hi Thierry, W dniu 12.06.2017 o 19:13, Thierry Escande pisze: From: Abhilash Kesavan This patch resets the encoding and decoding register bits before doing a soft reset. Here are my thoughts after consulting the documentation: Signed-off-by: Tony K Nadackal

[PATCH RESEND 1/7] [media] media: introduce MEDIA_REVISION macro

2017-06-21 Thread Johannes Thumshirn
Currently the media code abuses the KERNEL_VERSION macro to encode a version triplet. Introduce a MEDIA_REVISION macro to get rid of the confusing and creative KERNEL_VERSION usage in the media subsystem. Signed-off-by: Johannes Thumshirn --- include/uapi/linux/media.h | 4

[PATCH RESEND 4/7] [media] cx25821: use MEDIA_REVISION instead of KERNEL_VERSION

2017-06-21 Thread Johannes Thumshirn
Use MEDIA_REVISION instead of KERNEL_VERSION to encode the CX25821_VERSION_CODE. Signed-off-by: Johannes Thumshirn --- drivers/media/pci/cx25821/cx25821.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/cx25821/cx25821.h

Re: [PATCH 3/4] [media] dvb-frontends/stv0367: SNR DVBv5 statistics for DVB-C and T

2017-06-21 Thread Antti Palosaari
On 06/20/2017 08:45 PM, Daniel Scheller wrote: From: Daniel Scheller Add signal-to-noise-ratio as provided by the demodulator in decibel scale. QAM/DVB-C needs some intlog calculation to have usable dB values, OFDM/ DVB-T values from the demod look alright already and are

Re: LinuxTV V3 vs. V4 API doc inconsistency, V4 probably wrong

2017-06-21 Thread Mauro Carvalho Chehab
Em Wed, 21 Jun 2017 09:34:01 +0200 Thierry Lelegard escreveu: > Hi Mauro, > > > First of all, there's no Linux DVB API v4. It was skipped, because > > there > > was a proposal for a v4, with was never adopted. > > Alright, whatever, you have understood it was the

[PATCH v2] [media] dvb uapi docs: enums are passed by value, not reference

2017-06-21 Thread Mauro Carvalho Chehab
Since 2015, the documentation for FE_DISEQC_SEND_BURST, FE_SET_TONE and FE_SET_VOLTAGE are incorrectly saying that the enums are passed by reference. They aren't: they're passed by value. Fix the documentation to reflect reality. Fixes: 81959d996a3b ("[media] DocBook: better document

[ragnatech:media-tree 1869/1907] drivers/media/dvb-frontends/stv0367.c:3127:3-16: duplicated argument to & or | (fwd)

2017-06-21 Thread Julia Lawall
It seems that some of the constants on lines 3127 and on are the same as the ones on lines 3134 and on. julia -- Forwarded message -- Date: Wed, 21 Jun 2017 18:20:03 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall

[PATCH] [media] dvb uapi docs: enums are passed by value, not reference

2017-06-21 Thread Mauro Carvalho Chehab
Since 2015, the documentation for FE_DISEQC_SEND_BURST, FE_SET_TONE and FE_SET_VOLTAGE are incorrectly saying that the enums are passed by reference. They aren't: they're passed by value. Fix the documentation to reflect reality. Fixes: 81959d996a3b ("[media] DocBook: better document

[PATCH v3] [media] dvb uapi docs: enums are passed by value, not reference

2017-06-21 Thread Mauro Carvalho Chehab
Since 2015, the documentation for FE_DISEQC_SEND_BURST, FE_SET_TONE and FE_SET_VOLTAGE are incorrectly saying that the enums are passed by reference. They aren't: they're passed by value. Fix the documentation to reflect reality. Fixes: 81959d996a3b ("[media] DocBook: better document

[PATCH] [media] rainshadow-cec: avoid -Wmaybe-uninitialized warning again

2017-06-21 Thread Arnd Bergmann
Back in April I created a patch to address a false-positive warning: drivers/media/usb/rainshadow-cec/rainshadow-cec.c: In function 'rain_irq_work_handler': drivers/media/usb/rainshadow-cec/rainshadow-cec.c:171:31: error: 'data' may be used uninitialized in this function

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-21 Thread Daniel Scheller
Am Tue, 20 Jun 2017 16:10:43 -0300 schrieb Mauro Carvalho Chehab : > Em Tue, 20 Jun 2017 20:41:21 +0200 > Daniel Scheller escreveu: > > > Not sure about Thomas, but I know that Jasmin doesn't own and/ore uses > > such cards. However, for

OMAP3630 ISP V4L2 Camera Not Streaming to LCD

2017-06-21 Thread Adam Ford
I have a Leopard Imaging LI-5M03 camera attached in 8-bit mode, and I am trying to capture an image on camera and stream it to the LCD (/dev/fb0) without using the DSP or proprietary codecs. I was hoping to do it with either gstreamer (preferrably 1.0) or ffpeg. My board has mainline device

Re: [PATCH 3/4] [media] dvb-frontends/stv0367: SNR DVBv5 statistics for DVB-C and T

2017-06-21 Thread Antti Palosaari
On 06/21/2017 06:50 PM, Daniel Scheller wrote: Am Wed, 21 Jun 2017 09:30:27 +0300 schrieb Antti Palosaari : On 06/20/2017 08:45 PM, Daniel Scheller wrote: From: Daniel Scheller Add signal-to-noise-ratio as provided by the demodulator in decibel scale.

[PATCH v2 0/4] STV0367/DDB DVBv5 signal statistics

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller This series adds DVBv5 statistics support to the new DDB codepath of the stv0367 demodulator driver. The changes utilise already existing functionality (in form of register readouts), but wraps the reads in separate functions so the existing relative

[PATCH v2 2/4] [media] dvb-frontends/stv0367: split SNR determination into functions

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller The read_snr() functions currently do some magic to return relative scale values when called. Split out register readouts into separate functions so the functionality can be reused in some other way. Signed-off-by: Daniel Scheller

[PATCH v2 4/4] [media] dvb-frontends/stv0367: DVB-C signal strength statistics

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller Provide QAM/DVB-C signal strength in decibel scale. Values returned from stv0367cab_get_rf_lvl() are good but need to be multiplied as they're in 1dBm precision. Signed-off-by: Daniel Scheller ---

[PATCH v2 1/4] [media] dvb-frontends/stv0367: initial DDB DVBv5 stats, implement ucblocks

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller This adds the basics to stv0367ddb_read_status() to be able to properly provide signal statistics in DVBv5 format. Also adds UCB readout and provides those values. Also, don't return -EINVAL in ddb_read_status() if active_demod_state indicates no

[PATCH v2 3/4] [media] dvb-frontends/stv0367: SNR DVBv5 statistics for DVB-C and T

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller Add signal-to-noise-ratio as provided by the demodulator in decibel scale. QAM/DVB-C needs some intlog calculation to have usable dB values, OFDM/ DVB-T values from the demod look alright already and are provided as-is. Signed-off-by: Daniel Scheller

[PATCH] [media] dvb-frontends/stv0367: deduplicate DDB dvb_frontend_ops caps

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0367.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/media/dvb-frontends/stv0367.c

Re: [PATCH] [media] ddbridge: use dev_* macros in favor of printk

2017-06-21 Thread Antti Palosaari
On 06/21/2017 08:20 PM, Mauro Carvalho Chehab wrote: Em Wed, 21 Jun 2017 19:14:40 +0200 Daniel Scheller escreveu: Am Wed, 21 Jun 2017 14:08:08 -0300 schrieb Mauro Carvalho Chehab : Em Wed, 21 Jun 2017 18:53:47 +0200 Daniel Scheller

Re: [PATCH v2 0/4] STV0367/DDB DVBv5 signal statistics

2017-06-21 Thread Daniel Scheller
Am Wed, 21 Jun 2017 21:45:40 +0200 schrieb Daniel Scheller : > From: Daniel Scheller > > This series adds DVBv5 statistics support to the new DDB codepath of the > stv0367 demodulator driver. > > The changes utilise already existing functionality

Re: [PATCH] [media] ddbridge: use dev_* macros in favor of printk

2017-06-21 Thread Daniel Scheller
Am Wed, 21 Jun 2017 22:20:35 +0300 schrieb Antti Palosaari : > On 06/21/2017 08:20 PM, Mauro Carvalho Chehab wrote: > > Em Wed, 21 Jun 2017 19:14:40 +0200 > > Daniel Scheller escreveu: > > > >> I intentionally left this in for the pr_info used in > >>

[PATCH] radio: wl1273: add check on core->write() return value

2017-06-21 Thread Gustavo A. R. Silva
Check return value from call to core->write(), so in case of error print error message, jump to goto label fail and eventually return. Addresses-Coverity-ID: 1226943 Signed-off-by: Gustavo A. R. Silva --- drivers/media/radio/radio-wl1273.c | 15 +-- 1 file

Re: [PATCH] radio: wl1273: add check on core->write() return value

2017-06-21 Thread Baruch Siach
Hi Gustavi, On Wed, Jun 21, 2017 at 11:01:22PM -0500, Gustavo A. R. Silva wrote: > Check return value from call to core->write(), so in case of > error print error message, jump to goto label fail and eventually > return. > > Addresses-Coverity-ID: 1226943 > Signed-off-by: Gustavo A. R. Silva

[PATCH] tuners: mxl5005s: remove useless variable assignments

2017-06-21 Thread Gustavo A. R. Silva
Values assigned to variables Fmax and Fmin at lines 2740 and 2741 are overwritten at lines 2754 and 2755 before they can be used. This makes such variable assignments useless. Addresses-Coverity-ID: 1226952 Addresses-Coverity-ID: 1226953 Signed-off-by: Gustavo A. R. Silva

cron job: media_tree daily build: ERRORS

2017-06-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Jun 22 05:01:01 CEST 2017 media-tree git hash:76724b30f222067faf00874dc277f6c99d03d800 media_build

[PATCH] dvb-usb-v2: lmedm04: remove unnecessary variable in lme2510_stream_restart()

2017-06-21 Thread Gustavo A. R. Silva
Remove unnecessary variable _ret_ and refactor the code. Addresses-Coverity-ID: 1226934 Signed-off-by: Gustavo A. R. Silva --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

Re: [PATCH] [media] ddbridge: use dev_* macros in favor of printk

2017-06-21 Thread Mauro Carvalho Chehab
Em Wed, 21 Jun 2017 18:53:47 +0200 Daniel Scheller escreveu: > From: Daniel Scheller > > Side effect: KERN_DEBUG messages aren't written to the kernel log anymore. > This also improves the tda18212_ping reporting a bit so users know that if >

Re: [PATCH] [media] ddbridge: use dev_* macros in favor of printk

2017-06-21 Thread Daniel Scheller
Am Wed, 21 Jun 2017 14:08:08 -0300 schrieb Mauro Carvalho Chehab : > Em Wed, 21 Jun 2017 18:53:47 +0200 > Daniel Scheller escreveu: > > > From: Daniel Scheller > > > > Side effect: KERN_DEBUG messages aren't written to

Re: [PATCH] [media] ddbridge: use dev_* macros in favor of printk

2017-06-21 Thread Mauro Carvalho Chehab
Em Wed, 21 Jun 2017 19:14:40 +0200 Daniel Scheller escreveu: > Am Wed, 21 Jun 2017 14:08:08 -0300 > schrieb Mauro Carvalho Chehab : > > > Em Wed, 21 Jun 2017 18:53:47 +0200 > > Daniel Scheller escreveu: > > > > >

Re: [PATCH 1/4] [media] dvb-frontends/stv0367: initial DDB DVBv5 stats, implement ucblocks

2017-06-21 Thread Daniel Scheller
Am Wed, 21 Jun 2017 09:06:22 +0300 schrieb Antti Palosaari : > On 06/20/2017 08:45 PM, Daniel Scheller wrote: > > From: Daniel Scheller > > > > This adds the basics to stv0367ddb_get_frontend() to be able to properly > > provide signal statistics in DVBv5

[PATCH] [media] ddbridge: use dev_* macros in favor of printk

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller Side effect: KERN_DEBUG messages aren't written to the kernel log anymore. This also improves the tda18212_ping reporting a bit so users know that if pinging wasn't successful, bad things will happen. Since in module_init_ddbridge() there's no dev yet,

Re: [PATCH 3/4] [media] dvb-frontends/stv0367: SNR DVBv5 statistics for DVB-C and T

2017-06-21 Thread Daniel Scheller
Am Wed, 21 Jun 2017 09:30:27 +0300 schrieb Antti Palosaari : > On 06/20/2017 08:45 PM, Daniel Scheller wrote: > > From: Daniel Scheller > > > > Add signal-to-noise-ratio as provided by the demodulator in decibel scale. > > QAM/DVB-C needs some intlog