[PATCH 1/2] media: pci: saa7164: remove unnecessary code

Remove unnecessary variable 'loop'. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/pci/saa7164/saa7164-cmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/pci/saa7164/saa7164-cmd.c b/drivers/media/pci/saa7164/saa7164

[PATCH 2/2] media: pci: saa7164: remove dead code

Remove dead code. The following line of code is never reached: return SAA_OK; Addresses-Coverity-ID: 114283 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/pci/saa7164/saa7164-cmd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/s

[PATCH] au0828: fix unbalanced lock/unlock in au0828_usb_probe

Call mutex_unlock and free dev on failure. Reported-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/usb/au0828/au0828-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/usb/au0828/au08

[PATCH] marvell-ccic: constify i2c_algorithm structure

+const struct i2c_algorithm i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/platform/marvell-ccic/cafe-driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/marvell-ccic/cafe-driver.c b/drivers

[PATCH] s5h1420: constify i2c_algorithm structure

+const struct i2c_algorithm i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/dvb-frontends/s5h1420.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/s5h1420.c b/drivers/media/dvb-frontends/s5h1420.c

[PATCH] saa7146: constify i2c_algorithm structure

+const struct i2c_algorithm i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/common/saa7146/saa7146_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/common/saa7146/saa7146_i2c.c b/drivers/media/common/s

[PATCH] dib9000: constify i2c_algorithm structure

+const struct i2c_algorithm i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/dvb-frontends/dib9000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/dib9000.c b/drivers/media/dvb-frontends/dib

[PATCH] usbvision: constify i2c_algorithm structure

+const struct i2c_algorithm i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/usb/usbvision/usbvision-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/usbvision/usbvision-i2c.c b/drivers/media/usb/usb

[PATCH] dib7000p: constify i2c_algorithm structure

+const struct i2c_algorithm i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/dvb-frontends/dib7000p.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/dib7000p.c b/drivers/media/dvb-frontends/dib7

[PATCH] dvb-ttusb-budget: constify i2c_algorithm structure

+const struct i2c_algorithm i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c b/drivers/med

Re: [PATCH] rcar_fdp1: constify vb2_ops structure

Hi Kieran, Quoting Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>: Hi Gustavo, Thank you for the patch. Absolutely, glad to help. :) On 06/07/17 21:25, Gustavo A. R. Silva wrote: Check for vb2_ops structures that are only stored in the ops field of a vb2_queue str

[PATCH] ddbridge: constify i2c_algorithm structure

+const struct i2c_algorithm i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/pci/ddbridge/ddbridge-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/ddbridge/ddbridge-core.c b/drivers/media/pci/dd

[PATCH] dib8000: constify i2c_algorithm structure

+const struct i2c_algorithm i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/dvb-frontends/dib8000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/dib8000.c b/drivers/media/dvb-frontends/dib8000.c

[PATCH] cx24123: constify i2c_algorithm structure

+const struct i2c_algorithm i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/dvb-frontends/cx24123.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/cx24123.c b/drivers/media/dvb-frontends/cx24123.c

[PATCH] zd1301_demod: constify i2c_algorithm structure

+const struct i2c_algorithm i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/dvb-frontends/zd1301_demod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/zd1301_demod.c b/drivers/media/dvb-fro

[PATCH] ngene: constify i2c_algorithm structure

+const struct i2c_algorithm i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/pci/ngene/ngene-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/ngene/ngene-i2c.c b/drivers/media/pci/ngene/ngene-i2c.c

[PATCH] rcar_fdp1: constify vb2_ops structure

struct vb2_ops i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/platform/rcar_fdp1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/rcar_fdp1.c b/drivers/media/platform/rcar_fdp1.c index 3ee51fc..3245bc4

[PATCH] stm32-dcmi: constify vb2_ops structure

struct vb2_ops i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/platform/stm32/stm32-dcmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c

[PATCH] atmel-isc: constify vb2_ops structure

struct vb2_ops i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/platform/atmel/atmel-isc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c

[PATCH] mediatek: constify vb2_ops structure

struct vb2_ops i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mt

[PATCH] davinci: vpif_display: constify vb2_ops structure

struct vb2_ops i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/platform/davinci/vpif_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/davinci/vpif_display.c b/drivers/media/platform/d

[PATCH] mtk-mdp: constify vb2_ops structure

struct vb2_ops i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c b/drivers/media/platform/mtk-mdp/mtk_mdp

[PATCH] davinci: vpif_capture: constify vb2_ops structure

struct vb2_ops i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/platform/davinci/vpif_capture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/d

[PATCH] pxa_camera: constify vb2_ops structure

struct vb2_ops i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/platform/pxa_camera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/pxa_camera.c b/drivers/media/platform/pxa_camera.c index 3990951..5

[PATCH] dm1105: constify i2c_algorithm structure

+const struct i2c_algorithm i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/pci/dm1105/dm1105.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/dm1105/dm1105.c b/drivers/media/pci/dm1105/dm1105.c index 1

[PATCH] mantis: constify i2c_algorithm structure

+const struct i2c_algorithm i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/pci/mantis/mantis_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/mantis/mantis_i2c.c b/drivers/media/pci/mantis/mantis_i2c.c

Re: [PATCH] ddbridge: constify i2c_algorithm structure

Hi Daniel, On 07/10/2017 10:16 AM, Daniel Scheller wrote: Am Sun, 9 Jul 2017 20:15:36 -0500 schrieb "Gustavo A. R. Silva" <garsi...@embeddedor.com>: Check for i2c_algorithm structures that are only stored in the algo field of an i2c_adapter structure. This field is de

Re: [PATCH] stm32-dcmi: constify vb2_ops structure

On 07/07/2017 09:33 AM, Hugues FRUCHET wrote: Acked-by: Hugues Fruchet <hugues.fruc...@st.com> Thank you, Hugues. On 07/06/2017 10:05 PM, Gustavo A. R. Silva wrote: Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared con

Re: [PATCH] st-delta: constify vb2_ops structures

Thank you, Hugues. On 07/07/2017 09:33 AM, Hugues FRUCHET wrote: Acked-by: Hugues Fruchet <hugues.fruc...@st.com> On 07/06/2017 10:14 PM, Gustavo A. R. Silva wrote: Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared con

[PATCH] s5k5baf: remove unnecessary static in s5k5baf_get_selection()

277335600 256 335898335 drivers/media/i2c/s5k5baf.o Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/i2c/s5k5baf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/s5k5baf.c b/drivers/media/i2c/s5k5baf.c index 9620

[PATCH] st-delta: constify vb2_ops structures

struct vb2_ops i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/platform/sti/delta/delta-v4l2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/sti/delta/delta-v4l2.c b/drivers/media/platform/sti/delta

[PATCH] sir_ir: remove unnecessary static in sir_interrupt()

3400 512890022c4 drivers/media/rc/sir_ir.o Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/rc/sir_ir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/rc/sir_ir.c b/drivers/media/rc/sir_ir.c index 20234ba..be

[PATCH] tuners: remove unnecessary static in simple_dvb_configure()

lename 232573552 768 275776bb9 drivers/media/tuners/tuner-simple.o Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/tuners/tuner-simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/tuners/tuner-simple.c b/d

[PATCH] media: venus: fix duplicated code for different branches

Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1415317 Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- This code was reported by Coverity and it was tested by compilatio

[PATCH] dib0090: fix duplicated code for different branches

Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1226795 Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- This code was tested by compilation only. drivers/media/dvb-fro

Re: [PATCH v2] venus: fix copy/paste error in return_buf_error

On 08/21/2017 04:14 AM, Stanimir Varbanov wrote: Thanks Gustavo! Glad to help. :) On 08/18/2017 07:07 PM, Gustavo A. R. Silva wrote: Call function v4l2_m2m_dst_buf_remove_by_buf() instead of v4l2_m2m_src_buf_remove_by_buf() Addresses-Coverity-ID: 1415317 Cc: Stanimir Varbanov

[PATCH] media: i2c: initialize scalar variables

Initialize scalar variables _pid_ and _ver_ to avoid a possible misbehavior. Addresses-Coverity-ID: 1324239 Addresses-Coverity-ID: 1324240 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/i2c/ov2659.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH] media: usb: au0828: remove dead code

Local variable _ret_ is assigned to a constant value and it is never updated again. Remove this variable and the dead code it guards. Addresses-Coverity-ID: 112968 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/usb/au0828/au0828-video.c | 8 +---

[PATCH] media: platform: coda: remove variable self assignment

Remove variable self assignment. Addresses-Coverity-ID: 1408817 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/platform/coda/coda-common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platfor

Re: [media-pci-cx25821] question about value overwrite

Hi Hans, Quoting Hans Verkuil <hverk...@xs4all.nl>: On 05/19/2017 12:07 AM, Gustavo A. R. Silva wrote: Hello everybody, While looking into Coverity ID 1226903 I ran into the following piece of code at drivers/media/pci/cx25821/cx25821-medusa-video.c:393: 393int medusa_set_videost

[PATCH] radio: wl1273: add check on core->write() return value

Check return value from call to core->write(), so in case of error print error message, jump to goto label fail and eventually return. Addresses-Coverity-ID: 1226943 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/radio/radio-wl1273.c | 15 +-

[PATCH] tuners: mxl5005s: remove useless variable assignments

Values assigned to variables Fmax and Fmin at lines 2740 and 2741 are overwritten at lines 2754 and 2755 before they can be used. This makes such variable assignments useless. Addresses-Coverity-ID: 1226952 Addresses-Coverity-ID: 1226953 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.

[PATCH] dvb-usb-v2: lmedm04: remove unnecessary variable in lme2510_stream_restart()

Remove unnecessary variable _ret_ and refactor the code. Addresses-Coverity-ID: 1226934 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/media/usb/d

[PATCH] i2c: tvp5150: remove useless variable assignment in tvp5150_set_vbi()

Value assigned to variable _type_ at line 678 is overwritten at line 688 before it can be used. This makes such variable assignment useless. Remove this variable assignment and fix some coding style issues. Addresses-Coverity-ID: 1226968 Signed-off-by: Gustavo A. R. Silva <ga

[PATCH] dvb-frontends: mb86a16: remove useless variables in signal_det()

Remove useless variables wait_t and wait_sym and code related. Also, fix some coding style issues. Addresses-Coverity-ID: 1226947 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/dvb-frontends/mb86a16.c | 25 +++-- 1 file changed, 7 inse

[media-dvb-usb-v2] question about value overwrite

art Stream Command*/ + return lme2510_usb_talk(d, stream_on, sizeof(stream_on), rbuff, sizeof(rbuff)); - return ret; } What do you think? I'd really appreciate any comment on this. Thank you! -- Gustavo A. R. Silva

[media-pci-cx25821] question about value overwrite

n status; } What do you think? I'd really appreciate any comment on this. Thank you! -- Gustavo A. R. Silva

Re: [media-dvb-usb-v2] question about value overwrite

Hi Malcolm, Quoting Malcolm Priestley <tvbox...@gmail.com>: Hi On 18/05/17 20:09, Gustavo A. R. Silva wrote: Hello everybody, While looking into Coverity ID 1226934 I ran into the following piece of code at drivers/media/usb/dvb-usb-v2/lmedm04.c:205 205static int lme2510_stream_r

[PATCH] media: platform: s3c-camif: fix arguments position in function call

Hi Sylwester, Here is another patch in case you decide that it is better to apply this one. Thanks -- Gustavo A. R. Silva == Fix the position of the arguments in function call. Addresses-Coverity-ID: 1248800 Addresses-Coverity-ID: 1269141 Signed-off-by: Gustavo A. R. Silva <ga

Re: [PATCH] media: platform: s3c-camif: fix arguments position in function call

Hi Sylwester, Quoting Sylwester Nawrocki <s.nawro...@samsung.com>: On 06/02/2017 05:43 AM, Gustavo A. R. Silva wrote: Hi Sylwester, Here is another patch in case you decide that it is better to apply this one. Thanks, I applied this patch. In future please put any comments only

[media-af9013] question about return value in function af9013_wr_regs()

} and of course, all of its callers also should be refactored accordinly. Otherwise, the value contained in variable _ret_ should be properly returned. I can do the refactoring but first it would be great to hear your opinions on this. I'd really appreciate any comment on this. Thank you! -- Gustavo A. R. Silva

[media-m5602-po1030] question about return value check

data = (height + 3) & 0xff; err = m5602_write_sensor(sd, PO1030_WINDOWHEIGHT_L, , 1); + if (err < 0) + return err; height += 12; width -= 2; What do you think? It would be great to hear your opinions about it. I'd really appreciate any comment on this. Thank you! -- Gustavo A. R. Silva

[PATCH] af9013: add check on af9013_wr_regs() return value

Check return value from call to af9013_wr_regs(), so in case of error print debug message and return. Addresses-Coverity-ID: 1227035 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/dvb-frontends/af9013.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/d

Re: [git:media_tree/master] [media] s3c-camif: fix arguments position in a function call

Hi Sylwester, Quoting Mauro Carvalho Chehab <mche...@s-opensource.com>: This is an automatic generated email to let you know that the following patch were queued: Subject: [media] s3c-camif: fix arguments position in a function call Author: Gustavo A. R. Silva <garsi...@embed

[PATCH] i2c: tc358743: remove useless variable assignment in tc358743_isr

Remove useless variable assignment in function tc358743_isr(). The value stored in variable _intstatus_ at line 1299 is overwritten at line 1302, just before it can be used. Addresses-Coverity-ID: 1397678 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/med

[PATCH] media: platform: s3c-camif: fix function prototype

; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/platform/s3c-camif/camif-regs.c | 2 +- drivers/media/platform/s3c-camif/camif-regs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s3c-camif/camif-regs.c b/driv

Re: [media-s3c-camif] question about arguments position

Hello Sylwester, Quoting Sylwester Nawrocki <sylvester.nawro...@gmail.com>: Hi Gustavo, On 05/04/2017 09:05 PM, Gustavo A. R. Silva wrote: The issue here is that the position of arguments in the call to camif_hw_set_effect() function do not match the order of the parameters:

[media-s3c-camif] question about arguments position

ned int cr, unsigned int cb) My question here is if this is intentional? In case it is not, I will send a patch to fix it. But first it would be great to hear any comment about it. By the way... the same is happening at drivers/media/platform/s3c-camif/camif-capture.c:366 Thank you -- Gustavo A. R. Silva

[PATCH] ov9655: fix potential integer overflow

Add suffix ULL to constant 1 rather than casting the result of the operation in order to avoid a potential integer overflow. This constant is used in a context that expects an expression of type u64. Addresses-Coverity-ID: 1324146 Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.

[PATCH] siano: fix a potential integer overflow

Add suffix ULL to constant 65535 in order to avoid a potential integer overflow. This constant is used in a context that expects an expression of type u64. Addresses-Coverity-ID: 1056806 Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/common/siano/smsdvb-main

Re: [PATCH] media: venus: fix duplicated code for different branches

Hi Stanimir, On 08/18/2017 02:52 AM, Stanimir Varbanov wrote: Hi Gustavo, On 08/18/2017 02:12 AM, Gustavo A. R. Silva wrote: Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1415317 Signed-off

[PATCH v2] venus: fix copy/paste error in return_buf_error

Call function v4l2_m2m_dst_buf_remove_by_buf() instead of v4l2_m2m_src_buf_remove_by_buf() Addresses-Coverity-ID: 1415317 Cc: Stanimir Varbanov <stanimir.varba...@linaro.org> Cc: Hans Verkuil <hverk...@xs4all.nl> Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com>

[PATCH] staging: media: imx: fix inconsistent IS_ERR and PTR_ERR

Fix inconsistent IS_ERR and PTR_ERR in csi_link_validate. The proper pointer to be passed as argument is sensor. This issue was detected with the help of Coccinelle. Reported-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> -

[PATCH] davinci: vpif_capture: add NULL check on devm_kzalloc return value

Check return value from call to devm_kzalloc() in order to prevent a NULL pointer dereference. This issue was detected with the help of Coccinelle. Fixes: 4a5f8ae50b66 ("[media] davinci: vpif_capture: get subdevs from DT when available") Signed-off-by: Gustavo A. R. Si

Re: [PATCH] au0828: fix use-after-free at USB probing

Hi Andrey, I have successfully installed and tested syzkaller with QEMU. Can you please tell me how to reproduce this bug or share with me the full crash report? Also, can you point me out to the PoC file? Much appreciated Thank you! -- Gustavo A. R. Silva Quoting Andrey Konovalov

Re: [PATCH] c8sectpfe: fix potential NULL pointer dereference in c8sectpfe_timer_interrupt

On 11/21/2017 02:22 AM, Patrice CHOTARD wrote: Hi Gustavo On 11/20/2017 03:00 PM, Gustavo A. R. Silva wrote: _channel_ is being dereferenced before it is null checked, hence there is a potential null pointer dereference. Fix this by moving the pointer dereference after _channel_ has been null

Re: [PATCH] au0828: fix use-after-free at USB probing

Hey Andrey, Quoting Andrey Konovalov <andreyk...@google.com>: On Thu, Nov 23, 2017 at 2:31 AM, Gustavo A. R. Silva <garsi...@embeddedor.com> wrote: Hi Andrey, I have successfully installed and tested syzkaller with QEMU. Can you please tell me how to reproduce this bug or s

Re: [PATCH] au0828: fix use-after-free at USB probing

Quoting Andrey Konovalov <andreyk...@google.com>: On Fri, Nov 10, 2017 at 1:21 AM, Gustavo A. R. Silva <garsi...@embeddedor.com> wrote: Hi Andrey, Could you please try this patch? Thank you Hi Gustavo, With your patch I get a different crash. Not sure if it's another bug or

[PATCH] usb: uvc_debugfs: remove unnecessary NULL check before debugfs_remove_recursive

NULL check before freeing functions like debugfs_remove_recursive is not needed. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/usb/uvc/uvc_debugfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 del

[PATCH] c8sectpfe: fix potential NULL pointer dereference in c8sectpfe_timer_interrupt

iH407/10 Linux DVB demux support") Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/driver

[PATCH] au0828: fix use-after-free at USB probing

where _dev_ is also freed. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/usb/au0828/au0828-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers/media/usb/au0828/au0828-core.c index c

[PATCH] usb: dvb-usb-v2: dvb_usb_core: remove redundant code in dvb_usb_fe_sleep

Check on return value and goto instruction is redundant as the code that follows is the goto label err. Addresses-Coverity-ID: 1268783 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/usb/dvb-usb-v2/dvb_usb_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 del

Re: [PATCH] c8sectpfe: fix potential NULL pointer dereference in c8sectpfe_timer_interrupt

Hello, On 11/21/2017 02:22 AM, Patrice CHOTARD wrote: Hi Gustavo On 11/20/2017 03:00 PM, Gustavo A. R. Silva wrote: _channel_ is being dereferenced before it is null checked, hence there is a potential null pointer dereference. Fix this by moving the pointer dereference after _channel_ has

Re: [git:media_tree/master] media: davinci: vpif_capture: add NULL check on devm_kzalloc return value

Quoting Mauro Carvalho Chehab <mche...@s-opensource.com>: This is an automatic generated email to let you know that the following patch were queued: Subject: media: davinci: vpif_capture: add NULL check on devm_kzalloc return value Author: Gustavo A. R. Silva <garsi...@embed

[PATCH] st-hva: hva-h264: use swap macro in hva_h264_encode

Make use of the swap macro and remove unnecessary variable tmp_frame. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/media/platform/sti/hva/hva-h264.c | 5 +

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

Hi Mauro, On 04/26/2018 06:42 PM, Mauro Carvalho Chehab wrote: I noticed you changed the status of this series from rejected to new. Yes. Also, there are other similar issues in media/pci/ Well, the issues will be there everywhere on all media drivers. I marked your patches because I

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

On 05/16/2018 08:14 PM, Gustavo A. R. Silva wrote: On 05/15/2018 02:39 PM, Dan Carpenter wrote: Dan, These are all the Spectre media issues I see smatch is reporting in linux-next-20180515: drivers/media/cec/cec-pin-error-inj.c:170 cec_pin_error_inj_parse_line() warn: potential spectre

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

On 05/15/2018 09:16 AM, Dan Carpenter wrote: I'm curious about how you finally resolved to handle these issues. I noticed Smatch is no longer reporting them. There was no direct fix for it, but maybe this patch has something to do with the smatch error report cleanup: commit

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

On 05/17/2018 07:13 AM, Mauro Carvalho Chehab wrote: Em Thu, 17 May 2018 08:43:24 -0300 Mauro Carvalho Chehab escreveu: On 05/15/2018 02:39 PM, Dan Carpenter wrote: You'd need to rebuild the db (possibly twice but definitely once). How? Here, I just pull

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

On 05/17/2018 01:08 PM, Gustavo A. R. Silva wrote: BTW, Mauro, you sent a patch to fix an spectre v1 issue in this file yesterday: dvb_ca_en50221.c:1480, but it seems there is another instance of the same issue some lines above: diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c b

[media] duplicate code in media drivers

Hi Mauro, I found some duplicate code with the help of Coccinelle and Coverity. Notice that these are not code patches, they only point out the duplicate code in some media drivers: diff -u -p drivers/media/pci/bt8xx/dvb-bt8xx.c /tmp/nothing/media/pci/bt8xx/dvb-bt8xx.c ---

[PATCH] media: si470x: fix potential Spectre variant 1

kernel=152449131114778=2 Cc: sta...@vger.kernel.org Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/radio/si470x/radio-si470x-common.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/radio/si470x/radio-si470x-common.c b/drivers

[PATCH] media: dvb-bt8xx: remove duplicate code

The same code is executed regardless of whether c->frequency < 6 or c->frequency < 73000 is true. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/pci/bt8xx/dvb-bt8xx.c | 4

[PATCH] media: dib0700: add code comment

Add FIXME code comment: /* FIXME: check if it is fe_adap[1] */ It is likely that it should be adap->fe_adap[1].fe in the second clause, but this has never been verified. Suggested-by: Mauro Carvalho Chehab <mche...@kernel.org> Signed-off-by: Gustavo A. R. Silva <gust...@em

Re: [media] duplicate code in media drivers

Mauro, I already sent some patches based on your comments. Thanks! -- Gustavo On 05/21/2018 03:14 PM, Mauro Carvalho Chehab wrote: Em Mon, 21 May 2018 14:39:51 -0500 "Gustavo A. R. Silva" <gust...@embeddedor.com> escreveu: Hi Mauro, I found some duplicate code with the he

[PATCH] au8522: remove duplicate code

-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/dvb-frontends/au8522_decoder.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/media/dvb-frontends/au8522_decoder.c b/drivers/media/dvb-frontends/au8522_decoder.c index 3

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

On 05/15/2018 02:39 PM, Dan Carpenter wrote: Dan, These are all the Spectre media issues I see smatch is reporting in linux-next-20180515: drivers/media/cec/cec-pin-error-inj.c:170 cec_pin_error_inj_parse_line() warn: potential spectre issue 'pin->error_inj_args'

Re: [media] duplicate code in media drivers

On 05/21/2018 03:44 PM, Devin Heitmueller wrote: diff -u -p drivers/media/dvb-frontends/au8522_decoder.c /tmp/nothing/media/dvb-frontends/au8522_decoder.c --- drivers/media/dvb-frontends/au8522_decoder.c +++ /tmp/nothing/media/dvb-frontends/au8522_decoder.c @@ -280,14 +280,9 @@ static void

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

Hi Mauro, On 04/23/2018 02:17 PM, Mauro Carvalho Chehab wrote: Em Mon, 23 Apr 2018 14:11:02 -0500 Thanks, I 'll mark this series as rejected at patchwork.linuxtv.org. Please feel free to resubmit any patch if they represent a real threat, adding a corresponding description about the threat

Re: [PATCH][next] media: ispstat: don't dereference user_cfg before a null check

Hi Sakari, On 04/30/2018 10:15 AM, Sakari Ailus wrote: Isn't there a guarantee that new_buf won't be NULL ? The new_buf pointer comes from the parg variable in video_usercopy(), which should always point to a valid buffer given that the ioctl number specifies a non-zero size. Fair question.

Re: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR

Quoting Arnd Bergmann <a...@arndb.de>: On Wed, Jan 24, 2018 at 1:43 AM, Gustavo A. R. Silva <gust...@embeddedor.com> wrote: Fix inconsistent IS_ERR and PTR_ERR in vdic_get_ipu_resources. The proper pointer to be passed as argument is ch. This issue was detected with the help o

[PATCH 7/8] platform: sh_veu: fix potential integer overflow in sh_veu_colour_offset

ntional integer overflow") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/platform/sh_veu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/sh_veu.c b/drivers/media/platform/sh_veu.c index 976ea0b..e2795d0

[PATCH 5/8] pci: cx88-input: fix potential integer overflow

l integer overflow") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> --- drivers/media/pci/cx88/cx88-input.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/cx88/cx88-input.c b/drivers/media/pci/cx88/cx88-input.c index 4e9953e..096b3

Re: [PATCH 8/8] platform: vivid-cec: fix potential integer overflow in vivid_cec_pin_adap_events

Hi Hans, Quoting Hans Verkuil <hverk...@xs4all.nl>: Hi Gustavo, On 01/30/2018 01:33 AM, Gustavo A. R. Silva wrote: Cast len to const u64 in order to avoid a potential integer overflow. This variable is being used in a context that expects an expression of type const u64. Addresses-Co

[PATCH 1/8] rtl2832: fix potential integer overflow in rtl2832_set_frontend

Cast dev->pdata->clk to u64 in order to avoid a potential integer overflow. This variable is being used in a context that expects an expression of type u64. Addresses-Coverity-ID: 1271223 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedo

[PATCH 8/8] platform: vivid-cec: fix potential integer overflow in vivid_cec_pin_adap_events

Cast len to const u64 in order to avoid a potential integer overflow. This variable is being used in a context that expects an expression of type const u64. Addresses-Coverity-ID: 1454996 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com&

[PATCH 4/8] i2c: ov9650: fix potential integer overflow in __ov965x_set_frame_interval

Cast fi->interval.numerator to u64 in order to avoid a potential integer overflow. This variable is being used in a context that expects an expression of type u64. Addresses-Coverity-ID: 1324146 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva <gust..

[PATCH 3/8] i2c: max2175: fix potential integer overflow in max2175_set_nco_freq

Cast expression (clock_rate - abs_nco_freq) to s64 in order to avoid a potential integer overflow. This variable is being used in a context that expects an expression of type s64. Addresses-Coverity-ID: 1446589 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. S

[PATCH 6/8] rockchip/rga: fix potential integer overflow in rga_buf_map

Cast p to dma_addr_t in order to avoid a potential integer overflow. This variable is being used in a context that expects an expression of type dma_addr_t (u64). Addresses-Coverity-ID: 1458347 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva <gust...@e

[PATCH 0/8] fix potential integer overflows

8, 1271223, 1324146, 1392628, 1392630, 1446589, 1454996, 1458347. Thank you Gustavo A. R. Silva (8): rtl2832: fix potential integer overflow dvb-frontends: ves1820: fix potential integer overflow i2c: max2175: fix potential integer overflow in max2175_set_nco_freq i2c: ov9650: fix potenti

  1   2   >