Re: [PATCH v2.1 2/3] leds: as3645a: Add LED flash class driver

Hi Jacek, Jacek Anaszewski wrote: > Hi Sakari, > > On 08/21/2017 03:53 PM, Sakari Ailus wrote: >> Hi Jacek, >> >> Jacek Anaszewski wrote: >>> Hi Sakari, >>> >>> Thanks for the update. >>> I've noticed that you added node labels to the child device nodes >>> in [0]: >>> >>> "as3645a_flash :

Re: [PATCH v2.1 2/3] leds: as3645a: Add LED flash class driver

Hi Sakari, On 08/21/2017 03:53 PM, Sakari Ailus wrote: > Hi Jacek, > > Jacek Anaszewski wrote: >> Hi Sakari, >> >> Thanks for the update. >> I've noticed that you added node labels to the child device nodes >> in [0]: >> >> "as3645a_flash : flash" and "as3645a_indicator : indicator" > > The

Re: [PATCH v2.1 2/3] leds: as3645a: Add LED flash class driver

Hi Jacek, Jacek Anaszewski wrote: > Hi Sakari, > > Thanks for the update. > I've noticed that you added node labels to the child device nodes > in [0]: > > "as3645a_flash : flash" and "as3645a_indicator : indicator" The phandle references (as3645a_flash and as3645a_indicator) should actually

Re: [PATCH v2.1 2/3] leds: as3645a: Add LED flash class driver

Forgot to add a link to the referenced patch: [0] http://www.spinics.net/lists/devicetree/msg191273.html On 08/20/2017 12:09 PM, Jacek Anaszewski wrote: > Hi Sakari, > > Thanks for the update. > I've noticed that you added node labels to the child device nodes > in [0]: > > "as3645a_flash :

Re: [PATCH v2.1 2/3] leds: as3645a: Add LED flash class driver

Hi Sakari, Thanks for the update. I've noticed that you added node labels to the child device nodes in [0]: "as3645a_flash : flash" and "as3645a_indicator : indicator" I am still seeing problems with this approach: 1) AFAIK these labels are only used for referencing nodes inside dts files

[PATCH v2.1 2/3] leds: as3645a: Add LED flash class driver

From: Sakari Ailus Add a LED flash class driver for the as3654a flash controller. A V4L2 flash driver for it already exists (drivers/media/i2c/as3645a.c), and this driver is based on that. Signed-off-by: Sakari Ailus --- Well. The driver does