Re: [PATCH v2 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

2017-08-28 Thread Pavel Machek
Hi! > Thanks for the review! > > On 08/28/17 13:33, Pavel Machek wrote: > > Hi! > > > >> + > >> +Ranges below noted as [a, b] are closed ranges between a and b, i.e. a > >> +and b are included in the range. > > > > Normally I've seen for closed ranges, (a, b) for open > > ranges. Is

Re: [PATCH v2 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

2017-08-28 Thread Sakari Ailus
Hi Pavel, Thanks for the review! On 08/28/17 13:33, Pavel Machek wrote: > Hi! > >> + >> +Ranges below noted as [a, b] are closed ranges between a and b, i.e. a >> +and b are included in the range. > > Normally I've seen for closed ranges, (a, b) for open > ranges. Is that different in

Re: [PATCH v2 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

2017-08-28 Thread Pavel Machek
Hi! > + > +Ranges below noted as [a, b] are closed ranges between a and b, i.e. a > +and b are included in the range. Normally I've seen for closed ranges, (a, b) for open ranges. Is that different in your country? Otherwise Acked-by: Pavel Machek -- (english)

Re: [PATCH v2 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

2017-08-23 Thread Sakari Ailus
Hi Rob, On Tue, Aug 22, 2017 at 07:28:10PM -0500, Rob Herring wrote: > On Sun, Aug 20, 2017 at 12:24:08AM +0300, Sakari Ailus wrote: > > From: Sakari Ailus > > Commit msg? I'll add: Document DT bindings for analog devices as3645a flash LED controller which also supports

Re: [PATCH v2 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

2017-08-22 Thread Rob Herring
On Sun, Aug 20, 2017 at 12:24:08AM +0300, Sakari Ailus wrote: > From: Sakari Ailus Commit msg? > Signed-off-by: Sakari Ailus Shouldn't author and SoB be the same email? > --- > .../devicetree/bindings/leds/ams,as3645a.txt | 71 >

Re: [PATCH v2 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

2017-08-22 Thread Jacek Anaszewski
Hi Sakari, Thanks for the update. On 08/19/2017 11:24 PM, Sakari Ailus wrote: > From: Sakari Ailus > > Signed-off-by: Sakari Ailus > --- > .../devicetree/bindings/leds/ams,as3645a.txt | 71 > ++ > 1 file changed,