Re: [PATCH v2 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

[Pavel Machek]

Hi!

> Thanks for the review!
> 
> On 08/28/17 13:33, Pavel Machek wrote:
> > Hi!
> > 
> >> +
> >> +Ranges below noted as [a, b] are closed ranges between a and b, i.e. a
> >> +and b are included in the range.
> > 
> > Normally I've seen  for closed ranges, (a, b) for open
> > ranges. Is that different in your country?
> 
> I guess there are different notations. :-) I've seen regular parentheses
> being used for open ranges, too, but not < and >.
> 
> Open range is documented in a related well written Wikipedia article:
> 
> 
> 
> Are there such open ranges in Czechia? For instance, reindeer generally
> roam freely in Finnish Lappland.

:-). Well, we have pigs and roes roaming freely in the woods, but
would not normally call it open range.

> What comes to the patch, I guess "interval" could be a more appropriate
> term to use in this case:
> 
> 
> 
> The patch is in line with the Wikipedia article in notation but not in
> terminology. I'll send a fix.

Ok, that was really nitpicking, thanks!
Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


signature.asc
Description: Digital signature

Re: [PATCH v2 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

[Sakari Ailus]

Hi Pavel,

Thanks for the review!

On 08/28/17 13:33, Pavel Machek wrote:
> Hi!
> 
>> +
>> +Ranges below noted as [a, b] are closed ranges between a and b, i.e. a
>> +and b are included in the range.
> 
> Normally I've seen  for closed ranges, (a, b) for open
> ranges. Is that different in your country?

I guess there are different notations. :-) I've seen regular parentheses
being used for open ranges, too, but not < and >.

Open range is documented in a related well written Wikipedia article:



Are there such open ranges in Czechia? For instance, reindeer generally
roam freely in Finnish Lappland.

What comes to the patch, I guess "interval" could be a more appropriate
term to use in this case:



The patch is in line with the Wikipedia article in notation but not in
terminology. I'll send a fix.

-- 
Regards,

Sakari Ailus
sakari.ai...@linux.intel.com



signature.asc
Description: OpenPGP digital signature

Re: [PATCH v2 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

[Pavel Machek]

Hi!

> +
> +Ranges below noted as [a, b] are closed ranges between a and b, i.e. a
> +and b are included in the range.

Normally I've seen  for closed ranges, (a, b) for open
ranges. Is that different in your country?

Otherwise

Acked-by: Pavel Machek 


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


signature.asc
Description: Digital signature

Re: [PATCH v2 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

[Sakari Ailus]

Hi Rob,

On Tue, Aug 22, 2017 at 07:28:10PM -0500, Rob Herring wrote:
> On Sun, Aug 20, 2017 at 12:24:08AM +0300, Sakari Ailus wrote:
> > From: Sakari Ailus 
> 
> Commit msg?

I'll add:

Document DT bindings for analog devices as3645a flash LED controller which
also supports an indicator LED.

> 
> > Signed-off-by: Sakari Ailus 
> 
> Shouldn't author and SoB be the same email?

I'll change that.

> 
> > ---
> >  .../devicetree/bindings/leds/ams,as3645a.txt   | 71 
> > ++
> >  1 file changed, 71 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/leds/ams,as3645a.txt
> 
> Otherwise,
> 
> Acked-by: Rob Herring 

Thanks!

-- 
Regards,

Sakari Ailus
sakari.ai...@linux.intel.com

Re: [PATCH v2 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

[Rob Herring]

On Sun, Aug 20, 2017 at 12:24:08AM +0300, Sakari Ailus wrote:
> From: Sakari Ailus 

Commit msg?

> Signed-off-by: Sakari Ailus 

Shouldn't author and SoB be the same email?

> ---
>  .../devicetree/bindings/leds/ams,as3645a.txt   | 71 
> ++
>  1 file changed, 71 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/ams,as3645a.txt

Otherwise,

Acked-by: Rob Herring 

Re: [PATCH v2 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

[Jacek Anaszewski]

Hi Sakari,

Thanks for the update.

On 08/19/2017 11:24 PM, Sakari Ailus wrote:
> From: Sakari Ailus 
> 
> Signed-off-by: Sakari Ailus 
> ---
>  .../devicetree/bindings/leds/ams,as3645a.txt   | 71 
> ++
>  1 file changed, 71 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/ams,as3645a.txt
> 
> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt 
> b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> new file mode 100644
> index ..12c5ef26ec73
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> @@ -0,0 +1,71 @@
> +Analog devices AS3645A device tree bindings
> +
> +The AS3645A flash LED controller can drive two LEDs, one high current
> +flash LED and one indicator LED. The high current flash LED can be
> +used in torch mode as well.
> +
> +Ranges below noted as [a, b] are closed ranges between a and b, i.e. a
> +and b are included in the range.
> +
> +Please also see common.txt in the same directory.
> +
> +
> +Required properties
> +===
> +
> +compatible   : Must be "ams,as3645a".
> +reg  : The I2C address of the device. Typically 0x30.
> +
> +
> +Required properties of the "flash" child node
> +=
> +
> +flash-timeout-us: Flash timeout in microseconds. The value must be in
> +   the range [10, 85] and divisible by 5.
> +flash-max-microamp: Maximum flash current in microamperes. Has to be
> + in the range between [20, 50] and
> + divisible by 2.
> +led-max-microamp: Maximum torch (assist) current in microamperes. The
> +   value must be in the range between [2, 16] and
> +   divisible by 2.
> +ams,input-max-microamp: Maximum flash controller input current. The
> + value must be in the range [125, 200]
> + and divisible by 5.
> +
> +
> +Optional properties of the "flash" child node
> +=
> +
> +label: The label of the flash LED.
> +
> +
> +Required properties of the "indicator" child node
> +=
> +
> +led-max-microamp: Maximum indicator current. The allowed values are
> +   2500, 5000, 7500 and 1.
> +
> +Optional properties of the "indicator" child node
> +=
> +
> +label: The label of the indicator LED.
> +
> +
> +Example
> +===
> +
> + as3645a@30 {
> + reg = <0x30>;
> + compatible = "ams,as3645a";
> + flash {
> + flash-timeout-us = <15>;
> + flash-max-microamp = <32>;
> + led-max-microamp = <6>;
> + ams,input-max-microamp = <175>;
> + label = "as3645a:flash";
> + };
> + indicator {
> + led-max-microamp = <1>;
> + label = "as3645a:indicator";
> + };
> + };
> 

For the patch going through media tree:

Acked-by: Jacek Anaszewski 

-- 
Best regards,
Jacek Anaszewski