Re: [PATCH 14/17] dt: Consolidate __dtb_start declarations in linux/of_fdt.h

2013-11-19 Thread James Hogan
. This requires adding a few address of operators on architectures where __dtb_start was an array before. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Cc: Vineet Gupta vgu...@synopsys.com Cc: James Hogan james.ho...@imgtec.com Cc: Ralf Baechle r...@linux-mips.org Cc: Jonas Bonn jo

Re: [Consult] About tool chains of metag

2013-12-04 Thread James Hogan
Hi Chen, On 04/12/13 05:45, Chen Gang wrote: Could you provide any related information about metag tool chains? I plan to cross compile metag with allmodconfig, but now it seems not quite easy to find related gcc (binutils-2.23.2 support metag, but gcc main line does not). A buildroot tree

Re: [Consult] About tool chains of metag

2013-12-04 Thread James Hogan
On 04/12/13 12:02, James Hogan wrote: On 04/12/13 05:45, Chen Gang wrote: Could you provide any related information about metag tool chains? I plan to cross compile metag with allmodconfig, but now it seems not quite easy to find related gcc (binutils-2.23.2 support metag, but gcc main line

Re: [RFC PATCH v3 10/19] smp, metag: kill SMP single function call interrupt

2013-12-04 Thread James Hogan
...@goodmis.org Cc: Jiri Kosina triv...@kernel.org Cc: James Hogan james.ho...@imgtec.com Signed-off-by: Jiang Liu liu...@gmail.com Acked-by: James Hogan james.ho...@imgtec.com Do you want me to take this patch through the metag tree for v3.14 or let it go via another tree with the other patches

Re: [Consult] About tool chains of metag

2013-12-05 Thread James Hogan
On 05/12/13 08:46, Chen Gang wrote: On 12/05/2013 09:57 AM, Chen Gang wrote: I will/should try my best to let it pass allmodconfig, and I guess https://lkml.kernel.org/r/201211161520.03974.a...@arndb.de is valuable to me, and I will/should reference it. Oh, excuse me, I can not access

Re: [Consult] About tool chains of metag

2013-12-08 Thread James Hogan
On Sunday 08 December 2013 18:25:30 Chen Gang wrote: Assembler messages: Error: unrecognized option -minim make[2]: *** [crtbegin.o] Error 1 make[2]: *** Waiting for unfinished jobs Did you use meta2_defconfig in buildroot as I suggested? It has --enable-meta-default in

Re: [PATCH] arch: metag: lib: add umoddi3.S file for __umoddi3()

2013-12-20 Thread James Hogan
On 20/12/13 10:20, Chen Gang wrote: Hmm... but do you know why we need some 64-bit functions which are implemented under arch/metag/lib/*.S? can we use linux/math64.h instead of them? (e.g 64-bit '/'). If you look at linux/math64.h you'll see it only implements division operations. The other

Re: [Suggest] arch: metag: compiler: Are they compiler's issues?

2014-01-10 Thread James Hogan
On 10/01/14 15:57, Chen Gang wrote: On 01/08/2014 11:01 PM, Chen Gang wrote: On 01/06/2014 06:31 PM, James Hogan wrote: I suspect this is due to bad assumptions in the code. The metag ABI is unusual in padding the size of structs to a 32bit boundary even if all members are 32bit

[GIT PULL] Metag architecture changes for v3.14

2014-01-20 Thread James Hogan
single function call IPI. Chen Gang (1): metag: topology: export 'cpu_core_map' Geert Uytterhoeven (1): metag/smp: Make boot_secondary() static James Hogan (2): metag: dma: remove dead code in dma_alloc_init

Re: [patch 06/26] metag: Use irq_set_affinity instead of homebrewn code

2014-02-24 Thread James Hogan
Gleixner t...@linutronix.de Cc: James Hogan james.ho...@imgtec.com Cc: metag linux-metag@vger.kernel.org --- arch/metag/kernel/irq.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) Index: tip/arch/metag/kernel/irq.c

Re: remove _STK_LIM_MAX override

2014-04-28 Thread James Hogan
On 28 April 2014 20:21, Helge Deller del...@gmx.de wrote: Dear metag people, on the parisc arch we found a problem with GNU make, that our process stacks became too big so that many debian packages didn't built because not enough threads (started via GNU make) could be created. The final

Re: [PATCH] parisc,metag: Do not hardcode maximum userspace stack size

2014-05-01 Thread James Hogan
/exec.c:589/shift_arg_pages()! Signed-off-by: Helge Deller del...@gmx.de Signed-off-by: James Hogan james.ho...@imgtec.com Cc: linux-par...@vger.kernel.org Cc: linux-metag@vger.kernel.org Cc: John David Anglin dave.ang...@bell.net Cc: sta...@vger.kernel.org --- v2 (James Hogan): - updated

Re: remove _STK_LIM_MAX override

2014-05-01 Thread James Hogan
On 28/04/14 20:21, Helge Deller wrote: Dear metag people, on the parisc arch we found a problem with GNU make, that our process stacks became too big so that many debian packages didn't built because not enough threads (started via GNU make) could be created. The final solution was to

Re: [PATCH] vfs: workaround gcc 4.6 build error in link_path_walk()

2014-09-17 Thread James Hogan
On 16/09/14 18:39, Al Viro wrote: On Tue, Sep 16, 2014 at 01:07:35PM +0100, James Hogan wrote: Commit d6bb3e9075bb (vfs: simplify and shrink stack frame of link_path_walk()) introduced build problems with GCC versions older than 4.6 due to the initialisation of a member of an anonymous union

[PATCH 15/15] metag: tz1090: add TZ1090 clocks to device tree

2014-11-19 Thread James Hogan
to Linux. These are represented with placeholder clocks. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Ian Campbell ijc+devicet

[PATCH 12/15] clk: tz1090: add PDC clock driver

2014-11-19 Thread James Hogan
lock when changing the parent. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: linux-metag@vger.kernel.org --- drivers/clk/tz1090/Makefile | 1 + drivers/clk/tz1090/clk-tz1090-pdc.c | 185 2 files changed

[PATCH 07/15] dt: binding: add binding for TZ1090 mux bank

2014-11-19 Thread James Hogan
set bit. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Ian Campbell ijc+devicet...@hellion.org.uk Cc: Kumar Gala ga...@codeaurora.org Cc: linux

[PATCH 10/15] clk: tz1090: add deleter clock driver

2014-11-19 Thread James Hogan
Add driver for TZ1090 clock deleter, which deletes up to 1023 out of every 1024 clock pulses. Two of these exist, one for the Meta core and the other for the system clock. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: linux-metag@vger.kernel.org

[PATCH 05/15] dt: binding: add binding for TZ1090 gate bank

2014-11-19 Thread James Hogan
of set bits in the bit-mask, and the clocks and clock-output-names arrays list the clocks/names from the least significant set bit in the mask to the most significant set bit. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: Rob Herring robh...@kernel.org Cc

[PATCH 04/15] clk: tz1090: add PLL clock driver

2014-11-19 Thread James Hogan
, but the arrangement of the fields in the registers is I believe specific to the TZ1090 SoC. The driver supports recalc_rate, round_rate, and set_rate operations. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: linux-metag@vger.kernel.org --- drivers/clk

[PATCH 02/15] clk: divider: expose new clk_register_divider_mask

2014-11-19 Thread James Hogan
Expose a new function clk_register_divider_mask to set up a mask based divider. This will be used by the upcoming TZ1090 divider driver whose DT binding takes a mask rather than a shift and width. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org

[PATCH 01/15] clk: divider: replace bitfield width with mask

2014-11-19 Thread James Hogan
. Signed-off-by: Mike Turquette mturque...@linaro.org [james.ho...@imgtec.com: forward port, fix new uses of width] Signed-off-by: James Hogan james.ho...@imgtec.com Tested-by: Shawn Guo shawn@linaro.org Tested-by: Heiko Stuebner he...@sntech.de Reviewed-by: Heiko Stuebner he...@sntech.de Cc

[PATCH 03/15] dt: binding: add binding for tz1090-pll clock

2014-11-19 Thread James Hogan
Add simple device tree binding for TZ1090 PLL clock. It takes a couple of registers, and has a single reference clock source. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark

Re: [PATCH 01/15] clk: divider: replace bitfield width with mask

2014-11-20 Thread James Hogan
On 20/11/14 11:19, Tero Kristo wrote: On 11/20/2014 01:15 AM, James Hogan wrote: - Updated assignment of clk_divider::width in imx, rockchip, st, sunxi, ti clock components to use mask instead (not tested), using the following semantic patch: Hi James/Mike, This patch currently

Re: [PATCH 15/15] metag: tz1090: add TZ1090 clocks to device tree

2014-11-21 Thread James Hogan
there. Am Mittwoch, 19. November 2014, 23:15:43 schrieb James Hogan: Enable the common clock framework for the TZ1090 SoC, add a tz1090_clk device tree file describing the clocks, and connect the Meta core clock so that the rate of the Meta timer can be determined. Most of the clock tree

Re: [PATCH 15/15] metag: tz1090: add TZ1090 clocks to device tree

2014-11-25 Thread James Hogan
On 24/11/14 23:03, Heiko Stübner wrote: Am Freitag, 21. November 2014, 10:06:47 schrieb James Hogan: On Thu, Nov 20, 2014 at 01:56:24PM +0100, Heiko Stübner wrote: I don't know enough about your clock structure, but it looks quite a bit like Mike's mail from May [0] may apply here too

[PATCH v2 00/16] tz1090: add clock components

2014-12-01 Thread James Hogan
...@arm.com Cc: Pawel Moll pawel.m...@arm.com Cc: Rob Herring robh...@kernel.org Cc: Heiko Stuebner he...@sntech.de Cc: linux-metag@vger.kernel.org Cc: devicet...@vger.kernel.org James Hogan (16): clk: tz1090: add clock provider common code clk: tz1090: add gate bank clock driver clk: tz1090: add mux

[PATCH v2 15/16] metag: tz1090: add TZ1090 clocks to device tree

2014-12-01 Thread James Hogan
infrastructure) - hep_cru (img,tz1090-hep-cru, high end peripheral clocks) - perip_cru (img,tz1090-perip-cru, system clock to peripherals) Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com

[PATCH v2 16/16] metag: tz1090: connect Meta core clock

2014-12-01 Thread James Hogan
Connect the Meta core clock to the root DT node so that the precise rate of the Meta timer can be determined. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl

[PATCH v2 12/16] clk: tz1090: add HEP clock provider driver

2014-12-01 Thread James Hogan
The TZ1090 High End Peripheral (HEP) register region controls several clocks for the HEP peripherals. The set up is pretty straight forward, with only a clock gate bank (HEP_CLK_EN) needing to be configured. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque

[PATCH v2 11/16] dt: binding: add binding for TZ1090 HEP clocks

2014-12-01 Thread James Hogan
clocks, and the DDR enable clock which is fed back into the TOP clocks for dividing down. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Ian

[PATCH v2 13/16] dt: binding: add binding for TZ1090 PERIP clocks

2014-12-01 Thread James Hogan
clock, and multiple peripheral specific system clocks provided which should be referenced by the relevant peripheral device nodes. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark

[PATCH v2 10/16] clk: tz1090: add TOP clock provider driver

2014-12-01 Thread James Hogan
frequency system clock can be used as a source rather than the main external oscillator, in order to get a more accurate baud rate. - The main system clock divider which is flagged with CLK_DIVIDER_READ_ONLY to prevent the system clock being altered. Signed-off-by: James Hogan james.ho...@imgtec.com Cc

[PATCH v2 14/16] clk: tz1090: add PERIP clock provider driver

2014-12-01 Thread James Hogan
-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: linux-metag@vger.kernel.org --- Changes since v1 (patch 15): - New patch. - Convert explicit DT representation of clock infrastructure using generic bindings to several TZ1090 specific bindings representing

[PATCH v2 08/16] clk: tz1090: add PDC clock provider driver

2014-12-01 Thread James Hogan
to use the Meta exclusive lock when reconfiguring. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: linux-metag@vger.kernel.org --- Changes since v1 (patch 12): - Split out wrapped (meta exclusive locked) divider into patch 5. - Switch to using common

[PATCH v2 06/16] clk: tz1090: add PLL clock driver

2014-12-01 Thread James Hogan
in tz1090/clk.h to aid the creation of this data. For example: static const struct tz1090_clk_pll plls[] __initconst = { PLL(CLK_TOP_SYSPLL, sys_sw, sys_pll, TOP_SYSPLL_CTL0), ... }; ... tz1090_clk_register_plls(p, plls, ARRAY_SIZE(plls)); Signed-off-by: James Hogan james.ho

[PATCH v2 07/16] dt: binding: add binding for TZ1090 PDC clocks

2014-12-01 Thread James Hogan
file in dt-bindings/clock/ for enumerating the provided clocks. It essentially has just two clock inputs (xtal1 and xtal3), and two clock outputs, of which only 32khz is likely to be used. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: Rob Herring robh

[PATCH v2 05/16] clk: tz1090: add divider clock driver

2014-12-01 Thread James Hogan
(CLK_PDC_XTAL1_DIV, @xtal1, xtal1_div, PDC_SOC0, 11, 16), ... }; ... tz1090_clk_register_dividers(p, dividers, ARRAY_SIZE(dividers)); Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: linux-metag@vger.kernel.org --- Changes since v1

[PATCH v2 04/16] clk: tz1090: add deleter clock driver

2014-12-01 Thread James Hogan
), ... }; ... tz1090_clk_register_deleters(p, deleters, ARRAY_SIZE(deleters)); Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: linux-metag@vger.kernel.org --- Changes since v1 (patch 10): - Renamed function prefixes from clk_tz1090_ to tz1090_clk_ for consistency with the rest. - Drop DT

[PATCH v2 02/16] clk: tz1090: add gate bank clock driver

2014-12-01 Thread James Hogan
(tz1090_perip_clken, 0, PERIP_CLKEN, /* bit in out */ GATE( 0, @sys, sys_scb0) GATE( 1, @sys, sys_scb1) GATE( 2, @sys, sys_scb2) ... ); ... clk_register_gate_bank(p, tz1090_perip_clken); Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque

[PATCH v2 03/16] clk: tz1090: add mux bank clock driver

2014-12-01 Thread James Hogan
, tz1090_top_clkswitch); Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: linux-metag@vger.kernel.org --- Changes since v1 (patch 8): - Renamed function prefixes from clk_tz1090_ to tz1090_clk_ for consistency with the rest. - Drop DT binding

[PATCH v2 01/16] clk: tz1090: add clock provider common code

2014-12-01 Thread James Hogan
with '@' are used directly as the parent clock name. This is intended for other clocks within the clock provider. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mike Turquette mturque...@linaro.org Cc: linux-metag@vger.kernel.org --- New patch in v2 --- drivers/clk/Makefile| 1 + drivers

Re: linux-next: Tree for Dec 16

2014-12-16 Thread James Hogan
On 16/12/14 06:55, Guenter Roeck wrote: On 12/15/2014 10:44 PM, Andrew Morton wrote: On Mon, 15 Dec 2014 22:35:49 -0800 Guenter Roeck li...@roeck-us.net wrote: On Tue, Dec 16, 2014 at 03:46:22PM +1100, Stephen Rothwell wrote: Hi all, Please do not add any code destined for v3.20 to your

Re: [PATCH 2/2] gpio: tz1090-pdc: Use resource_size to fix off-by-one resource size calculation

2015-01-02 Thread James Hogan
On 28/12/14 06:01, Axel Lin wrote: Signed-off-by: Axel Lin axel@ingics.com Thanks, both patches Acked-by: James Hogan james.ho...@imgtec.com Note that the previous off-by-one behaviour should be harmless since the SoC IO memory region is unmapped on Meta (i.e. the ioremap becomes a no-op

Re: [PATCH repost 09/16] metag/uaccess: fix sparse errors

2015-01-02 Thread James Hogan
; \ same here (this one causes a checkpatch error due to 80 column limit) __gu_err; \ }) With those changes, Acked-by: James Hogan james.ho...@imgtec.com Cheers James signature.asc Description: OpenPGP

Re: [PATCH v2 09/40] metag/uaccess: fix sparse errors

2015-01-07 Thread James Hogan
) = (__force __typeof__(*(ptr)))__gu_val; \ same here (this one causes checkpatch error due to 80 column limit). __gu_err; \ }) With those changes, Acked-by: James Hogan james.ho...@imgtec.com Cheers

Re: [PATCH v2 00/16] tz1090: add clock components

2015-01-09 Thread James Hogan
Hi, On 01/12/14 23:19, James Hogan wrote: This patchset adds common clock framework support for the TZ1090 SoC. Any further comments on these patches? It'd be nice to be able to get them into v3.20 if possible. Cheers James Patch 1 adds common code to simplify TZ1090 clock providers

Re: [PATCHv2 16/32] metag: copy_thread(): rename 'arg' argument to 'kthread_arg'

2015-03-16 Thread James Hogan
Hi Alex, On 16/03/15 13:13, Alex Dowad wrote: The 'arg' argument to copy_thread() is only ever used when forking a new kernel thread. Hence, rename it to 'kthread_arg' for clarity. Signed-off-by: Alex Dowad alexinbeij...@gmail.com --- James Hogan, Thanks for reviewing this patch

Re: [PATCHv3 16/32] metag: copy_thread(): rename 'arg' argument to 'kthread_arg'

2015-03-16 Thread James Hogan
On 16/03/15 14:38, Alex Dowad wrote: The 'arg' argument to copy_thread() is only ever used when forking a new kernel thread. Hence, rename it to 'kthread_arg' for clarity. Signed-off-by: Alex Dowad alexinbeij...@gmail.com --- Fixed problem with whitespace, sending again. AD

Another metag architecture fix for v4.0

2015-03-24 Thread James Hogan
problem when using ioremap_wc() from asm/io.h without also including asm/pgtable.h. James Hogan (1): metag: Fix ioremap_wc/ioremap_cached build errors arch/metag/include/asm/io.h | 1 + arch/metag/include/asm/pgtable

Re: [PATCH -next] metag: Fix ioremap_wc/ioremap_cached build errors

2015-03-24 Thread James Hogan
On 23/03/15 21:02, Stephen Rothwell wrote: Hi Greg, On Mon, 23 Mar 2015 20:54:01 +0100 Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Mar 23, 2015 at 12:26:15PM +, James Hogan wrote: When ioremap_wc() or ioremap_cached() are used without first including asm/pgtable.h

[PATCH -next] metag: Fix ioremap_wc/ioremap_cached build errors

2015-03-23 Thread James Hogan
), and include that in io.h instead. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: linux-metag@vger.kernel.org Cc: Abhilash Kesavan a.kesa...@samsung.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- GregKH: I can apply this patch to the metag tree for 4.0. However commit

[GIT PULL] metag architectures fixes for v4.0

2015-03-02 Thread James Hogan
. James Hogan (1): metag: Fix KSTK_EIP() and KSTK_ESP() macros arch/metag/include/asm/processor.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) signature.asc Description: OpenPGP digital signature

[PATCH 1/2] metag: SMP: Fix 4KiB stack setup on secondary CPUs

2015-10-29 Thread James Hogan
in a crash when SMP is configured with 4KiB stacks, as soon as the first interrupt arrived on a secondary CPU. Fix with calls to irq_ctx_exit()/irq_ctx_exit() when bringing up/down a CPU. Signed-off-by: James Hogan <james.ho...@imgtec.com> Cc: linux-metag@vger.kernel.org --- arch/metag/

[PATCH 0/2] metag: 4KB stacks + SMP fix + tweak

2015-10-29 Thread James Hogan
state, and the second is just a small clean up to avoid bit rot. James Hogan (2): metag: SMP: Fix 4KiB stack setup on secondary CPUs metag: Turn irq_ctx_* macros into static inlines arch/metag/include/asm/irq.h | 8 ++-- arch/metag/kernel/smp.c | 2 ++ 2 files changed, 8 insertions(+), 2

[PATCH] MAINTAINERS: Change Meta arch port status to Odd Fixes

2015-11-09 Thread James Hogan
reality. Signed-off-by: James Hogan <james.ho...@imgtec.com> Cc: linux-metag@vger.kernel.org --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7ba7ab749c85..dc5de44fb50d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6846,7 +

METALinux 3.2 (v3.10) in metag-legacy.git

2015-11-12 Thread James Hogan
FYI, for reference I've created a new metag-legacy.git repository containing the final official release of MetaLinux, from July 2013: https://git.kernel.org/cgit/linux/kernel/git/jhogan/metag-legacy.git/ It's based on v3.10 and adds a few more arch features, fuller support for various Meta SoCs

[GIT] Metag architecture changes for v4.4

2015-11-10 Thread James Hogan
with SMP, and a change of maintenance status to "Odd Fixes". -------- James Hogan (3): metag: SMP: Fix 4KiB stack setup on secondary CPUs metag: Turn irq_ctx_* macros into static inlines MAINTAINERS: Change Meta

Re: [PATCH v2 1/3] mm, printk: introduce new format string for flags

2015-12-10 Thread James Hogan
0578a28 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -7,8 +7,8 @@ > > #include > #include > -#include > #ifndef __GENERATING_BOUNDS_H > +#include > #include > #include > #endif /* !__GENERATING_BOUNDS_H */ Same build

Re: [PATCH v2 20/32] metag: define __smp_xxx

2016-01-04 Thread James Hogan
its already inconsistent tabs/spaces, but it'd be nice if the definitions at least still all lined up. You're touching all the definitions which use spaces anyway, so feel free to convert them to tabs while you're at it. Other than those niggles, it looks sensible to me: Acked-by: James Hogan <j

Re: [PATCH v2 20/32] metag: define __smp_xxx

2016-01-04 Thread James Hogan
Hi Peter, On Mon, Jan 04, 2016 at 02:41:28PM +0100, Peter Zijlstra wrote: > On Thu, Dec 31, 2015 at 09:08:22PM +0200, Michael S. Tsirkin wrote: > > +#ifdef CONFIG_SMP > > +#define fence() metag_fence() > > +#else > > +#define fence()do { } while (0) > > #endif > > James, it strikes

Re: [PATCH v2 20/32] metag: define __smp_xxx

2016-01-04 Thread James Hogan
On Mon, Jan 04, 2016 at 04:30:36PM +0100, Peter Zijlstra wrote: > On Mon, Jan 04, 2016 at 03:25:58PM +0000, James Hogan wrote: > > It is used along with the metag specific __global_lock1() (global > > voluntary lock between hw threads) whenever a write is performed, and by >