Re: [PATCH] mmc: agressive clocking framework v9

2010-11-06 Thread Ohad Ben-Cohen
Hi Phillip, On Sat, Nov 6, 2010 at 1:38 AM, Philip Rakity prak...@marvell.com wrote: d) keep sdio clock gating OFF -- need this from our experience. I'm really interested to hear more about that one - what issues did you see ? Can you please elaborate ? Thanks, Ohad. -- To unsubscribe from

Re: [PATCH] mmc: agressive clocking framework v9

2010-11-06 Thread Philip Rakity
We need a way to specify a) Hardware can support clock gating setting the clock to 0 in the call to set_ios (with hardware clock gating enabled) becomes a no-op so some care is needed which is why I suggested another field in the ios structure. When clock gating is enabled with SDIO cards we

Re: MMC runtime PM patches break libertas probe

2010-11-06 Thread Daniel Drake
On 1 November 2010 08:27, Ohad Ben-Cohen o...@wizery.com wrote: On such boards, the right thing to do would be to disable runtime PM altogether. The patch below (/attached) should trivially fix the problem - can you please check it out ? Thanks. It solves the problem. But, what you point

Re: [PATCH] mmc: agressive clocking framework v9

2010-11-06 Thread Nicolas Pitre
On Sat, 6 Nov 2010, Philip Rakity wrote: We need a way to specify a) Hardware can support clock gating setting the clock to 0 in the call to set_ios (with hardware clock gating enabled) becomes a no-op so some care is needed which is why I suggested another field in the ios structure.

Re: MMC runtime PM patches break libertas probe

2010-11-06 Thread Nicolas Pitre
On Sat, 6 Nov 2010, Daniel Drake wrote: On 1 November 2010 08:27, Ohad Ben-Cohen o...@wizery.com wrote: On such boards, the right thing to do would be to disable runtime PM altogether. The patch below (/attached) should trivially fix the problem - can you please check it out ?