Hi Daniel,
OK so we can't do much anything at mwifiex probe time on SDIO bus
because it won't probe unless the pins are configured.
Maybe we should have a separate mwifiex-power helper module that just
manages the reset/idle/regulator pins? Then mwifiex-reset can be
always loaded and
Hi James,
On Mon, Jun 30, 2014 at 11:44:29PM -0700, Bing Zhao wrote:
I may have missed something, but doesn't the MMC_POWER_OFF and
MMC_POWER_ON|UP handling in controller driver help?
Anyway the clocks/GPIOs/regulators are sort of platform dependent.
Would it be better putting
on a dw_mmc controller (Samsung Chromebook)
with MMC_CAP_SDIO_IRQ disabled.
Could you please review this patch?
Thanks,
Bing
Reviewed-by: Paul Stewart ps...@chromium.org
Reviewed-by: Doug Anderson diand...@chromium.org
Signed-off-by: Bing Zhao bz...@marvell.com
Acked-by: Ulf Hansson ulf.hans
Hi Ulf,
Thanks for your comments.
@@ -89,3 +99,14 @@ void mmc_fixup_device(struct mmc_card *card, const
struct mmc_fixup *table)
}
}
EXPORT_SYMBOL(mmc_fixup_device);
+
+void mmc_fixup_broken_irq_polling(struct mmc_card *card)
+{
+ unsigned char dummy;
+
+
(Samsung Chromebook)
with MMC_CAP_SDIO_IRQ disabled.
Reviewed-by: Paul Stewart ps...@chromium.org
Reviewed-by: Doug Anderson diand...@chromium.org
Signed-off-by: Bing Zhao bz...@marvell.com
---
v2: remove mmc_fixup_broken_irq_polling() and add inline
mmc_card_broken_irq_polling(). (Ulf Hansson
Hi Ulf,
diff --git a/drivers/mmc/core/quirks.c b/drivers/mmc/core/quirks.c
index 06ee1ae..02c94b5 100644
--- a/drivers/mmc/core/quirks.c
+++ b/drivers/mmc/core/quirks.c
@@ -13,6 +13,9 @@
#include linux/kernel.h
#include linux/export.h
#include linux/mmc/card.h
+#include
(Samsung Chromebook)
with MMC_CAP_SDIO_IRQ disabled.
Reviewed-by: Paul Stewart ps...@chromium.org
Reviewed-by: Doug Anderson diand...@chromium.org
Signed-off-by: Bing Zhao bz...@marvell.com
Acked-by: Ulf Hansson ulf.hans...@linaro.org
---
v2: remove mmc_fixup_broken_irq_polling() and add inline
(Samsung Chromebook)
with MMC_CAP_SDIO_IRQ disabled.
Reviewed-by: Paul Stewart ps...@chromium.org
Reviewed-by: Doug Anderson diand...@chromium.org
Signed-off-by: Bing Zhao bz...@marvell.com
---
drivers/mmc/core/quirks.c | 21 +
drivers/mmc/core/sdio_irq.c | 5 +
include
Hi Alexander,
Your Chromebook supports SDIO high speed mode (SDIO 2.0 spec). So
50MHz is correct.
Ok, but mainline kernel doesn't try this frequency. It tries 400kHz at
most.
What are you trying to do here? Are you trying to run a mainline kernel on
your Chromebook?
Yes. I've
CC: linux-mmc
Hi Alexander,
Hello.
I am trying to debug the issue with incorrect initialization of WiFi chip on
Samsung ARM Chromebook. And I search for assistance. I have posted my
investigation results on launchpad.net (bug #1247512). Here is
copy:
Marvell SDIO WiFi chip doesn't get
I didn't get the same result..In my case, it's working fine.
But as Bing's result, i will check more and share the result.
I want to add that my kernel is from cros/release-R26-3701.B branch with this
HEAD:
4e13a9c CHERRY-PICK: UPSTREAM: loop: prevent bdev freeing while device in use
Hi Seungwon,
I don't have the failing unit myself, so we'll have to get Bing to try
the patches. You are suggesting that we try applying both of your
patches, right?
Did you test the patch?
I wonder that both are good for your side.
I tested Doug's patch on my failing unit.
Without
Hi Doug,
I tested Doug's patch on my failing unit.
Without this patch, mmc got hung_task and rebooted eventually.
With this patch applied, mmc returns CRC error instead of hung_task, and
the error is handled
gracefully.
Have you tried one or both or Seungwon's fixes without mine?
Hi Subhash,
sdhci_add_host() reads host controller's capabilities and initialize
host-caps of function
mmc_host_uhs(). So mmc_host_uhs() only return this cached values.
So, it does represent host controller's capabilities, not the capabilities
of the card.
What happens if I have a
[mailto:linux-mmc-ow...@vger.kernel.org] On Behalf Of Bing Zhao
Sent: Wednesday, December 05, 2012 5:14 AM
To: Subhash Jadavani; linux-mmc@vger.kernel.org
Cc: linux-arm-...@vger.kernel.org; Sujit Reddy Thumma
Subject: RE: [PATCH v1 2/3] mmc: sdio: Fix SDIO 3.0 UHS-I initialization
sequence
a UHS capable controller and a 2.0 card?
The S18R bit will be set in this case, which might cause problem for the card?
Thanks,
Bing
Thanks,
Jackey
-Original Message-
From: Bing Zhao [mailto:bz...@marvell.com]
Sent: Thursday, December 06, 2012 3:14 AM
To: Shen, Jackey; Subhash
Hi,
From: Sujit Reddy Thumma sthu...@codeaurora.org
According to UHS-I initialization sequence for SDIO 3.0 cards,
the host must set bit[24] (S18R) of OCR register during OCR
handshake to know whether the SDIO card is capable of doing
1.8V I/O.
In SDIO 2.0 spec, bit[24] is reserved, shall
Hi Neil,
In the other case where I do let it suspend early (And it never recovers
without the reset line being toggled) I see:
[ 2170.100982] mmc_wait_for_cmd 52 - -110
[ 2170.105407] mmc_wait_for_cmd 52 - -110
[ 2170.110260] mmc_wait_for_cmd 0 - 0
[ 2170.115509] mmc_wait_for_cmd 8 - -110
Hi Ohad,
But shortly there after the extra tracing I put in shows that mmc_power_off
is called,
Probably right after libertas' if_sdio_probe() returns ?
then mmc_sdio_power_restore calls mmc_send_io_op_cond
Is that as a result of libertas' if_sdio_power_restore() being called
Table 6-2: CCCR bit Definitions, address 00h
Part E1 SDIO Simplified Specification Version 3.00
Feb. 25, 2011
Signed-off-by: Bing Zhao bz...@marvell.com
---
drivers/mmc/core/sdio.c |2 +-
include/linux/mmc/sdio.h |2 ++
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git
Table 6-2: CCCR bit Definitions, address 00h
Part E1 SDIO Simplified Specification Version 3.00
Feb. 25, 2011
This patch has been tested with Marvell WLAN device SD8797.
Signed-off-by: Bing Zhao bz...@marvell.com
---
v2: add device name that was used to test this patch in commit log
drivers
On Thu, Jun 2, 2011 at 11:39 AM, Bing Zhao bz...@marvell.com wrote:
If we power down the sd8686, and power it up again, without toggling
the reset pin at all (e.g. keep it always high), will the card work ?
Yes. The card should work without toggling the reset pin.
Thanks.
Just
Hi Ohad,
-Original Message-
From: Ohad Ben-Cohen [mailto:o...@wizery.com]
Sent: Saturday, January 22, 2011 2:01 PM
To: zhangfei gao
Cc: Nicolas Pitre; Bing Zhao; Sahitya Tummala; linux-mmc@vger.kernel.org;
Michal Miroslaw; Chris Ball;
Andrew Morton; Maxim Levitsky
Subject: Re
Hi Zhangfei,
-Original Message-
From: zhangfei gao [mailto:zhangfei@gmail.com]
Sent: Friday, January 21, 2011 1:07 AM
To: Nicolas Pitre; Bing Zhao
Cc: Sahitya Tummala; linux-mmc@vger.kernel.org; Michal Miroslaw; Chris Ball;
Andrew Morton; Maxim
Levitsky
Subject: Re: [PATCH v2
-Original Message-
From: Nicolas Pitre [mailto:n...@fluxnic.net]
Sent: Friday, January 21, 2011 6:56 PM
To: Bing Zhao
Cc: zhangfei gao; Sahitya Tummala; linux-mmc@vger.kernel.org; Michal
Miroslaw; Chris Ball; Andrew
Morton; Maxim Levitsky
Subject: RE: [PATCH v2] sdio: skip
Hi Sahitya,
-Original Message-
From: Sahitya Tummala [mailto:stumm...@codeaurora.org]
Sent: Tuesday, September 14, 2010 3:16 AM
To: Bing Zhao
Cc: Nicolas Pitre; linux-mmc@vger.kernel.org; Michal Miroslaw; Chris Ball;
Andrew Morton
Subject: RE: [PATCH v2] sdio: skip initialization
Hi Nicolas,
-Original Message-
From: Nicolas Pitre [mailto:n...@fluxnic.net]
Sent: Thursday, September 02, 2010 4:30 PM
To: Bing Zhao
Cc: linux-mmc@vger.kernel.org; Michal Miroslaw; Chris Ball; Andrew Morton
Subject: RE: [PATCH v2] sdio: skip initialization on powered resume
Hi Nicolas,
-Original Message-
From: Nicolas Pitre [mailto:n...@fluxnic.net]
Sent: Tuesday, September 07, 2010 6:29 PM
To: Bing Zhao
Cc: linux-mmc@vger.kernel.org; Michal Miroslaw; Chris Ball; Andrew Morton
Subject: RE: [PATCH v2] sdio: skip initialization on powered resume
Hi Nicolas,
Thanks for your comments.
-Original Message-
From: Nicolas Pitre [mailto:n...@fluxnic.net]
Sent: Thursday, September 02, 2010 10:54 AM
To: Bing Zhao
Cc: linux-mmc@vger.kernel.org; Michal Miroslaw; Chris Ball; Andrew Morton
Subject: Re: [PATCH v2] sdio: skip
) then reinitialization
should be entirely skipped on resume unless the power was lost between
suspend and resume (or card was temporarily removed from the slot).
Signed-off-by: Bing Zhao bz...@marvell.com
---
Changes since v1:
* Subject changed (was add MMC_PM_SKIP_RESUME_PROBE to...)
* No need
30 matches
Mail list logo
