Re: [PATCH v2 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-20 Thread Dmitry Torokhov
On Mon, Jul 20, 2015 at 10:20:13AM +0530, Vignesh R wrote: On am437x-gp-evm, pixcir touchscreen can wake the system from low power state by generating wake-up interrupt via pinctrl and IO daisy chain. Add support for optional wakeup interrupt source by regsitering to automated wake IRQ

Re: [PATCH v2 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-20 Thread Dmitry Torokhov
On Sun, Jul 19, 2015 at 11:09:30PM -0700, Tony Lindgren wrote: * Vignesh R vigne...@ti.com [150719 21:53]: @@ -445,6 +443,8 @@ static struct pixcir_ts_platform_data *pixcir_parse_dt(struct device *dev) dev_dbg(dev, %s: x %d, y %d, gpio %d\n, __func__, pdata-x_max + 1,

Re: [PATCH 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-20 Thread Dmitry Torokhov
On Sun, Jul 19, 2015 at 11:05:07PM -0700, Tony Lindgren wrote: * Vignesh R vigne...@ti.com [150719 21:51]: On 7/18/2015 3:21 AM, Dmitry Torokhov wrote: I wonder if driver core should be responsible for clearing wake irq and also for clearing wakeup flag. AFAICU, wakeup flag

Re: [PATCH v2 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-20 Thread Tony Lindgren
* Vignesh R vigne...@ti.com [150719 21:53]: @@ -445,6 +443,8 @@ static struct pixcir_ts_platform_data *pixcir_parse_dt(struct device *dev) dev_dbg(dev, %s: x %d, y %d, gpio %d\n, __func__, pdata-x_max + 1, pdata-y_max + 1, pdata-gpio_attb); + pdata-wakeirq =

Re: [PATCH v2 3/3] soc: ti: Add wkup_m3_ipc driver

2015-07-20 Thread Tony Lindgren
* Dave Gerlach d-gerl...@ti.com [150717 13:59]: + +/* Public functions */ ... +EXPORT_SYMBOL_GPL(wkup_m3_set_mem_type); +EXPORT_SYMBOL_GPL(wkup_m3_set_resume_address); +EXPORT_SYMBOL_GPL(wkup_m3_request_pm_status); +EXPORT_SYMBOL_GPL(wkup_m3_prepare_low_power);

Re: [PATCH 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-20 Thread Tony Lindgren
* Vignesh R vigne...@ti.com [150719 21:51]: On 7/18/2015 3:21 AM, Dmitry Torokhov wrote: I wonder if driver core should be responsible for clearing wake irq and also for clearing wakeup flag. AFAICU, wakeup flag is deleted when struct device is deleted, hence, device_init_wakeup()

twl6030-gpadc support for twl6037

2015-07-20 Thread Belisko Marek
Hi all, I'm trying to figure out what is relation between palmas mfd driver and twl-core for twl603x devices. twl-core driver seems to be older than palmas driver but seems both export same functionality (except that palmas have defined structs for gpadc but functionality is missing). My main

Re: [PATCH 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-20 Thread Tony Lindgren
* Dmitry Torokhov dmitry.torok...@gmail.com [150719 23:36]: On Sun, Jul 19, 2015 at 11:05:07PM -0700, Tony Lindgren wrote: * Vignesh R vigne...@ti.com [150719 21:51]: On 7/18/2015 3:21 AM, Dmitry Torokhov wrote: I wonder if driver core should be responsible for clearing wake irq and

Re: [PATCH v3 2/3] ARM: dts: dra7: Add syscon-pllreset syscon to SATA PHY

2015-07-20 Thread Tero Kristo
On 07/17/2015 04:47 PM, Roger Quadros wrote: This register is required to be passed to the SATA PHY driver to workaround errata i783 (SATA Lockup After SATA DPLL Unlock/Relock). Signed-off-by: Roger Quadros rog...@ti.com --- arch/arm/boot/dts/dra7.dtsi | 1 + 1 file changed, 1 insertion(+)

[PATCH] ARM: dts: am437x: add aliases for all UART instances

2015-07-20 Thread Sekhar Nori
Add serialN aliases for all 6 UART instances on the AM437x SoC so each board's .dts file does not have to define its own aliases. Remove the alias added for am437x-gp-evm.dts now that we have the aliases defined in am4372.dtsi file. Signed-off-by: Sekhar Nori nsek...@ti.com ---

Re: [PATCH v3 3/3] ARM: dts: dra7: Add scm_conf1 node and remove redundant nodes

2015-07-20 Thread Tero Kristo
On 07/17/2015 04:47 PM, Roger Quadros wrote: scm_conf1 maps the control register address space after the padconf till the end. Fix the scm_conf and pmx_core resource lengths. We need to add 4 bytes to include the last 32-bit register space. Remove the redundant dra7_ctrl_core and

Re: [PATCH 1/1 linux-next] mmc: omap: use for_each_sg() for scatterlist parsing

2015-07-20 Thread Ulf Hansson
On 16 June 2015 at 21:15, Fabian Frederick f...@skynet.be wrote: See Documentation/DMA-API.txt - Part Id Signed-off-by: Fabian Frederick f...@skynet.be Thanks, applied! Kind regards Uffe --- This is untested. drivers/mmc/host/omap.c | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [PATCH 0/3] omap_hsmmc: Fix card enumeration failure on

2015-07-20 Thread Ulf Hansson
On 16 June 2015 at 12:37, Vignesh R vigne...@ti.com wrote: Hi, When using omap_hsmmc driver, if sd-card repeatedly plug unplugged multiple times quickly, card enumeration stops after few iterations. This can be easily reproduced on DRA74X EVM which uses omap_hsmmc driver. This patch series

Re: [PATCH v3 01/46] usb: gadget: encapsulate endpoint claiming mechanism

2015-07-20 Thread Krzysztof Opasiak
On 07/15/2015 08:31 AM, Robert Baldyga wrote: So far it was necessary for usb functions to set ep-driver_data in endpoint obtained from autoconfig to non-null value, to indicate that endpoint is claimed by function (in autoconfig it was checked if endpoint has set this field to non-null value,

Re: [PATCH v3 26/46] usb: gadget: pch_ud: add ep capabilities support

2015-07-20 Thread Krzysztof Opasiak
On 07/15/2015 08:32 AM, Robert Baldyga wrote: Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/pch_udc.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-20 Thread Adam Lee
Hello, here is some more context from the TPS65950's TRM [1]. Quoting from section 15.3.1.2.1 VUSB3V1 section: VUSB3V1 is also used to bias analog multiplexers on the four MCPC pins between the carkit and the MADC (supplied by VINTANA2). And from section 15.4.11. MADC Monitoring Using

Re: [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-20 Thread Adam Lee
Hello Jonathan, I sent the same patch with linux-iio cc'd. I expanded the cover letter with the quotes from TI's documents, but the text has been removed in the email somehow. The discussion in this thread should be enough (I think) for linux-iio maintainers, so we will see! Thanks, Adam On

Re: [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-20 Thread Peter Meerwald
On Mon, 20 Jul 2015, Adam YH Lee wrote: MADC[3:6] reads incorrect values without these two following changes: - enable the 3v1 bias regulator for ADC[3:6] - configure ADC[3:6] lines as input, not as USB comments below Signed-off-by: Adam YH Lee adam.yh@gmail.com ---

Re: [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-20 Thread Jonathan Cameron
On 20/07/15 18:47, Adam Lee wrote: Hello, here is some more context from the TPS65950's TRM [1]. Quoting from section 15.3.1.2.1 VUSB3V1 section: VUSB3V1 is also used to bias analog multiplexers on the four MCPC pins between the carkit and the MADC (supplied by VINTANA2). And from

[PATCH] Fix incomplete initialization of ADC[3:6]$

2015-07-20 Thread Adam YH Lee
Additionally the original discussion for this patch can be found here [5]. $ [1] http://comments.gmane.org/gmane.linux.ports.arm.omap/83698$ [2] http://gumstix.8.x6.nabble.com/twl4030-madc-low-read-value-td4967139.html#none$ [3] https://e2e.ti.com/support/power_management/pmu/f/43/t/732$ [4]

[PATCH] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-20 Thread Adam YH Lee
MADC[3:6] reads incorrect values without these two following changes: - enable the 3v1 bias regulator for ADC[3:6] - configure ADC[3:6] lines as input, not as USB Signed-off-by: Adam YH Lee adam.yh@gmail.com --- drivers/iio/adc/twl4030-madc.c | 14 ++

Re: [PATCH] irqchip: omap-intc: improve IRQ handler

2015-07-20 Thread Felipe Balbi
On Wed, Jul 15, 2015 at 02:36:54PM +0200, Thomas Gleixner wrote: On Wed, 15 Jul 2015, Tony Lindgren wrote: Felipe, * Tony Lindgren t...@atomide.com [150119 13:41]: * Felipe Balbi ba...@ti.com [150102 10:50]: as it turns out the current IRQ number will *always* be available from

[PATCH RESEND] irqchip: omap-intc: improve IRQ handler

2015-07-20 Thread Felipe Balbi
as it turns out the current IRQ number will *always* be available from SIR register which renders the reads of PENDING registers as plain unnecessary overhead. In order to catch any situation where SIR reads as zero, we're adding a WARN() to turn it into a very verbose error and users actually

Re: [PATCH RESEND] irqchip: omap-intc: improve IRQ handler

2015-07-20 Thread Thomas Gleixner
On Mon, 20 Jul 2015, Felipe Balbi wrote: + irqnr = intc_readl(INTC_SIR); + irqnr = ACTIVEIRQ_MASK; + WARN(!irqnr, Spurious IRQ ?\n); Shouldn't that be WARN_ONCE? Thanks, tglx -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: linux 4.2-rc1 broken Nokia N900

2015-07-20 Thread Michael Welling
On Tue, Jul 14, 2015 at 09:14:12AM +0200, Pali Rohár wrote: On Monday 13 July 2015 17:36:07 Michael Welling wrote: On Tue, Jul 14, 2015 at 12:02:44AM +0200, Pali Rohár wrote: I think nothing special. I just call: export ARCH=arm export CROSS_COMPILE=arm-linux-gnueabi- make

Re: linux 4.2-rc1 broken Nokia N900

2015-07-20 Thread Michael Welling
On Wed, Jul 15, 2015 at 09:49:33PM +0200, Pavel Machek wrote: Hi! Ok, so: 4.2-rc1 worked for me, IIRC. This does not make sense. Nothing has changed in drivers/spi between these versions. Are you sure that 4.2-rc1 worked for you? Tested again: yes, I have 4.2-rc1 booted

Re: [PATCH RESEND] irqchip: omap-intc: improve IRQ handler

2015-07-20 Thread Felipe Balbi
On Mon, Jul 20, 2015 at 10:44:08PM +0200, Thomas Gleixner wrote: On Mon, 20 Jul 2015, Felipe Balbi wrote: + irqnr = intc_readl(INTC_SIR); + irqnr = ACTIVEIRQ_MASK; + WARN(!irqnr, Spurious IRQ ?\n); Shouldn't that be WARN_ONCE? Sure, why not ?

Re: [PATCH] ARM: dts: omap5-uevm: Add Palmas power button support

2015-07-20 Thread Nishanth Menon
On 07/20/2015 04:07 PM, Aparna Balasubramanian wrote: Palmas on OMAP5uevm has support for power button, so enable it. Signed-off-by: Aparna Balasubramanian apar...@ti.com --- Based on kernel tag 4.2.0-rc1 and test result log is at http://pastebin.ubuntu.com/11910178/

Re: linux 4.2-rc1 broken Nokia N900

2015-07-20 Thread Pali Rohár
On Monday 20 July 2015 22:46:47 Michael Welling wrote: On Tue, Jul 14, 2015 at 09:14:12AM +0200, Pali Rohár wrote: On Monday 13 July 2015 17:36:07 Michael Welling wrote: On Tue, Jul 14, 2015 at 12:02:44AM +0200, Pali Rohár wrote: I think nothing special. I just call: export

[PATCH] ARM: dts: omap5-uevm: Add Palmas power button support

2015-07-20 Thread Aparna Balasubramanian
Palmas on OMAP5uevm has support for power button, so enable it. Signed-off-by: Aparna Balasubramanian apar...@ti.com --- Based on kernel tag 4.2.0-rc1 and test result log is at http://pastebin.ubuntu.com/11910178/ arch/arm/boot/dts/omap5-uevm.dts |7 +++ 1 file changed, 7 insertions(+)

Re: [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-20 Thread Adam Lee
Hi Peter, I sent a V2 with corrected wording. My bad! And yes I agree that register setting should be done in the ADC driver. Let me see what I can do, and will report back. Thanks, Adam On Mon, Jul 20, 2015 at 11:54 AM, Peter Meerwald pme...@pmeerw.net wrote: On Mon, 20 Jul 2015, Adam YH Lee

[V2] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-20 Thread Adam YH Lee
MADC[3:6] reads incorrect values without these two following changes: - enable the 3v1 bias regulator for ADC[3:6] - configure ADC[3:6] lines as input, not as USB Signed-off-by: Adam YH Lee adam.yh@gmail.com --- drivers/iio/adc/twl4030-madc.c | 14 ++

Re: [PATCH] ARM: OMAP2+: Remove module references from IOMMU machine layer

2015-07-20 Thread Suman Anna
Hi Tony, On 07/16/2015 02:16 AM, Tony Lindgren wrote: * Suman Anna s-a...@ti.com [150710 13:45]: The OMAP IOMMU driver has been adapted to the IOMMU framework for a while now, and it no longer supports being built as a module. Cleanup all the module related references both from the code and

[V3] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-20 Thread Adam YH Lee
MADC[3:6] reads incorrect values without these two following changes: - enable the 3v1 bias regulator for ADC[3:6] - configure ADC[3:6] lines as input, not as USB Signed-off-by: Adam YH Lee adam.yh@gmail.com --- drivers/iio/adc/twl4030-madc.c | 36 1

Re: [V3] [TWL4030 MADC] Fix ADC[3:6] readings

2015-07-20 Thread Adam Lee
Hello Peter, Just sent up the V3 of my patch. Register configuration is now done in madc driver code. Another difference from V2 and V1 is that I am using `devm_regulator_put` instead of `regulator_put` to match the `devm_regulator_get` call. I've tested it on Gumstix Overo (OMAP3 + TPS65950).

[PATCH 4/4] ARM: OMAP2+: omap3-pandora: add wifi support

2015-07-20 Thread Grazvydas Ignotas
Add wl1251 support via pdata-quirks as it's driver lacks DT support. MMC3 is marked disabled in DT so that MMC3 instance of hsmmc driver is probed using platform data with special card init callback. Signed-off-by: Grazvydas Ignotas nota...@gmail.com ---

[PATCH 1/4] ARM: dts: omap3-pandora: miscellaneous corrections

2015-07-20 Thread Grazvydas Ignotas
- add pandora specific compatible name - fix mmc2 card detect polarity - fix mmc1 and mmc2 write protect polarity - disable write protect pins because of production issue and add an explanation why they are disabled - fix NAND partition name to reflect the correct address Signed-off-by:

[PATCH 2/4] ARM: dts: omap3-pandora: add support for usb host and 32k buffer

2015-07-20 Thread Grazvydas Ignotas
This adds missing bits for EHCI HS USB host support and 32k clock buffer control for the wg7210 bt+wifi module. Signed-off-by: Grazvydas Ignotas nota...@gmail.com --- arch/arm/boot/dts/omap3-pandora-common.dtsi | 36 + 1 file changed, 36 insertions(+) diff --git

[PATCH 3/4] ARM: OMAP2+: omap3-pandora: add backlight support

2015-07-20 Thread Grazvydas Ignotas
Add backlight support via pdata-quirks as it's driver lacks DT support. Signed-off-by: Grazvydas Ignotas nota...@gmail.com --- arch/arm/mach-omap2/pdata-quirks.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/mach-omap2/pdata-quirks.c

[PATCH 06/11] iommu/omap: Remove trailing semi-colon from a macro

2015-07-20 Thread Suman Anna
Remove the trailing semi-colon in the DEBUG_FOPS_RO macro definition. This fixes the checking warning, WARNING: macros should not use a trailing semicolon Signed-off-by: Suman Anna s-a...@ti.com --- drivers/iommu/omap-iommu-debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 03/11] iommu/omap: Move debugfs functions to omap-iommu-debug.c

2015-07-20 Thread Suman Anna
The main OMAP IOMMU driver file has some helper functions used by the OMAP IOMMU debugfs functionality, and there is already a dedicated source file omap-iommu-debug.c dealing with these debugfs routines. Move all these functions to the omap-iommu-debug.c file, so that all the debugfs related

[PATCH 04/11] iommu/omap: Protect omap-iopgtable.h against double inclusion

2015-07-20 Thread Suman Anna
Protect the omap-pgtable.h header against double inclusion in source code by using the standard include guard mechanism. Signed-off-by: Suman Anna s-a...@ti.com --- drivers/iommu/omap-iopgtable.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/iommu/omap-iopgtable.h

[PATCH 02/11] iommu/omap: Remove all module references

2015-07-20 Thread Suman Anna
The OMAP IOMMU driver has been adapted to the IOMMU framework for a while now, and it does not support being built as a module anymore. So, remove all the module references from the OMAP IOMMU driver. While at it, also relocate a comment around the subsys_initcall to avoid a checkpatch strict

[PATCH 10/11] iommu/omap: Align code with open parenthesis

2015-07-20 Thread Suman Anna
Fix all the occurrences of the following check warning generated with the checkpatch --strict option: CHECK: Alignment should match open parenthesis Signed-off-by: Suman Anna s-a...@ti.com --- drivers/iommu/omap-iommu.c | 23 +++ 1 file changed, 11 insertions(+), 12

[PATCH 05/11] iommu/omap: Remove unused union fields

2015-07-20 Thread Suman Anna
There are couple of unions defined in the structures iotlb_entry and cr_regs. There are no usage/references to some of these union fields in the code, so clean them up and simplify the structures. Signed-off-by: Suman Anna s-a...@ti.com --- drivers/iommu/omap-iommu.h | 23 +++

[PATCH 08/11] iommu/omap: Use BIT(x) macros in omap-iopgtable.h

2015-07-20 Thread Suman Anna
Switch to using the BIT(x) macros in omap-iopgtable.h where possible. This eliminates the following checkpatch check warning: CHECK: Prefer using the BIT macro A couple of macros that used zero bit shifting are defined directly to avoid the above warning on one of the macros. Signed-off-by:

[PATCH 09/11] iommu/omap: Use BIT(x) macros in omap-iommu.h

2015-07-20 Thread Suman Anna
Switch to using the BIT(x) macros in omap-iommu.h where possible. This eliminates the following checkpatch check warning: CHECK: Prefer using the BIT macro A couple of the warnings were ignored for better readability of the bit-shift for the different values. Signed-off-by: Suman Anna

[PATCH 07/11] iommu/omap: Remove unnecessary error traces on alloc failures

2015-07-20 Thread Suman Anna
Fix couple of checkpatch warnings of the type, WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Suman Anna s-a...@ti.com --- drivers/iommu/omap-iommu.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/iommu/omap-iommu.c

[PATCH 00/11] Some OMAP IOMMU cleanup patches

2015-07-20 Thread Suman Anna
Hi Joerg, The following series includes minor cleanup patches and checkpatch fixes to the OMAP IOMMU driver. The first 5 patches do some cleanup and some debugfs code rearrangement, while the last 6 patches deal with the stricter checkpatch warnings/checks. The series is baselined on 4.2-rc3 and

[PATCH 11/11] iommu/omap: Split multiple assignments into separate lines

2015-07-20 Thread Suman Anna
Use separate assignments for assigning the same value into different variables. This fixes the following check warning generated with the checkpatch --strict option: CHECK: multiple assignments should be avoided Signed-off-by: Suman Anna s-a...@ti.com --- drivers/iommu/omap-iommu.c | 6

[PATCH 01/11] Documentation: dt: Add #iommu-cells info to OMAP iommu bindings

2015-07-20 Thread Suman Anna
The OMAP IOMMU bindings is updated to reflect the required #iommu-cells property. Signed-off-by: Suman Anna s-a...@ti.com --- Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [PATCH v3 3/3] ARM: dts: dra7: Add scm_conf1 node and remove redundant nodes

2015-07-20 Thread Kishon Vijay Abraham I
Hi, On Monday 20 July 2015 05:34 PM, Tero Kristo wrote: On 07/17/2015 04:47 PM, Roger Quadros wrote: scm_conf1 maps the control register address space after the padconf till the end. Fix the scm_conf and pmx_core resource lengths. We need to add 4 bytes to include the last 32-bit register