RE: AM335x pinctrl error -19 (-ENODEV)

2013-02-28 Thread AnilKumar, Chimata
On Wed, Feb 27, 2013 at 21:14:25, Mark Jackson wrote: I've specified an I2C bus and all 6 UARTs in the dts file for my custom cpu board, as follows:- ocp { uart1: serial@44e09000 { pinctrl-names = default; Hi Mark, Specify pinctrl-0 property with

RE: [PATCH] ARM: omap2: register cpufreq-cpu0 device for am33xx

2013-01-31 Thread AnilKumar, Chimata
On Wed, Jan 30, 2013 at 20:02:22, Shawn Guo wrote: The cpufreq-cpu0 driver changes to instantiate use platform_driver mechanism. The patch is an am33xx platform level adaptation for it. Tested-by: AnilKumar Ch anilku...@ti.com Hi Shawn, I have tested your patch on AM335x-EVM, no issues

RE: OMAP baseline test results for v3.8-rc5

2013-01-28 Thread AnilKumar, Chimata
On Mon, Jan 28, 2013 at 17:48:49, Mohammed, Afzal wrote: Hi Felipe, On Mon, Jan 28, 2013 at 17:46:35, Balbi, Felipe wrote: didn't help :-s Hands up :( Hi Felipe, Could you please try with any of these options? 1. Change/add mem=512M (should be same value as u-boot printed RAM size)

RE: [PATCH v4] ARM: OMAP2+: AM33XX: omap2plus_defconfig: Add support for few drivers

2013-01-18 Thread AnilKumar, Chimata
On Thu, Jan 03, 2013 at 14:07:59, AnilKumar, Chimata wrote: Adds tps65910 PMIC, lis3lv02d accelerometer, tsl2550 ambient light sensor, tmp275 temperature sensor, matrix keypad, gbio based leds and D_CAN drivers support. These peripherals are present on AM33XX family of devices (EVM, BeagleBone

RE: [PATCH v4 1/4] rtc: OMAP: Add system pm_power_off to rtc driver

2013-01-11 Thread AnilKumar, Chimata
On Fri, Jan 11, 2013 at 14:24:46, Russ Dill wrote: On Fri, Jan 11, 2013 at 12:08 AM, Russ Dill russ.d...@gmail.com wrote: On Thu, Dec 13, 2012 at 10:03 PM, AnilKumar Ch anilku...@ti.com wrote: From: Colin Foe-Parker colin.foepar...@logicpd.com Add system power off control to rtc driver

RE: [PATCH v4 1/4] rtc: OMAP: Add system pm_power_off to rtc driver

2013-01-11 Thread AnilKumar, Chimata
On Fri, Jan 11, 2013 at 15:00:03, AnilKumar, Chimata wrote: On Fri, Jan 11, 2013 at 14:24:46, Russ Dill wrote: On Fri, Jan 11, 2013 at 12:08 AM, Russ Dill russ.d...@gmail.com wrote: On Thu, Dec 13, 2012 at 10:03 PM, AnilKumar Ch anilku...@ti.com wrote: From: Colin Foe-Parker colin.foepar

RE: [PATCH 0/3] can: Add D_CAN raminit support to am335x-evm

2013-01-09 Thread AnilKumar, Chimata
On Wed, Jan 09, 2013 at 17:46:37, Cousson, Benoit wrote: Hi Anil, On 11/14/2012 07:08 PM, AnilKumar Ch wrote: This patch series adds d_can raminit support to c_can/d_can driver, which is required to init/de-init D_CAN message RAM (holds message objects). Added corresponding DT changes to

RE: [PATCH 0/7] ARM: OMAP2+: AM33XX: Enable few drivers in omap2plus_defconfig

2013-01-02 Thread AnilKumar, Chimata
On Fri, Dec 14, 2012 at 23:39:05, Tony Lindgren wrote: * AnilKumar Ch anilku...@ti.com [121120 23:01]: This patch series enable tps65910, lis3lv02d accelerometer, tsl2550 ambient light sensor, matrix keypad, tmp275 temperature sensor, gpio leds and D_CAN drivers in omap2plus_defconfig.

RE: [PATCH RESEND] ARM: dts: AM33XX: Rename I2C and GPIO nodes

2013-01-02 Thread AnilKumar, Chimata
On Wed, Nov 21, 2012 at 17:22:17, AnilKumar, Chimata wrote: Rename I2C and GPIO nodes according to AM33XX TRM. According to AM33XX TRM device instances are starting from 0 like i2c0, i2c1 and i2c3. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com [pa...@antoniou-consulting.com

RE: [PATCH 2/3] ARM: dts: AM33XX: Add d_can instances to aliases

2013-01-02 Thread AnilKumar, Chimata
On Tue, Nov 20, 2012 at 16:21:42, Marc Kleine-Budde wrote: On 11/14/2012 07:08 PM, AnilKumar Ch wrote: Add d_can instances to aliases node to get the D_CAN instance number from the driver. To initialize D_CAN message RAM, corresponding instance number is required. To initialize

RE: [PATCH 3/3] ARM: dts: AM33XX: Add memory resource to d_can node

2013-01-02 Thread AnilKumar, Chimata
On Wed, Nov 21, 2012 at 13:50:26, Marc Kleine-Budde wrote: On 11/14/2012 07:08 PM, AnilKumar Ch wrote: Add a new address space/memory resource to d_can device tree node. D_CAN RAM initialization is achieved through RAMINIT register which is part of AM33XX control module address space. D_CAN

RE: [PATCH v4 0/4] pm: Add power off control

2013-01-02 Thread AnilKumar, Chimata
On Fri, Dec 14, 2012 at 11:33:13, AnilKumar, Chimata wrote: Add PM power_off control to rtc driver and PMIC status is set to STATUS_OFF to shutdown PMIC if PWR_EN is toggled by RTC module. System power off sequence:- * Set PMIC STATUS_OFF when PMIC_POWER_EN is pulled low * Enable

RE: [PATCH v3 0/7] ARM: OMAP2+: AM33XX: Enable few drivers in omap2plus_defconfig

2013-01-02 Thread AnilKumar, Chimata
On Thu, Jan 03, 2013 at 01:49:57, Olof Johansson wrote: Hi, On Wed, Jan 2, 2013 at 2:27 AM, AnilKumar Ch anilku...@ti.com wrote: This patch series enable tps65910, lis3lv02d accelerometer, tsl2550 ambient light sensor, matrix keypad, tmp275 temperature sensor, gpio leds and D_CAN drivers

RE: [rtc-linux] [PATCH v3 1/5] rtc: OMAP: Add system pm_power_off to rtc driver

2012-12-09 Thread AnilKumar, Chimata
On Wed, Nov 28, 2012 at 16:42:26, Russell King - ARM Linux wrote: On Tue, Nov 27, 2012 at 03:42:39PM -0800, Andrew Morton wrote: + /* Do not allow to execute any other task */ + spin_lock_irqsave(lock, flags); + while (1); I suspect this doesn't do what you want it to do.

RE: [PATCH 6/7] ARM: OMAP2+: omap2plus_defconfig: Enable leds-gpio driver

2012-11-26 Thread AnilKumar, Chimata
On Mon, Nov 26, 2012 at 13:59:24, Javier Martinez Canillas wrote: On Wed, Nov 21, 2012 at 7:59 AM, AnilKumar Ch anilku...@ti.com wrote: AM335X-EVMSK and AM335X-BONE devices have gpio controlled user leds, one has to manually enable this support to use user leds. So this patch enables

RE: [PATCH 1/1] ARM: OMAP2+: enable support for GPIO connected LEDs

2012-11-25 Thread AnilKumar, Chimata
On Sat, Nov 24, 2012 at 15:04:02, Javier Martinez Canillas wrote: Many OMAP boards use GPIO LEDs to notify status to the user on boot. So, it is good to have by default support for GPIO connected LEDs as well as some commonly used triggers. Signed-off-by: Javier Martinez Canillas

RE: [PATCH v3 5/5] ARM: OMAP2+: omap2plus_defconfig: Enable RTC support

2012-11-25 Thread AnilKumar, Chimata
On Fri, Nov 23, 2012 at 22:25:07, Igor Mazanov wrote: AnilKumar Ch wrote: AM33XX family of devices uses RTC module, one has to manually enable this support to use RTC features. So this patch enable RTC driver in omap2plus_defconfig. Signed-off-by: AnilKumar Ch

RE: [PATCH v3 2/5] mfd: tps65217: Set PMIC to shutdown on PWR_EN toggle

2012-11-22 Thread AnilKumar, Chimata
On Wed, Nov 21, 2012 at 19:17:58, Samuel Ortiz wrote: Hi Anilkumar, On Tue, Nov 20, 2012 at 03:18:44PM +0530, AnilKumar Ch wrote: From: Colin Foe-Parker colin.foepar...@logicpd.com Set tps65217 PMIC status to OFF if power enable toggle is supported. By setting this bit to 1 to enter

RE: [PATCH v3 1/5] rtc: OMAP: Add system pm_power_off to rtc driver

2012-11-22 Thread AnilKumar, Chimata
+Andrew Morton On Tue, Nov 20, 2012 at 15:18:43, AnilKumar, Chimata wrote: From: Colin Foe-Parker colin.foepar...@logicpd.com Add system power off control to rtc driver which is the in-charge of controlling the BeagleBone system power. The power_off routine can be hooked up to pm_power_off

RE: [PATCH v2] can: c_can: Add d_can raminit support

2012-11-21 Thread AnilKumar, Chimata
On Wed, Nov 21, 2012 at 13:57:17, Marc Kleine-Budde wrote: On 11/21/2012 06:44 AM, AnilKumar Ch wrote: Add D_CAN raminit support to C_CAN driver to enable D_CAN RAM, which holds all the message objects during transmission or receiving of data. This initialization/de-initialization should

RE: [PATCH v2] can: c_can: Add d_can raminit support

2012-11-21 Thread AnilKumar, Chimata
On Wed, Nov 21, 2012 at 14:18:56, Marc Kleine-Budde wrote: On 11/21/2012 06:44 AM, AnilKumar Ch wrote: Add D_CAN raminit support to C_CAN driver to enable D_CAN RAM, which holds all the message objects during transmission or receiving of data. This initialization/de-initialization should

RE: [PATCH v3] can: c_can: Add d_can raminit support

2012-11-21 Thread AnilKumar, Chimata
On Wed, Nov 21, 2012 at 15:01:22, Marc Kleine-Budde wrote: From: AnilKumar Ch anilku...@ti.com Add D_CAN raminit support to C_CAN driver to enable D_CAN RAM, which holds all the message objects during transmission or receiving of data. This initialization/de-initialization should be done in

RE: [PATCH] OMAP2+: enable TPS65217 support in omap2plus_defconfig

2012-11-20 Thread AnilKumar, Chimata
On Mon, Nov 19, 2012 at 17:15:25, Igor Mazanov wrote: TPS65217 is described in arch/arm/boot/dts/am335x-bone.dts but doesn't enabled in arch/arm/configs/omap2plus_defconfig. Enable TPS65217 support in omap2plus_defconfig. Signed-off-by: Igor Mazanov i.maza...@gmail.com ---

RE: [PATCH 1/3] can: c_can: Add d_can raminit support

2012-11-20 Thread AnilKumar, Chimata
On Tue, Nov 20, 2012 at 16:20:41, Marc Kleine-Budde wrote: On 11/14/2012 07:08 PM, AnilKumar Ch wrote: Add D_CAN raminit support to C_CAN driver to enable D_CAN RAM, which holds all the message objects during transmission or receiving of data. This initialization/de-initialization should

RE: [PATCH 3/3] ARM: dts: AM33XX: Add memory resource to d_can node

2012-11-20 Thread AnilKumar, Chimata
On Tue, Nov 20, 2012 at 15:56:32, Marc Kleine-Budde wrote: On 11/20/2012 11:23 AM, AnilKumar, Chimata wrote: On Tue, Nov 20, 2012 at 15:43:04, Marc Kleine-Budde wrote: On 11/14/2012 07:08 PM, AnilKumar Ch wrote: Add a new address space/memory resource to d_can device tree node. D_CAN RAM

RE: [PATCH v2 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-19 Thread AnilKumar, Chimata
On Mon, Nov 19, 2012 at 16:20:27, Peter Korsgaard wrote: AnilKumar == AnilKumar Ch anilku...@ti.com writes: s/shutdowm/shutdown/ in the subject. I will change AnilKumar From: Colin Foe-Parker colin.foepar...@logicpd.com AnilKumar Set tps65217 PMIC status to OFF if power enable toggle

RE: [PATCH 0/3] can: Add D_CAN raminit support to am335x-evm

2012-11-19 Thread AnilKumar, Chimata
On Wed, Nov 14, 2012 at 23:38:22, AnilKumar, Chimata wrote: This patch series adds d_can raminit support to c_can/d_can driver, which is required to init/de-init D_CAN message RAM (holds message objects). Added corresponding DT changes to get resource of RAMINIT register and device instance

RE: [PATCH v2 4/4] ARM: dts: AM33XX: Enable system power off control in am335x-bone

2012-11-18 Thread AnilKumar, Chimata
On Sat, Nov 17, 2012 at 00:40:04, Kevin Hilman wrote: AnilKumar Ch anilku...@ti.com writes: Enable system power off control for BeagleBone in am335x-bone.dts file under rtc node. RTC is the incharge of controlling the system power. This flag is used by the driver to hook up the

RE: [PATCH 2/4] rtc: OMAP: Add system pm_power_off to rtc driver

2012-11-16 Thread AnilKumar, Chimata
On Fri, Nov 16, 2012 at 11:43:36, AnilKumar, Chimata wrote: On Mon, Nov 12, 2012 at 15:17:48, AnilKumar, Chimata wrote: On Tue, Nov 06, 2012 at 11:15:34, Bedia, Vaibhav wrote: On Mon, Nov 05, 2012 at 15:12:27, AnilKumar, Chimata wrote: [...] +#define SHUTDOWN_TIME_SEC

RE: [PATCH 2/4] rtc: OMAP: Add system pm_power_off to rtc driver

2012-11-15 Thread AnilKumar, Chimata
On Mon, Nov 12, 2012 at 15:17:48, AnilKumar, Chimata wrote: On Tue, Nov 06, 2012 at 11:15:34, Bedia, Vaibhav wrote: On Mon, Nov 05, 2012 at 15:12:27, AnilKumar, Chimata wrote: [...] +#define SHUTDOWN_TIME_SEC2 +#define SECS_IN_MIN 60 +#define

RE: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-15 Thread AnilKumar, Chimata
On Wed, Nov 14, 2012 at 15:54:53, Mark Brown wrote: On Wed, Nov 14, 2012 at 11:08:49AM +0100, Benoit Cousson wrote: I was wondering that, because exposing a pin to control the whole PMIC low power mode seems to be something that should be generic enough to be handled by the regulator

RE: [PATCH 2/4] rtc: OMAP: Add system pm_power_off to rtc driver

2012-11-13 Thread AnilKumar, Chimata
+Mark On Mon, Nov 12, 2012 at 15:17:13, AnilKumar, Chimata wrote: On Tue, Nov 06, 2012 at 22:26:54, Cousson, Benoit wrote: Hi Anil, On 11/06/2012 06:07 AM, AnilKumar, Chimata wrote: On Mon, Nov 05, 2012 at 22:13:25, Cousson, Benoit wrote: Hi Anil / Colin, On 11/05/2012 10:42

RE: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-13 Thread AnilKumar, Chimata
On Wed, Nov 14, 2012 at 07:53:42, Mark Brown wrote: On Mon, Nov 05, 2012 at 05:59:36PM +0100, Benoit Cousson wrote: On 11/05/2012 10:42 AM, AnilKumar Ch wrote: +Optional properties: +- ti,pmic-shutdown-controller: Telling the PMIC to shutdown on PWR_EN toggle. That sounds like a

RE: [PATCH 2/4] rtc: OMAP: Add system pm_power_off to rtc driver

2012-11-13 Thread AnilKumar, Chimata
On Wed, Nov 14, 2012 at 10:31:42, AnilKumar, Chimata wrote: +Mark On Mon, Nov 12, 2012 at 15:17:13, AnilKumar, Chimata wrote: On Tue, Nov 06, 2012 at 22:26:54, Cousson, Benoit wrote: Hi Anil, On 11/06/2012 06:07 AM, AnilKumar, Chimata wrote: On Mon, Nov 05, 2012 at 22:13:25

RE: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-13 Thread AnilKumar, Chimata
On Wed, Nov 14, 2012 at 10:40:18, AnilKumar, Chimata wrote: On Wed, Nov 14, 2012 at 07:53:42, Mark Brown wrote: On Mon, Nov 05, 2012 at 05:59:36PM +0100, Benoit Cousson wrote: On 11/05/2012 10:42 AM, AnilKumar Ch wrote: +Optional properties: +- ti,pmic-shutdown-controller: Telling

RE: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-13 Thread AnilKumar, Chimata
On Wed, Nov 14, 2012 at 11:51:19, Mark Brown wrote: On Wed, Nov 14, 2012 at 06:11:45AM +, AnilKumar, Chimata wrote: From these two threads we can infer that this is handled in power_off sequence only. And this is feature of PMIC to go to shutdown mode nothing to be fixed in silicon

RE: [PATCH 2/4] rtc: OMAP: Add system pm_power_off to rtc driver

2012-11-12 Thread AnilKumar, Chimata
On Tue, Nov 06, 2012 at 22:26:54, Cousson, Benoit wrote: Hi Anil, On 11/06/2012 06:07 AM, AnilKumar, Chimata wrote: On Mon, Nov 05, 2012 at 22:13:25, Cousson, Benoit wrote: Hi Anil / Colin, On 11/05/2012 10:42 AM, AnilKumar Ch wrote: From: Colin Foe-Parker colin.foepar...@logicpd.com

RE: [PATCH 2/4] rtc: OMAP: Add system pm_power_off to rtc driver

2012-11-12 Thread AnilKumar, Chimata
On Tue, Nov 06, 2012 at 11:15:34, Bedia, Vaibhav wrote: On Mon, Nov 05, 2012 at 15:12:27, AnilKumar, Chimata wrote: [...] +#define SHUTDOWN_TIME_SEC 2 +#define SECS_IN_MIN60 +#define WAIT_AFTER (SECS_IN_MIN - SHUTDOWN_TIME_SEC

RE: [PATCH RESEND 00/10] ARM: dts: AM33XX: Add device tree data

2012-11-07 Thread AnilKumar, Chimata
On Tue, Nov 06, 2012 at 20:26:48, Cousson, Benoit wrote: Hi Anil, On 11/06/2012 02:48 PM, AnilKumar Ch wrote: Add device tree date for GPIO based various drivers matrix keypad, volume keys, push buttons and use leds accross three AM33XX devices viz EVM, BeagleBone and Starter Kit.

RE: [PATCH 00/10] ARM: dts: AM33XX: Add device tree data

2012-11-05 Thread AnilKumar, Chimata
On Mon, Nov 05, 2012 at 16:15:40, AnilKumar, Chimata wrote: Add device tree date for GPIO based various drivers matrix keypad, volume keys, push buttons and use leds accross three AM33XX devices viz EVM, BeagleBone and Starter Kit. To make it functional this series also adds pinctrl data

RE: [PATCH 00/10] ARM: dts: AM33XX: Add device tree data

2012-11-05 Thread AnilKumar, Chimata
On Mon, Nov 05, 2012 at 22:07:45, Cousson, Benoit wrote: Hi Anil, On 11/05/2012 02:46 PM, AnilKumar, Chimata wrote: On Mon, Nov 05, 2012 at 16:15:40, AnilKumar, Chimata wrote: Add device tree date for GPIO based various drivers matrix keypad, volume keys, push buttons and use leds

RE: [PATCH 2/4] rtc: OMAP: Add system pm_power_off to rtc driver

2012-11-05 Thread AnilKumar, Chimata
On Mon, Nov 05, 2012 at 22:13:25, Cousson, Benoit wrote: Hi Anil / Colin, On 11/05/2012 10:42 AM, AnilKumar Ch wrote: From: Colin Foe-Parker colin.foepar...@logicpd.com Add system power off control to rtc driver which is the in-charge of controlling the BeagleBone system power. The

RE: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-05 Thread AnilKumar, Chimata
On Mon, Nov 05, 2012 at 22:29:36, Cousson, Benoit wrote: + Mark On 11/05/2012 10:42 AM, AnilKumar Ch wrote: From: Colin Foe-Parker colin.foepar...@logicpd.com Set tps65217 PMIC status to OFF if power enable toggle is supported. Also adds platform data flag, which should be passed

RE: [PATCH v2] leds: leds-gpio: adopt pinctrl support

2012-11-04 Thread AnilKumar, Chimata
On Sun, Nov 04, 2012 at 23:07:44, Linus Walleij wrote: On Tue, Oct 30, 2012 at 3:12 PM, AnilKumar, Chimata anilku...@ti.com wrote: I completely understood this named modes, I have added named modes like this in am335x-xxx.dts files I do not understand how the pinctrl-single dts files

RE: [PATCH v2] leds: leds-gpio: adopt pinctrl support

2012-10-30 Thread AnilKumar, Chimata
On Wed, Oct 03, 2012 at 18:06:10, Linus Walleij wrote: On Wed, Oct 3, 2012 at 12:52 PM, AnilKumar, Chimata anilku...@ti.com wrote: On Tue, Oct 02, 2012 at 01:29:37, Linus Walleij wrote: This is what we're doing for ux500 and should be a good model. I have looked into this, but not seen

RE: [RFC PATCH v3 13/16] ARM: dts: add AM33XX MMC support

2012-10-29 Thread AnilKumar, Chimata
On Thu, Oct 18, 2012 at 18:56:52, Porter, Matt wrote: Adds AM33XX MMC support for am335x-bone and am335x-evm. Signed-off-by: Matt Porter mpor...@ti.com --- arch/arm/boot/dts/am335x-bone.dts |6 ++ arch/arm/boot/dts/am335x-evm.dts |6 ++ arch/arm/boot/dts/am33xx.dtsi |

RE: Multimachine uImage and cpufreq-cpu0/cpufreq-omap2 breakage

2012-10-19 Thread AnilKumar, Chimata
On Wed, Oct 17, 2012 at 15:48:22, Koen Kooi wrote: Hi, I'm currently building 3.7rc1 kernels meant to run on beagleboards (omap3), pandaboards (omap4) and beaglebones (am335x). At the moment I'm only testing it on beaglebone and I noticed a problem with the different cpufreq drivers

RE: Multimachine uImage and cpufreq-cpu0/cpufreq-omap2 breakage

2012-10-19 Thread AnilKumar, Chimata
On Fri, Oct 19, 2012 at 12:10:51, AnilKumar, Chimata wrote: On Wed, Oct 17, 2012 at 15:48:22, Koen Kooi wrote: Hi, I'm currently building 3.7rc1 kernels meant to run on beagleboards (omap3), pandaboards (omap4) and beaglebones (am335x). At the moment I'm only testing it on beaglebone

RE: [PATCH] ARM: dts: AM33XX: Add tsl2550 ambient light sensor DT data

2012-10-18 Thread AnilKumar, Chimata
+Grant, DTML On Thu, Oct 18, 2012 at 13:38:30, Cousson, Benoit wrote: Hi Anil, On 10/18/2012 07:46 AM, AnilKumar, Chimata wrote: On Fri, Sep 21, 2012 at 21:19:11, AnilKumar, Chimata wrote: Add tsl2550 ambient light sensor DT data to am335x-evm.dts. In AM335x EVM tsl2550 ambient light

RE: [PATCH] ARM: dts: AM33XX: Add tsl2550 ambient light sensor DT data

2012-10-17 Thread AnilKumar, Chimata
On Fri, Sep 21, 2012 at 21:19:11, AnilKumar, Chimata wrote: Add tsl2550 ambient light sensor DT data to am335x-evm.dts. In AM335x EVM tsl2550 ambient light sensor is connected to I2C2 bus. So this patch adds child node inside i2c2 node with i2c slave address. TAOS tsl2550 sensor with two

RE: [PATCH v2] leds: leds-gpio: adopt pinctrl support

2012-10-03 Thread AnilKumar, Chimata
On Tue, Oct 02, 2012 at 01:29:37, Linus Walleij wrote: On Mon, Oct 1, 2012 at 5:44 PM, Tony Lindgren t...@atomide.com wrote: OK that is typical pinctrl driver implementation work. I hope Tony can advice on this? I think we're best off to just stick to alternative named modes passed

RE: [PATCH v2] leds: leds-gpio: adopt pinctrl support

2012-10-01 Thread AnilKumar, Chimata
+Don Aisheng On Tue, Sep 11, 2012 at 01:10:12, Linus Walleij wrote: On Sat, Sep 1, 2012 at 10:16 AM, AnilKumar Ch anilku...@ti.com wrote: Adopt pinctrl support to leds-gpio driver based on leds-gpio device pointer, pinctrl driver configure SoC pins to GPIO mode according to definitions

RE: [PATCH RESEND 3/5] ARM: OMAP2+: AM33XX: Add clock entries to omap_clk data

2012-09-19 Thread AnilKumar, Chimata
On Thu, Sep 20, 2012 at 02:54:31, Paul Walmsley wrote: Hi On Thu, 20 Sep 2012, AnilKumar Ch wrote: Add AM335x cpu0 clock entry to the corresponding clock data file. This is useful in getting the correct mpu clock pointer to change the cpu frequency in cpufreq driver.

RE: [PATCH RESEND 0/5] ARM: dts: AM33XX: Add device tree data

2012-09-19 Thread AnilKumar, Chimata
On Thu, Sep 20, 2012 at 02:53:38, Cousson, Benoit wrote: + Paul Hi Anil, Thanks for the rebase / repost. I'll pulled the full series if Paul is OK with ARM: OMAP2+: AM33XX: Add clock entries to omap_clk data Thanks Benoit, Thanks AnilKumar -- To unsubscribe from this list: send

RE: [PATCH v3 4/4] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm

2012-09-18 Thread AnilKumar, Chimata
Hi Andrew, On Tue, Sep 18, 2012 at 04:05:59, Andrew Morton wrote: On Mon, 17 Sep 2012 12:53:22 +0530 AnilKumar Ch anilku...@ti.com wrote: Add lis331dlh device tree data to am335x-evm.dts. In AM335x EVM lis331dlh accelerometer is connected to I2C2 bus. So this patch change the status of

RE: [PATCH 2/2] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm

2012-09-14 Thread AnilKumar, Chimata
Hi Arnd, Thanks for the review, On Fri, Sep 14, 2012 at 13:56:06, Arnd Bergmann wrote: On Thursday 13 September 2012, AnilKumar Ch wrote: Add lis331dlh device tree data to am335x-evm.dts. In AM335x EVM lis331dlh accelerometer is connected to I2C2 bus. So this patch change the status to

RE: [PATCH 2/2] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm

2012-09-14 Thread AnilKumar, Chimata
+Daniel On Fri, Sep 14, 2012 at 15:58:37, Arnd Bergmann wrote: On Friday 14 September 2012, AnilKumar, Chimata wrote: On Fri, Sep 14, 2012 at 13:56:06, Arnd Bergmann wrote: On Thursday 13 September 2012, AnilKumar Ch wrote: Why do you put the reg property here Here I specified

RE: [PATCH 2/2] arm/dts: AM33XX: Add device tree OPP table

2012-09-13 Thread AnilKumar, Chimata
On Wed, Sep 12, 2012 at 22:51:55, Cousson, Benoit wrote: + Paul Hi Anil, On 08/31/2012 11:37 AM, AnilKumar Ch wrote: Add DT OPP table for AM33XX family of devices. This data is decoded by OF with of_init_opp_table() helper function. Also adds cpu0 supply name to the corresponding

RE: [PATCH 4/4] can: c_can: Add d_can suspend resume support

2012-09-13 Thread AnilKumar, Chimata
Marc, On Wed, Sep 12, 2012 at 18:32:53, Marc Kleine-Budde wrote: On 09/12/2012 02:48 PM, AnilKumar, Chimata wrote: Hi Marc, On Tue, Sep 04, 2012 at 12:57:18, Marc Kleine-Budde wrote: On 09/04/2012 08:14 AM, AnilKumar, Chimata wrote: Marc, Thanks for the comments, On Tue, Sep

RE: [PATCH] can: c_can: Move pm_runtime_enable/disable calls to common code

2012-09-13 Thread AnilKumar, Chimata
Marc, On Thu, Sep 13, 2012 at 13:18:07, Marc Kleine-Budde wrote: On 09/13/2012 09:28 AM, AnilKumar Ch wrote: Move pm_runtime_enable/disable calls to c_can.c driver. Current implementation is such that platform driver is doing pm_runtime enable/disable and core driver is doing

RE: [PATCH 4/4] can: c_can: Add d_can suspend resume support

2012-09-12 Thread AnilKumar, Chimata
Hi Marc, On Tue, Sep 04, 2012 at 12:57:18, Marc Kleine-Budde wrote: On 09/04/2012 08:14 AM, AnilKumar, Chimata wrote: Marc, Thanks for the comments, On Tue, Sep 04, 2012 at 01:31:35, Marc Kleine-Budde wrote: On 09/03/2012 01:52 PM, AnilKumar Ch wrote: Adds suspend resume support

RE: [PATCH v9] can: c_can: Add runtime PM support to Bosch C_CAN/D_CAN controller

2012-09-10 Thread AnilKumar, Chimata
Hi Kevin, On Sat, Sep 08, 2012 at 02:31:22, Kevin Hilman wrote: AnilKumar, Chimata anilku...@ti.com writes: Hi Kevin, On Fri, Sep 07, 2012 at 05:07:56, Kevin Hilman wrote: AnilKumar Ch anilku...@ti.com writes: Add Runtime PM support to C_CAN/D_CAN controller. The runtime PM

RE: [PATCH v3 4/4] arm/dts: Add tps65217 regulator DT data to am335x-bone.dts

2012-09-08 Thread AnilKumar, Chimata
On Wed, Sep 05, 2012 at 19:59:54, Koen Kooi wrote: Op 5 sep. 2012, om 16:24 heeft Matt Porter mpor...@ti.com het volgende geschreven: On Wed, Sep 05, 2012 at 03:29:30PM +0200, Koen Kooi wrote: Op 28 aug. 2012, om 07:34 heeft AnilKumar, Chimata anilku...@ti.com het volgende

RE: [PATCH v2] leds: leds-gpio: adopt pinctrl support

2012-09-07 Thread AnilKumar, Chimata
On Fri, Sep 07, 2012 at 05:39:35, Marek Vasut wrote: Dear Tony Lindgren, * Marek Vasut ma...@denx.de [120905 19:05]: Hi Tony, * Marek Vasut ma...@denx.de [120904 20:13]: Dear Bryan Wu, On Sat, Sep 1, 2012 at 4:16 PM, AnilKumar Ch anilku...@ti.com wrote:

RE: [PATCH v2 4/4] can: c_can: Add d_can suspend resume support

2012-09-07 Thread AnilKumar, Chimata
On Wed, Sep 05, 2012 at 16:42:44, AnilKumar, Chimata wrote: Adds suspend resume support to DCAN driver which enables DCAN power down mode bit (PDR). Then DCAN will ack the local power-down mode by setting PDA bit in STATUS register. Marc, I missed out this patch, I will remove raminit calls

RE: [PATCH v2] leds: leds-gpio: adopt pinctrl support

2012-09-07 Thread AnilKumar, Chimata
Hi Domenico, On Fri, Sep 07, 2012 at 14:18:39, Domenico Andreoli wrote: On Sat, Sep 1, 2012 at 10:16 AM, AnilKumar Ch anilku...@ti.com wrote: Adopt pinctrl support to leds-gpio driver based on leds-gpio device pointer, pinctrl driver configure SoC pins to GPIO mode according to definitions

RE: [PATCH v2] leds: leds-gpio: adopt pinctrl support

2012-09-07 Thread AnilKumar, Chimata
On Fri, Sep 07, 2012 at 16:32:51, Domenico Andreoli wrote: On Fri, Sep 07, 2012 at 09:10:50AM +, AnilKumar, Chimata wrote: Hi Domenico, Hi, On Fri, Sep 07, 2012 at 14:18:39, Domenico Andreoli wrote: On Sat, Sep 1, 2012 at 10:16 AM, AnilKumar Ch anilku...@ti.com wrote: Adopt

RE: [PATCH v2 0/4] can: c_can: Add suspend/resume and pinctrl support

2012-09-06 Thread AnilKumar, Chimata
On Thu, Sep 06, 2012 at 04:56:10, Tony Lindgren wrote: * Marc Kleine-Budde m...@pengutronix.de [120905 06:55]: On 09/05/2012 01:54 PM, Marc Kleine-Budde wrote: On 09/05/2012 01:12 PM, AnilKumar Ch wrote: Adds suspend/resume functionality of d_can driver along with d_can raminit support

RE: [PATCH v5 1/5] arm/dts: AM33XX: Add basic pinctrl device tree data

2012-09-06 Thread AnilKumar, Chimata
On Thu, Sep 06, 2012 at 05:02:05, Tony Lindgren wrote: * AnilKumar Ch anilku...@ti.com [120831 02:30]: Adds basic pinctrl device tree data for AM33XX family of devices. This patch is based on the pinctrl-single driver. Signed-off-by: AnilKumar Ch anilku...@ti.com ---

RE: [PATCH v2] of: Modify c_can binding documentation

2012-09-06 Thread AnilKumar, Chimata
Marc, On Tue, Sep 04, 2012 at 21:05:17, Stephen Warren wrote: On 09/02/2012 10:54 PM, AnilKumar Ch wrote: Modify c_can binding documentation according to recent review comments on device tree data addition patches. Signed-off-by: AnilKumar Ch anilku...@ti.com Reviewed-by: Stephen

RE: [PATCH v2] of: Modify c_can binding documentation

2012-09-06 Thread AnilKumar, Chimata
On Thu, Sep 06, 2012 at 15:00:34, Marc Kleine-Budde wrote: On 09/06/2012 11:26 AM, AnilKumar, Chimata wrote: Marc, On Tue, Sep 04, 2012 at 21:05:17, Stephen Warren wrote: On 09/02/2012 10:54 PM, AnilKumar Ch wrote: Modify c_can binding documentation according to recent review comments

RE: [PATCH v2] of: Modify c_can binding documentation

2012-09-06 Thread AnilKumar, Chimata
On Thu, Sep 06, 2012 at 15:12:29, Marc Kleine-Budde wrote: On 09/03/2012 06:54 AM, AnilKumar Ch wrote: Modify c_can binding documentation according to recent review comments on device tree data addition patches. Signed-off-by: AnilKumar Ch anilku...@ti.com --- Changes from v1:

RE: [PATCH 5/5] omap-serial: Request pins using pinctrl framework

2012-09-06 Thread AnilKumar, Chimata
Hi Tony, On Fri, Sep 07, 2012 at 00:28:32, Tony Lindgren wrote: Request pins using pinctrl framework. Only show a warning on error as some boards set the pins in the bootloader even if CONFIG_PINCTRL is enabled. Cc: linux-ser...@vger.kernel.org Cc: Greg Kroah-Hartman

RE: [PATCH v9] can: c_can: Add runtime PM support to Bosch C_CAN/D_CAN controller

2012-09-06 Thread AnilKumar, Chimata
Hi Kevin, On Fri, Sep 07, 2012 at 05:07:56, Kevin Hilman wrote: AnilKumar Ch anilku...@ti.com writes: Add Runtime PM support to C_CAN/D_CAN controller. The runtime PM APIs control clocks for C_CAN/D_CAN IP and prevent access to the register of C_CAN/D_CAN IP when clock is turned off.

RE: [PATCH v7 0/3] arm/dts: Add device tree data for AM33XX devices

2012-09-06 Thread AnilKumar, Chimata
On Thu, Sep 06, 2012 at 15:08:21, AnilKumar, Chimata wrote: Add pinctrl and d_can device tree data to AM33XX family of devices. First two patches add support for pinctrl DT data and third one adds dcan DT data. Reason behind combining these patches is to apply cleanly on linux-omap tree

RE: [PATCH v2 1/8] ARM/dts: OMAP2: Add McBSP entries for OMAP2420 and OMAP2430 SoC

2012-09-06 Thread AnilKumar, Chimata
On Wed, Sep 05, 2012 at 20:11:11, Hiremath, Vaibhav wrote: On Wed, Sep 05, 2012 at 19:01:55, Cousson, Benoit wrote: Hi Vaibhav, On 09/05/2012 11:15 AM, Hiremath, Vaibhav wrote: On Wed, Sep 05, 2012 at 13:53:58, Ujfalusi, Peter wrote: Hi, On 09/05/2012 09:11 AM, Hiremath,

RE: [PATCH 4/4] can: c_can: Add d_can suspend resume support

2012-09-04 Thread AnilKumar, Chimata
Marc, Thanks for the comments, On Tue, Sep 04, 2012 at 01:31:35, Marc Kleine-Budde wrote: On 09/03/2012 01:52 PM, AnilKumar Ch wrote: Adds suspend resume support to DCAN driver which enables DCAN power down mode bit (PDR). Then DCAN will ack the local power-down mode by setting PDA bit in

RE: [PATCH 2/4] can: c_can: Add d_can raminit support

2012-09-04 Thread AnilKumar, Chimata
Hi Marc, On Tue, Sep 04, 2012 at 02:09:15, Marc Kleine-Budde wrote: On 09/03/2012 01:52 PM, AnilKumar Ch wrote: Add D_CAN raminit support to C_CAN driver to enable D_CAN RAM. DCAN RAM holds all the message objects during transmission or receiving of data. This

RE: [PATCH 1/4] can: c_can: Adopt pinctrl support

2012-09-04 Thread AnilKumar, Chimata
Hi Marc, On Tue, Sep 04, 2012 at 02:12:04, Marc Kleine-Budde wrote: On 09/03/2012 01:52 PM, AnilKumar Ch wrote: Adopt pinctrl support to c_can driver based on c_can device pointer, pinctrl driver configure SoC pins to d_can mode according to definitions provided in .dts file. In

RE: [PATCH 3/4] ARM: AM33XX: board-generic: Add of_dev_auxdata to pass d_can raminit

2012-09-04 Thread AnilKumar, Chimata
On Tue, Sep 04, 2012 at 01:41:14, Marc Kleine-Budde wrote: On 09/03/2012 01:52 PM, AnilKumar Ch wrote: Add of_dev_auxdata to pass d_can raminit callback APIs to initialize d_can RAM. D_CAN RAM initialization bits are present in CONTROL module address space, which can be accessed by platform

RE: [PATCH 1/4] can: c_can: Adopt pinctrl support

2012-09-04 Thread AnilKumar, Chimata
On Tue, Sep 04, 2012 at 13:12:17, Marc Kleine-Budde wrote: On 09/04/2012 08:14 AM, AnilKumar, Chimata wrote: Hi Marc, On Tue, Sep 04, 2012 at 02:12:04, Marc Kleine-Budde wrote: On 09/03/2012 01:52 PM, AnilKumar Ch wrote: Adopt pinctrl support to c_can driver based on c_can device

RE: [PATCH v9] can: c_can: Add runtime PM support to Bosch C_CAN/D_CAN controller

2012-09-03 Thread AnilKumar, Chimata
Marc, On Mon, Sep 03, 2012 at 14:22:22, Marc Kleine-Budde wrote: On 08/20/2012 01:20 PM, AnilKumar Ch wrote: Add Runtime PM support to C_CAN/D_CAN controller. The runtime PM APIs control clocks for C_CAN/D_CAN IP and prevent access to the register of C_CAN/D_CAN IP when clock is turned

RE: [PATCH RESEND v4 2/3] arm/dts: AM33XX: Configure pinmuxs for user leds control on Bone

2012-09-03 Thread AnilKumar, Chimata
Hi Koen, On Sat, Sep 01, 2012 at 18:21:10, AnilKumar, Chimata wrote: Hi Koen, On Sat, Sep 01, 2012 at 16:17:35, Koen Kooi wrote: Op 1 sep. 2012 om 09:01 heeft AnilKumar, Chimata anilku...@ti.com het volgende geschreven: Hi Koen, On Fri, Aug 31, 2012 at 21:23:18, Koen

RE: [PATCH] ARM: OMAP2+: select PINCTRL in Kconfig

2012-09-03 Thread AnilKumar, Chimata
Hi Tony, On Mon, Aug 27, 2012 at 11:30:44, AnilKumar, Chimata wrote: Select PINCTRL in Kconfig under Typical OMAP configuration, this is required to add pinctrl driver to omap2+ family of devices. Signed-off-by: AnilKumar Ch anilku...@ti.com --- arch/arm/mach-omap2/Kconfig |1 + 1

RE: [PATCH RESEND v4 2/3] arm/dts: AM33XX: Configure pinmuxs for user leds control on Bone

2012-09-01 Thread AnilKumar, Chimata
Hi Koen, On Fri, Aug 31, 2012 at 21:23:18, Koen Kooi wrote: Op 30 aug. 2012, om 22:35 heeft Tony Lindgren t...@atomide.com het volgende geschreven: * AnilKumar Ch anilku...@ti.com [120828 01:11]: Adds GPIO pinctrl nodes to am3358_pinmux master node to control user leds (USR0, USR1,

RE: [PATCH 5/5] of: Modify c_can binding documentation

2012-09-01 Thread AnilKumar, Chimata
Hi Marc, On Fri, Aug 31, 2012 at 14:59:21, AnilKumar, Chimata wrote: Modify c_can binding documentation according to recent review comments on device tree data addition patches. Signed-off-by: AnilKumar Ch anilku...@ti.com --- .../devicetree/bindings/net/can/c_can.txt | 25

RE: [PATCH RESEND v4 2/3] arm/dts: AM33XX: Configure pinmuxs for user leds control on Bone

2012-09-01 Thread AnilKumar, Chimata
Hi Koen, On Sat, Sep 01, 2012 at 16:17:35, Koen Kooi wrote: Op 1 sep. 2012 om 09:01 heeft AnilKumar, Chimata anilku...@ti.com het volgende geschreven: Hi Koen, On Fri, Aug 31, 2012 at 21:23:18, Koen Kooi wrote: Op 30 aug. 2012, om 22:35 heeft Tony Lindgren t...@atomide.com

RE: [PATCH 4/5] leds: leds-gpio: adopt pinctrl support

2012-08-31 Thread AnilKumar, Chimata
Hi Tony, Thanks for the review, On Fri, Aug 31, 2012 at 21:34:04, Tony Lindgren wrote: * AnilKumar Ch anilku...@ti.com [120831 02:30]: Adopt pinctrl support to leds-gpio driver, based on the device pointer (leds-gpio) pinctrl driver configure SoC pins to GPIO mode. Signed-off-by:

RE: [PATCH v4 2/4] mfd: omap: control: core system control driver

2012-08-29 Thread AnilKumar, Chimata
Hi Konstantin, On Wed, Jul 25, 2012 at 16:35:16, Konstantin Baydarov wrote: This patch introduces a MFD core device driver for OMAP system control module. The control module allows software control of various static modes supported by the device. It is composed of two control submodules:

RE: [PATCH v3 4/4] arm/dts: Add tps65217 regulator DT data to am335x-bone.dts

2012-08-27 Thread AnilKumar, Chimata
Hi Koen, On Fri, Aug 24, 2012 at 13:32:17, Koen Kooi wrote: Op 24 aug. 2012, om 09:56 heeft Koen Kooi k...@dominion.thruhere.net het volgende geschreven: Op 24 aug. 2012, om 09:26 heeft AnilKumar, Chimata anilku...@ti.com het volgende geschreven: Hi Koen, On Fri, Aug 24

RE: [PATCH v9] can: c_can: Add runtime PM support to Bosch C_CAN/D_CAN controller

2012-08-26 Thread AnilKumar, Chimata
Hi Marc, On Mon, Aug 20, 2012 at 16:50:54, AnilKumar, Chimata wrote: Add Runtime PM support to C_CAN/D_CAN controller. The runtime PM APIs control clocks for C_CAN/D_CAN IP and prevent access to the register of C_CAN/D_CAN IP when clock is turned off. Signed-off-by: AnilKumar Ch anilku

RE: [PATCH v3 4/4] arm/dts: Add tps65217 regulator DT data to am335x-bone.dts

2012-08-24 Thread AnilKumar, Chimata
Hi Koen, On Fri, Aug 24, 2012 at 11:58:34, Koen Kooi wrote: Op 24 aug. 2012, om 07:50 heeft AnilKumar, Chimata anilku...@ti.com het volgende geschreven: Hi Koen, On Thu, Aug 23, 2012 at 19:43:48, Koen Kooi wrote: Op 21 aug. 2012, om 13:17 heeft AnilKumar Ch anilku...@ti.com het

RE: [PATCH v3] backlight: Add TPS65217 WLED driver

2012-08-23 Thread AnilKumar, Chimata
Hi Kaehlcke, On Thu, Aug 23, 2012 at 02:34:19, Matthias Kaehlcke wrote: The TPS65217 chip contains a boost converter and current sinks which can be used to drive LEDs for use as backlights. Expose this functionality via the backlight API. Tested on an AM335x based custom board with a single

RE: [PATCH v3 4/4] arm/dts: Add tps65217 regulator DT data to am335x-bone.dts

2012-08-23 Thread AnilKumar, Chimata
Hi Koen, On Thu, Aug 23, 2012 at 19:43:48, Koen Kooi wrote: Op 21 aug. 2012, om 13:17 heeft AnilKumar Ch anilku...@ti.com het volgende geschreven: Add tps65217 regulator device tree data to AM335x-Bone by adding regulator consumers with tightened constraints and regulator-name.

RE: [PATCH v2 3/4] arm/dts: Add tps65910 regulator DT data to am335x-evm.dts

2012-08-21 Thread AnilKumar, Chimata
Hi Mark, On Tue, Aug 21, 2012 at 01:37:15, Mark Brown wrote: On Mon, Aug 20, 2012 at 06:27:01AM +, AnilKumar, Chimata wrote: On Thu, Aug 16, 2012 at 19:30:56, Mark Brown wrote: Why does this mean you need multiple regulators? A single regulator can of course supply multiple

RE: [PATCH v2 3/4] arm/dts: Add tps65910 regulator DT data to am335x-evm.dts

2012-08-20 Thread AnilKumar, Chimata
Hi Mark, On Thu, Aug 16, 2012 at 19:30:56, Mark Brown wrote: On Thu, Aug 16, 2012 at 01:22:27PM +, AnilKumar, Chimata wrote: But problem here is single input supply battery/main is not sufficient. What makes you say this? pmic-desc[i].supply_name = info-vin_name

RE: [PATCH v8] can: c_can: Add runtime PM support to Bosch C_CAN/D_CAN controller

2012-08-20 Thread AnilKumar, Chimata
On Mon, Aug 20, 2012 at 16:27:53, Marc Kleine-Budde wrote: On 08/20/2012 12:41 PM, Marc Kleine-Budde wrote: On 08/20/2012 10:45 AM, AnilKumar Ch wrote: Add Runtime PM support to C_CAN/D_CAN controller. The runtime PM APIs control clocks for C_CAN/D_CAN IP and prevent access to the

RE: [PATCH v8] can: c_can: Add runtime PM support to Bosch C_CAN/D_CAN controller

2012-08-20 Thread AnilKumar, Chimata
On Mon, Aug 20, 2012 at 16:33:43, AnilKumar, Chimata wrote: On Mon, Aug 20, 2012 at 16:27:53, Marc Kleine-Budde wrote: On 08/20/2012 12:41 PM, Marc Kleine-Budde wrote: On 08/20/2012 10:45 AM, AnilKumar Ch wrote: Add Runtime PM support to C_CAN/D_CAN controller. The runtime PM APIs

RE: [PATCH v7] can: c_can: Add runtime PM support to Bosch C_CAN/D_CAN controller

2012-08-19 Thread AnilKumar, Chimata
Marc, On Sun, Aug 19, 2012 at 01:03:37, Marc Kleine-Budde wrote: On 08/13/2012 04:06 PM, AnilKumar Ch wrote: Add Runtime PM support to C_CAN/D_CAN controller. The runtime PM APIs control clocks for C_CAN/D_CAN IP and prevent access to the register of C_CAN/D_CAN IP when clock is turned

RE: [PATCH v2 3/4] arm/dts: Add tps65910 regulator DT data to am335x-evm.dts

2012-08-16 Thread AnilKumar, Chimata
Mark, On Wed, Aug 15, 2012 at 22:24:32, Mark Brown wrote: On Wed, Aug 15, 2012 at 04:47:02PM +, AnilKumar, Chimata wrote: On Wed, Aug 15, 2012 at 18:23:39, Mark Brown wrote: If you have all these unrelated supplies in the system then your device tree should accurately reflect

  1   2   >