Re: [PATCH 2/2 v3] net/smsc911x: Add regulator support

2011-10-28 Thread Sascha Hauer
Hi Linus, On Thu, Oct 27, 2011 at 02:48:11PM +0200, Linus Walleij wrote: From: Robert Marklund robert.markl...@stericsson.com Add some basic regulator support for the power pins, as needed by the ST-Ericsson Snowball platform that powers up the SMSC911 chip using an external regulator.

Re: [PATCH 2/2 v3] net/smsc911x: Add regulator support

2011-10-28 Thread Mike Frysinger
On Fri, Oct 28, 2011 at 22:33, Sascha Hauer wrote: On Thu, Oct 27, 2011 at 02:48:11PM +0200, Linus Walleij wrote: +/* + * Request or free resources, currently just regulators. + * + * The SMSC911x has two power pins: vddvario and vdd33a, in designs where + * these are not always-on we need

[PATCH 2/2 v3] net/smsc911x: Add regulator support

2011-10-27 Thread Linus Walleij
From: Robert Marklund robert.markl...@stericsson.com Add some basic regulator support for the power pins, as needed by the ST-Ericsson Snowball platform that powers up the SMSC911 chip using an external regulator. Platforms that use regulators and the smsc911x and have no defined regulator for

Re: [PATCH 2/2 v3] net/smsc911x: Add regulator support

2011-10-27 Thread Mike Frysinger
On Thu, Oct 27, 2011 at 14:48, Linus Walleij wrote: Platforms that use regulators and the smsc911x and have no defined regulator for the smsc911x and claim complete regulator constraints with no dummy regulators will need to provide it, for example using a fixed voltage regulator. It appears

Re: [PATCH 2/2 v3] net/smsc911x: Add regulator support

2011-10-27 Thread Mark Brown
On Thu, Oct 27, 2011 at 03:21:47PM +0200, Mike Frysinger wrote: my gut reaction: smsc911x is working just fine without regulator support for many people, so why do we suddenly need to make it a requirement ? this is a fairly small amount of code, so adding a smsc911x Kconfig symbol to

Re: [PATCH 2/2 v3] net/smsc911x: Add regulator support

2011-10-27 Thread Mike Frysinger
On Thu, Oct 27, 2011 at 17:46, Mark Brown wrote: On Thu, Oct 27, 2011 at 03:21:47PM +0200, Mike Frysinger wrote: my gut reaction: smsc911x is working just fine without regulator support for many people, so why do we suddenly need to make it a requirement ?  this is a fairly small amount of

Re: [PATCH 2/2 v3] net/smsc911x: Add regulator support

2011-10-27 Thread Mark Brown
On Thu, Oct 27, 2011 at 10:59:14PM +0200, Mike Frysinger wrote: i saw that !CONFIG_REGULATOR works great. my concern is that these boards don't define any regulators for smsc resources, so if CONFIG_REGULATOR is enabled to test out unrelated daughter cards, i don't want the network driver

Re: [PATCH 2/2 v3] net/smsc911x: Add regulator support

2011-10-27 Thread Mike Frysinger
On Thu, Oct 27, 2011 at 23:42, Mark Brown wrote: On Thu, Oct 27, 2011 at 10:59:14PM +0200, Mike Frysinger wrote: i saw that !CONFIG_REGULATOR works great.  my concern is that these boards don't define any regulators for smsc resources, so if CONFIG_REGULATOR is enabled to test out unrelated