Re: [PATCH v4 1/3] ARM: OMAP: Beagle: revision detection

2010-08-18 Thread Jarkko Nikula
On Tue, 17 Aug 2010 15:10:35 -0500 Robert Nelson robertcnel...@gmail.com wrote: Do you have any preference if the gpio allocation fails? Right now it'll just halts, we could just return as Cx based board.. Which would be the route the current kernel would take without this patch... I think

Re: [PATCH v4 1/3] ARM: OMAP: Beagle: revision detection

2010-08-17 Thread Tony Lindgren
* Robert Nelson robertcnel...@gmail.com [100816 17:29]: Due to the omap3530 ES3.0 Silicon being used on both the B5/B6 and C1/2/3 Beagle we can't use the cpu_is_omap34xx() routines to differentiate the Beagle Boards. However gpio pins 171,172,173 where setup for this prupose, so lets use

Re: [PATCH v4 1/3] ARM: OMAP: Beagle: revision detection

2010-08-17 Thread Robert Nelson
On Tue, Aug 17, 2010 at 12:48 AM, Jarkko Nikula jhnik...@gmail.com wrote: Hi On Mon, 16 Aug 2010 09:36:41 -0500 Robert Nelson robertcnel...@gmail.com wrote: +u8 get_omap3_beagle_rev(void) +{ +     return omap3_beagle_version; +} + +static void __init omap3_beagle_get_revision(void) +{

Re: [PATCH v4 1/3] ARM: OMAP: Beagle: revision detection

2010-08-17 Thread Robert Nelson
On Tue, Aug 17, 2010 at 1:10 AM, Tony Lindgren t...@atomide.com wrote: * Robert Nelson robertcnel...@gmail.com [100816 17:29]: Due to the omap3530 ES3.0 Silicon being used on both the B5/B6 and C1/2/3 Beagle we can't use the cpu_is_omap34xx() routines to differentiate the Beagle Boards.

[PATCH v4 1/3] ARM: OMAP: Beagle: revision detection

2010-08-16 Thread Robert Nelson
Due to the omap3530 ES3.0 Silicon being used on both the B5/B6 and C1/2/3 Beagle we can't use the cpu_is_omap34xx() routines to differentiate the Beagle Boards. However gpio pins 171,172,173 where setup for this prupose, so lets use them. Changes: for older U-Boot's, use omap_mux_init_gpio()

Re: [PATCH v4 1/3] ARM: OMAP: Beagle: revision detection

2010-08-16 Thread Jarkko Nikula
Hi On Mon, 16 Aug 2010 09:36:41 -0500 Robert Nelson robertcnel...@gmail.com wrote: +u8 get_omap3_beagle_rev(void) +{ + return omap3_beagle_version; +} + +static void __init omap3_beagle_get_revision(void) +{ + int ret; + u16 beagle_rev = 0; + + omap_mux_init_gpio(171,