On Fri, 2009-07-10 at 01:51 +0200, ext Guzman Lugo, Fernando wrote:
Thanks for the patch, it only has indentation problems, this is the
checkpatch output:
WARNING: suspect code indent for conditional statements (8, 12)
#34: FILE: drivers/dsp/bridge/pmgr/wcd.c:152:
+ if
Phil,
-Original Message-
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Phil Carmody
Sent: Tuesday, July 14, 2009 6:03 AM
On Fri, 2009-07-10 at 01:51 +0200, ext Guzman Lugo, Fernando wrote:
Thanks for the patch, it only has
ext Menon, Nishanth wrote:
Phil,
-Original Message-
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Phil Carmody
Sent: Tuesday, July 14, 2009 6:03 AM
On Fri, 2009-07-10 at 01:51 +0200, ext Guzman Lugo, Fernando wrote:
Thanks for the
On Tue, 2009-07-14 at 13:05 +0200, ext Menon, Nishanth wrote:
Phil,
-Original Message-
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Phil Carmody
Sent: Tuesday, July 14, 2009 6:03 AM
On Fri, 2009-07-10 at 01:51 +0200, ext
From: Carmody Phil.2 (EXT-Ixonos/Helsinki) ext-phil.2.carm...@nokia.com
Subject: RE: [PATCH 1/4] DSPBRIDGE: Fix macros that break when inside an if/else
Date: Tue, 14 Jul 2009 13:20:30 +0200
On Tue, 2009-07-14 at 13:05 +0200, ext Menon, Nishanth wrote:
Phil,
-Original Message
On Tue, 2009-07-14 at 14:30 +0200, Doyu Hiroshi (Nokia-D/Helsinki)
wrote:
From: Carmody Phil.2 (EXT-Ixonos/Helsinki) ext-phil.2.carm...@nokia.com
Subject: RE: [PATCH 1/4] DSPBRIDGE: Fix macros that break when inside an
if/else
Date: Tue, 14 Jul 2009 13:20:30 +0200
On Tue, 2009-07-14 at 13
From: Carmody Phil.2 (EXT-Ixonos/Helsinki) ext-phil.2.carm...@nokia.com
Subject: Re: [PATCH 1/4] DSPBRIDGE: Fix macros that break when inside an if/else
Date: Tue, 14 Jul 2009 15:17:25 +0200
[...]
I am not sure if these copy_from_user() wrapping are practically
useful or not. It may be enough
Thanks for the patch, it only has indentation problems, this is the checkpatch
output:
WARNING: suspect code indent for conditional statements (8, 12)
#34: FILE: drivers/dsp/bridge/pmgr/wcd.c:152:
+ if (DSP_SUCCEEDED(status)) {\
+ if (unlikely((src) == NULL)
