RE: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Gopinath, Thara
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Kevin Hilman Sent: Thursday, September 16, 2010 3:27 AM To: linux-omap@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Subject: [PATCH 1/4] OMAP: introduce OPP layer

RE: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Menon, Nishanth
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Gopinath, Thara [...] diff --git a/arch/arm/plat-omap/include/plat/opp.h b/arch/arm/plat- omap/include/plat/opp.h new file mode 100644 index 000..997b56e ---

RE: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Gopinath, Thara
-Original Message- From: Menon, Nishanth Sent: Thursday, September 16, 2010 4:02 PM To: Gopinath, Thara; Kevin Hilman; linux-omap@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Subject: RE: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs -Original Message

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Linus Walleij
2010/9/15 Kevin Hilman khil...@deeprootsystems.com: OMAP SOCs have a standard set of tuples consisting of frequency and voltage pairs that the device will support per voltage domain.  These are called Operating Performance Points or OPPs. (...) This introduces a common handling OPP mechanism

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Nishanth Menon
Linus Walleij had written, on 09/16/2010 07:19 AM, the following: 2010/9/15 Kevin Hilman khil...@deeprootsystems.com: OMAP SOCs have a standard set of tuples consisting of frequency and voltage pairs that the device will support per voltage domain. These are called Operating Performance

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Linus Walleij
Nishanth Menon wrote: Linus Walleij had written, on 09/16/2010 07:19 AM, the following: 2010/9/15 Kevin Hilman khil...@deeprootsystems.com: OMAP SOCs have a standard set of tuples consisting of frequency and voltage pairs that the device will support per voltage domain. These are called

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Roger Quadros
Nishant, Since you are anyways re-sending this you might as well fix these nits. On 09/16/2010 12:56 AM, ext Kevin Hilman wrote: From: Nishanth Menonn...@ti.com diff --git a/arch/arm/plat-omap/opp.c b/arch/arm/plat-omap/opp.c new file mode 100644 index 000..17f93b2 --- /dev/null +++

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Nishanth Menon
Roger Quadros had written, on 09/16/2010 08:54 AM, the following: Since you are anyways re-sending this you might as well fix these nits. thanks for reviewing.. [..] diff --git a/arch/arm/plat-omap/opp.c b/arch/arm/plat-omap/opp.c new file mode 100644 index 000..17f93b2 --- /dev/null

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Nishanth Menon
Roger Quadros had written, on 09/16/2010 09:20 AM, the following: [...] +/** + * opp_get_freq() - Gets the frequency corresponding to an opp + * @opp: opp for which frequency has to be returned for + * + * Return frequency in hertz corresponding to the opp, else + * return 0 + */ +unsigned

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Kevin Hilman
Hi Linus, Linus Walleij linus.wall...@stericsson.com writes: 2010/9/15 Kevin Hilman khil...@deeprootsystems.com: OMAP SOCs have a standard set of tuples consisting of frequency and voltage pairs that the device will support per voltage domain.  These are called Operating Performance Points

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Nishanth Menon
Kevin Hilman had written, on 09/16/2010 10:08 AM, the following: [..] more than that you name some functions omap_*, and how hard would it be to put it under arch/arm/common/*.c arch/arm/include/asm/*.h Possible even higher up in the directory hiearchy in include/linux/opp.h for the header and

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Kevin Hilman had written, on 09/16/2010 10:08 AM, the following: [..] more than that you name some functions omap_*, and how hard would it be to put it under arch/arm/common/*.c arch/arm/include/asm/*.h Possible even higher up in the directory hiearchy

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Linus Walleij
2010/9/16 Kevin Hilman khil...@deeprootsystems.com: lib/opp/* seems more appropriate to me with the header at include/linux/opp.h as Linus suggested. I second this. I would love to see the generic OPP stuff in lib/opp/* so we put it in the right place from the beginning and don't have to

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Nishanth Menon
Linus Walleij had written, on 09/16/2010 12:07 PM, the following: 2010/9/16 Kevin Hilman khil...@deeprootsystems.com: lib/opp/* seems more appropriate to me with the header at include/linux/opp.h as Linus suggested. I second this. I would love to see the generic OPP stuff in lib/opp/* so we

RE: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Shilimkar, Santosh
Subject: Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs Linus Walleij had written, on 09/16/2010 12:07 PM, the following: 2010/9/16 Kevin Hilman khil...@deeprootsystems.com: lib/opp/* seems more appropriate to me with the header at include/linux/opp.h as Linus suggested

Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Kevin Hilman
@vger.kernel.org; linux-arm- ker...@lists.infradead.org Subject: Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs Linus Walleij had written, on 09/16/2010 12:07 PM, the following: 2010/9/16 Kevin Hilman khil...@deeprootsystems.com: lib/opp/* seems more appropriate to me