Re: [PATCH 2/4] mfd: twl-core: switch over to defines in twl.h

2010-08-21 Thread Felipe Balbi
On Sat, Aug 21, 2010 at 12:11:46AM +0200, ext Samuel Ortiz wrote: Should I expect a new patch then ? it's patch 1/4. I already replied to that patch with the new version: https://patchwork.kernel.org/patch/120084/ -- balbi DefectiveByDesign.org -- To unsubscribe from this list: send the

Re: [PATCH 2/4] mfd: twl-core: switch over to defines in twl.h

2010-08-20 Thread Samuel Ortiz
Hi Felipe, On Wed, Aug 18, 2010 at 10:16:19AM +0300, Felipe Balbi wrote: Hi, On Wed, Aug 18, 2010 at 09:10:22AM +0200, Balbi Felipe (Nokia-MS/Helsinki) wrote: On Wed, Aug 18, 2010 at 09:03:44AM +0200, ext Gopinath, Thara wrote: No I am not talking about the key values. I was talking about

RE: [PATCH 2/4] mfd: twl-core: switch over to defines in twl.h

2010-08-18 Thread Gopinath, Thara
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of felipe.ba...@nokia.com Sent: Wednesday, August 18, 2010 11:50 AM To: Samuel Ortiz Cc: linux-ker...@vger.kernel.org; linux-omap@vger.kernel.org; Tony Lindgren; Andrew Morton;

RE: [PATCH 2/4] mfd: twl-core: switch over to defines in twl.h

2010-08-18 Thread Gopinath, Thara
: [PATCH 2/4] mfd: twl-core: switch over to defines in twl.h On Wed, Aug 18, 2010 at 08:32:57AM +0200, ext Gopinath, Thara wrote: R_PROTECT_KEY offset is 0xE where as the new TWL4030_PM_MASTER_PROTECT_KEY is defined as 0xd. I have not checked the trm to see which is correct. But you can use either

Re: [PATCH 2/4] mfd: twl-core: switch over to defines in twl.h

2010-08-18 Thread Felipe Balbi
On Wed, Aug 18, 2010 at 08:32:57AM +0200, ext Gopinath, Thara wrote: R_PROTECT_KEY offset is 0xE where as the new TWL4030_PM_MASTER_PROTECT_KEY is defined as 0xd. I have not checked the trm to see which is correct. But you can use either 0xc0|0x0c or 0xce|0xec, both will work are unlock keys.

RE: [PATCH 2/4] mfd: twl-core: switch over to defines in twl.h

2010-08-18 Thread Gopinath, Thara
-Original Message- From: Gopinath, Thara Sent: Wednesday, August 18, 2010 12:33 PM To: 'felipe.ba...@nokia.com' Cc: Samuel Ortiz; linux-ker...@vger.kernel.org; linux-omap@vger.kernel.org; Tony Lindgren; Andrew Morton Subject: RE: [PATCH 2/4] mfd: twl-core: switch over to defines

Re: [PATCH 2/4] mfd: twl-core: switch over to defines in twl.h

2010-08-18 Thread Felipe Balbi
Hi, On Wed, Aug 18, 2010 at 09:03:44AM +0200, ext Gopinath, Thara wrote: No I am not talking about the key values. I was talking about the register offset for TWL4030_PM_MASTER_PROTECT_KEY. My question is, is it ok for it to be 0xd or 0xe. Earlier we were using 0xd and in the new

Re: [PATCH 2/4] mfd: twl-core: switch over to defines in twl.h

2010-08-18 Thread Felipe Balbi
Hi, On Wed, Aug 18, 2010 at 09:10:22AM +0200, Balbi Felipe (Nokia-MS/Helsinki) wrote: On Wed, Aug 18, 2010 at 09:03:44AM +0200, ext Gopinath, Thara wrote: No I am not talking about the key values. I was talking about the register offset for TWL4030_PM_MASTER_PROTECT_KEY. My question is, is

RE: [PATCH 2/4] mfd: twl-core: switch over to defines in twl.h

2010-08-18 Thread Gopinath, Thara
: [PATCH 2/4] mfd: twl-core: switch over to defines in twl.h Hi, On Wed, Aug 18, 2010 at 09:10:22AM +0200, Balbi Felipe (Nokia-MS/Helsinki) wrote: On Wed, Aug 18, 2010 at 09:03:44AM +0200, ext Gopinath, Thara wrote: No I am not talking about the key values. I was talking about the register offset