Re: [PATCH] ARM: OMAP2: fix mailbox init code

2012-02-23 Thread Ramirez Luna, Omar
Hi, On Thu, Feb 23, 2012 at 3:18 AM, Bedia, Vaibhav vaibhav.be...@ti.com wrote: On Thu, Feb 23, 2012 at 14:23:35, Ohad Ben-Cohen wrote: [...] Which happens on CONFIG_ARCH_OMAP2 !CONFIG_SOC_OMAP2420, due to missing omap2_mboxes declaration. [...] -struct omap_mbox *omap2_mboxes[] = {

Re: [PATCH] ARM: OMAP2: fix mailbox init code

2012-02-23 Thread Ohad Ben-Cohen
On Thu, Feb 23, 2012 at 11:18 AM, Bedia, Vaibhav vaibhav.be...@ti.com wrote: Instead of adding more #ifs can they be completely removed please? Care to propose something specific (which is viable for the -rc cycle) ? Thanks, Ohad. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] ARM: OMAP2: fix mailbox init code

2012-02-23 Thread Tony Lindgren
* Ohad Ben-Cohen o...@wizery.com [120223 08:32]: On Thu, Feb 23, 2012 at 11:18 AM, Bedia, Vaibhav vaibhav.be...@ti.com wrote: Instead of adding more #ifs can they be completely removed please? Care to propose something specific (which is viable for the -rc cycle) ? This is pretty much the

RE: [PATCH] ARM: OMAP2: fix mailbox init code

2012-02-23 Thread Bedia, Vaibhav
On Thu, Feb 23, 2012 at 14:23:35, Ohad Ben-Cohen wrote: [...] Which happens on CONFIG_ARCH_OMAP2 !CONFIG_SOC_OMAP2420, due to missing omap2_mboxes declaration. [...] -struct omap_mbox *omap2_mboxes[] = { mbox_dsp_info, mbox_iva_info, NULL }; +#ifdef CONFIG_ARCH_OMAP2 +struct omap_mbox