Re: [PATCH v2] staging: tidspbridge: protect dmm_map properly

2010-12-28 Thread Felipe Contreras
On Tue, Dec 28, 2010 at 8:33 AM, Ohad Ben-Cohen o...@wizery.com wrote: On Mon, Dec 27, 2010 at 3:55 PM, Felipe Contreras felipe.contre...@nokia.com wrote: So, effectively, serializing the proc_begin_dma() and proc_end_dma() would not affect anyone negatively for the time being. You can never

Re: [PATCH v2] staging: tidspbridge: protect dmm_map properly

2010-12-28 Thread Ohad Ben-Cohen
On Tue, Dec 28, 2010 at 12:36 PM, Felipe Contreras felipe.contre...@gmail.com wrote: You can never really tell who is using the kernel (or will be using this kernel version), how and under which workload. No, but it's better to address real issues rather than hypothetical. Right. and both

Re: [PATCH 1/5] ASoC: DMIC: Adding the OMAP DMIC driver

2010-12-28 Thread Felipe Balbi
Hi, On Mon, Dec 27, 2010 at 10:17:02PM -0600, David Lambert wrote: This patch adds support for the OMAP4 digital microphone DAI. This DAI can support support recording in 2, 4, or 6 channels When provided with a 19.2Mhz functional clock, can encode at 96Khz or 192Khz (all channels must have

Re: [PATCH 5/5] MAP4: DMIC: Add DMIC codec platform devices

2010-12-28 Thread Felipe Balbi
Hi, $SUBJECT should read OMAP4 instead of MAP4 On Mon, Dec 27, 2010 at 10:17:06PM -0600, David Lambert wrote: This creates the DMIC codec platform devices. The platform devices create an instance of the driver during boot up. Signed-off-by: David Lambert dlamb...@ti.com is this a virtual

Re: [PATCH 3/5] ASoC: DMIC: Adding OMAP DMIC driver to build

2010-12-28 Thread Mark Brown
On Mon, Dec 27, 2010 at 10:17:04PM -0600, David Lambert wrote: Adds the OMAP DMIC driver and codec to the build. Signed-off-by: David Lambert dlamb...@ti.com --- sound/soc/codecs/Kconfig |3 +++ sound/soc/codecs/Makefile |2 ++ sound/soc/omap/Kconfig|5 +

Re: [PATCH v2] staging: tidspbridge: protect dmm_map properly

2010-12-28 Thread Felipe Contreras
On Tue, Dec 28, 2010 at 12:56 PM, Ohad Ben-Cohen o...@wizery.com wrote: On Tue, Dec 28, 2010 at 12:36 PM, Felipe Contreras felipe.contre...@gmail.com wrote: You can never really tell who is using the kernel (or will be using this kernel version), how and under which workload. No, but it's

Re: [PATCH v2] staging: tidspbridge: protect dmm_map properly

2010-12-28 Thread Ohad Ben-Cohen
On Tue, Dec 28, 2010 at 2:12 PM, Felipe Contreras felipe.contre...@gmail.com wrote: I haven't investigated why that happens, but kernel-space should not panic regardless of what user-space does. Agree of course. But that's not what we were discussing... Anyhow, a thread that is calling

Re: [PATCH v2] staging: tidspbridge: protect dmm_map properly

2010-12-28 Thread Felipe Contreras
On Tue, Dec 28, 2010 at 2:18 PM, Ohad Ben-Cohen o...@wizery.com wrote: On Tue, Dec 28, 2010 at 2:12 PM, Felipe Contreras felipe.contre...@gmail.com wrote: I haven't investigated why that happens, but kernel-space should not panic regardless of what user-space does. Agree of course. But

Re: [PATCH v2] staging: tidspbridge: protect dmm_map properly

2010-12-28 Thread Ohad Ben-Cohen
On Tue, Dec 28, 2010 at 2:24 PM, Felipe Contreras felipe.contre...@gmail.com wrote: user-space crashed, not kernel-space; the code would continue to run and eventually release the lock. So you'll have to be more specific about the scenario you are describing. If there's a user thread that is

[RFC/PATCH 0/2] Move twl*-irq.c to threaded_irq infrastructure

2010-12-28 Thread Felipe Balbi
Hi all, This is truly untested. I only compile tested thus far as I'm not sure it's the right path. It looks like that's what's supposed to be done, but I wanted to check with you guys before going any further. In a few minutes, I'll be starting to test these two patches and will try to find any

[RFC/PATCH 2/2] mfd: twl4030-irq: move to threaded_irq

2010-12-28 Thread Felipe Balbi
... and while at that, also start using handle_nested_irq() as we should. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/twl4030-irq.c | 133 ++--- 1 files changed, 42 insertions(+), 91 deletions(-) diff --git a/drivers/mfd/twl4030-irq.c

[RFC/PATCH 1/2] mfd: twl6030-irq: move to threaded_irq

2010-12-28 Thread Felipe Balbi
... and while at that, also start using handle_nested_irq() as we should. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/twl6030-irq.c | 141 - 1 files changed, 49 insertions(+), 92 deletions(-) diff --git a/drivers/mfd/twl6030-irq.c

Re: [PATCH 1/5] ASoC: DMIC: Adding the OMAP DMIC driver

2010-12-28 Thread Mark Brown
On Mon, Dec 27, 2010 at 10:17:02PM -0600, David Lambert wrote: + case 1920: + if (div == 5) + div_sel = 0x1; + else if (div == 8) + div_sel = 0x0; + break; A switch statement for the valid div values would

Re: [PATCH 2/5] ASoC: DMIC codec: Adding a generic DMIC codec

2010-12-28 Thread Mark Brown
On Mon, Dec 27, 2010 at 10:17:03PM -0600, David Lambert wrote: At this time, the codec driver just registers the codec DAI. If it's doing more than that it's going to be a separate driver anyway I expect. +static struct snd_soc_dai_driver dmic_dai = { + .name = dmic-hifi, + .capture

Re: [PATCH v2] staging: tidspbridge: protect dmm_map properly

2010-12-28 Thread Ohad Ben-Cohen
On Tue, Dec 28, 2010 at 2:12 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Tue, Dec 28, 2010 at 12:56 PM, Ohad Ben-Cohen o...@wizery.com wrote: I still don't know how exactly you triggered the bug: is gst-dsp multithreaded ? and one of its threads invoked proc_un_map() while

Re: [RFC/PATCH 1/2] mfd: twl6030-irq: move to threaded_irq

2010-12-28 Thread Mark Brown
On Tue, Dec 28, 2010 at 03:59:49PM +0200, Felipe Balbi wrote: + disable_irq_nosync(irq); You shouldn't need this any more; the driver used to be faffing around with this because it wasn't using genirq for this in the past. + for (i = 0; sts.int_sts; sts.int_sts = 1, i++) { +

Re: [RFC/PATCH 1/2] mfd: twl6030-irq: move to threaded_irq

2010-12-28 Thread Felipe Balbi
Hi, On Tue, Dec 28, 2010 at 03:46:17PM +, Mark Brown wrote: On Tue, Dec 28, 2010 at 03:59:49PM +0200, Felipe Balbi wrote: + disable_irq_nosync(irq); You shouldn't need this any more; the driver used to be faffing around with this because it wasn't using genirq for this in the

RE: [PATCH v6 01/10] OMAP3: PM: Adding voltage driver support.

2010-12-28 Thread Anand Sawant
Thara, Here are some comments on the voltage layer; many of them are cosmetic in nature. -Original Message- From: Thara Gopinath [mailto:th...@ti.com] Sent: Monday, December 20, 2010 10:29 PM To: linux-omap@vger.kernel.org; linux-arm- ker...@lists.infradead.org Cc:

RE: [PATCH v6 09/10] OMAP3: PM: Adding debug support to Voltage and Smartreflex drivers

2010-12-28 Thread Anand Sawant
Thara, Few comments on the changes in voltage layer ... -Original Message- From: Thara Gopinath [mailto:th...@ti.com] Sent: Monday, December 20, 2010 10:29 PM To: linux-omap@vger.kernel.org; linux-arm- ker...@lists.infradead.org Cc: khil...@deeprootsystems.com; p...@pwsan.com; b-

[RFC/PATCH 0/3] TWL4030 IRQ Changes

2010-12-28 Thread Felipe Balbi
Hi all, I dropped the twl6030-irq.c changes because that thing is a bit messy. I hope the original author will feel inspired and fix that one up. Anyway, twl4030-irq.c seems to be going to the right direction now. Thanks to Mark Brown for pointing out the need to drop the locking and implement

[RFC/PATCH 2/3] mfd: twl4030-irq: drop the workqueue hackery

2010-12-28 Thread Felipe Balbi
Finally that workqueue isn't needed anymore. Drop that hackery and move the spinlock_t to a mutex so we can issue I2C operations with a lock held. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/twl4030-irq.c | 226 +++-- 1 files changed, 96

[RFC/PATCH 1/3] mfd: twl4030-irq: move to threaded_irq

2010-12-28 Thread Felipe Balbi
... and while at that, also start using handle_nested_irq() as we should. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/twl4030-irq.c | 131 + 1 files changed, 38 insertions(+), 93 deletions(-) diff --git a/drivers/mfd/twl4030-irq.c

[RFC/PATCH 3/3] mfd: twl4030-irq: implement bus_*lock

2010-12-28 Thread Felipe Balbi
drop all the locking around mask/unmask and implement bus_lock and bus_sync_unlock methods. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/twl4030-irq.c | 30 ++ 1 files changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/mfd/twl4030-irq.c

RE: [PATCH v5 2/5] OMAP4: Adding voltage driver support

2010-12-28 Thread Anand Sawant
Thara, -Original Message- From: Thara Gopinath [mailto:th...@ti.com] Sent: Monday, December 20, 2010 10:31 PM To: linux-omap@vger.kernel.org; linux-arm- ker...@lists.infradead.org Cc: khil...@deeprootsystems.com; p...@pwsan.com; b- cous...@ti.com; vishwanath...@ti.com;

Re: [RFC/PATCH 0/3] TWL4030 IRQ Changes

2010-12-28 Thread Felipe Balbi
Hi, On Tue, Dec 28, 2010 at 07:14:16PM +0200, Felipe Balbi wrote: I dropped the twl6030-irq.c changes because that thing is a bit messy. I hope the original author will feel inspired and fix that one up. Anyway, twl4030-irq.c seems to be going to the right direction now. Thanks to Mark Brown

Re: [RFC/PATCH 1/2] mfd: twl6030-irq: move to threaded_irq

2010-12-28 Thread David Brownell
--- On Tue, 12/28/10, Mark Brown broo...@opensource.wolfsonmicro.com wrote: F You shouldn't need this any more; the driver used to be faffing around with this because it wasn't using genirq for this in the past. Originally it couldn't, since genirq didn't support threaded IRQ handling...

Re: [RFC/PATCH 0/3] TWL4030 IRQ Changes

2010-12-28 Thread Mark Brown
On Tue, Dec 28, 2010 at 07:36:04PM +0200, Felipe Balbi wrote: when we finally move to struct irq_data, the below could be used. BTW, Thomas do you have any plans for exposing irq_data_to_desc() ? The general idea is to move to struct irq_data sooner rather than later (all the existing MFD

OMAP Color Rotation

2010-12-28 Thread David Lynch Jr.
I am looking for an example of programing the color rotation registers. I need to swap red and blue in software. This should be fairly easy, but some code usi_ng the color rotation registers would help. DISPC_CPR_COEF_R -- Dave Lynch

Re: [RFC/PATCH 1/2] mfd: twl6030-irq: move to threaded_irq

2010-12-28 Thread Mark Brown
On Tue, Dec 28, 2010 at 09:40:03AM -0800, David Brownell wrote: What I'd expect to see from a conversion like this would be that most of the locking/IRQ management stuff would be dropped I'd expect that genirq solve all the issues and that its support be used. That's not the same as

Re: [RFC/PATCH 3/3] mfd: twl4030-irq: implement bus_*lock

2010-12-28 Thread Mark Brown
On Tue, Dec 28, 2010 at 07:14:19PM +0200, Felipe Balbi wrote: +static void twl4030_sih_bus_sync_unlock(unsigned int irq) +{ + struct sih_agent*agent = get_irq_chip_data(irq); + + mutex_unlock(agent-irq_lock); +} I suspect you need to do some sort of sync with the

Re: [RFC/PATCH 3/3] mfd: twl4030-irq: implement bus_*lock

2010-12-28 Thread Felipe Balbi
Hi, On Tue, 2010-12-28 at 23:58 +, Mark Brown wrote: On Tue, Dec 28, 2010 at 07:14:19PM +0200, Felipe Balbi wrote: +static void twl4030_sih_bus_sync_unlock(unsigned int irq) +{ + struct sih_agent*agent = get_irq_chip_data(irq); + +

Re: [RFC/PATCH 0/3] TWL4030 IRQ Changes

2010-12-28 Thread Felipe Balbi
Hi, On Tue, 2010-12-28 at 17:41 +, Mark Brown wrote: when we finally move to struct irq_data, the below could be used. BTW, Thomas do you have any plans for exposing irq_data_to_desc() ? The general idea is to move to struct irq_data sooner rather than later (all the existing MFD

Re: [PATCH 1/5] ASoC: DMIC: Adding the OMAP DMIC driver

2010-12-28 Thread Lambert, David
On Tue, Dec 28, 2010 at 5:14 AM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Dec 27, 2010 at 10:17:02PM -0600, David Lambert wrote: This patch adds support for the OMAP4 digital microphone DAI. This DAI can support support recording in 2, 4, or 6 channels When provided with a 19.2Mhz

Re: [PATCH 3/5] ASoC: DMIC: Adding OMAP DMIC driver to build

2010-12-28 Thread Lambert, David
On Tue, Dec 28, 2010 at 5:40 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Mon, Dec 27, 2010 at 10:17:04PM -0600, David Lambert wrote: Adds the OMAP DMIC driver and codec to the build. Signed-off-by: David Lambert dlamb...@ti.com ---  sound/soc/codecs/Kconfig  |    3 +++  

Re: [PATCH 0/7 v2] OMAP: McSPI: Hwmod adaptation + runtime conversion

2010-12-28 Thread Govindraj
Hi Grant, On Wed, Dec 1, 2010 at 7:31 PM, Govindraj.R govindraj.r...@ti.com wrote: Changes invloves: 1) Addition of hwmod data for omap2/3/4. 1) McSPI driver hwmod adaptation with cleanup of base address   macros and using omap-device API's. 2) Runtime Conversion of McSPI

Re: [PATCH v6 1/1] OMAP2: Spi: Force CS to be in inactive state after off-mode transition

2010-12-28 Thread Grant Likely
On Fri, Dec 24, 2010 at 01:21:25PM +0100, Gregory CLEMENT wrote: When SPI wake up from OFF mode, CS is in the wrong state: force it to the inactive state. During the system life, I monitored the CS behavior using a oscilloscope. I also activated debug in omap2_mcspi, so I saw when driver

Re: [PATCH 0/7 v2] OMAP: McSPI: Hwmod adaptation + runtime conversion

2010-12-28 Thread Grant Likely
On Wed, Dec 29, 2010 at 12:57:35PM +0530, Govindraj wrote: Hi Grant, On Wed, Dec 1, 2010 at 7:31 PM, Govindraj.R govindraj.r...@ti.com wrote: Changes invloves: 1) Addition of hwmod data for omap2/3/4. 1) McSPI driver hwmod adaptation with cleanup of base address