[PATCH v3 3/4] regulator: pass additional of_node to regulator_register()

2011-10-27 Thread Rajendra Nayak
With device tree support for regulators, its needed that the regulator_dev-dev device has the right of_node attached. To be able to do this add an additional parameter to the regulator_register() api, wherein the dt-adapted driver can then pass this additional info onto the regulator core.

[PATCH 0/3] Device tree support for TWL regulators

2011-10-27 Thread Rajendra Nayak
Hi, This series adapts TWL regulator driver to work with device tree and passes regulator data for two OMAP4 boards (OMAP4 panda and OMAP4 sdp) from device tree. The series has a few dependencies -1- base regulator dt support series posted here http://marc.info/?l=linux-omapm=131970236516788w=2

[PATCH 2/3] omap4: sdp: Pass regulator data from dt

2011-10-27 Thread Rajendra Nayak
Pass adjustable regulator information for omap4sdp from device tree so the regulator driver can then use the regulator helper routine to extract and use them during the driver probe(). Also add documentation for TWL regulator specific bindings. Signed-off-by: Rajendra Nayak rna...@ti.com ---

[PATCH 3/3] omap4: panda: Pass regulator data from DT

2011-10-27 Thread Rajendra Nayak
Pass the fixed and adjustable voltage regulator information for omap4panda board from device tree. Signed-off-by: Rajendra Nayak rna...@ti.com --- arch/arm/boot/dts/omap4-panda.dts | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) diff --git

Re: [PATCH v3 1/4] regulator: helper routine to extract regulator_init_data

2011-10-27 Thread Mark Brown
On Thu, Oct 27, 2011 at 01:26:22PM +0530, Rajendra Nayak wrote: + min_uV = of_get_property(np, regulator-min-uV, NULL); + if (min_uV) + (*init_data)-constraints.min_uV = be32_to_cpu(*min_uV); + max_uV = of_get_property(np, regulator-max-uV, NULL); + if (max_uV) +

Re: [PATCH 1/3] regulator: twl: adapt twl-regulator driver to dt

2011-10-27 Thread Mark Brown
On Thu, Oct 27, 2011 at 01:34:32PM +0530, Rajendra Nayak wrote: + select OF_REGULATOR if OF We should probably just not have OF_REGULATOR or do the select from the core, this is just going to end up being noisy. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the

Re: [PATCH 2/3] omap4: sdp: Pass regulator data from dt

2011-10-27 Thread Mark Brown
On Thu, Oct 27, 2011 at 01:34:33PM +0530, Rajendra Nayak wrote: Also add documentation for TWL regulator specific bindings. This should've been in the previous patch. +For twl6030 regulators/LDO's LDOs. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a

Re: [PATCH v3 0/4] Device tree support for regulators

2011-10-27 Thread Mark Brown
On Thu, Oct 27, 2011 at 01:26:21PM +0530, Rajendra Nayak wrote: v3 is based on the latest devicetree/next and is tested (with twl adaptaions, which will be posted seperately) on the OMAP4 panda and OMAP4 sdp boards. Looking at the device bindings I notice that these bindings loose the ability

Re: [PATCH v3 1/4] regulator: helper routine to extract regulator_init_data

2011-10-27 Thread Nayak, Rajendra
If we have min_uV and max_uV we should also set REGULATOR_CHANGE_VOLTAGE (and similarly for the currents). We should also have a way to enable status changes - since there's an always_on property (which does make sense) I'd suggest that as a first pass we should enable status changes if

Re: [PATCH v3 1/4] regulator: helper routine to extract regulator_init_data

2011-10-27 Thread Mark Brown
On Thu, Oct 27, 2011 at 04:13:08PM +0530, Nayak, Rajendra wrote: okay, here's an updated patch which does that. I also added a binding to specify a descriptive name to the regulator outputs as you suggested in the other thread. Looks good! I guess we may run into issues with the status

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-10-27 Thread Mark Brown
On Thu, Oct 27, 2011 at 01:26:23PM +0530, Rajendra Nayak wrote: The fixed regulator driver uses of_get_fixed_voltage_config() to extract fixed_voltage_config structure contents from device tree. Also add documenation for additional bindings for fixed regulators that can be passed through dt.

Re: [PATCH v3 3/4] regulator: pass additional of_node to regulator_register()

2011-10-27 Thread Mark Brown
On Thu, Oct 27, 2011 at 01:26:24PM +0530, Rajendra Nayak wrote: With device tree support for regulators, its needed that the regulator_dev-dev device has the right of_node attached. To be able to do this add an additional parameter to the regulator_register() api, wherein the dt-adapted

Re: [PATCH v3 4/4] regulator: map consumer regulator based on device tree

2011-10-27 Thread Mark Brown
On Thu, Oct 27, 2011 at 01:26:25PM +0530, Rajendra Nayak wrote: Device nodes in DT can associate themselves with one or more regulators/supply by providing a list of phandles (to regulator nodes) and corresponding supply names. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com -- To

[PATCH 2/2 v3] net/smsc911x: Add regulator support

2011-10-27 Thread Linus Walleij
From: Robert Marklund robert.markl...@stericsson.com Add some basic regulator support for the power pins, as needed by the ST-Ericsson Snowball platform that powers up the SMSC911 chip using an external regulator. Platforms that use regulators and the smsc911x and have no defined regulator for

Re: [PATCH 2/2 v3] net/smsc911x: Add regulator support

2011-10-27 Thread Mike Frysinger
On Thu, Oct 27, 2011 at 14:48, Linus Walleij wrote: Platforms that use regulators and the smsc911x and have no defined regulator for the smsc911x and claim complete regulator constraints with no dummy regulators will need to provide it, for example using a fixed voltage regulator. It appears

[PATCH v4 1/4] regulator: helper routine to extract regulator_init_data

2011-10-27 Thread Rajendra Nayak
The helper routine is meant to be used by the regulator drivers to extract the regulator_init_data structure from the data that is passed from device tree. 'consumer_supplies' which is part of regulator_init_data is not extracted as the regulator consumer mappings are passed through DT

Re: [PATCH v3 1/4] regulator: helper routine to extract regulator_init_data

2011-10-27 Thread Rajendra Nayak
On Thursday 27 October 2011 05:19 PM, Mark Brown wrote: On Thu, Oct 27, 2011 at 04:13:08PM +0530, Nayak, Rajendra wrote: okay, here's an updated patch which does that. I also added a binding to specify a descriptive name to the regulator outputs as you suggested in the other thread. Looks

Re: [PATCH 2/2 v3] net/smsc911x: Add regulator support

2011-10-27 Thread Mark Brown
On Thu, Oct 27, 2011 at 03:21:47PM +0200, Mike Frysinger wrote: my gut reaction: smsc911x is working just fine without regulator support for many people, so why do we suddenly need to make it a requirement ? this is a fairly small amount of code, so adding a smsc911x Kconfig symbol to

Re: [PATCH 2/2 v3] net/smsc911x: Add regulator support

2011-10-27 Thread Mike Frysinger
On Thu, Oct 27, 2011 at 17:46, Mark Brown wrote: On Thu, Oct 27, 2011 at 03:21:47PM +0200, Mike Frysinger wrote: my gut reaction: smsc911x is working just fine without regulator support for many people, so why do we suddenly need to make it a requirement ?  this is a fairly small amount of

Re: [PATCH 2/2 v3] net/smsc911x: Add regulator support

2011-10-27 Thread Mark Brown
On Thu, Oct 27, 2011 at 10:59:14PM +0200, Mike Frysinger wrote: i saw that !CONFIG_REGULATOR works great. my concern is that these boards don't define any regulators for smsc resources, so if CONFIG_REGULATOR is enabled to test out unrelated daughter cards, i don't want the network driver

Re: [PATCH 2/2 v3] net/smsc911x: Add regulator support

2011-10-27 Thread Mike Frysinger
On Thu, Oct 27, 2011 at 23:42, Mark Brown wrote: On Thu, Oct 27, 2011 at 10:59:14PM +0200, Mike Frysinger wrote: i saw that !CONFIG_REGULATOR works great.  my concern is that these boards don't define any regulators for smsc resources, so if CONFIG_REGULATOR is enabled to test out unrelated