Re: [PATCH] arm: dts: omap4-sdp: pinmux configuration for keypad

2012-10-23 Thread Sourav
Hi Tony, On Monday 22 October 2012 09:49 PM, Tony Lindgren wrote: * Sourav Poddar sourav.pod...@ti.com [121022 00:30]: --- a/arch/arm/boot/dts/omap4-sdp.dts +++ b/arch/arm/boot/dts/omap4-sdp.dts @@ -194,6 +194,27 @@ 0xbc 0x100 /* abe_mcbsp2_fsx.abe_mcbsp2_fsx INPUT

Re: Errors at boot time from OMAP4430SDP (and a whinge about serial stuff)

2012-10-23 Thread Igor Grinberg
On 10/21/12 16:54, Ohad Ben-Cohen wrote: On Fri, Oct 19, 2012 at 7:07 PM, Tony Lindgren t...@atomide.com wrote: ... We could optimize away a minimal amount of code for many configurations with the ifdef? :) Sure, here goes (compile tested only): From

Re: [RFC] ARM: OMAP: hwmod: wait for sysreset complete after enabling hwmod

2012-10-23 Thread Paul Walmsley
Hi Tero, On Mon, 22 Oct 2012, Tero Kristo wrote: When waking up from off-mode, some IP blocks are reset automatically by hardware. For this reason, software must wait until the reset has completed before attempting to access the IP block. This patch fixes for example the bug introduced by

Re: Errors at boot time from OMAP4430SDP (and a whinge about serial stuff)

2012-10-23 Thread Ohad Ben-Cohen
On Tue, Oct 23, 2012 at 9:37 AM, Igor Grinberg grinb...@compulab.co.il wrote: + ret = wl12xx_set_platform_data(wlan_data); + /* bail out silently in case wl12xx isn't configured */ + if (ret == -ENOSYS) + return ret; Since we have the function ifdef'ed, I don't think

Re: [PATCH 5/7] ARM: OMAP2+: WDT: move init; add read_reset_sources pdata function pointer

2012-10-23 Thread Wim Van Sebroeck
Hi Paul, The OMAP watchdog timer driver directly calls a function exported by code in arch/arm/mach-omap2. This is not good; it tightly couples this driver to the mach-omap2 integration code. Instead, add a temporary platform_data function pointer to abstract this function call. A

Re: [PATCH 6/7] watchdog: OMAP: use standard GETBOOTSTATUS interface; use platform_data fn ptr

2012-10-23 Thread Wim Van Sebroeck
Hi Paul, Previously the OMAP watchdog driver used a non-standard way to report the chip reset source via the GETBOOTSTATUS ioctl. This patch converts the driver to use the standard WDIOF_* flags for this purpose. This patch may break existing userspace code that uses the existing

Re: [RFC] ARM: OMAP: hwmod: wait for sysreset complete after enabling hwmod

2012-10-23 Thread Tero Kristo
Hi Paul, On Tue, 2012-10-23 at 07:47 +, Paul Walmsley wrote: Hi Tero, On Mon, 22 Oct 2012, Tero Kristo wrote: When waking up from off-mode, some IP blocks are reset automatically by hardware. For this reason, software must wait until the reset has completed before attempting to

Re: [PATCH 5/7] ARM: OMAP2+: WDT: move init; add read_reset_sources pdata function pointer (fwd)

2012-10-23 Thread Wim Van Sebroeck
Hi Paul, When you have the opportunity, could you take a look at this patch, and the subsequent patch 6/7, and ack them if you're okay with them? Signed them off, Acked-by would probably have been better :-). We'd like to merge thse as part of a larger cleanup series through the arm-soc

[PATCH v2 0/4] ARM: dts: Update OMAP5 with address space and interrupts

2012-10-23 Thread Sebastien Guiriec
Since kernel 3.7 the DTS data are not overwriten by hwmod data we can add the address space and interrupt line description inside dtsi file for OMAP5. This serie is updating the current OMAP5 IP with missing entry. It has been tested on OMAP5 with 3.7-audio-display feature tree. - MMC is

[PATCH v2 2/4] ARM: dts: omap5: Update I2C with address space and interrupts

2012-10-23 Thread Sebastien Guiriec
Add base address and interrupt line inside Device Tree data for OMAP5 Signed-off-by: Sebastien Guiriec s-guir...@ti.com Reviewed-by: Shubhrajyoti D shubhrajy...@ti.com --- arch/arm/boot/dts/omap5.dtsi | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

[PATCH v2 4/4] ARM: dts: omap5: Update MMC with address space and interrupts

2012-10-23 Thread Sebastien Guiriec
Add base address and interrupt line inside Device Tree data for OMAP5. Signed-off-by: Sebastien Guiriec s-guir...@ti.com --- arch/arm/boot/dts/omap5.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index

[PATCH v2 1/4] ARM: dts: omap5: Update GPIO with address space and interrupts

2012-10-23 Thread Sebastien Guiriec
Add base address and interrupt line inside Device Tree data for OMAP5 Signed-off-by: Sebastien Guiriec s-guir...@ti.com --- arch/arm/boot/dts/omap5.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index

[PATCH v2 3/4] ARM: dts: omap5: Update UART with address space and interrupts

2012-10-23 Thread Sebastien Guiriec
Add base address and interrupt line inside Device Tree data for OMAP5. Signed-off-by: Sebastien Guiriec s-guir...@ti.com Reviewed-by: Shubhrajyoti D shubhrajy...@ti.com --- arch/arm/boot/dts/omap5.dtsi | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Linus Walleij
On Mon, Oct 22, 2012 at 5:50 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Sourav, On Mon, Oct 22, 2012 at 06:43:00PM +0530, Sourav Poddar wrote: Adapt keypad to use pinctrl framework. Tested on omap4430 sdp with 3.7-rc1 kernel. I do not see anything in the driver that would

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Benoit Cousson
Hi Dimitry, On 10/22/2012 05:50 PM, Dmitry Torokhov wrote: Hi Sourav, On Mon, Oct 22, 2012 at 06:43:00PM +0530, Sourav Poddar wrote: Adapt keypad to use pinctrl framework. Tested on omap4430 sdp with 3.7-rc1 kernel. I do not see anything in the driver that would directly use pinctrl. Is

Re: RT throttling and suspend/resume (was Re: [PATCH] i2c: omap: revert i2c: omap: switch to threaded IRQ support)

2012-10-23 Thread Russell King - ARM Linux
On Mon, Oct 22, 2012 at 09:47:06AM -0700, Kevin Hilman wrote: Peter Zijlstra pet...@infradead.org writes: On Fri, 2012-10-19 at 16:54 -0700, Kevin Hilman wrote: So I did the same thing for my ARM SoC, and it definitley stops the RT throttling. However, it has the undesriable

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Benoit Cousson
Hi Linus, On 10/23/2012 11:13 AM, Linus Walleij wrote: On Mon, Oct 22, 2012 at 5:50 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Sourav, On Mon, Oct 22, 2012 at 06:43:00PM +0530, Sourav Poddar wrote: Adapt keypad to use pinctrl framework. Tested on omap4430 sdp with 3.7-rc1

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-23 Thread Tomi Valkeinen
On 2012-10-23 03:48, Ricardo Neri wrote: +#if defined(CONFIG_OMAP4_DSS_HDMI_AUDIO) +#define HDMI_AUDIO_MEM_RESOURCE 0 +#define HDMI_AUDIO_DMA_RESOURCE 1 I don't see much point with these definitions. They are hdmi.c internal, so the audio driver can't use them, and so they aren't really

Re: Errors at boot time from OMAP4430SDP (and a whinge about serial stuff)

2012-10-23 Thread Igor Grinberg
On 10/23/12 09:51, Ohad Ben-Cohen wrote: On Tue, Oct 23, 2012 at 9:37 AM, Igor Grinberg grinb...@compulab.co.il wrote: + ret = wl12xx_set_platform_data(wlan_data); + /* bail out silently in case wl12xx isn't configured */ + if (ret == -ENOSYS) + return ret; Since

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Linus Walleij
On Tue, Oct 23, 2012 at 11:35 AM, Benoit Cousson b-cous...@ti.com wrote: On 10/23/2012 11:13 AM, Linus Walleij wrote: So Sourav, please tell us a bit about your plans for this and other drivers! Yeah, this idea is to handle pinctrl from all the drivers, and potentially change the mode

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Felipe Balbi
Hi, On Tue, Oct 23, 2012 at 12:04:01PM +0200, Linus Walleij wrote: On Tue, Oct 23, 2012 at 11:35 AM, Benoit Cousson b-cous...@ti.com wrote: On 10/23/2012 11:13 AM, Linus Walleij wrote: So Sourav, please tell us a bit about your plans for this and other drivers! Yeah, this idea is to

Re: Errors at boot time from OMAP4430SDP (and a whinge about serial stuff)

2012-10-23 Thread Russell King - ARM Linux
On Fri, Oct 12, 2012 at 04:54:34PM +0100, Russell King - ARM Linux wrote: For those who don't bother looking at my kautobuild boot tests on the OMAP boards I have, here's the errors which get spat out at boot time. Note that some of these I've reported in the past, and one of them is missing

Re: [PATCH] arm: sched: stop sched_clock() during suspend

2012-10-23 Thread Linus Walleij
On Mon, Oct 22, 2012 at 1:54 PM, Felipe Balbi ba...@ti.com wrote: The scheduler imposes a requirement to sched_clock() which is to stop the clock during suspend, if we don't do that IRQ threads will be rescheduled in the future which might cause transfers to timeout depending on how driver

RE: Fwd: [PATCH 2/5] ARM: OMAP3+: hwmod: Add AM33XX HWMOD data for davinci_mdio

2012-10-23 Thread Hiremath, Vaibhav
On Fri, Oct 19, 2012 at 11:46:30, Richard Cochran wrote: On Fri, Oct 19, 2012 at 02:18:29AM +0530, Vaibhav Hiremath wrote: Another important point is, this driver is also required and used for Davinci family of devices (arch/mach/mach-davinci/). That is really beside the point. If the

RE: [PATCH 1/4] mtd: nand: omap2: Update nerrors using ecc.strength

2012-10-23 Thread Philip, Avinash
On Tue, Oct 16, 2012 at 00:26:40, Peter Korsgaard wrote: Philip, Avinash avinashphi...@ti.com writes: Update number of errors using nand ecc strength. Also add macro definitions BCH8_ERROR_MAX BCH4_ERROR_MAX Signed-off-by: Philip, Avinash avinashphi...@ti.com --- :100644

RE: [PATCH 2/4] mtd: devices: elm: Add support for ELM error correction

2012-10-23 Thread Philip, Avinash
On Tue, Oct 16, 2012 at 01:10:47, Peter Korsgaard wrote: Philip, Avinash avinashphi...@ti.com writes: Platforms containing the ELM module can be used to correct errors reported by BCH 4, 8 16 bit ECC scheme. For now only 4 8 bit support is added. This sounds odd to me. What about

RE: [PATCH 3/4] ARM: OMAP2: gpmc: Add support for BCH ECC scheme

2012-10-23 Thread Philip, Avinash
On Tue, Oct 16, 2012 at 00:18:30, Peter Korsgaard wrote: Philip, Avinash avinashphi...@ti.com writes: Add support for BCH ECC scheme to gpmc driver and also enabling multi sector read/write. This helps in doing single shot NAND page read and write. ECC engine configurations

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Thomas Petazzoni
On Tue, 23 Oct 2012 13:03:33 +0300, Felipe Balbi wrote: But it appears that shmobile prefer to get all resources using bus notifiers. So we need to form some kind of consensus ... or live with the fact that different systems do it different ways. Which will explode the day we need

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Linus Walleij
On Tue, Oct 23, 2012 at 12:23 PM, Thomas Petazzoni thomas.petazz...@free-electrons.com wrote: On Tue, 23 Oct 2012 13:03:33 +0300, Felipe Balbi wrote: But it appears that shmobile prefer to get all resources using bus notifiers. So we need to form some kind of consensus ... or live with

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Felipe Balbi
Hi, On Tue, Oct 23, 2012 at 12:29:28PM +0200, Linus Walleij wrote: On Tue, Oct 23, 2012 at 12:23 PM, Thomas Petazzoni thomas.petazz...@free-electrons.com wrote: On Tue, 23 Oct 2012 13:03:33 +0300, Felipe Balbi wrote: But it appears that shmobile prefer to get all resources using bus

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Linus Walleij
On Tue, Oct 23, 2012 at 12:29 PM, Felipe Balbi ba...@ti.com wrote: On Tue, Oct 23, 2012 at 12:29:28PM +0200, Linus Walleij wrote: So the biggest implementation of the notifier approach to resource handling is the SH clock thing: drivers/base/power/clock_ops.c that's different right ? It's

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Felipe Balbi
Hi, On Tue, Oct 23, 2012 at 12:45:33PM +0200, Linus Walleij wrote: On Tue, Oct 23, 2012 at 12:29 PM, Felipe Balbi ba...@ti.com wrote: On Tue, Oct 23, 2012 at 12:29:28PM +0200, Linus Walleij wrote: So the biggest implementation of the notifier approach to resource handling is the SH clock

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Thomas Petazzoni
On Tue, 23 Oct 2012 12:45:33 +0200, Linus Walleij wrote: Hm so I have had this idea of runtime PM core helping out with pins, so I could add something like pm_pins_fetch() pm_pins_default() pm_pins_idle() pm_pins_sleep() So if one is using the pin states defined in

Re: OMAP baseline test results for v3.7-rc2

2012-10-23 Thread Matt Porter
On Tue, Oct 23, 2012 at 03:15:44AM +, Paul Walmsley wrote: On Mon, 22 Oct 2012, Matt Porter wrote: I've mentioned this a few times in various threads...no need to use appended DTB on a current U-Boot. Some of us are indeed booting this way with the DTB properly passed separately from

Re: OMAP baseline test results for v3.7-rc2

2012-10-23 Thread Matt Porter
On Tue, Oct 23, 2012 at 08:24:36AM -0400, Matt Porter wrote: On Tue, Oct 23, 2012 at 03:15:44AM +, Paul Walmsley wrote: On Mon, 22 Oct 2012, Matt Porter wrote: I've mentioned this a few times in various threads...no need to use appended DTB on a current U-Boot. Some of us are

Re: [RFC] ARM: OMAP: hwmod: wait for sysreset complete after enabling hwmod

2012-10-23 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: Hi Tero, On Mon, 22 Oct 2012, Tero Kristo wrote: When waking up from off-mode, some IP blocks are reset automatically by hardware. For this reason, software must wait until the reset has completed before attempting to access the IP block. This patch

Re: [RFC] ARM: OMAP: hwmod: wait for sysreset complete after enabling hwmod

2012-10-23 Thread Santosh Shilimkar
On Tuesday 23 October 2012 07:58 PM, Kevin Hilman wrote: Paul Walmsley p...@pwsan.com writes: Hi Tero, On Mon, 22 Oct 2012, Tero Kristo wrote: When waking up from off-mode, some IP blocks are reset automatically by hardware. For this reason, software must wait until the reset has completed

Re: [PATCH v2 1/4] ARM: dts: omap5: Update GPIO with address space and interrupts

2012-10-23 Thread Jon Hunter
Hi Seb, On 10/23/2012 03:37 AM, Sebastien Guiriec wrote: Add base address and interrupt line inside Device Tree data for OMAP5 Signed-off-by: Sebastien Guiriec s-guir...@ti.com --- arch/arm/boot/dts/omap5.dtsi | 16 1 file changed, 16 insertions(+) diff --git

Re: [PATCH v2 1/4] ARM: dts: omap5: Update GPIO with address space and interrupts

2012-10-23 Thread Benoit Cousson
On 10/23/2012 04:49 PM, Jon Hunter wrote: Hi Seb, On 10/23/2012 03:37 AM, Sebastien Guiriec wrote: Add base address and interrupt line inside Device Tree data for OMAP5 Signed-off-by: Sebastien Guiriec s-guir...@ti.com --- arch/arm/boot/dts/omap5.dtsi | 16 1 file

[PATCH] i2c: omap: re-factor omap_i2c_init function

2012-10-23 Thread Shubhrajyoti D
re-factor omap_i2c_init() so that we can re-use it for resume. While at it also remove the bufstate variable as we write it in omap_i2c_resize_fifo for every transfer. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- Applies on Felipe's series

Re: [RFC] ARM: OMAP: hwmod: wait for sysreset complete after enabling hwmod

2012-10-23 Thread Shubhrajyoti Datta
On Tue, Oct 23, 2012 at 3:16 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Tero Kristo t-kri...@ti.com writes: When waking up from off-mode, some IP blocks are reset automatically by hardware. For this reason, software must wait until the reset has completed before attempting to access

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-23 Thread Ricardo Neri
On 10/23/2012 04:37 AM, Tomi Valkeinen wrote: On 2012-10-23 03:48, Ricardo Neri wrote: +#if defined(CONFIG_OMAP4_DSS_HDMI_AUDIO) +#define HDMI_AUDIO_MEM_RESOURCE 0 +#define HDMI_AUDIO_DMA_RESOURCE 1 I don't see much point with these definitions. They are hdmi.c internal, so the audio

Re: [PATCH v2 1/4] ARM: dts: omap5: Update GPIO with address space and interrupts

2012-10-23 Thread Jon Hunter
On 10/23/2012 10:09 AM, Benoit Cousson wrote: On 10/23/2012 04:49 PM, Jon Hunter wrote: Hi Seb, On 10/23/2012 03:37 AM, Sebastien Guiriec wrote: Add base address and interrupt line inside Device Tree data for OMAP5 Signed-off-by: Sebastien Guiriec s-guir...@ti.com ---

Re: [PATCH v2 1/4] ARM: dts: omap5: Update GPIO with address space and interrupts

2012-10-23 Thread Benoit Cousson
On 10/23/2012 05:59 PM, Jon Hunter wrote: On 10/23/2012 10:09 AM, Benoit Cousson wrote: On 10/23/2012 04:49 PM, Jon Hunter wrote: Hi Seb, On 10/23/2012 03:37 AM, Sebastien Guiriec wrote: Add base address and interrupt line inside Device Tree data for OMAP5 Signed-off-by: Sebastien

Re: [RFC] ARM: OMAP: hwmod: wait for sysreset complete after enabling hwmod

2012-10-23 Thread Kevin Hilman
Shubhrajyoti Datta omaplinuxker...@gmail.com writes: On Tue, Oct 23, 2012 at 3:16 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Tero Kristo t-kri...@ti.com writes: When waking up from off-mode, some IP blocks are reset automatically by hardware. For this reason, software must wait

Re: [PATCH v2 1/4] ARM: dts: omap5: Update GPIO with address space and interrupts

2012-10-23 Thread Sebastien Guiriec
Hi Benoit and John, On 10/23/2012 06:07 PM, Benoit Cousson wrote: On 10/23/2012 05:59 PM, Jon Hunter wrote: On 10/23/2012 10:09 AM, Benoit Cousson wrote: On 10/23/2012 04:49 PM, Jon Hunter wrote: Hi Seb, On 10/23/2012 03:37 AM, Sebastien Guiriec wrote: Add base address and interrupt line

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-23 Thread Tomi Valkeinen
On 2012-10-23 18:42, Ricardo Neri wrote: What registers does the audio side need to access? It only needs access to the DMA audio data port. All other operations that the audio driver needs are done through the omapdss audio interface. Hmm, so the audio side only needs the address of one

Re: [PATCH v2 1/4] ARM: dts: omap5: Update GPIO with address space and interrupts

2012-10-23 Thread Mitch Bradley
On 10/23/2012 4:49 AM, Jon Hunter wrote: Therefore, I believe it will improve search time and hence, boot time if we have interrupt-parent defined in each node. I strongly suspect (based on many years of performance tuning, with special focus on boot time) that the time difference will be

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Mitch Bradley
On 10/23/2012 12:03 AM, Felipe Balbi wrote: Hi, I much prefer having drivers explicitly manage all their resources, which would mean that pinctrl calls need to be done on probe() and, if necessary, during suspend()/resume(). Per-driver resource management is certainly convenient when you

Re: [RFC] ARM: OMAP: hwmod: wait for sysreset complete after enabling hwmod

2012-10-23 Thread Kevin Hilman
Kevin Hilman khil...@deeprootsystems.com writes: Paul Walmsley p...@pwsan.com writes: Hi Tero, On Mon, 22 Oct 2012, Tero Kristo wrote: When waking up from off-mode, some IP blocks are reset automatically by hardware. For this reason, software must wait until the reset has completed

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-23 Thread Ricardo Neri
On 10/23/2012 11:17 AM, Tomi Valkeinen wrote: On 2012-10-23 18:42, Ricardo Neri wrote: What registers does the audio side need to access? It only needs access to the DMA audio data port. All other operations that the audio driver needs are done through the omapdss audio interface. Hmm,

Re: [PATCH] i2c: omap: re-factor omap_i2c_init function

2012-10-23 Thread Felipe Balbi
Hi, On Tue, Oct 23, 2012 at 08:57:19PM +0530, Shubhrajyoti D wrote: re-factor omap_i2c_init() so that we can re-use it for resume. While at it also remove the bufstate variable as we write it in omap_i2c_resize_fifo for every transfer. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com ---

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Felipe Balbi
HI, On Tue, Oct 23, 2012 at 07:02:09AM -1000, Mitch Bradley wrote: On 10/23/2012 12:03 AM, Felipe Balbi wrote: Hi, I much prefer having drivers explicitly manage all their resources, which would mean that pinctrl calls need to be done on probe() and, if necessary, during

Re: [RFC] ARM: OMAP: hwmod: wait for sysreset complete after enabling hwmod

2012-10-23 Thread Shubhrajyoti Datta
On Tue, Oct 23, 2012 at 9:39 PM, Kevin Hilman khil...@deeprootsystems.com wrote: Shubhrajyoti Datta omaplinuxker...@gmail.com writes: [...] Could you please explain what worked and didn't work on each platforms? Also, which 3430 did you test on? If it's SDP, then it has a UART1 console,

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Mitch Bradley
Perhaps I misunderstood what you were suggesting. I thought that, when you said explicitly manage all their resources, you meant that the driver should know the platform-specific details about clocks and power domains. That is one possible interpretation of the word explicit. Now I see that you

Re: [PATCH] i2c: omap: re-factor omap_i2c_init function

2012-10-23 Thread Shubhrajyoti Datta
On Tue, Oct 23, 2012 at 10:48 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Oct 23, 2012 at 08:57:19PM +0530, Shubhrajyoti D wrote: re-factor omap_i2c_init() so that we can re-use it for resume. While at it also remove the bufstate variable as we write it in omap_i2c_resize_fifo for every

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Felipe Balbi
Hi, (please don't top-post) On Tue, Oct 23, 2012 at 07:51:22AM -1000, Mitch Bradley wrote: Perhaps I misunderstood what you were suggesting. I thought that, when you said explicitly manage all their resources, you meant that the driver should know the platform-specific details about clocks

Re: [PATCH] i2c: omap: re-factor omap_i2c_init function

2012-10-23 Thread Felipe Balbi
Hi, On Tue, Oct 23, 2012 at 11:26:15PM +0530, Shubhrajyoti Datta wrote: @@ -1268,23 +1271,8 @@ static int omap_i2c_runtime_resume(struct device *dev) { struct omap_i2c_dev *_dev = dev_get_drvdata(dev); - if (_dev-flags OMAP_I2C_FLAG_RESET_REGS_POSTIDLE) { -

Re: [PATCH] i2c: omap: re-factor omap_i2c_init function

2012-10-23 Thread Shubhrajyoti Datta
On Tue, Oct 23, 2012 at 11:27 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Oct 23, 2012 at 11:26:15PM +0530, Shubhrajyoti Datta wrote: @@ -1268,23 +1271,8 @@ static int omap_i2c_runtime_resume(struct device *dev) { struct omap_i2c_dev *_dev = dev_get_drvdata(dev); -

[PATCH] gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable

2012-10-23 Thread Kevin Hilman
From: Kevin Hilman khil...@ti.com When debounce clocks are disabled, ensure that the banks dbck_enable_mask is cleared also. Otherwise, context restore on subsequent off-mode transition will restore previous value from the shadow copies (bank-context.debounce*) leading to mismatch state between

Re: OMAP baseline test results for v3.7-rc2

2012-10-23 Thread Kevin Hilman
Kevin Hilman khil...@deeprootsystems.com writes: +Igor Paul Walmsley p...@pwsan.com writes: Here are some basic OMAP test results for Linux v3.7-rc2. Logs and other details at: http://www.pwsan.com/omap/testlogs/test_v3.7-rc2/20121020134755/ [...] * 37xx EVM: CORE not entering

Re: [PATCH] gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable

2012-10-23 Thread Felipe Balbi
Hi, On Tue, Oct 23, 2012 at 11:09:31AM -0700, Kevin Hilman wrote: From: Kevin Hilman khil...@ti.com When debounce clocks are disabled, ensure that the banks dbck_enable_mask is cleared also. Otherwise, context restore on subsequent off-mode transition will restore previous value from the

Re: OMAP baseline test results for v3.7-rc1

2012-10-23 Thread Kevin Hilman
Jean Pihet jean.pi...@newoldbits.com writes: Hi, On Sat, Oct 20, 2012 at 8:14 AM, Paul Walmsley p...@pwsan.com wrote: Hi Jean On Fri, 19 Oct 2012, Paul Walmsley wrote: On Thu, 18 Oct 2012, Paul Walmsley wrote: Here are some basic OMAP test results for Linux v3.7-rc1. Logs and other

Re: [PATCH] i2c: omap: re-factor omap_i2c_init function

2012-10-23 Thread Felipe Balbi
Hi, On Tue, Oct 23, 2012 at 08:57:19PM +0530, Shubhrajyoti D wrote: re-factor omap_i2c_init() so that we can re-use it for resume. While at it also remove the bufstate variable as we write it in omap_i2c_resize_fifo for every transfer. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com ---

Re: OMAP baseline test results for v3.7-rc1

2012-10-23 Thread Paul Walmsley
Hi On Mon, 22 Oct 2012, Jean Pihet wrote: I tried the latest l-o with omap2plus defconfig on my Beagleboard B5 (ES2.1) and could not reproduce the problem. I do not have the I2C error messages at boot, nor at user space start up. I tried to read/write the TWL RTC, successfully. Another

Re: OMAP baseline test results for v3.7-rc1

2012-10-23 Thread Paul Walmsley
On Mon, 22 Oct 2012, Jean Pihet wrote: On Mon, Oct 22, 2012 at 6:12 PM, Jean Pihet jean.pi...@newoldbits.com wrote: Do you have CPU_IDLE enabled? FYI the issue is not present with CPU_IDLE enabled. Hmm, how can you tell? I thought you weren't able to reproduce it with CPU_IDLE disabled

Re: OMAP baseline test results for v3.7-rc1

2012-10-23 Thread Jean Pihet
On Tue, Oct 23, 2012 at 9:19 PM, Paul Walmsley p...@pwsan.com wrote: On Mon, 22 Oct 2012, Jean Pihet wrote: On Mon, Oct 22, 2012 at 6:12 PM, Jean Pihet jean.pi...@newoldbits.com wrote: Do you have CPU_IDLE enabled? FYI the issue is not present with CPU_IDLE enabled. Hmm, how can you

Re: OMAP baseline test results for v3.7-rc2

2012-10-23 Thread Paul Walmsley
On Mon, 22 Oct 2012, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [121022 09:30]: On 10/20/2012 04:26 PM, Paul Walmsley wrote: * 2430sdp: vfp_reload_hw oops during MMC initialization - Kernel attempts to save FP registers that don't exist; fix posted: -

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-23 Thread Dmitry Torokhov
On Tue, Oct 23, 2012 at 11:18:12AM +0200, Benoit Cousson wrote: Hi Dimitry, On 10/22/2012 05:50 PM, Dmitry Torokhov wrote: Hi Sourav, On Mon, Oct 22, 2012 at 06:43:00PM +0530, Sourav Poddar wrote: Adapt keypad to use pinctrl framework. Tested on omap4430 sdp with 3.7-rc1 kernel.

[PATCH] ARM: PMU: fix runtime PM enable

2012-10-23 Thread Jon Hunter
Commit 7be2958 (ARM: PMU: Add runtime PM Support) updated the ARM PMU code to use runtime PM which was prototyped and validated on the OMAP devices. In this commit, there is no call pm_runtime_enable() and for OMAP devices pm_runtime_enable() is currently being called from the OMAP PMU code when

OMAP NAND driver issue with subpage reads

2012-10-23 Thread Juha Kuikka
Hi, There seems to be an issue in the omap nand driver (drivers/mtd/nand/omap2.c) concerning sub-page reads (visible when using 16bit LP NAND, SOFT_ECC and UBI). Problem is caused by the omap_read_buf_pref() function using 32bit reads from the pre-fetch engine. It takes care of the mis-aligned

Re: OMAP baseline test results for v3.7-rc2

2012-10-23 Thread Kevin Hilman
Matt Porter mpor...@ti.com writes: [...] Ok, very quick update...no need to mess around with the eeprom. I just received the official word on what will be supported. Since A2 is pre-release, simply go to http://beagleboard.org/support/rma and fill out the form to have it replaced with the

Re: OMAP baseline test results for v3.7-rc2

2012-10-23 Thread Matt Porter
On Tue, Oct 23, 2012 at 02:03:43PM -0700, Kevin Hilman wrote: Matt Porter mpor...@ti.com writes: [...] Ok, very quick update...no need to mess around with the eeprom. I just received the official word on what will be supported. Since A2 is pre-release, simply go to

[RFC PATCH 3/6] ARM: OMAP: voltage: move voltdm_reset to platform_data header

2012-10-23 Thread Nishanth Menon
Move voltdm_reset to include/linux/platform_data/voltage-omap.h This is an intermediate step to allow usage of the header by smartreflex driver for usage of the same. Signed-off-by: Nishanth Menon n...@ti.com --- arch/arm/mach-omap2/voltage.h |1 -

[RFC PATCH 0/6] ARM: OMAP3+: move smartreflex-class3.c to drivers/power/avs

2012-10-23 Thread Nishanth Menon
smartreflex.c now resides in drivers/power/avs directory, but class driver is in mach-omap2. High time we move it off to drivers/power/avs. This series *does not* try to fix VP/VC to be voltage regulator OR introduce a new OMAP voltage regulator series. instead, it purely tries to do the minimal

[RFC PATCH 1/6] PM / AVS / OMAP: move Kconfig definition of smartreflex to avs directory

2012-10-23 Thread Nishanth Menon
Don't see why the source should be in drivers/power/avs, but not config option Signed-off-by: Nishanth Menon n...@ti.com --- arch/arm/plat-omap/Kconfig | 22 -- drivers/power/avs/Kconfig | 22 ++ 2 files changed, 22 insertions(+), 22 deletions(-)

[RFC PATCH 2/6] ARM: OMAP: voltage: remove duplicate header definitions

2012-10-23 Thread Nishanth Menon
Remove duplicate definitions which are already present in linux/platform_data/voltage-omap.h Signed-off-by: Nishanth Menon n...@ti.com --- arch/arm/mach-omap2/voltage.h |3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/mach-omap2/voltage.h b/arch/arm/mach-omap2/voltage.h index

[RFC PATCH 5/6] ARM: OMAP: SmartReflex: use pr_warn instead of pr_warning

2012-10-23 Thread Nishanth Menon
Minor cleanup to use the preferred pr_warn Signed-off-by: Nishanth Menon n...@ti.com --- arch/arm/mach-omap2/smartreflex-class3.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex-class3.c b/arch/arm/mach-omap2/smartreflex-class3.c index

[RFC PATCH 6/6] PM / AVS / OMAP: move Smartreflex-class3 driver to power/avs

2012-10-23 Thread Nishanth Menon
Move the SmartReflex AVS class3 driver to AVS directory along with the config definition Signed-off-by: Nishanth Menon n...@ti.com --- arch/arm/mach-omap2/Makefile |1 - arch/arm/plat-omap/Kconfig |9 - drivers/power/avs/Kconfig

[RFC PATCH 4/6] ARM: OMAP: SmartReflex: provide SoC integration API for VP

2012-10-23 Thread Nishanth Menon
SoC integration of SmartReflex AVS block is varied. Some use Voltage Processor for a hardware loop in certain OMAP SoC (called hardware loop), while others have just the AVS block without hardware loop automatic calibration mechanism for AVS block to talk through. So provide the Voltage Processor

Re: [PATCH] gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable

2012-10-23 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: Hi, On Tue, Oct 23, 2012 at 11:09:31AM -0700, Kevin Hilman wrote: From: Kevin Hilman khil...@ti.com When debounce clocks are disabled, ensure that the banks dbck_enable_mask is cleared also. Otherwise, context restore on subsequent off-mode transition

Re: [PATCH 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod

2012-10-23 Thread Mark A. Greer
On Mon, Oct 22, 2012 at 07:49:47PM +, Paul Walmsley wrote: On Mon, 22 Oct 2012, Mark A. Greer wrote: On Sat, Oct 20, 2012 at 07:40:19PM +, Paul Walmsley wrote: static void omap_init_sham(void) { - if (cpu_is_omap24xx()) { - sham_device.resource

[GIT PULL] ARM: OMAP: PM fixes for v3.7-rc3

2012-10-23 Thread Kevin Hilman
Tony, Here are a few more fixes PM-related fixes for v3.7-rc Kevin The following changes since commit 6f0c0580b70c89094b3422ba81118c7b959c7556: Linux 3.7-rc2 (2012-10-20 12:11:32 -0700) are available in the git repository at:

Re: [PATCH] genirq: provide means to retrigger parent

2012-10-23 Thread Kevin Hilman
Russell King - ARM Linux li...@arm.linux.org.uk writes: On Tue, Oct 16, 2012 at 03:07:49PM -0700, Kevin Hilman wrote: From: Thomas Gleixner t...@linutronix.de Attempts to retrigger nested threaded IRQs currently fail because they have no primary handler. In order to support retrigger of

Re: [PATCH] genirq: provide means to retrigger parent

2012-10-23 Thread Thomas Gleixner
On Tue, 23 Oct 2012, Kevin Hilman wrote: Russell King - ARM Linux li...@arm.linux.org.uk writes: On Tue, Oct 16, 2012 at 03:07:49PM -0700, Kevin Hilman wrote: From: Thomas Gleixner t...@linutronix.de Attempts to retrigger nested threaded IRQs currently fail because they have no

Re: [PATCH v2 1/4] ARM: dts: omap5: Update GPIO with address space and interrupts

2012-10-23 Thread Jon Hunter
Hi Mitch, On 10/23/2012 11:55 AM, Mitch Bradley wrote: On 10/23/2012 4:49 AM, Jon Hunter wrote: Therefore, I believe it will improve search time and hence, boot time if we have interrupt-parent defined in each node. I strongly suspect (based on many years of performance tuning, with

Re: [PATCH v2 1/4] ARM: dts: omap5: Update GPIO with address space and interrupts

2012-10-23 Thread Mitch Bradley
On 10/23/2012 1:15 PM, Jon Hunter wrote: Hi Mitch, On 10/23/2012 11:55 AM, Mitch Bradley wrote: On 10/23/2012 4:49 AM, Jon Hunter wrote: Therefore, I believe it will improve search time and hence, boot time if we have interrupt-parent defined in each node. I strongly suspect (based on

Re: [GIT PULL] ARM: OMAP: PM fixes for v3.7-rc3

2012-10-23 Thread Tony Lindgren
* Kevin Hilman khil...@deeprootsystems.com [121023 15:15]: Tony, Here are a few more fixes PM-related fixes for v3.7-rc Kevin The following changes since commit 6f0c0580b70c89094b3422ba81118c7b959c7556: Linux 3.7-rc2 (2012-10-20 12:11:32 -0700) are available in the git

Re: Errors at boot time from OMAP4430SDP (and a whinge about serial stuff)

2012-10-23 Thread Tony Lindgren
* Ohad Ben-Cohen o...@wizery.com [121021 07:56]: On Fri, Oct 19, 2012 at 7:07 PM, Tony Lindgren t...@atomide.com wrote: --- a/arch/arm/mach-davinci/board-da850-evm.c +++ b/arch/arm/mach-davinci/board-da850-evm.c @@ -1401,13 +1401,9 @@ static __init int da850_wl12xx_init(void)

Re: [PATCH] ARM: AM33XX: Fix configuration of dmtimer parent clock by dmtimer driver

2012-10-23 Thread Tony Lindgren
* Jon Hunter jon-hun...@ti.com [121017 11:57]: From: Vaibhav Hiremath hvaib...@ti.com Add dmtimer clock aliases for AM33XX devices so that the parent clock for the dmtimer can be set correctly by the dmtimer driver. Without these clock aliases the dmtimer driver will fail to find the parent

[PATCH v2 0/7] crypto: omap-sham updates

2012-10-23 Thread Mark A. Greer
From: Mark A. Greer mgr...@animalcreek.com Changes since v1: - Removed the check of CM_IDLEST to see if the module exists and instead add the hwmod data for all omap2's and omap3 GP's. - Placed new sha_ick clk entries after the 'omap-sham' entry in the

[PATCH v2 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod

2012-10-23 Thread Mark A. Greer
From: Mark A. Greer mgr...@animalcreek.com Convert the device data for the OMAP2 SHAM crypto IP from explicit platform_data to hwmod. CC: Paul Walmsley p...@pwsan.com Signed-off-by: Mark A. Greer mgr...@animalcreek.com --- arch/arm/mach-omap2/clock2430_data.c | 1 +

[PATCH v2 2/7] ARM: OMAP2xxx: hwmod: Add DMA support for SHAM module

2012-10-23 Thread Mark A. Greer
From: Mark A. Greer mgr...@animalcreek.com The current OMAP2 SHAM support doesn't enable DMA so add that support so it can use DMA just like OMAP3. CC: Paul Walmsley p...@pwsan.com Signed-off-by: Mark A. Greer mgr...@animalcreek.com --- arch/arm/mach-omap2/omap_hwmod_2xxx_interconnect_data.c |

[PATCH v2 4/7] ARM: OMAP2+: Remove unnecessary message when no SHA IP is present

2012-10-23 Thread Mark A. Greer
From: Mark A. Greer mgr...@animalcreek.com Remove the error message that prints when there is no SHA IP present to make it consistent with all the other IPs. CC: Paul Walmsley p...@pwsan.com Signed-off-by: Mark A. Greer mgr...@animalcreek.com --- arch/arm/mach-omap2/devices.c | 19

[PATCH v2 3/7] ARM: OMAP3xxx: hwmod: Convert SHAM crypto device data to hwmod

2012-10-23 Thread Mark A. Greer
From: Mark A. Greer mgr...@animalcreek.com Convert the device data for the OMAP3 SHAM2 (SHA1/MD5) crypto IP from explicit platform_data to hwmod. CC: Paul Walmsley p...@pwsan.com Signed-off-by: Mark A. Greer mgr...@animalcreek.com --- arch/arm/mach-omap2/clock3xxx_data.c | 1 +

[PATCH v2 5/7] crypto: omap-sham: Convert to use pm_runtime API

2012-10-23 Thread Mark A. Greer
From: Mark A. Greer mgr...@animalcreek.com Convert the omap-sham crypto driver to use the pm_runtime API instead of the clk API. CC: Kevin Hilman khil...@deeprootsystems.com CC: Paul Walmsley p...@pwsan.com CC: Dmitry Kasatkin dmitry.kasat...@intel.com Signed-off-by: Mark A. Greer

[PATCH v2 6/7] crypto: omap-sham: Add code to use dmaengine API

2012-10-23 Thread Mark A. Greer
From: Mark A. Greer mgr...@animalcreek.com Add code to use the new dmaengine API alongside the existing DMA code that uses the private OMAP DMA API. The API to use is chosen by defining or undefining 'OMAP_SHAM_DMA_PRIVATE'. CC: Russell King rmk+ker...@arm.linux.org.uk CC: Dmitry Kasatkin

[PATCH v2 7/7] crypto: omap_sham: Remove usage of private DMA API

2012-10-23 Thread Mark A. Greer
From: Mark A. Greer mgr...@animalcreek.com Remove usage of the private OMAP DMA API. The dmaengine API will be used instead. CC: Russell King rmk+ker...@arm.linux.org.uk CC: Dmitry Kasatkin dmitry.kasat...@intel.com Signed-off-by: Mark A. Greer mgr...@animalcreek.com ---

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-23 Thread Tomi Valkeinen
On 2012-10-23 20:21, Ricardo Neri wrote: If so, you could pass only that one address, instead of the whole HDMI register space? Yes, that could work. I thought about that but the common HDMI driver would have to know the the IP-specific register, which it should not. Argh, of course...

Re: Fwd: [PATCH 2/5] ARM: OMAP3+: hwmod: Add AM33XX HWMOD data for davinci_mdio

2012-10-23 Thread Richard Cochran
On Tue, Oct 23, 2012 at 10:12:29AM +, Hiremath, Vaibhav wrote: I understand, and as you mentioned we are not fully there at v3.7-rc1 with all the drivers/module support, due to all known reasons. Its good that with v3.7-rc2, Beaglebone boots up out of box from mainline. Can you say

  1   2   >