Re: [PATCH] rtc-twl: Switch to using threaded irq

2011-04-13 Thread Krishnamoorthy, Balaji T
On Wed, Mar 16, 2011 at 9:37 PM, Ilkka Koskinen ilkka.koski...@nokia.com wrote: The driver is accessing to i2c bus in interrupt handler. Therefore, it should use threaded irq. Acked-by: Balaji T K balaj...@ti.com Signed-off-by: Ilkka Koskinen ilkka.koski...@nokia.com ---  

Re: [PATCH 2 14/18] I2C: OMAP1/OMAP2+: create omap I2C functionality flags for each cpu_... test

2011-03-09 Thread Krishnamoorthy, Balaji T
On Tue, Mar 8, 2011 at 4:39 PM, Andy Green a...@warmcat.com wrote: +/* struct omap_i2c_bus_platform_data .flags meanings */ + +#define OMAP_I2C_FLAG_NO_FIFO 1 Hi, Minor comment, Can you use BIT(0) for 1, BIT(1) for 2 ... BIT (8) for 0x100 +#define OMAP_I2C_FLAG_SIMPLE_CLOCK 2 +#define

Re: [PATCH v8 4/7] omap3: pm: TWL5030 version checking

2011-03-03 Thread Krishnamoorthy, Balaji T
On Wed, Mar 2, 2011 at 7:00 PM, Lesly A M lesl...@ti.com wrote: snip  static struct device *  add_numbered_child(unsigned chip, const char *name, int num,                void *pdata, unsigned pdata_len, @@ -1056,6 +1114,9 @@ twl_probe(struct i2c_client *client, const struct i2c_device_id

Re: State of SDP4430 platform

2011-03-03 Thread Krishnamoorthy, Balaji T
in ES1, timeouts were observed only with RTC. I2C burst access to IRQ registers and bq24156 were OK Was an errata generated for this bug? er, erratum, pardon me... Is an erratum present for this bug? Also, will you generate a patch for this to at least warn the user when

Re: [PATCH 5/8] omap3: pm: TWL5030 version checking

2011-02-28 Thread Krishnamoorthy, Balaji T
On Mon, Feb 28, 2011 at 4:34 PM, Manuel, Lesly Arackal lesl...@ti.com wrote: Hi Balaji, On Mon, Feb 28, 2011 at 12:54 PM, Krishnamoorthy, Balaji T balaj...@ti.com wrote: On Sat, Feb 26, 2011 at 5:55 PM, Lesly A M lesl...@ti.com wrote: Minor comment you missed version number in subject

Re: [PATCH 2/2 v4] mfd: twl4030: Driver for twl4030 madc module

2011-02-28 Thread Krishnamoorthy, Balaji T
On Mon, Feb 28, 2011 at 3:18 PM, Keerthy j-keer...@ti.com wrote: +static int twl4030_madc_read_channels(struct twl4030_madc_data *madc, +                                     u8 reg_base, unsigned +                                               long channels, int *buf) +{ +       int count =

Re: [PATCH 5/8] omap3: pm: TWL5030 version checking

2011-02-27 Thread Krishnamoorthy, Balaji T
On Sat, Feb 26, 2011 at 5:55 PM, Lesly A M lesl...@ti.com wrote: Minor comment you missed version number in subject. snip +/** + * twl_get_si_type - api to get TWL Si type. + * + * Api to get the TWL Si type from IDCODE value. + */ +int twl_get_si_type(void) +{ +       return

Re: [PATCH v4 5/6] OMAP: adapt hsmmc to hwmod framework

2011-02-25 Thread Krishnamoorthy, Balaji T
snip -               if (cpu_is_omap44xx()) -                       mmc-reg_offset = OMAP4_MMC_REG_OFFSET; -               else -                       mmc-reg_offset = 0; +static struct omap_mmc_platform_data *mmc __initdata; can you pass this *mmc as another argument to

Re: [PATCH 09/12] omap3: pm: TWL5030 version checking

2011-02-21 Thread Krishnamoorthy, Balaji T
On Fri, Feb 18, 2011 at 10:38 PM, Lesly A M lesl...@ti.com wrote: snip +int twl5030_get_si_ver(u32 *value) +{ +       int ret = 0; +       static u32 twl_idcode; + +       if (twl_idcode == 0) +               ret = twl_read_idcode_register(twl_idcode); +       if (ret) +              

Re: [PATCH] OMAP4:Fix -EINVAL for vana, vcxio, vdac

2011-02-17 Thread Krishnamoorthy, Balaji T
On Mon, Feb 7, 2011 at 8:59 PM, Balaji T K balaj...@ti.com wrote: Fixed regulators in twl6030 do not have set_voltage hook. Regulator core returns -22 if set_voltage is NULL and apply_uV is set while applying the constraint to set voltage resulting in failure during probe of these regulators.

Re: [PATCH v2 0/5] OMAP: HSMMC: hwmod adaptation

2011-02-10 Thread Krishnamoorthy, Balaji T
On Wed, Feb 9, 2011 at 5:14 AM, Tony Lindgren t...@atomide.com wrote: * Kishore Kadiyala kishore.kadiy...@ti.com [110208 12:45]: Adding hwmod data for hsmmc device on OMAP2420/OMAP2430/OMAP3/OMAP4. Adapting the omap_hsmmc driver to hwmod framework V2: --- Updated hwmod data for OMAP2420

Re: [PATCH 1/2] regulator: twl: add clk32kg to twl-regulator

2011-02-09 Thread Krishnamoorthy, Balaji T
On Wed, Feb 9, 2011 at 9:14 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Feb 09, 2011 at 09:07:25PM +0530, Balaji T K wrote: -     TWL6030_FIXED_LDO(VUSB, 0x70, 3300, 18, 0, 0x21) +     TWL6030_FIXED_LDO(VUSB, 0x70, 3300, 18, 0, 0x21), +     TWL6030_FIXED_LDO(CLK32KG,

Re: [PATCH 2/2] OMAP4: add clk32kg data to omap4panda and blaze board file

2011-02-09 Thread Krishnamoorthy, Balaji T
On Wed, Feb 9, 2011 at 9:15 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Feb 09, 2011 at 09:07:31PM +0530, Balaji T K wrote: +     .constraints = { +             .valid_modes_mask       = REGULATOR_MODE_NORMAL +                                     |

Re: State of SDP4430 platform

2011-02-06 Thread Krishnamoorthy, Balaji T
On Sun, Feb 6, 2011 at 3:19 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: lm75 3-0048: hwmon0: sensor 'tmp105' omap_i2c omap_i2c.1: controller timed out omap_i2c omap_i2c.1: controller timed out omap_i2c omap_i2c.2: controller timed out omap_i2c omap_i2c.2: controller timed out

Re: State of SDP4430 platform

2011-01-19 Thread Krishnamoorthy, Balaji T
On Tue, Jan 18, 2011 at 4:49 AM, Paul Walmsley p...@pwsan.com wrote: On Mon, 17 Jan 2011, Santosh Shilimkar wrote: The I2C timeout issue I could reproduce on my ES1.0 board. It's ES1.0 specific issue because I2C burst mode wasn't fuctional on it. Twl RTC driver uses I2C burst mode and hence

RE: [RFC][PATCH] [I2C]pass scll, sclh through board file for Errata i585

2010-04-28 Thread Krishnamoorthy, Balaji T
From: Tony Lindgren [mailto:t...@atomide.com] * balaj...@ti.com balaj...@ti.com [100419 07:59]: From: Balaji T K balaj...@ti.com Errata ID: i535 - I2C1 to 3 SCL low period is shorter in FS mode Due to IO cell influence, I2C1 to 3 SCL low period can be shorter than expected. As a

RE: [PATCH] twl6030: add base addr for ID0, ID1, ID2

2010-02-18 Thread Krishnamoorthy, Balaji T
Sending this as a separate patch which was earlier combined with the series http://marc.info/?l=linux-omapm=126633460408606w=2 -Original Message- From: Krishnamoorthy, Balaji T Sent: Thursday, February 18, 2010 10:30 PM To: linux-omap@vger.kernel.org; sa...@linux.intel.com Cc: t

RE: [PATCH] mfd: twl: fix twl4030 rename for remaining driver, board files

2009-12-16 Thread Krishnamoorthy, Balaji T
From: Peter Ujfalusi [mailto:peter.ujfal...@nokia.com] I have not followed the thread too closely, but have you made the changes also to the sound/soc/codec/twl4030.c driver as well, since that also includes the linux/i2c/twl4030.h ? Yes, that has been taken care I should have taken little

RE: [PATCH v2] mfd: twl: fix twl4030 rename for remaining driver, board files

2009-12-16 Thread Krishnamoorthy, Balaji T
-Original Message- From: Tony Lindgren [mailto:t...@atomide.com] * Tony Lindgren t...@atomide.com [091215 10:19]: * Tony Lindgren t...@atomide.com [091215 09:43]: * Krishnamoorthy, Balaji T balaj...@ti.com [091215 08:09]: Hi Samuel, Could you please take this patch

RE: commit fc7b92fca4e546184557f1c53f84ad57c66b7695 broke compilation

2009-12-15 Thread Krishnamoorthy, Balaji T
-Original Message- From: Felipe Balbi [mailto:felipe.ba...@nokia.com] Sent: Tuesday, December 15, 2009 5:28 PM To: Linux OMAP Mailing List Cc: Krishnamoorthy, Balaji T Subject: commit fc7b92fca4e546184557f1c53f84ad57c66b7695 broke compilation Hi, the patch renaming twl4030

RE: [PATCH v2] mfd: twl: fix twl4030 rename for remaining driver, board files

2009-12-15 Thread Krishnamoorthy, Balaji T
Hi Samuel, Could you please take this patch through the mfd tree. Thanks and Regards, Balaji T K -Original Message- From: Krishnamoorthy, Balaji T Sent: Tuesday, December 15, 2009 8:09 PM To: linux-omap@vger.kernel.org; sa...@linux.intel.com Cc: broo...@opensource.wolfsonmicro.com

[PATCH v4 0/8] TWL6030 patch series

2009-12-11 Thread Krishnamoorthy, Balaji T
The TWL6030 is companion chip for OMAP4 like the current TWL4030 for OMAP3. This patch series adds support for TWL6030 irq framework, and driver support for RTC and regulator. [PATCH v4 01/08] ARM: OMAP: Rename twl4030* driver files to enable re-use [PATCH v4 02/08] ARM: OMAP:

RE: [PATCH v3 0/4] TWL patch series

2009-12-08 Thread Krishnamoorthy, Balaji T
Hi Samuel, This patch is not merged. Please let me know if I am missing something so that i can post the patches rebased on the latest 2.6.32. Thanks and Regards, Balaji T K -Original Message- From: Krishnamoorthy, Balaji T Sent: Thursday, October 01, 2009 5:35 PM To: linux-omap

[PATCH v3 0/4] TWL patch series

2009-10-01 Thread Krishnamoorthy, Balaji T
This patch series v3 incorporates comments received earlier[1]. The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030 for OMAP3. The common modules like RTC, Regulator creates opportunity to re-use the most of the code from twl4030. [PATCH v3 01/04] ARM: OMAP: Rename

[PATCH v3 0/4] TWL6030 patch series

2009-10-01 Thread Krishnamoorthy, Balaji T
This patch series v3 incorporates comments received earlier[1]. The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030 for OMAP3. This patch series adds support for TWL6030 irq framework, and driver support for RTC and regulator. These patches has dependancy on TWL patch

RE: [PATCH v3 01/04] ARM: OMAP: Rename twl4030* driver files to enable re-use

2009-10-01 Thread Krishnamoorthy, Balaji T
On Thu, Oct 01, 2009 at 05:46:49PM +0530, balaj...@ti.com wrote: The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030 for OMAP3. The common modules like RTC, Regulator creates opportunity to re-use the most of the code from twl4030. This patch renames few common

RE: [RFC][PATCH 0/4] TWL6030 patch series

2009-08-17 Thread Krishnamoorthy, Balaji T
-Original Message- From: Samuel Ortiz [mailto:sa...@linux.intel.com] On Mon, Aug 17, 2009 at 10:46:55AM +0530, Krishnamoorthy, Balaji T wrote: From: Samuel Ortiz [mailto:sa...@linux.intel.com] * Why are you moving twl_init_irq and twl_exit_irq to twl.h ? twl_init_irq

RE: [RFC][PATCH 0/4] TWL6030 patch series

2009-08-16 Thread Krishnamoorthy, Balaji T
-Original Message- From: Samuel Ortiz [mailto:sa...@linux.intel.com] Sent: Monday, August 17, 2009 5:30 AM To: Krishnamoorthy, Balaji T Cc: linux-omap@vger.kernel.org; t...@atomide.com; khil...@deeprootsystems.com; davi...@pacbell.net; Shilimkar, Santosh; Nayak, Rajendra; sa

RE: [RFC][PATCH 0/4] TWL6030 patch series

2009-08-11 Thread Krishnamoorthy, Balaji T
Hi All, Can I have your comments on this so that I can rebase the patch for the upcoming merge window. Thanks and Regards, Balaji T K -Original Message- From: Krishnamoorthy, Balaji T Sent: Thursday, August 06, 2009 2:28 PM To: sa...@linux.intel.com Cc: linux-omap@vger.kernel.org

RE: [RFC][PATCH v2 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators

2009-08-04 Thread Krishnamoorthy, Balaji T
From: Shilimkar, Santosh From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Tony Lindgren * Mark Brown broo...@opensource.wolfsonmicro.com [090803 17:23]: On Wed, Jul 29, 2009 at 10:06:13AM +0530, balaj...@ti.com wrote: - if

[RFC][PATCH 0/4] TWL6030 patch series

2009-07-20 Thread Krishnamoorthy, Balaji T
The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030 for OMAP3. This patch series adds support for TWL6030 irq framework, and driver support for RTC and regulator. drivers/mfd/twl6030-irq.c files is newly added as INTERRUPT status registers, ack and

RE: [RFC][PATCH 0/4] TWL6030 patch series

2009-07-20 Thread Krishnamoorthy, Balaji T
-Original Message- From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] Sent: Monday, July 20, 2009 5:45 PM To: Felipe Balbi Cc: Krishnamoorthy, Balaji T; linux-omap@vger.kernel.org; t...@atomide.com; khil...@deeprootsystems.com; davi...@pacbell.net; Shilimkar, Santosh

[RFC][PATCH 0/4] TWL6030 patch series

2009-07-20 Thread Krishnamoorthy, Balaji T
The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030 for OMAP3. This patch series adds support for TWL6030 irq framework, and driver support for RTC and regulator. drivers/mfd/twl6030-irq.c files is newly added as INTERRUPT status registers, ack and

[PATCH 0/4] TWL patch series

2009-07-14 Thread Krishnamoorthy, Balaji T
The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030 for OMAP3. The common modules like RTC, Regulator creates opportunity to re-use the most of the code from twl4030. Summary of Major difference between Triton and Phoenix chips are: -GPIO, Keypad is not present