Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2016-01-03 Thread Paul Kocialkowski
Le jeudi 31 décembre 2015 à 22:14 +, Mark Brown a écrit : > On Thu, Dec 31, 2015 at 10:59:06PM +0100, Paul Kocialkowski wrote: > > > I understand, thanks for pointing this out. Well, for my use case, there > > is no use in disabling the chip at any point as it powers th

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-31 Thread Paul Kocialkowski
Le jeudi 31 décembre 2015 à 21:40 +, Mark Brown a écrit : > On Wed, Dec 30, 2015 at 07:37:19PM +0100, Paul Kocialkowski wrote: > > Le mercredi 30 décembre 2015 à 16:33 +, Mark Brown a écrit : > > > On Wed, Dec 30, 2015 at 09:35:21AM +0100, Paul Kocialkowski wrote: >

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-30 Thread Paul Kocialkowski
Le mercredi 30 décembre 2015 à 16:33 +, Mark Brown a écrit : > On Wed, Dec 30, 2015 at 09:35:21AM +0100, Paul Kocialkowski wrote: > > > In my opinion, it would be more elegant to adapt the core regulator > > framework to first enable the GPIO and then call the regula

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-30 Thread Paul Kocialkowski
Hi Milo, Le mercredi 30 décembre 2015 à 09:22 +0900, Milo Kim a écrit : > Hi Paul, > > On 29/12/15 20:13, Paul Kocialkowski wrote: > > Hi Milo, > > > > Le mardi 29 décembre 2015 à 09:45 +0900, Milo Kim a écrit : > >> Hi Paul, > >> > >> On

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-29 Thread Paul Kocialkowski
Le mardi 29 décembre 2015 à 14:02 -0600, Rob Herring a écrit : > On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > > LP872x regulators are made active via the EN pin, which might be hooked to a > > GPIO. This adds support for driving the GPIO high when the d

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-29 Thread Paul Kocialkowski
Hi Milo, Le mardi 29 décembre 2015 à 09:45 +0900, Milo Kim a écrit : > Hi Paul, > > On 29/12/15 07:49, Paul Kocialkowski wrote: > > Hi Milo, thanks for the review, > > > > Le lundi 28 décembre 2015 à 09:56 +0900, Milo Kim a écrit : > >> Hi Paul, > >

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-28 Thread Paul Kocialkowski
Hi Milo, thanks for the review, Le lundi 28 décembre 2015 à 09:56 +0900, Milo Kim a écrit : > Hi Paul, > > On 23/12/15 20:56, Mark Brown wrote: > > On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > > > >> + gpio = lp->pdata->enable_g

Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features

2015-12-24 Thread Paul Kocialkowski
Hi, Le mercredi 23 décembre 2015 à 07:44 -0800, Tony Lindgren a écrit : > * Paul Kocialkowski <cont...@paulk.fr> [151223 03:00]: > > + { > > + ti,no-reset-on-init; > > +}; > > + > > + { > > + ti,no-reset-on-init; >

Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features

2015-12-24 Thread Paul Kocialkowski
please use the IOPAD mux macros from > include/dt-bindings/pinctrl/omap.h instead? > > We just did a massive cleanup on the OMAP DTS to use them instead of > an offset from the padconf registers. Sure thing, will do in v2. Thanks for the review! -- Paul Kocialkowski, Replicant develo

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-24 Thread Paul Kocialkowski
Le jeudi 24 décembre 2015 à 19:35 +, Mark Brown a écrit : > On Thu, Dec 24, 2015 at 07:12:53PM +0100, Paul Kocialkowski wrote: > > Le mercredi 23 décembre 2015 à 11:56 +, Mark Brown a écrit : > > > > This isn't really adding support for the enable GPIO as the cha

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-24 Thread Paul Kocialkowski
Le mercredi 23 décembre 2015 à 11:56 +, Mark Brown a écrit : > On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > > > + gpio = lp->pdata->enable_gpio; > > + if (!gpio_is_valid(gpio)) > > + return 0; > > + > > + /* A

Re: [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS GPIO

2015-12-23 Thread Paul Kocialkowski
Le mercredi 23 décembre 2015 à 11:41 +, Mark Brown a écrit : > On Wed, Dec 23, 2015 at 11:58:36AM +0100, Paul Kocialkowski wrote: > > Some devices don't hook the DVS pin to a GPIO but to ground or VCC. > > In those cases, it is not a problem to have no DVS GPIO. > > I wo

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-23 Thread Paul Kocialkowski
Le mercredi 23 décembre 2015 à 11:56 +, Mark Brown a écrit : > On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > > > + gpio = lp->pdata->enable_gpio; > > + if (!gpio_is_valid(gpio)) > > + return 0; > > + > > + /* A

[PATCH 0/6] LG Optimus Black (P970) codename sniper support and lp872x improvements

2015-12-23 Thread Paul Kocialkowski
This series introduces support for the LG Optimus Black, as described in the patch adding devicetree support for the device. In order to power the external mmc (mmc1), the lp872x regulator is used. Its code had to be improved a bit to work on the device. Note that the patch adding devicetree

[PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features

2015-12-23 Thread Paul Kocialkowski
, internal emmc and external mmc. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/omap3-sniper.dts | 220 + 2 files changed, 221 insertions(+) create mode 100644 arch/arm/boot/dts

[PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to DVS GPIO

2015-12-23 Thread Paul Kocialkowski
The lp872x structure holds a reference to the DVS GPIO, but it is never actually used anywhere, since a first reference exists from the lp872x_dvs structure. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- drivers/regulator/lp872x.c | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-23 Thread Paul Kocialkowski
LP872x regulators are made active via the EN pin, which might be hooked to a GPIO. This adds support for driving the GPIO high when the driver is in use. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- .../devicetree/bindings/regulator/lp872x.txt | 1 + drivers/regulator/lp

[PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS GPIO

2015-12-23 Thread Paul Kocialkowski
Some devices don't hook the DVS pin to a GPIO but to ground or VCC. In those cases, it is not a problem to have no DVS GPIO. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- drivers/regulator/lp872x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/reg

[PATCH 1/6] regulator: lp872x: Add missing of_match in regulators descriptions

2015-12-23 Thread Paul Kocialkowski
In order to select the regulators via of_find_regulator_by_node (and thus use them in devicetree), defining of_match for each regulator is required. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- drivers/regulator/lp872x.c | 15 +++ 1 file changed, 15 insertions(+)

[PATCH 6/6] ARM: multi_v7_defconfig: Enable LP872x regulator support

2015-12-23 Thread Paul Kocialkowski
The LP872x regulator is used in the LG Optimus Black (P970) codename sniper to supply the external mmc card. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig