Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

On 04/12/15 11:18, Grygorii Strashko wrote: On 12/04/2015 12:54 PM, Sudeep Holla wrote: Hi Grygorii, On 04/12/15 10:44, Grygorii Strashko wrote: On 12/03/2015 11:37 PM, Tony Lindgren wrote: [...] And these both need to be applied together when we have a fix for the above as otherwise

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

On 12/03/2015 11:37 PM, Tony Lindgren wrote: * Grygorii Strashko [151203 10:36]: I think, this patch should not break our wake-up functionality. It will just change the moment when pcs_irq_handler() will be called: before this change: - suspend_enter() -

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

Hi Grygorii, On 04/12/15 10:44, Grygorii Strashko wrote: On 12/03/2015 11:37 PM, Tony Lindgren wrote: [...] And these both need to be applied together when we have a fix for the above as otherwise we'll get the lock recursion Sudeep mentioned in patch 2/2. Most probably below diff will

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

On 12/04/2015 12:54 PM, Sudeep Holla wrote: > Hi Grygorii, > > On 04/12/15 10:44, Grygorii Strashko wrote: >> On 12/03/2015 11:37 PM, Tony Lindgren wrote: > > [...] > >>> And these both need to be applied together when we have a fix for the >>> above >>> as otherwise we'll get the lock

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

* Grygorii Strashko [151204 02:45]: > On 12/03/2015 11:37 PM, Tony Lindgren wrote: > >* Grygorii Strashko [151203 10:36]: > >> > >>I think, this patch should not break our wake-up functionality. > >>It will just change the moment when

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

* Tony Lindgren [151203 13:41]: > * Sudeep Holla [151203 11:00]: > > > > I have added irq_set_irq_wake(pcs_soc->irq, state) in pcs_irq_set_wake > > which ensures it's marked for wakeup. > > Hmm well see the error I pasted in this thread, maybe that

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

On 04/12/15 15:40, Tony Lindgren wrote: * Tony Lindgren [151203 13:41]: * Sudeep Holla [151203 11:00]: I have added irq_set_irq_wake(pcs_soc->irq, state) in pcs_irq_set_wake which ensures it's marked for wakeup. Hmm well see the error I pasted in

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

On 12/04/2015 05:35 PM, Tony Lindgren wrote: > * Grygorii Strashko [151204 02:45]: >> On 12/03/2015 11:37 PM, Tony Lindgren wrote: >>> * Grygorii Strashko [151203 10:36]: I think, this patch should not break our wake-up functionality.

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

* Grygorii Strashko [151204 08:00]: > On 12/04/2015 05:35 PM, Tony Lindgren wrote: > > * Grygorii Strashko [151204 02:45]: > >> On 12/03/2015 11:37 PM, Tony Lindgren wrote: > >>> * Grygorii Strashko [151203 10:36]: >

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

* Sudeep Holla [151204 08:27]: > > > On 04/12/15 16:19, Grygorii Strashko wrote: > >On 12/04/2015 05:44 PM, Sudeep Holla wrote: > >> > >> > >>On 04/12/15 15:40, Tony Lindgren wrote: > >>>* Tony Lindgren [151203 13:41]: > * Sudeep Holla

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

* Grygorii Strashko [151204 08:31]: > On 12/04/2015 06:11 PM, Sudeep Holla wrote: > > > > > > On 04/12/15 15:59, Grygorii Strashko wrote: > >> > >> Sorry, I can't test it right now :( > >> Potential fix below: > > > > I had posted similar patch a while ago which Tony

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

* Sudeep Holla [151204 08:16]: > Hi Tony, > > On 04/12/15 15:40, Tony Lindgren wrote: > >* Tony Lindgren [151203 13:41]: > >>* Sudeep Holla [151203 11:00]: > >>> > >>>I have added irq_set_irq_wake(pcs_soc->irq, state) in

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

On 04/12/15 16:19, Grygorii Strashko wrote: On 12/04/2015 05:44 PM, Sudeep Holla wrote: On 04/12/15 15:40, Tony Lindgren wrote: * Tony Lindgren [151203 13:41]: * Sudeep Holla [151203 11:00]: I have added irq_set_irq_wake(pcs_soc->irq, state) in

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

Hi Tony, On 04/12/15 15:40, Tony Lindgren wrote: * Tony Lindgren [151203 13:41]: * Sudeep Holla [151203 11:00]: I have added irq_set_irq_wake(pcs_soc->irq, state) in pcs_irq_set_wake which ensures it's marked for wakeup. Hmm well see the error I

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

On 04/12/15 15:59, Grygorii Strashko wrote: Sorry, I can't test it right now :( Potential fix below: I had posted similar patch a while ago which Tony rejected. I might have made a mistake of not putting them together, though they were part of the same series[1], patch 12 and 16 diff

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

On 12/04/2015 05:44 PM, Sudeep Holla wrote: > > > On 04/12/15 15:40, Tony Lindgren wrote: >> * Tony Lindgren [151203 13:41]: >>> * Sudeep Holla [151203 11:00]: I have added irq_set_irq_wake(pcs_soc->irq, state) in pcs_irq_set_wake which

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

On 12/04/2015 06:11 PM, Sudeep Holla wrote: > > > On 04/12/15 15:59, Grygorii Strashko wrote: >> >> Sorry, I can't test it right now :( >> Potential fix below: > > I had posted similar patch a while ago which Tony rejected. > I might have made a mistake of not putting them together, though they

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

On 03/12/15 18:13, Tony Lindgren wrote: * Linus Walleij [151201 06:07]: On Fri, Nov 27, 2015 at 6:21 PM, Sudeep Holla wrote: From: Sudeep Holla The IRQF_NO_SUSPEND flag is used to identify the interrupts that should

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

* Sudeep Holla [151203 11:00]: > On 03/12/15 18:13, Tony Lindgren wrote: > >At least on omaps, this controller is always powered and we never want to > >suspend it as it handles wake-up events for all the IO pins. And that > >usecase sounds exactly like what you're

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

* Grygorii Strashko [151203 10:36]: > > I think, this patch should not break our wake-up functionality. > It will just change the moment when pcs_irq_handler() will be called: > > before this change: > - suspend_enter() > > - arch_suspend_enable_irqs(); >

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

* Linus Walleij [151201 06:07]: > On Fri, Nov 27, 2015 at 6:21 PM, Sudeep Holla wrote: > > > From: Sudeep Holla > > > > The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > > be left enabled so as to

Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

On 12/03/2015 08:13 PM, Tony Lindgren wrote: > * Linus Walleij [151201 06:07]: >> On Fri, Nov 27, 2015 at 6:21 PM, Sudeep Holla wrote: >> >>> From: Sudeep Holla >>> >>> The IRQF_NO_SUSPEND flag is used to identify the