Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2016-01-03 Thread Paul Kocialkowski
Le jeudi 31 décembre 2015 à 22:14 +, Mark Brown a écrit : > On Thu, Dec 31, 2015 at 10:59:06PM +0100, Paul Kocialkowski wrote: > > > I understand, thanks for pointing this out. Well, for my use case, there > > is no use in disabling the chip at any point as it powers the external > > mmc. >

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-31 Thread Mark Brown
On Thu, Dec 31, 2015 at 10:59:06PM +0100, Paul Kocialkowski wrote: > I understand, thanks for pointing this out. Well, for my use case, there > is no use in disabling the chip at any point as it powers the external > mmc. Presumably someone might decide not to use the MMC in some case (perhaps

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-31 Thread Paul Kocialkowski
Le jeudi 31 décembre 2015 à 21:40 +, Mark Brown a écrit : > On Wed, Dec 30, 2015 at 07:37:19PM +0100, Paul Kocialkowski wrote: > > Le mercredi 30 décembre 2015 à 16:33 +, Mark Brown a écrit : > > > On Wed, Dec 30, 2015 at 09:35:21AM +0100, Paul Kocialkowski wrote: > > > > > In my opinion,

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-31 Thread Mark Brown
On Wed, Dec 30, 2015 at 07:37:19PM +0100, Paul Kocialkowski wrote: > Le mercredi 30 décembre 2015 à 16:33 +, Mark Brown a écrit : > > On Wed, Dec 30, 2015 at 09:35:21AM +0100, Paul Kocialkowski wrote: > > > In my opinion, it would be more elegant to adapt the core regulator > > > framework to

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-30 Thread Mark Brown
On Wed, Dec 30, 2015 at 09:35:21AM +0100, Paul Kocialkowski wrote: > In my opinion, it would be more elegant to adapt the core regulator > framework to first enable the GPIO and then call the regulator enable > ops callback instead of handling the GPIO in the driver. Why would we want to

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-30 Thread Paul Kocialkowski
Le mercredi 30 décembre 2015 à 16:33 +, Mark Brown a écrit : > On Wed, Dec 30, 2015 at 09:35:21AM +0100, Paul Kocialkowski wrote: > > > In my opinion, it would be more elegant to adapt the core regulator > > framework to first enable the GPIO and then call the regulator enable > > ops

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-30 Thread Paul Kocialkowski
Hi Milo, Le mercredi 30 décembre 2015 à 09:22 +0900, Milo Kim a écrit : > Hi Paul, > > On 29/12/15 20:13, Paul Kocialkowski wrote: > > Hi Milo, > > > > Le mardi 29 décembre 2015 à 09:45 +0900, Milo Kim a écrit : > >> Hi Paul, > >> > >> On 29/12/15 07:49, Paul Kocialkowski wrote: > >>> Hi Milo,

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-29 Thread Milo Kim
Hi Paul, On 29/12/15 20:13, Paul Kocialkowski wrote: Hi Milo, Le mardi 29 décembre 2015 à 09:45 +0900, Milo Kim a écrit : Hi Paul, On 29/12/15 07:49, Paul Kocialkowski wrote: Hi Milo, thanks for the review, Le lundi 28 décembre 2015 à 09:56 +0900, Milo Kim a écrit : Hi Paul, On 23/12/15

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-29 Thread Paul Kocialkowski
Le mardi 29 décembre 2015 à 14:02 -0600, Rob Herring a écrit : > On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > > LP872x regulators are made active via the EN pin, which might be hooked to a > > GPIO. This adds support for driving the GPIO high when the driver is in use. > >

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-29 Thread Rob Herring
On Tue, Dec 29, 2015 at 3:26 PM, Paul Kocialkowski wrote: > Le mardi 29 décembre 2015 à 14:02 -0600, Rob Herring a écrit : >> On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: >> > LP872x regulators are made active via the EN pin, which might be hooked to >> >

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-29 Thread Rob Herring
On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > LP872x regulators are made active via the EN pin, which might be hooked to a > GPIO. This adds support for driving the GPIO high when the driver is in use. > > Signed-off-by: Paul Kocialkowski > --- >

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-29 Thread Paul Kocialkowski
Hi Milo, Le mardi 29 décembre 2015 à 09:45 +0900, Milo Kim a écrit : > Hi Paul, > > On 29/12/15 07:49, Paul Kocialkowski wrote: > > Hi Milo, thanks for the review, > > > > Le lundi 28 décembre 2015 à 09:56 +0900, Milo Kim a écrit : > >> Hi Paul, > >> > >> On 23/12/15 20:56, Mark Brown wrote: >

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-28 Thread Paul Kocialkowski
Hi Milo, thanks for the review, Le lundi 28 décembre 2015 à 09:56 +0900, Milo Kim a écrit : > Hi Paul, > > On 23/12/15 20:56, Mark Brown wrote: > > On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > > > >> + gpio = lp->pdata->enable_gpio; > >> + if (!gpio_is_valid(gpio)) > >>

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-28 Thread Milo Kim
Hi Paul, On 29/12/15 07:49, Paul Kocialkowski wrote: Hi Milo, thanks for the review, Le lundi 28 décembre 2015 à 09:56 +0900, Milo Kim a écrit : Hi Paul, On 23/12/15 20:56, Mark Brown wrote: On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: + gpio =

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-27 Thread Milo Kim
Hi Paul, On 23/12/15 20:56, Mark Brown wrote: On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: + gpio = lp->pdata->enable_gpio; + if (!gpio_is_valid(gpio)) + return 0; + + /* Always set enable GPIO high. */ + ret =

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-27 Thread Milo Kim
Hi Paul, Thanks for the patches. Please see my comments below. On 23/12/15 19:58, Paul Kocialkowski wrote: LP872x regulators are made active via the EN pin, which might be hooked to a GPIO. This adds support for driving the GPIO high when the driver is in use. EN pin is used for enabling HW

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-24 Thread Mark Brown
On Thu, Dec 24, 2015 at 07:12:53PM +0100, Paul Kocialkowski wrote: > Le mercredi 23 décembre 2015 à 11:56 +, Mark Brown a écrit : > > This isn't really adding support for the enable GPIO as the changelog > > suggests, it's requesting but not managing the GPIO. Since there is > > core support

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-24 Thread Paul Kocialkowski
Le jeudi 24 décembre 2015 à 19:35 +, Mark Brown a écrit : > On Thu, Dec 24, 2015 at 07:12:53PM +0100, Paul Kocialkowski wrote: > > Le mercredi 23 décembre 2015 à 11:56 +, Mark Brown a écrit : > > > > This isn't really adding support for the enable GPIO as the changelog > > > suggests,

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-24 Thread Paul Kocialkowski
Le mercredi 23 décembre 2015 à 11:56 +, Mark Brown a écrit : > On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > > > + gpio = lp->pdata->enable_gpio; > > + if (!gpio_is_valid(gpio)) > > + return 0; > > + > > + /* Always set enable GPIO high. */ > > + ret =

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-23 Thread Mark Brown
On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > + gpio = lp->pdata->enable_gpio; > + if (!gpio_is_valid(gpio)) > + return 0; > + > + /* Always set enable GPIO high. */ > + ret = devm_gpio_request_one(lp->dev, gpio, GPIOF_OUT_INIT_HIGH, "LP872X >

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-23 Thread Paul Kocialkowski
Le mercredi 23 décembre 2015 à 11:56 +, Mark Brown a écrit : > On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > > > + gpio = lp->pdata->enable_gpio; > > + if (!gpio_is_valid(gpio)) > > + return 0; > > + > > + /* Always set enable GPIO high. */ > > + ret =