Re: stalled again

2015-12-02 Thread Jason Gunthorpe
On Wed, Dec 02, 2015 at 04:29:27AM -0800, Christoph Hellwig wrote: > Maybe we need more co-maintainers if the two current maintainers can't > handle the workload? Doug is the only maintainer. The idea of co-maintainers was rejected by some parties. Don't be confused, the other 'M' people in the

Re: stalled again

2015-12-02 Thread Doug Ledford
On 12/02/2015 01:42 PM, Jason Gunthorpe wrote: > On Wed, Dec 02, 2015 at 04:29:27AM -0800, Christoph Hellwig wrote: >> Maybe we need more co-maintainers if the two current maintainers can't >> handle the workload? > > Doug is the only maintainer. The idea of co-maintainers was rejected > by some

[PATCH 1/5] staging/rdma/hfi1: Convert to use get_user_pages_fast

2015-12-02 Thread ira . weiny
From: Mitko Haralanov Convert hfi1_get_user_pages() to use get_user_pages_fast(), which is much fatster. The mm semaphore is still taken to update the pinned page count but is for a much shorter amount of time. Signed-off-by: Mitko Haralanov

[PATCH 2/5] staging/rdma/hfi1: Unconditionally clean-up SDMA queues

2015-12-02 Thread ira . weiny
From: Mitko Haralanov There is no need to cleck if the packet queue is allocated when cleaning up a user context. The hfi1_user_sdma_free_queues() function already does all the required checks. Reviewed-by: Ira Weiny Signed-off-by: Mitko

[PATCH 4/5] staging/rdma/hfi1: Detect SDMA transmission error early

2015-12-02 Thread ira . weiny
From: Mitko Haralanov It is possible for an SDMA transmission error to happen during the processing of an user SDMA transfer. In that case it is better to detect it early and abort any further attempts to send more packets. Reviewed-by: Ira Weiny

[PATCH 5/5] staging/rdma/hfi1: Add page lock limit check for SDMA requests

2015-12-02 Thread ira . weiny
From: Mitko Haralanov The driver pins pages on behalf of user processes in two separate instances - when the process has submitted a SDMA transfer and when the process programs an expected receive buffer. When pinning pages, the driver is required to observe the

[PATCH 0/5] staging/rdma/hfi1: Clean up SDMA engine code

2015-12-02 Thread ira . weiny
From: Ira Weiny Various improvements to the SDMA engine code. Mitko Haralanov (5): staging/rdma/hfi1: Convert to use get_user_pages_fast staging/rdma/hfi1: Unconditionally clean-up SDMA queues staging/rdma/hfi1: Clean-up unnecessary goto statements

[PATCH 3/5] staging/rdma/hfi1: Clean-up unnecessary goto statements

2015-12-02 Thread ira . weiny
From: Mitko Haralanov Clean-up unnecessary goto statements based on feedback from the mailing list on previous patch submissions. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov ---

Re: [PATCH 4/6] IB/srp: Fix indirect data buffer rkey endianness

2015-12-02 Thread Sagi Grimberg
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index 72fac20..fac1423 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/drivers/infiniband/ulp/srp/ib_srp.c @@ -1662,7 +1662,7 @@ static int srp_map_data(struct scsi_cmnd *scmnd, struct srp_rdma_ch *ch,

Re: [PATCH 5/6] IB core: Fix ib_sg_to_pages()

2015-12-02 Thread Sagi Grimberg
On 01/12/2015 21:10, Bart Van Assche wrote: On 12/01/2015 10:32 AM, Sagi Grimberg wrote: Fix the code for detecting gaps and disable the code for chunking. A gap occurs not only if the second or later scatterlist element is not aligned but also if any scatterlist element other than the last

Re: [PATCH 2/6] IB/srp: Fix possible send queue overflow

2015-12-02 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/6] IB/srp: Fix indirect data buffer rkey endianness

2015-12-02 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V3 1/2] IB/core: Fix user mode post wr corruption

2015-12-02 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Future of FMR support, was: Re: [PATCH v1 5/9] xprtrdma: Add ro_unmap_sync method for FMR

2015-12-02 Thread Christoph Hellwig
On Tue, Dec 01, 2015 at 10:33:18AM -0500, Chuck Lever wrote: > Oracle recently announced Sonoma, which is a SPARC CPU with > an on-chip IB HCA. Oracle plans to publish an open-source > GPL device driver that enables this HCA in Linux for SPARC. > We???d eventually like to contribute it to the

Re: stalled again

2015-12-02 Thread Christoph Hellwig
On Tue, Dec 01, 2015 at 06:30:28PM +0200, Or Gerlitz wrote: > Any reason on earth not to rebase your tree (== create new branch, move > their the for-next tag) after an rc1 is out? how long does this take? I'm not too worried about the base as there doesn't seem to be anything pending for 4.5-rc

Re: [PATCH 6/6] IB/srp: Fix srp_map_sg_fr()

2015-12-02 Thread Sagi Grimberg
On 01/12/2015 20:39, Bart Van Assche wrote: On 12/01/2015 10:35 AM, Sagi Grimberg wrote: After dma_map_sg() has been called the return value of that function must be used as the number of elements in the scatterlist instead of scsi_sg_count(). Umm, but ib_map_mr_sg iterates on the sg list.

Re: [PATCH 6/6] IB/srp: Fix srp_map_sg_fr()

2015-12-02 Thread Christoph Hellwig
On Wed, Dec 02, 2015 at 01:59:38PM +0200, Sagi Grimberg wrote: > >where nents is the number of entries in the sglist. > > > > From Documentation/DMA_API.txt > > > int > dma_map_sg(struct device *dev, struct scatterlist *sg, > int nents, enum dma_data_direction

Re: [PATCH 6/6] IB/srp: Fix srp_map_sg_fr()

2015-12-02 Thread Sagi Grimberg
dma_map_sg returns the actual number of entries to iterate. At least historically some IOMMU implementations would do strange tricks like: If entries 2 and 3 could be merged dma_len for 2 would span 2 and 3, and then entry 3 would actually have the dma addr and len for entry 4. I'm

Re: [PATCH 5/6] IB core: Fix ib_sg_to_pages()

2015-12-02 Thread Bart Van Assche
On 12/02/2015 01:31 AM, Sagi Grimberg wrote: > On 01/12/2015 21:10, Bart Van Assche wrote: >> On 12/01/2015 10:32 AM, Sagi Grimberg wrote: >> How ib_sg_to_pages() reports to its caller that mapping the first >> scatterlist element failed is not important to me. I included that >> change in this