Re: [PATCH for-next] IB/usnic: Expose flows via debugfs

2014-01-12 Thread Or Gerlitz
On 08/01/2014 20:57, Upinder Malhi (umalhi) wrote: Or, Yeah, I did think about extending the existing infrastructure to export HW specific stats and exposing some stats via standard infrastructure. Besides the below, there are few other drawbacks with exposing statistics via netlink:

[PATCH] amso1100: Add check if cache memory was allocated before freeing it

2014-01-12 Thread Svetlana Mavrina
From: Svetlana Mavrina another.kar...@gmail.com There is a path in handle_vq() where kmem_cache_free() can be called with pointer to a local variable. It can happen if vq_repbuf_alloc() failed to allocate memory from cache and req is NULL. The patch adds check if cache memory was allocated

Re: [PATCH 09/11] IB/isert: Accept RDMA_WRITE completions

2014-01-12 Thread Sagi Grimberg
On 1/11/2014 11:14 PM, Or Gerlitz wrote: On Thu, Jan 9, 2014 at 6:40 PM, Sagi Grimberg sa...@mellanox.com wrote: In case of protected transactions, we will need to check the protection status of the transaction before sending SCSI response. So be ready for RDMA_WRITE completions. currently we

Re: [PATCH 06/11] IB/isert: Initialize T10-PI resources

2014-01-12 Thread Sagi Grimberg
On 1/11/2014 11:09 PM, Or Gerlitz wrote: On Thu, Jan 9, 2014 at 6:40 PM, Sagi Grimberg sa...@mellanox.com wrote: @@ -557,8 +629,14 @@ isert_connect_request(struct rdma_cm_id *cma_id, struct rdma_cm_event *event) goto out_mr; } + if (pi_support

Re: [PATCH 06/11] IB/isert: Initialize T10-PI resources

2014-01-12 Thread Or Gerlitz
On 12/01/2014 14:41, Sagi Grimberg wrote: --- a/drivers/infiniband/ulp/isert/ib_isert.h +++ b/drivers/infiniband/ulp/isert/ib_isert.h @@ -48,11 +48,21 @@ struct iser_tx_desc { struct ib_send_wr send_wr; } __packed; +struct pi_context { + struct ib_mr *prot_mr;

RE: [PATCH infiniband-diags] libibnetdisc/ibnetdisc.c: fix insert of invalid lid 0xFFFF into lid_port hash_table

2014-01-12 Thread Weiny, Ira
Good catch some comments below. -Original Message- From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] Sent: Monday, December 30, 2013 6:51 AM To: Ira Weiny Cc: linux-rdma (linux-rdma@vger.kernel.org); Dan Ben-Yosef Subject: [PATCH infiniband-diags] libibnetdisc/ibnetdisc.c: fix

RE: [PATCH infiniband-diags] libibnetdisc/ibnetdisc.c: improve log information to stdout

2014-01-12 Thread Weiny, Ira
-Original Message- From: Dan Ben Yosef [mailto:da...@mellanox.com] Sent: Wednesday, January 01, 2014 10:44 PM Subject: [PATCH infiniband-diags] libibnetdisc/ibnetdisc.c: improve log information to stdout Write to stdout the route-path when smp returns with status error. As part of