Re: [PATCH] IB/srp: Fix initiator lockup

2010-01-07 Thread Bart Van Assche
On Thu, Jan 7, 2010 at 8:57 AM, Roland Dreier rdre...@cisco.com wrote:   It was only recently that I had the time to analyze this issue in   depth and that I added SRP_CRED_REQ support in SCST (checked in that   support about one week ago). Before SRP_CRED_REQ support was added in   SCST, the

Re: [PATCH] IB/srp: Fix initiator lockup

2010-01-07 Thread Bart Van Assche
On Thu, Jan 7, 2010 at 9:03 AM, Bart Van Assche bart.vanass...@gmail.com wrote: On Thu, Jan 7, 2010 at 8:57 AM, Roland Dreier rdre...@cisco.com wrote:   It was only recently that I had the time to analyze this issue in   depth and that I added SRP_CRED_REQ support in SCST (checked in that  

Re: [PATCHv3] opensm: Add support for optimized SLtoVLMappingTable programming

2010-01-07 Thread Hal Rosenstock
Hi Sasha, On Tue, Jan 5, 2010 at 6:18 AM, Sasha Khapyorsky sas...@voltaire.com wrote: Hi Hal, On 14:41 Tue 01 Dec     , Hal Rosenstock wrote: Optimized SLtoVLMappingTable programming reduces the number of MADs needed from O(n**2) to O(n). See IBA 1.2.1 vol 1 p. 843 14.2.5.8

Re: [PATCHv3] opensm: Add support for optimized SLtoVLMappingTable programming

2010-01-07 Thread Hal Rosenstock
On Tue, Jan 5, 2010 at 6:23 AM, Sasha Khapyorsky sas...@voltaire.com wrote: On 13:18 Tue 05 Jan     , Sasha Khapyorsky wrote: Optimized SLtoVLMappingTable programming reduces the number of MADs needed from O(n**2) to O(n). See IBA 1.2.1 vol 1 p. 843 14.2.5.8 SLtoVLMappingTable.

Re: [PATCH] opensm/osm_qos.c: split switch external and end ports setup

2010-01-07 Thread Hal Rosenstock
On Tue, Jan 5, 2010 at 6:10 AM, Sasha Khapyorsky sas...@voltaire.com wrote: This splits QoS related port parameters setup over switch external ports and end ports. Such separation leaves us with simpler code and saves some repeated flows in case of switch external ports (actually required per

Re: [PATCHv7 4/9] ib_core: RoCEE CMA device binding

2010-01-07 Thread Or Gerlitz
Eli Cohen wrote: +static int cma_resolve_rocee_route(struct rdma_id_private *id_priv) [...] + route-path_rec-hop_limit = 2; why? does this value has any specific meaning? + route-path_rec-mtu_selector = 2; all the xxx_selector usages in this code should be transformed to be from the

Re: [PATCHv7 4/9] ib_core: RoCEE CMA device binding

2010-01-07 Thread Eli Cohen
On Thu, Jan 07, 2010 at 04:02:31PM +0200, Or Gerlitz wrote: + route-path_rec-hop_limit = 2; The reason is that ib_init_ah_from_path() will not set IB_AH_GRH for hop_limit smaller then 2, and since that GRH is required in RoCEE, and since this is specific to RoCEE, I put 2 to make pass this.

Re: [PATCH] IB/srp: Fix initiator lockup

2010-01-07 Thread David Dillow
On Thu, 2010-01-07 at 08:59 +0100, Bart Van Assche wrote: On Wed, Jan 6, 2010 at 10:40 PM, Roland Dreier rdre...@cisco.com wrote: Is that regular kernel coding practice, to run away with the work someone else did and to claim authorship ? As far as I know this is considered as

RE: [PATCHv7 4/9] ib_core: RoCEE CMA device binding

2010-01-07 Thread Sean Hefty
+ route-path_rec-hop_limit = 2; The reason is that ib_init_ah_from_path() will not set IB_AH_GRH for hop_limit smaller then 2, and since that GRH is required in RoCEE, and since this is specific to RoCEE, I put 2 to make pass this. A hop limit of 2 seems wrong though. Isn't there some

Re: [PATCHv7 4/9] ib_core: RoCEE CMA device binding

2010-01-07 Thread Jason Gunthorpe
On Thu, Jan 07, 2010 at 08:50:47AM -0800, Sean Hefty wrote: +route-path_rec-hop_limit = 2; The reason is that ib_init_ah_from_path() will not set IB_AH_GRH for hop_limit smaller then 2, and since that GRH is required in RoCEE, and since this is specific to RoCEE, I put 2 to make

[GIT PULL] please pull infiniband.git

2010-01-07 Thread Roland Dreier
Linus, please pull from master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This tree is also available from kernel.org mirrors at: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This will get a few very small fixes that have