...@mellanox.com
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: Roland Dreier rol...@purestorage.com
Cc: David Dillow dillo...@ornl.gov
Cc: Vu Pham v...@mellanox.com
Cc: Sebastian Riemer sebastian.rie...@profitbricks.com
---
Documentation/ABI/stable/sysfs-driver-ib_srp |2 ++
drivers/infiniband/ulp
Signed-off-by: Vu Pham v...@mellanox.com
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: Roland Dreier rol...@purestorage.com
Cc: David Dillow dillo...@ornl.gov
Cc: Sebastian Riemer sebastian.rie...@profitbricks.com
---
drivers/infiniband/ulp/srp/ib_srp.c |4 ++--
1 file changed, 2
On 07/03/13 15:38, Or Gerlitz wrote:
Some of these patches were already picked by Roland (SB), I would
suggest that you post V4 and drop the ones which were accepted.
One of the patches that is already in Roland's tree and that was in v1
of this series has been split into two patches in v2
On 07/03/13 16:08, David Dillow wrote:
On Wed, 2013-07-03 at 14:55 +0200, Bart Van Assche wrote:
Finish all outstanding I/O requests after fast_io_fail_tmo expired,
which speeds up failover in a multipath setup. This patch is a
reworked version of a patch from Sebastian Riemer.
Reported
On 07/03/13 17:14, David Dillow wrote:
On Wed, 2013-07-03 at 14:54 +0200, Bart Van Assche wrote:
+int srp_tmo_valid(int fast_io_fail_tmo, int dev_loss_tmo)
+{
+ return (fast_io_fail_tmo 0 || dev_loss_tmo 0 ||
+ fast_io_fail_tmo dev_loss_tmo
On 07/03/13 19:27, David Dillow wrote:
On Wed, 2013-07-03 at 18:00 +0200, Bart Van Assche wrote:
The combination of dev_loss_tmo off and reconnect_delay 0 worked fine
in my tests. An I/O failure was detected shortly after the cable to the
target was pulled. I/O resumed shortly after the cable
On 07/03/13 20:57, David Dillow wrote:
And I'm getting the strong sense that the answer to my question about
fast_io_fail_tmo = 0 when dev_loss_tmo is that we should not allow that
combination, even if it doesn't break the kernel. If it doesn't make
sense, there is no reason to create an
On 07/04/13 10:01, Bart Van Assche wrote:
On 07/03/13 20:57, David Dillow wrote:
And I'm getting the strong sense that the answer to my question about
fast_io_fail_tmo = 0 when dev_loss_tmo is that we should not allow that
combination, even if it doesn't break the kernel. If it doesn't make
On 07/08/13 15:19, Or Gerlitz wrote:
+ iser_err(FMR alloction failed, err %d\n, ret);
I see alloction instead of allocation - this looks like an
(unimportant) typo ?
Bart.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to
On 07/08/13 15:19, Or Gerlitz wrote:
+#define ISER_DEF_XMIT_CMDS_DEFUALT 512
+#if ISCSI_DEF_XMIT_CMDS_MAX ISER_DEF_XMIT_CMDS_DEFUALT
This looks like another spelling issue - shouldn't DEFUALT be changed
into DEFAULT ?
Bart.
--
To unsubscribe from this list: send the line
On 07/08/13 19:26, Vu Pham wrote:
After running cable pull test on two local IB links for several hrs,
I/Os got stuck.
Further commands multipath -ll or fdisk -l got stuck and never return
Here are the stack dump for srp-x kernel threads.
I'll run with #DEBUG to get more debug info on scsi
On 07/10/13 16:38, Roland Dreier wrote:
On Wed, Jul 10, 2013 at 7:35 AM, Sebastian Riemer
sebastian.rie...@profitbricks.com wrote:
I've checked the commits on that tag and the following commit is not
what we've agreed on:
Sorry about that. The discussion was long and complex and I probably
If the transport layer is offline it is more appropriate to let
srp_abort() return FAST_IO_FAIL instead of SUCCESS.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Reported-by: Sebastian Riemer sebastian.rie...@profitbricks.com
Cc: David Dillow dillo...@ornl.gov
Cc: Roland Dreier rol
On 14/07/2013 3:43, Sagi Grimberg wrote:
On 7/3/2013 3:58 PM, Bart Van Assche wrote:
Several InfiniBand HCA's allow to configure the completion vector
per queue pair. This allows to spread the workload created by IB
completion interrupts over multiple MSI-X vectors and hence over
multiple CPU
On 15/07/2013 7:29, Sagi Grimberg wrote:
srp_daemon is a package designated for the customer to automatically
detect targets in the IB fabric. From our experience here in Mellanox,
customers/users like automatic plugplay tools.
They are reluctant to build their own scriptology to enhance
On 16/07/2013 4:11, Sagi Grimberg wrote:
This sounds like a nice Idea, but there an inherent problem about
applications coming and going while the connections are static (somewhat),
how can you control pinning an arbitrary application running (over SRP
devices of-course) at certain point of
On 14/07/2013 3:43, Sagi Grimberg wrote:
Just wrote a small patch to allow srp_daemon spread connection across
HCA's completion vectors.
Hello Sagi,
How about the following approach:
- Add support for reading the completion vector from srp_daemon.conf,
similar to how several other
On 07/18/13 15:25, Or Gerlitz wrote:
+static int iser_fast_reg_mr(struct fast_reg_descriptor *desc,
+ struct iser_conn *ib_conn,
+ struct iser_regd_buf *regd_buf,
+ u32 offset, unsigned int data_size,
+
connected.
Note: I'm posting this patch as an RFC since it involves a behavior
change (a signal sent to a worker thread that is waiting for a
command to finish causes the command to fail) and since I'm not sure
this behavior change is acceptable.
Signed-off-by: Bart Van Assche bvanass...@acm.org
On 07/22/13 15:11, Sagi Grimberg wrote:
So just to clarify the flow:
. at connection establishment allocate pool of fastreg descriptors
. upon each IOP take a fastreg descriptor from the pool
. if it is not invalidated - invalidate it.
. register using FRWR.
. when cleanup_task is
On 07/23/13 16:21, Or Gerlitz wrote:
Bart, iSER's FMR and FRWR code works under the assumption that an SG
list is 4K aligned. For SGs which don't obey that assumption we're
using bounce buffer.
Note that the SG page size used by FMRs/FRWRs doesn't have to be 1:1
with the OS page size, so in
On 07/24/13 17:17, Or Gerlitz wrote:
On 22/07/2013 18:23, Bart Van Assche wrote:
Avoid that kernel threads running mlx4_cmd_wait() contribute to the
system load by setting the task state to TASK_INTERRUPTIBLE instead
of TASK_UNINTERRUPTIBLE while waiting. This patch reduces the load
average
On 07/24/13 19:06, Or Gerlitz wrote:
On 24/07/2013 19:48, Bart Van Assche wrote:
I saw a load of 0.5 with several different upstream kernels (3.6..3.10
at least). The only IB-related process that was running on the system
was opensmd. This is definitely reproducible. It was only a month
after I
On 07/24/13 19:06, Or Gerlitz wrote:
On 24/07/2013 19:48, Bart Van Assche wrote:
I saw a load of 0.5 with several different upstream kernels (3.6..3.10
at least). The only IB-related process that was running on the system
was opensmd. This is definitely reproducible. It was only a month
after I
On 07/25/13 01:05, Weiny, Ira wrote:
-Original Message-
From: Hefty, Sean
Subject: RE: [PATCH] ib/mad: remove Device Mgmt from RMPP class list
See Annex 8; DevMgt class version 2 rather than 1 is currently
supported.
Could older devices still return version 1? If so the kernel
On 07/24/13 18:28, Or Gerlitz wrote:
On 23/07/2013 17:47, Bart Van Assche wrote:
Still regarding page sizes: shouldn't ib_alloc_fast_reg_page_list()
and ib_alloc_fast_reg_mr() multiply the SG list length by PAGE_SIZE /
SIZE_4K to compensate for page size differences on architectures where
This is a small series of four patches addressing issues I noticed while
analyzing the warnings reported by a recent gcc version. These patches
do not change the behavior of librdmacm.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to
The variable 'pri_path' is assigned a value but is never used.
This triggers the following compiler warning:
src/acm.c:301:26: warning: variable 'pri_path' set but not used
[-Wunused-but-set-variable]
Hence remove this variable.
Signed-off-by: Bart Van Assche bvanass...@acm.org
---
src/acm.c
The variable 'id_priv' is assigned a value but is never used.
This triggers the following compiler warning:
src/cma.c:1178:25: warning: variable 'id_priv' set but not used
[-Wunused-but-set-variable]
Hence remove this variable.
Signed-off-by: Bart Van Assche bvanass...@acm.org
---
src/cma.c
The variable 'ret' is assigned a value but that value is never used.
This triggers the following compiler warning:
src/rsocket.c:3720:9: warning: variable 'ret' set but not used
[-Wunused-but-set-variable]
Hence remove this variable.
Signed-off-by: Bart Van Assche bvanass...@acm.org
---
src
Change the data type of the 'server_port' variable from signed to
unsigned such that the cast in the fscanf() call can be removed.
Signed-off-by: Bart Van Assche bvanass...@acm.org
---
src/acm.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/acm.c b/src/acm.c
Set errno to EINVAL instead of an undefined value if max_retries = 0.
This patch avoids that the following compiler warning is triggered:
src/rpc.c:187:8: warning: 'status' may be used uninitialized in this function
[-Wmaybe-uninitialized]
Signed-off-by: Bart Van Assche bvanass...@acm.org
This patch avoids that the following compiler warning is triggered:
src/saquery.c:869:18: warning: variable 'p_ni' set but not used
[-Wunused-but-set-variable]
Signed-off-by: Bart Van Assche bvanass...@acm.org
---
src/saquery.c |2 --
1 file changed, 2 deletions(-)
diff --git a/src
The purpose of this InfiniBand SRP initiator patch series is as follows:
- Make the SRP initiator driver better suited for use in a H.A. setup.
Add fast_io_fail_tmo, dev_loss_tmo and reconnect_delay parameters.
These can be used either to speed up failover or to avoid device
removal when
-off-by: Bart Van Assche bvanass...@acm.org
Cc: Roland Dreier rol...@purestorage.com
Cc: James Bottomley jbottom...@parallels.com
Cc: David Dillow dillo...@ornl.gov
Cc: Vu Pham v...@mellanox.com
Cc: Sebastian Riemer sebastian.rie...@profitbricks.com
---
drivers/infiniband/ulp/srp/ib_srp.c |3
connection to a target has been lost.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: Roland Dreier rol...@purestorage.com
Cc: James Bottomley jbottom...@parallels.com
Cc: David Dillow dillo...@ornl.gov
Cc: Vu Pham v...@mellanox.com
Cc: Sebastian Riemer sebastian.rie...@profitbricks.com
Finish all outstanding I/O requests after fast_io_fail_tmo expired,
which speeds up failover in a multipath setup. This patch is a
reworked version of a patch from Sebastian Riemer.
Reported-by: Sebastian Riemer sebastian.rie...@profitbricks.com
Signed-off-by: Bart Van Assche bvanass...@acm.org
Enable reconnect_delay, fast_io_fail_tmo and dev_loss_tmo
functionality for the IB SRP initiator. Add kernel module
parameters that allow to specify default values for these
three parameters.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Acked-by: David Dillow dillo...@ornl.gov
Cc: Roland
Start the reconnect timer, fast_io_fail timer and dev_loss timers
if a transport layer error occurs.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Acked-by: David Dillow dillo...@ornl.gov
Cc: Roland Dreier rol...@kernel.org
Cc: Vu Pham v...@mellanox.com
Cc: Sebastian Riemer sebastian.rie
This patch does not change any functionality.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: Roland Dreier rol...@purestorage.com
Cc: David Dillow dillo...@ornl.gov
Cc: Vu Pham v...@mellanox.com
Cc: Sebastian Riemer sebastian.rie...@profitbricks.com
---
drivers/infiniband/ulp/srp/ib_srp.c
Certain storage configurations, e.g. a sufficiently large array of
hard disks in a RAID configuration, need a queue depth above 64 to
achieve optimal performance. Hence make the queue depth configurable.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: Roland Dreier rol...@purestorage.com
Cc
On 08/20/13 17:34, Sagi Grimberg wrote:
On 8/20/2013 3:50 PM, Bart Van Assche wrote:
Certain storage configurations, e.g. a sufficiently large array of
hard disks in a RAID configuration, need a queue depth above 64 to
achieve optimal performance. Hence make the queue depth configurable
On 08/26/13 11:57, bgottumu...@emulex.com wrote:
From: Naresh Gottumukkala bgottumukk...@emulex.com
Also get the max_srq value from query_config mailbox response.
Signed-off-by: Naresh Gottumukkala bgottumukk...@emulex.com
There are already a few drivers upstream in which the fast register
On 08/26/13 15:53, Jack Wang wrote:
From: Jack Wang jinpu.w...@profitbricks.com
Date: Mon, 26 Aug 2013 15:50:03 +0200
Subject: [PATCH] IB/srp: add change_queue_depth/change_queue_type support
Signed-off-by: Jack Wang jinpu.w...@profitbricks.com
Hello Jack,
When posting a Linux kernel patch
On 08/27/13 18:39, Jack Wang wrote:
I look into scsi core about above statement:
In drivers/scsi/scsi_scan.c:865:
if ((sdev-scsi_level = SCSI_2) (inq_result[7] 2)
!(*bflags BLIST_NOTQ))
sdev-tagged_supported = 1;
It check inquiry result byte 7
that as a separate patch on top of this patch
series. Does this sound Ok ?
Thanks!!
Naresh.
-Original Message-
From: Bart Van Assche [mailto:bvanass...@acm.org]
Sent: Monday, August 26, 2013 3:39 PM
To: bgottumu...@emulex.com
Cc: linux-rdma@vger.kernel.org; rol...@kernel.org; B.A.L.N.Raju
driver.
Signed-off-by: Jack Wang jinpu.w...@profitbricks.com
Tested-by: Bart Van Assche bvanass...@acm.org
Bart.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
On 09/10/13 05:01, David Dillow wrote:
On Tue, 2013-08-20 at 14:50 +0200, Bart Van Assche wrote:
@@ -2227,6 +2270,7 @@ static const match_table_t srp_opt_tokens = {
{ SRP_OPT_SG_TABLESIZE, sg_tablesize=%u },
{ SRP_OPT_COMP_VECTOR, comp_vector=%u
On 09/12/13 18:16, Jack Wang wrote:
On 09/12/2013 12:16 AM, David Dillow wrote:
On Tue, 2013-09-10 at 19:44 +0200, Bart Van Assche wrote:
If this name was not yet in use in any interface that is visible in user
space, I would agree that we should come up with a better name. However,
the SCSI
On 09/13/13 10:06, Jack Wang wrote:
On 09/12/2013 06:30 PM, Bart Van Assche wrote:
On 09/12/13 18:16, Jack Wang wrote:
On 09/12/2013 12:16 AM, David Dillow wrote:
On Tue, 2013-09-10 at 19:44 +0200, Bart Van Assche wrote:
If this name was not yet in use in any interface that is visible
On 09/13/13 10:40, Bart Van Assche wrote:
On 09/13/13 10:06, Jack Wang wrote:
On 09/12/2013 06:30 PM, Bart Van Assche wrote:
On 09/12/13 18:16, Jack Wang wrote:
On 09/12/2013 12:16 AM, David Dillow wrote:
On Tue, 2013-09-10 at 19:44 +0200, Bart Van Assche wrote:
If this name was not yet
On 09/13/13 14:25, Jack Wang wrote:
I tried your srp-ha branch in github,
echo string
SRP2=id_ext=${THCA2_GUID},ioc_guid=${THCA2_GUID},dgid=${TGID_P2},pkey=${PKEY},service_id=${THCA2_GUID},can_queue=512
to add_target failed with
ib_srp: unknown parameter or missing value 'can_queue=512
[
On 09/13/13 15:51, Jack Wang wrote:
On 09/13/2013 03:33 PM, Bart Van Assche wrote:
On 09/13/13 14:25, Jack Wang wrote:
I tried your srp-ha branch in github,
echo string
SRP2=id_ext=${THCA2_GUID},ioc_guid=${THCA2_GUID},dgid=${TGID_P2},pkey=${PKEY},service_id=${THCA2_GUID},can_queue=512
On 09/13/13 16:15, Jack Wang wrote:
Hello Bart,
cat /sys/class/scsi_host/host36/req_lim
64
I just checked srp spec, which do define such behaviour, I wonder in
SCST/SRPT, how the request limit is chosen, is it report from low level
hardware driver?
Hello Jack,
The following code probably
On 09/12/13 00:16, David Dillow wrote:
On Tue, 2013-09-10 at 19:44 +0200, Bart Van Assche wrote:
If this name was not yet in use in any interface that is visible in user
space, I would agree that we should come up with a better name. However,
the SCSI mid-layer already uses that name today
On 09/27/13 11:20, Jack Wang wrote:
Hi all,
Currently handle of srp_rsp for task management is broken.
in 6.9
T10/1415-D revision 16a
SRP_RSP responses that contain either
RESPONSE DATA or SENSE DATA shall be sent as the minimum length message
containing those fields.
LENGTH field specify the
The new rules for stable kernel tree patches require these patches to
be posted separately from patches introducing new features. Hence a
short patch series with the following three patches:
0001-IB-srp-Remove-target-from-list-before-freeing-Scsi_H.patch
/0xa0
[8100c20a] child_rip+0xa/0x20
Signed-off-by: Vu Pham vuhu...@mellanox.com
[bvanassche: Modified path description and CC'ed stable]
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: David Dillow dillo...@ornl.gov
Cc: Roland Dreier rol...@kernel.org
Cc: Sebastian Riemer sebastian.rie
after it has been reset by
srp_rport_reconnect(). Tell the SCSI error handler that such commands
have finished and that it is not necessary to continue its recovery
strategy for commands that have been reset by srp_rport_reconnect().
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: David
The IB spec does not guarantee that the opcode is available in error
completions. Hence do not rely on it. See also commit 948d1e88
(IB/srp: Introduce srp_handle_qp_err()).
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: David Dillow dillo...@ornl.gov
Cc: Roland Dreier rol...@kernel.org
Cc
The purpose of this InfiniBand SRP initiator patch series is as follows:
- Make the SRP initiator driver better suited for use in a H.A. setup.
Add fast_io_fail_tmo, dev_loss_tmo and reconnect_delay parameters.
With the default values of these parameters failover happens
significantly
/ changed default retry count]
Signed-off-by: Bart Van Assche bvanass...@acm.org
Acked-by: David Dillow dillo...@ornl.gov
Cc: Roland Dreier rol...@purestorage.com
Cc: Sebastian Riemer sebastian.rie...@profitbricks.com
---
Documentation/ABI/stable/sysfs-driver-ib_srp | 2 ++
drivers/infiniband/ulp/srp
freed.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: David Dillow dillo...@ornl.gov
Cc: Roland Dreier rol...@purestorage.com
Cc: James Bottomley jbottom...@parallels.com
Cc: Vu Pham v...@mellanox.com
Cc: Sebastian Riemer sebastian.rie...@profitbricks.com
---
drivers/infiniband/ulp/srp
after having detected a transport layer problem and
before failing I/O.
- Support for implementing dev_loss_tmo, the time that should
elapse after having detected a transport layer problem and
before removing a remote port.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: David Dillow
Enable fast_io_fail_tmo and dev_loss_tmo functionality for the IB
SRP initiator. Add kernel module parameters that allow to specify
default values for these parameters.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Acked-by: David Dillow dillo...@ornl.gov
Cc: Roland Dreier rol...@kernel.org
Start the reconnect timer, fast_io_fail timer and dev_loss timers
if a transport layer error occurs.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Acked-by: David Dillow dillo...@ornl.gov
Cc: Roland Dreier rol...@kernel.org
Cc: Vu Pham v...@mellanox.com
Cc: Sebastian Riemer sebastian.rie
Add support for periodically reconnecting to an SRP target until
the dev_loss timer expires. After the tenth reconnection attempt,
gradually slow down subsequent reconnect attempts.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: David Dillow dillo...@ornl.gov
Cc: Roland Dreier rol
from 60s into 600s
to give the reconnect mechanism a chance to kick in.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Acked-by: David Dillow dillo...@ornl.gov
Cc: Roland Dreier rol...@kernel.org
Cc: Vu Pham v...@mellanox.com
Cc: Sebastian Riemer sebastian.rie...@profitbricks.com
This patch does not change any functionality.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: David Dillow dillo...@ornl.gov
Cc: Roland Dreier rol...@purestorage.com
Cc: Vu Pham v...@mellanox.com
Cc: Sebastian Riemer sebastian.rie...@profitbricks.com
---
drivers/infiniband/ulp/srp/ib_srp.c
Certain storage configurations, e.g. a sufficiently large array of
hard disks in a RAID configuration, need a queue depth above 64 to
achieve optimal performance. Hence make the queue depth configurable.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: David Dillow dillo...@ornl.gov
Cc
On 10/10/13 14:45, Jack Wang wrote:
On 10/10/2013 01:50 PM, Bart Van Assche wrote:
From: Vu Pham vuhu...@mellanox.com
Remove an SRP target from the SRP target list before invoking the
last scsi_host_put() call. This change is necessary because that
last put frees the memory that holds
On 31/10/2013 9:21, Or Gerlitz wrote:
Fix the below few make W=1 build warnings we have on the IB core.
drivers/infiniband/core/sysfs.c: In function ‘state_show’:
drivers/infiniband/core/sysfs.c:107: warning: comparison of unsigned expression
= 0 is always true
drivers/infiniband/core/verbs.c:
On 31/10/2013 5:24, Sagi Grimberg wrote:
In T10-DIF, when a series of 512-byte data blocks are transferred, each
block is followed by an 8-byte guard. The guard consists of CRC that
protects the integrity of the data in the block, and some other tags
that protects against mis-directed IOs.
On 31/10/2013 5:24, Sagi Grimberg wrote:
+static u8 bs_selector(int block_size)
+{
+ switch (block_size) {
+ case 512: return 0x1;
+ case 520: return 0x2;
+ case 4096: return 0x3;
+ case 4160: return 0x4;
+ case
On 31/10/2013 5:24, Sagi Grimberg wrote:
+/**
+ * struct ib_sig_domain - Parameters specific for T10-DIF
+ * domain.
+ * @sig_type: specific signauture type
+ * @sig: union of all signature domain attributes that may
+ * be used to set domain layout.
+ * @dif:
+ *
On 31/10/2013 5:24, Sagi Grimberg wrote:
+/**
+ * ib_mr_init_attr - Memory region init attributes passed to routine
+ * ib_create_mr.
+ * @max_reg_descriptors: max number of registration units that
+ * may be used with UMR work requests.
+ * @flags: MR creation flags bit mask.
+ */
+struct
On 31/10/2013 5:24, Sagi Grimberg wrote:
This patch implements IB_WR_REG_SIG_MR posted by the user.
Baisically this WR involvs 3 WQEs in order to prepare and properly
register the signature layout:
1. post UMR WR to register the sig_mr in one of two possible ways:
* In case the user
On 31/10/2013 5:24, Sagi Grimberg wrote:
+ /* connect to MR tree */
+ write_lock_irq(table-lock);
+ err = radix_tree_insert(table-tree, mr-key 0xff00, mr);
+ write_unlock_irq(table-lock);
The conversion from MR key into radix tree index occurs three times so
maybe
On 31/10/2013 5:24, Sagi Grimberg wrote:
+ * @type3_inc_reftag: T10-DIF type 3 does not state
+ * about the reference tag, it is the user
+ * choice to increment it or not.
Can you explain this further ? Does this mean that the HCA can check
On 2/11/2013 12:21, Or Gerlitz wrote:
On Fri, Nov 1, 2013 at 10:37 PM, Bart Van Assche bvanass...@acm.org wrote:
On 31/10/2013 5:24, Sagi Grimberg wrote:
This patch implements IB_WR_REG_SIG_MR posted by the user.
Baisically this WR involvs 3 WQEs in order to prepare and properly
register
On 3/11/2013 4:15, Sagi Grimberg wrote:
On 11/1/2013 8:46 PM, Bart Van Assche wrote:
On 31/10/2013 5:24, Sagi Grimberg wrote:
+/**
+ * Signature T10-DIF block-guard types
+ */
+enum ib_t10_dif_bg_type {
+IB_T10DIF_CRC,
+IB_T10DIF_CSUM
+};
In SPC-4 paragraph 4.22.4 I found
On 11/13/13 17:27, Hal Rosenstock wrote:
From: Vladimir Koushnir vladim...@mellanox.com
Signed-off-by: Vladimir Koushnir vladim...@mellanox.com
---
opensm/osm_sa.c | 20
1 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/opensm/osm_sa.c b/opensm/osm_sa.c
On 11/22/13 15:57, Hal Rosenstock wrote:
Hi Bart,
On 11/13/2013 1:00 PM, Bart Van Assche wrote:
Isn't an fdatasync() call missing after dump_func() and before fclose()
? According to Theodore Ts'o calling fdatasync() or fsync() before
fclose() is essential during an atomic update. See also
which value fast_io_fail_tmo has been
set to. Make the behavior of the SRP transport layer consistent with
that of the FC transport layer to avoid confusion.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: David Dillow dillo...@ornl.gov
Cc: Vu Pham v...@mellanox.com
Cc: Sebastian Riemer
[81090876] kthread+0x96/0xa0
[8100c0ca] child_rip+0xa/0x20
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: David Dillow dillo...@ornl.gov
Cc: Vu Pham v...@mellanox.com
Cc: Sebastian Riemer sebastian.rie...@profitbricks.com
Cc: James Bottomley jbottom...@parallels.com
---
drivers/infiniband
Add a diagram in Documentation/scsi/scsi_transport_srp that
illustrates the rport state transitions.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: David Dillow dillo...@ornl.gov
Cc: Vu Pham v...@mellanox.com
Cc: Sebastian Riemer sebastian.rie...@profitbricks.com
Cc: James Bottomley
On 12/20/13 23:31, Hal Rosenstock wrote:
-int osm_db_store(IN osm_db_domain_t * p_domain)
+int osm_db_store(IN osm_db_domain_t * p_domain,
+ IN boolean_t fsync_high_avail_files)
{
osm_log_t *p_log = p_domain-p_db-p_log;
osm_db_domain_imp_t *p_domain_imp;
FILE
On 12/21/13 03:05, Upinder Malhi (umalhi) wrote:
Change from V0:
Make reserved field 9 bytes instead of 8 bytes.
This patch depends on http://www.spinics.net/lists/linux-rdma/msg18193.html.
Change the type of the reserve field to u32 from u64 in
usnic_ib_create_qp_resp bc u64 will align
On 12/17/13 17:48, Upinder Malhi wrote:
Errors with IS_ERR_OR_NULL are not handleded correctly in few places
in usNIC. This patch remedies that.
Signed-off-by: Upinder Malhi uma...@cisco.com
---
drivers/infiniband/hw/usnic/usnic_ib_main.c | 10 ++
On 12/17/13 17:48, Upinder Malhi wrote:
usNIC calls BUG_ON(spinlock_is_held..) at few places. In some of these
instances, the call is made with another spinlock already held. Change
all such calls in usNIC to WARN_ON to make it fool-proof.
Signed-off-by: Upinder Malhi uma...@cisco.com
---
On 12/17/13 17:48, Upinder Malhi wrote:
diff --git a/drivers/infiniband/hw/usnic/usnic_uiom.c
b/drivers/infiniband/hw/usnic/usnic_uiom.c
index 359897d..0477d70 100644
--- a/drivers/infiniband/hw/usnic/usnic_uiom.c
+++ b/drivers/infiniband/hw/usnic/usnic_uiom.c
@@ -81,15 +81,16 @@ static
On 12/17/13 17:48, Upinder Malhi wrote:
Sparse spit out few functions should be static warnings. This
patch provides a fix for the warnings.
[ ... ]
@@ -579,6 +580,7 @@ static void __exit usnic_ib_destroy(void)
{
usnic_dbg(\n);
usnic_debugfs_exit();
+
On 12/21/13 13:54, Hal Rosenstock wrote:
-int osm_db_store(IN osm_db_domain_t * p_domain)
+int osm_db_store(IN osm_db_domain_t * p_domain,
+ IN boolean_t fsync_high_avail_files)
Version two of this patch looks fine to me, but while reviewing this
patch I noticed two issues in
The following command has been used to verify that the kernel-doc
tool no longer complains about undocumented fields:
scripts/kernel-doc -html drivers/scsi/scsi_transport_srp.c \
include/scsi/scsi_transport_srp.h srp-transport-doc.html
Signed-off-by: Bart Van Assche bvanass...@acm.org
Acked
On 01/30/14 09:19, Or Gerlitz wrote:
On 29/01/2014 19:56, Bart Van Assche wrote:
On 01/29/14 16:06, Sagi Grimberg wrote:
Didn't understand why should it matter where the copy is done
(iser/block)?
In the Linux kernel community it is considered important to avoid code
duplication. Hence
Hello,
While testing kernel 3.14-rc3 I noticed the call stack below. Had anyone
else perhaps already noticed this ? The test I ran was to change the
mlx4 port type a few times while the ib_ipoib kernel module was loaded.
Thanks,
Bart.
On 02/18/14 17:47, Sebastian Riemer wrote:
I've also noticed the added target locking around target-free_tx
handling in srp_rport_reconnect(). There are cases e.g. in
srp_queuecommand() where holding the rport mutex isn't enough to protect
it. So for me this looks right.
Then, in
On 02/18/14 18:25, Sagi Grimberg wrote:
Regarding the FMR unmap crash, I experienced it when running our
distro-backported MLNX_OFED
and hadn't got a chance to see if it reproduces in upstream yet. Thanks
for confirming this reproduces here as well.
Bart, Are you familiar with this issue? it
This patch series includes the following six patches:
0001-scsi_transport_srp-Fix-two-kernel-doc-warnings.patch
0002-IB-srp-Add-more-logging.patch
0003-IB-srp-Fail-SCSI-commands-silently.patch
0004-IB-srp-Avoid-duplicate-connections.patch
This patch fixes the following two kernel-doc warnings:
Warning(drivers/scsi/scsi_transport_srp.c:819): No description found for
parameter 'rport'
Warning(include/scsi/scsi_transport_srp.h:75): Excess struct/union/enum/typedef
member 'deleted' description in 'srp_rport'
Signed-off-by: Bart Van
601 - 700 of 1130 matches
Mail list logo
