Re: [PATCH net-next 0/2] new maintainers for Mellanox mlx4/mlx5 core and IB drivers

2015-12-23 Thread David Miller
From: Doug Ledford Date: Wed, 23 Dec 2015 13:31:06 -0500 > On 12/23/2015 11:30 AM, Or Gerlitz wrote: >> Hi Dave, Doug >> >> We're happily assigning new maintainers for mlx4/mlx5 core and IB drivers. >> >> This is aligned with Eli (mlx5) and Roland (mlx4). >> >> FWIW, I

Re: [PATCH for-next 0/2] RDMA/cxgb4: Add iWARP support for T6 adapter

2015-10-21 Thread David Miller
From: Doug Ledford Date: Wed, 21 Oct 2015 16:58:50 -0400 > Probably. Unless David objects, I'll queue them up. No objection from me. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2 05/14] RDS: defer the over_batch work to send worker

2015-10-05 Thread David Miller
From: Santosh Shilimkar Date: Wed, 30 Sep 2015 13:24:24 -0400 > @@ -423,7 +423,9 @@ over_batch: >!list_empty(>c_send_queue)) && > send_gen == conn->c_send_gen) { > rds_stats_inc(s_send_lock_queue_raced); >

Re: message size, was Re: merge struct ib_device_attr into struct ib_device

2015-09-22 Thread David Miller
From: "Steve Wise" Date: Tue, 22 Sep 2015 17:15:15 -0500 > How do we change the message size limits? Reviewing w/o it being > inline is painful for the (many) reviewers... I've increased it. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma"

Re: [patch -next] net/mlx5_core: fix an error code

2015-06-11 Thread David Miller
From: Dan Carpenter dan.carpen...@oracle.com Date: Thu, 11 Jun 2015 11:50:01 +0300 We return success if mlx5e_alloc_sq_db() fails but we should return an error code. Fixes: f62b8bb8f2d3 ('net/mlx5: Extend mlx5_core to support ConnectX-4 Ethernet functionality') Signed-off-by: Dan

Re: [PATCH net] net/mlx4_core: Fix reading HCA max message size in mlx4_QUERY_DEV_CAP

2015-04-21 Thread David Miller
From: Or Gerlitz ogerl...@mellanox.com Date: Tue, 21 Apr 2015 15:46:34 +0300 From: Eran Ben Elisha era...@mellanox.com Currently we parse max_msg_sz from the wrong offset in QUERY_DEV_CAP, fix to use the right offset. Fixes: 0b131561a7d6 ('net/mlx4_en: Add Flow control statistics [..]')

Re: [PATCH V1 net-next] IB/ipoib: Fix ndo_get_iflink

2015-04-17 Thread David Miller
From: Erez Shitrit ere...@mellanox.com Date: Thu, 16 Apr 2015 16:34:34 +0300 Currently, iflink of the parent interface was always accessed, even when interface didn't have a parent and hence we crashed there. Handle the interface types properly: for a child interface, return the ifindex of

Re: [PATCH linux-next v2] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-14 Thread David Miller
From: Honggang Li ho...@redhat.com Date: Mon, 13 Apr 2015 17:21:58 +0800 If CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for x86 systems and physical memory is more than 4GB, dma_map_page may return a valid memory address which greater than 0x. As a result, the mlx5 device page allocator RB

Re: [PATCH net-next v2 3/4] cxgb4: add DDP support for FCoE target

2015-04-13 Thread David Miller
From: Varun Prakash va...@chelsio.com Date: Mon, 13 Apr 2015 19:34:25 +0530 diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c index 6c8a62e..f78d632 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c +++

Re: [PATCH for-next 0/9] mlx4 changes in virtual GID management

2015-04-05 Thread David Miller
From: Roland Dreier rol...@kernel.org Date: Sun, 5 Apr 2015 07:51:08 -0700 On Sat, Apr 4, 2015 at 10:15 PM, Or Gerlitz gerlitz...@gmail.com wrote: Indeed. No maintainer voice makes it kind of impossible for discussions to converge. What happens over the last years is that when there's no easy

Re: [PATCH for-next 0/9] mlx4 changes in virtual GID management

2015-03-31 Thread David Miller
From: Or Gerlitz gerlitz...@gmail.com Date: Tue, 31 Mar 2015 14:22:50 +0300 On Tue, Mar 31, 2015 at 6:47 AM, Roland Dreier rol...@kernel.org wrote: Roland, I have to genuinely agree with Or, that your handling of patch integration is sub-par and really painful for anyone actually trying to

Re: [PATCH for-next 0/9] mlx4 changes in virtual GID management

2015-03-31 Thread David Miller
From: Christoph Lameter c...@linux.com Date: Tue, 31 Mar 2015 07:49:38 -0500 (CDT) Well this needs to be addressed yes but in order to have that done someone needs to step forward do the proper work, maintain git trees, do the review and show up for the conferences. Neither Roland nor Or was

Re: [PATCH for-next 0/9] mlx4 changes in virtual GID management

2015-03-30 Thread David Miller
From: Or Gerlitz gerlitz...@gmail.com Date: Mon, 30 Mar 2015 19:17:01 +0300 On Sun, Mar 29, 2015 at 4:51 PM, Or Gerlitz ogerl...@mellanox.com wrote: Under the existing implementation for virtual GIDs, if the SM is not reachable or incurs a delayed response, or if the VF is probed into a VM

Re: [PATCH 3/15] net/mlx5_core: don't export static symbol

2015-03-11 Thread David Miller
From: Julia Lawall julia.law...@lip6.fr Date: Wed, 11 Mar 2015 17:56:25 +0100 From: Julia Lawall julia.law...@lip6.fr The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) ... Signed-off-by: Julia Lawall julia.law...@lip6.fr Applied, thank you Julia. -- To

Re: [PATCH v2] net: Mellanox: Delete unnecessary checks before the function call vunmap

2015-02-09 Thread David Miller
From: SF Markus Elfring elfr...@users.sourceforge.net Date: Mon, 09 Feb 2015 11:21:26 +0100 From: Markus Elfring elfr...@users.sourceforge.net Date: Mon, 9 Feb 2015 11:10:41 +0100 The vunmap() function performs also input parameter validation. Thus the test around the call is not needed.

Re: [PATCH] net: Mellanox: Delete unnecessary checks before the function call vunmap

2015-02-05 Thread David Miller
From: SF Markus Elfring elfr...@users.sourceforge.net Date: Wed, 04 Feb 2015 15:22:33 +0100 From: Markus Elfring elfr...@users.sourceforge.net Date: Wed, 4 Feb 2015 15:17:00 +0100 The vunmap() function performs also input parameter validation. Thus the test around the call is not needed.

Re: [PATCH for-next 0/2] Refactor macros to conform to uniform standards

2015-01-15 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Fri, 16 Jan 2015 09:24:46 +0530 This patch series cleansup macros/register defines, defined in t4.h and t4fw_ri_api.h and all the affected files. This patch series is created against net-next tree and includes patches on iw_cxgb4 tree.

Re: [PATCH] infiniband: mlx5: avoid a compile-time warning

2015-01-13 Thread David Miller
From: Arnd Bergmann a...@arndb.de Date: Tue, 13 Jan 2015 17:09:43 +0100 The return type of find_first_bit() is architecture specific, on ARM it is 'unsigned int', while the asm-generic code used on x86 and a lot of other architectures returns 'unsigned long'. When building the mlx5 driver

Re: [PATCH] mlx5: avoid build warnings on 32-bit

2015-01-13 Thread David Miller
From: Arnd Bergmann a...@arndb.de Date: Tue, 13 Jan 2015 17:08:06 +0100 The mlx5 driver passes a string pointer in through a 'u64' variable, which on 32-bit machines causes a build warning: drivers/net/ethernet/mellanox/mlx5/core/debugfs.c: In function 'qp_read_field':

Re: [PATCH net-next 0/2] All Chelsio drivers : Cleanup CPL messages macros

2015-01-12 Thread David Miller
From: Anish Bhatt an...@chelsio.com Date: Thu, 8 Jan 2015 21:38:14 -0800 This patch series cleans up all register defines/MACROS defined in t4_msg.h and affected files as part of the continuing cleanup effort The patches series is created against 'net-next' tree and includes patches to

Re: [PATCH net-next 0/5] RDMA/cxgb4/cxgb4vf/csiostor: Cleanup register defines

2015-01-05 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Mon, 5 Jan 2015 16:30:42 +0530 This series continues to cleanup all the macros/register defines related to SGE, PCIE, MC, MA, TCAM, MAC, etc that are defined in t4_regs.h and the affected files. Will post another 1 or 2 series so that we

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-12-29 Thread David Miller
From: Wengang wen.gang.w...@oracle.com Date: Mon, 29 Dec 2014 15:11:32 +0800 So, what information else do you need? I need a patch formally (re-)submitted. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-12-29 Thread David Miller
From: Wengang Wang wen.gang.w...@oracle.com Date: Tue, 30 Dec 2014 11:04:42 +0800 When last slave of a bonding master is removed, the bonding then does not work. At the time if packet_snd is called against with a master net_device, it calls then header_ops-create which points to slave's

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-12-29 Thread David Miller
From: Wengang wen.gang.w...@oracle.com Date: Tue, 30 Dec 2014 11:01:42 +0800 There are more than one way we do things. For this case, considering needs, complexity and stability I think moving ipoib_header_ops is the right way to go. I completely disagree, it's a gross hack at best. It's

Re: [PATCH net-next 0/9] mlx5 driver updates

2014-12-08 Thread David Miller
From: Eli Cohen e...@dev.mellanox.co.il Date: Tue, 2 Dec 2014 12:26:10 +0200 The following series contains some fixes to mlx5 as well as update to the list of supported devices. Series applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-11-25 Thread David Miller
From: Jay Vosburgh jay.vosbu...@canonical.com Date: Tue, 25 Nov 2014 10:41:17 -0800 Or Gerlitz ogerl...@mellanox.com wrote: On 11/25/2014 8:07 AM, David Miller wrote: IPOIB should not work over bonding as it requires that the device use ARPHRD_ETHER. Hi Dave, IPoIB devices can be enslaved

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-11-24 Thread David Miller
From: Wengang Wang wen.gang.w...@oracle.com Date: Tue, 25 Nov 2014 13:36:08 +0800 When last slave of a bonding master is removed, the bonding then does not work. At the time if packet_snd is called against with a master net_device, it calls then header_ops-create which points to slave's

Re: [PATCH net-next 0/5] RDMA/cxgb4,cxgb4vf,csiostor: Cleanup macros

2014-11-22 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Fri, 21 Nov 2014 12:52:00 +0530 This series continues to cleanup all the macros/register defines related to filter, port, VI, queue, RSS, LDST, firmware, etc that are defined in t4fw_api.h and the affected files. Will post few more

Re: mlx5: don't duplicate kvfree()

2014-11-21 Thread David Miller
From: Al Viro v...@zeniv.linux.org.uk Date: Thu, 20 Nov 2014 08:13:57 + Signed-off-by: Al Viro v...@zeniv.linux.org.uk Applied. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH net-next] cxgb4i/cxgb4 : Refactor macros to conform to uniform standards

2014-11-13 Thread David Miller
From: Anish Bhatt an...@chelsio.com Date: Wed, 12 Nov 2014 17:15:57 -0800 Refactored all macros used in cxgb4i as part of previously started cxgb4 macro names cleanup. Makes them more uniform and avoids namespace collision. Minor changes in other drivers where required as some of these macros

Re: [PATCHv3 net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros

2014-11-10 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Fri, 7 Nov 2014 09:35:22 +0530 This series moves the debugfs code to a new file debugfs.c and cleans up macros/register defines. Various patches have ended up changing the style of the symbolic macros/register defines and some of them

Re: [PATCH net 0/2] mlx5_core fixes for 3.18

2014-11-06 Thread David Miller
From: Eli Cohen e...@dev.mellanox.co.il Date: Thu, 6 Nov 2014 12:51:20 +0200 the following two patches fix races to could lead to kernel panic in some cases. Series applied, thanks Eli. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to

Re: [PATCHv2 net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros

2014-11-06 Thread David Miller
From: Hariprasad S haripra...@chelsio.com Date: Thu, 6 Nov 2014 21:45:10 +0530 On Wed, Nov 05, 2014 at 14:54:43 -0500, David Miller wrote: From: Hariprasad Shenai haripra...@chelsio.com Date: Tue, 4 Nov 2014 08:20:54 +0530 It's not really the hardware which generates these hardware

Re: [PATCHv2 net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros

2014-11-05 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Tue, 4 Nov 2014 08:20:54 +0530 It's not really the hardware which generates these hardware constant symbolic macros/register defines of course, it's scripts developed by the hardware team. Various patches have ended up changing the

Re: [PATCH net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros

2014-11-03 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Mon, 3 Nov 2014 17:46:51 +0530 This series moves the debugfs code to a new file debugfs.c, Cleans up macros so that they match the hardware generated one. How does hardware generate the macros? I don't understand what this means at all.

Re: 3.17-rc1 oops during network interface configuration

2014-09-10 Thread David Miller
From: Or Gerlitz ogerl...@mellanox.com Date: Wed, 10 Sep 2014 10:42:41 +0300 Hi Chuck, thanks for bisecting this out. Indeed, as of this kernel 3.2 commit 936d7de IPoIB: Stop lying about hard_header_len and use skb-cb to stash LL addresses we are using the skb-cb field to enable proper work

Re: [PATCH 0/5] Misc. fix for cxgb4 and iw_cxgb4

2014-07-21 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Mon, 21 Jul 2014 20:55:11 +0530 This patch series adds support to enchance error reporting, log detailed warning for negative advice, support query_qp verb and advertise correct device max attributes for iwarp. The patches series is

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-20 Thread David Miller
From: Benoit Taine benoit.ta...@lip6.fr Date: Fri, 18 Jul 2014 17:26:47 +0200 We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes

Re: [PATCH net-next 3/4] libcxgbi: Add ipv6 api to driver

2014-07-17 Thread David Miller
From: Anish Bhatt an...@chelsio.com Date: Tue, 15 Jul 2014 19:55:52 -0700 +#define pr_info_ipaddr(fmt_trail,\ + addr1, addr2, args_trail...)\ Barf... use %pIS instead, which takes a pointer to a sockaddr of family

Re: [PATCH net-next v2 0/4] cxgb4i: Add ipv6 support

2014-07-17 Thread David Miller
From: Anish Bhatt an...@chelsio.com Date: Thu, 17 Jul 2014 00:18:14 -0700 The following patchset add ipv6 support for the cxgb4i(iscsi) driver. Patch 1 moves a define from the iw_cxgb4 to cxgb4 to prevent code duplication, as it is used by cxgb4i and iw_cxgb4 both. Patch 2 exports

Re: [PATCH] iw_cxgb4: fix for 64-bit integer division

2014-07-17 Thread David Miller
From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Date: Thu, 17 Jul 2014 22:44:42 +0400 Hello. On 07/17/2014 09:01 PM, Hariprasad Shenai wrote: Fixed error introduced in commit id 7730b4c ( cxgb4/iw_cxgb4: work request logging feature) while compiling on 32 bit architecture

Re: [PATCHv2 net-next 0/4] Misc. fixes for iw_cxgb4

2014-07-15 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Mon, 14 Jul 2014 21:34:50 +0530 This patch series adds support to determine ingress padding boundary at runtime. Advertise a larger max read queue depth for qps, and gather the resource limits from fw and use them to avoid exhausting all

Re: [PATCH 0/5] cxgb4: Fix for PCI passthrough and some Misc. fixes

2014-07-01 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Fri, 27 Jun 2014 19:23:46 +0530 This patch series fixes probe failure in VM when PF is exposed through PCI Passthrough. Adds support to use firmware interface to get BAR0 value. Replace the backdoor mechanism to access the HW memory with

Re: [PATCH 00/22] Add and use pci_zalloc_consistent

2014-06-23 Thread David Miller
From: Joe Perches j...@perches.com Date: Mon, 23 Jun 2014 06:41:28 -0700 Adding the helper reduces object code size as well as overall source size line count. It's also consistent with all the various zalloc mechanisms in the kernel. Done with a simple cocci script and some typing. For

Re: [PATCH net-next 0/4] Adds support for CIQ and other misc. fixes for rdma/cxgb4

2014-06-10 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Fri, 6 Jun 2014 21:40:41 +0530 This patch series adds support to allocate and use IQs specifically for indirect interrupts, adds fixes to align ISS for iWARP connections fixes related to tcp snd/rvd window for Chelsio T4/T5 adapters on

Re: [PATCH] drivers: net: ethernet: mellanox: mlx4: let mlx4 depend on SMP

2014-05-16 Thread David Miller
From: Chen Gang gang.chen.5...@gmail.com Date: Sat, 17 May 2014 13:26:16 +0800 'struct irq_affinity_notify' and the related functions are only defined when SMP enabled, so at present, mlx4 has to only run under SMP. The related error (allmodconfig under unicore32): Making the entire driver

Re: [PATCH] [resend] net: get rid of SET_ETHTOOL_OPS

2014-05-13 Thread David Miller
From: Wilfried Klaebe w-l...@lebenslange-mailadresse.de Date: Sun, 11 May 2014 00:12:32 + net: get rid of SET_ETHTOOL_OPS Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone. This does that. Mostly done via coccinelle script: @@ struct ethtool_ops *ops; struct net_device

Re: [PATCH V2] mellanox: Logging message cleanups

2014-05-08 Thread David Miller
From: Joe Perches j...@perches.com Date: Wed, 7 May 2014 12:52:57 -0700 Use a more current logging style. o Coalesce formats o Add missing spaces for coalesced formats o Align arguments for modified formats o Add missing newlines for some logging messages o Use DRV_NAME as part of format

Re: [PATCH] mellanox: Logging message cleanups

2014-05-07 Thread David Miller
Joe, please get rid of the initial empty line you're adding to fw.c and resubmit with Amir's ACK. Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] RDMA/cxgb4: set error code on kmalloc() failure

2014-03-28 Thread David Miller
From: Steve Wise sw...@opengridcomputing.com Date: Wed, 26 Mar 2014 10:25:22 -0500 Acked-by: Steve Wise sw...@opengridcomputing.com Note: This fix applies only to net-next because the commit that introduced this is still pending in net-next: commit

Re: [Patch 0/3] Hangs with IPoIB when doing PCI error injection

2014-03-28 Thread David Miller
From: cls...@linux.vnet.ibm.com Date: Thu, 27 Mar 2014 09:28:13 -0500 This patch is to resolve some hangs we are seeing when doing PCI error injection to Mellanox Infiniband cards. With this patch we make mlx4 driver send an IB_EVENT_DEVICE_FATAL to the users and added this event to event

Re: [PATCHv6 net-next 20/31] iw_cxgb4: adjust tcp snd/rcv window based on link speed

2014-03-12 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Wed, 12 Mar 2014 21:20:35 +0530 Added module option named adjust_win, defaulted to 1, that allows disabling the 40G window bump. This allows a user to specify the exact default window sizes via module options snd_win and rcv_win. This is

Re: [PATCHv6 net-next 00/31] Misc. fixes for cxgb4 and iw_cxgb4

2014-03-12 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Wed, 12 Mar 2014 21:20:15 +0530 V6: In patch 8/31, move the existing neigh_release() call right before the if(!e) test, that way you don't need a completely new label and code block to fix this bug - thanks to review by David

Re: [PATCHv6 net-next 20/31] iw_cxgb4: adjust tcp snd/rcv window based on link speed

2014-03-12 Thread David Miller
From: Steve Wise sw...@opengridcomputing.com Date: Wed, 12 Mar 2014 16:29:27 -0500 You can just use the TCP settings the kernel already provides for the real TCP stack. Do you mean use sysctl_tcp_*mem, sysctl_tcp_timestamps, sysctl_tcp_window_scaling, etc? I'll look into this.

Re: [PATCHv6 net-next 00/31] Misc. fixes for cxgb4 and iw_cxgb4

2014-03-12 Thread David Miller
From: Casey Leedom lee...@chelsio.com Date: Wed, 12 Mar 2014 16:43:33 -0700 Should we revisit that decision and ask Hari to submit a series of much smaller patch sets (one at a time obviously)? That might be a good idea, honestly. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCHv5 net-next 00/31] Misc. fixes for cxgb4 and iw_cxgb4

2014-03-10 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Mon, 10 Mar 2014 22:37:57 +0530 Dropped patch cxgb4: use spinlock_irqsave/spinlock_irqrestore for db lock. save/restore spinlock variants are not required - thanks to review by David Miller. That is absolutely not what I said. I

Re: [PATCHv5 net-next 08/31] iw_cxgb4: release neigh entry in error paths

2014-03-10 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Mon, 10 Mar 2014 22:38:05 +0530 diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index 360807e..74a2250 100644 --- a/drivers/infiniband/hw/cxgb4/cm.c +++ b/drivers/infiniband/hw/cxgb4/cm.c @@ -3350,10

Re: [PATCH] IB/mlx5_core: remove unreachable function call in module init

2014-03-10 Thread David Miller
From: Kleber Sacilotto de Souza kleb...@linux.vnet.ibm.com Date: Fri, 7 Mar 2014 19:48:25 -0300 The call to mlx5_health_cleanup() in the module init function can never be reached. Removing it. Signed-off-by: Kleber Sacilotto de Souza kleb...@linux.vnet.ibm.com Applied to net-next, thank

Re: [PATCHv4 net-next 05/32] cxgb4: use spinlock_irqsave/spinlock_irqrestore for db lock

2014-03-07 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Fri, 7 Mar 2014 16:03:02 +0530 @@ -3585,9 +3585,11 @@ static void disable_txq_db(struct sge_txq *q) static void enable_txq_db(struct sge_txq *q) { - spin_lock_irq(q-db_lock); + unsigned long flags; + +

Re: [PATCHv3 net-next 00/31] Misc. fixes for cxgb4 and iw_cxgb4

2014-03-04 Thread David Miller
BTW, if you're frustrated from having to send these patches so many times because of changes being requested, this is the main reason why you shouldn't queue up such enormous numbers of patches at one time. Please try to keep your future submissions sizes more reasonable, perhaps ~10 patches or

Re: [PATCH net-next 10/31] cxgb4/iw_cxgb4: Doorbell Drop Avoidance Bug Fixes.

2014-02-27 Thread David Miller
From: Steve Wise sw...@opengridcomputing.com Date: Thu, 27 Feb 2014 11:11:49 -0600 -static int allow_db_fc_on_t5; -module_param(allow_db_fc_on_t5, int, 0644); -MODULE_PARM_DESC(allow_db_fc_on_t5, - Allow DB Flow Control on T5 (default = 0)); - -static int

Re: [PATCH net-next 10/31] cxgb4/iw_cxgb4: Doorbell Drop Avoidance Bug Fixes.

2014-02-26 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Wed, 26 Feb 2014 20:36:49 +0530 -static int allow_db_fc_on_t5; -module_param(allow_db_fc_on_t5, int, 0644); -MODULE_PARM_DESC(allow_db_fc_on_t5, - Allow DB Flow Control on T5 (default = 0)); - -static int

Re: net,IB/mlx: Bump all Mellanox driver versions

2014-02-25 Thread David Miller
From: Amir Vadai am...@mellanox.com Date: Wed, 19 Feb 2014 18:23:18 +0200 On 19/02/14 17:47 +0200, Amir Vadai wrote: Bump all Mellanox driver versions. Signed-off-by: Amir Vadai am...@mellanox.com --- Hi, We're changing the version scheme of our drivers. I would be happy if it goes to

Re: [PATCH net-next 00/35] net: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-02-18 Thread David Miller
From: Alexander Gordeev agord...@redhat.com Date: Tue, 18 Feb 2014 11:07:52 +0100 As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and

Re: [PATCH net v2 0/8] Fixes for server entries and server filter entries for Chelsio T4/T5

2013-12-22 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Wed, 18 Dec 2013 16:38:18 +0530 This patch series provides miscelleneous fixes for Chelsio T4/T5 adapters related to server entries and server filter entries. Series applied, thanks. -- To unsubscribe from this list: send the line

Re: [PATCH net 0/9] Fixes for server entries and server filter entries for Chelsio T4/T5

2013-12-17 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Mon, 16 Dec 2013 17:42:09 +0530 This patch series provides miscelleneous fixes for Chelsio T4/T5 adapters related to server entries and server filter entries. You add the sftids_in_use counter, but it is never tested by any code. It is only

Re: [PATCH for-next] mlx4_core: Roll back round robin bitmap allocation commit for CQs, SRQs, and MPTs

2013-12-09 Thread David Miller
From: Or Gerlitz ogerl...@mellanox.com Date: Sun, 8 Dec 2013 16:50:17 +0200 From: Jack Morgenstein ja...@dev.mellanox.co.il Commit f4ec9e9 mlx4_core: Change bitmap allocator to work in round-robin fashion introduced round-robin allocation (via bitmap) for all resources which allocate

Re: [patch v2] mlx5_core: delete some dead code

2013-11-05 Thread David Miller
From: Dan Carpenter dan.carpen...@oracle.com Date: Tue, 5 Nov 2013 01:20:56 +0300 The printk() looks like it is left over debug code. I have removed it. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- v2: Remove the printk instead of moving it infront of the return. This

Re: [PATCH 2/2] fs: use inode_set_user to set uid/gid of inode

2013-08-22 Thread David Miller
From: Rui Xiang rui.xi...@huawei.com Date: Fri, 23 Aug 2013 10:48:38 +0800 Use the new interface to set i_uid/i_gid in inode struct. Signed-off-by: Rui Xiang rui.xi...@huawei.com For the networking bits: Acked-by: David S. Miller da...@davemloft.net -- To unsubscribe from this list: send

Re: [PATCH] mlx5: fix error return code in mlx5_alloc_uuars()

2013-07-30 Thread David Miller
From: Wei Yongjun weiyj...@gmail.com Date: Tue, 30 Jul 2013 07:57:06 +0800 From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENOMEM from the ioremap error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn

Re: [patch] mlx5: use after free in mlx5_cmd_comp_handler()

2013-07-24 Thread David Miller
From: Eli Cohen e...@dev.mellanox.co.il Date: Wed, 24 Jul 2013 19:35:44 +0300 This race has been spotted and fixed by Moshe Lazer two weeks ago. Anyways, Acked by Eli Cohen e...@mellanox.com Applied. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a

Re: [PATCH 3.11-rc1] mlx5 core: Fix __udivdi3 when compiling for 32 bit arches

2013-07-16 Thread David Miller
From: Randy Dunlap rdun...@infradead.org Date: Mon, 15 Jul 2013 08:52:18 -0700 On 07/15/13 07:56, Tim Gardner wrote: Cc: Eli Cohen e...@mellanox.com Signed-off-by: Tim Gardner tim.gard...@canonical.com I reported this last week and Eli wrote: I have this fixed in my tree and we run the

Re: [PATCH V2 0/4] Add IPv6 support for iWARP

2013-07-02 Thread David Miller
From: Vipul Pandya vi...@chelsio.com Date: Tue, 02 Jul 2013 12:17:57 +0530 I upgraded my GCC version from 4.4.6-4 to 4.8.1 and after that I am able to see that warning. I will resubmit this series soon. That's fine, but realize it is too late to submit this for the current merge window. -- To

Re: [PATCH for/net-next 3/8] net/mlx5: Mellanox Connect-IB, core driver part 3/3

2013-07-01 Thread David Miller
From: Jack Morgenstein ja...@dev.mellanox.co.il Date: Mon, 1 Jul 2013 14:44:54 +0300 Thus, the for loop could read: for (--i; i = 0; i--) { However, my own personal opinion is that this is a bit confusing. I would prefer to leave these lines as they are. Is that OK with you?

Re: [PATCH for/net-next 3/8] net/mlx5: Mellanox Connect-IB, core driver part 3/3

2013-07-01 Thread David Miller
From: Jack Morgenstein ja...@dev.mellanox.co.il Date: Mon, 1 Jul 2013 14:44:54 +0300 On Saturday 29 June 2013 07:10, David Miller wrote: From: Or Gerlitz ogerl...@mellanox.com Date: Wed, 26 Jun 2013 17:22:12 +0300 + for (--i; i = 0; --i) { Please, i-- is more canonical in for() loops

Re: [PATCH for/net-next 2/8] net/mlx5: Mellanox Connect-IB, core driver part 2/3

2013-06-28 Thread David Miller
From: Or Gerlitz ogerl...@mellanox.com Date: Wed, 26 Jun 2013 17:22:11 +0300 + eqe-owner = 0x55; Magic constant. If this is how you will represent Invalid Owner, then make a macro for this value 0x55 expressing that. + switch (synd) { + case 0x1: Please make descriptive

Re: [PATCH for/net-next 3/8] net/mlx5: Mellanox Connect-IB, core driver part 3/3

2013-06-28 Thread David Miller
From: Or Gerlitz ogerl...@mellanox.com Date: Wed, 26 Jun 2013 17:22:12 +0300 + for (--i; i = 0; --i) { Please, i-- is more canonical in for() loops. + for (--i; i = 0; --i) { Likewise. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to

Re: [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB devices

2013-06-25 Thread David Miller
From: Or Gerlitz ogerl...@mellanox.com Date: Thu, 20 Jun 2013 17:44:49 +0300 So we skipped netdev in V0, in an attempt to reduce cross postings... anyway, the mlx5_core driver is similar story as of mlx4_core. So, if looking forward, for the initial merge to be simpler, are you OK for both

Re: [PATCH V2 0/4] Add IPv6 support for iWARP

2013-06-19 Thread David Miller
From: Vipul Pandya vi...@chelsio.com Date: Wed, 12 Jun 2013 17:11:38 +0530 We have included all the maintainers of respective drivers. Kindly review the change and let us know in case of any review comments. I have not seen anyone review v2 of this patch series. At least the Infiniband

Re: [PATCH V2 1/4] RDMA/cma: Add IPv6 support for iWARP.

2013-06-12 Thread David Miller
From: Nikolova, Tatyana E tatyana.e.nikol...@intel.com Date: Wed, 12 Jun 2013 19:56:37 + I reviewed the iWarp IPv6 nes patch. Can you please not top-post and quote the entire patch like this? -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to

Re: [PATCH 1/4] RDMA/cma: Add IPv6 support for iWARP.

2013-06-07 Thread David Miller
Please use local variables for the sockaddr_in{,6} pointers instead of casting over and over and over and over again. Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v2 0/5] tipc: add TIPC over Infiniband support

2013-04-17 Thread David Miller
From: Patrick McHardy ka...@trash.net Date: Wed, 17 Apr 2013 18:18:24 +0200 The following patchset adds support for running TIPC over InfiniBand. The patchset consists of three parts (+ a minor fix for the ethernet media type): - Preparation: removal of an the unused str2addr callback and

Re: [PATCH v2 net-next 00/22] Add support for Chelsio T5 adapter

2013-03-14 Thread David Miller
From: Vipul Pandya vi...@chelsio.com Date: Thu, 14 Mar 2013 20:38:46 +0530 We request to merge this patch series via David Miller's net-next tree. We are copying respective maintainers of all the drivers for reviewing the changes. Kindly let us know in case of any review comments. All applied

Re: [PATCH net-next 05/22] cxgb4: Add T5 write combining support

2013-03-12 Thread David Miller
From: Vipul Pandya vi...@chelsio.com Date: Tue, 12 Mar 2013 17:16:17 +0530 + writel(n, adap-bar2 + q-udb + 8); +#if defined(CONFIG_X86_32) || defined(CONFIG_X86_64) + asm volatile(sfence : : : memory); +#endif There is absolutely no way I'm

Re: [patch net-next V6 00/15] net: introduce upper device lists and remove dev-master

2013-01-04 Thread David Miller
From: Jiri Pirko j...@resnulli.us Date: Fri, 4 Jan 2013 09:48:48 +0100 This patchset adds a possibility to record upper device linkage. All upper-lower devices are converted to use this mechanism right after. That leads to dev-master removal because this info becomes redundant since master

Re: [PATCH 1/2] IB/rds: Correct ib_api use with gs_dma_address/sg_dma_len

2012-12-26 Thread David Miller
From: Mike Marciniszyn mike.marcinis...@intel.com Date: Fri, 21 Dec 2012 13:01:49 -0500 0b088e00 (RDS: Use page_remainder_alloc() for recv bufs) added uses of sg_dma_len() and sg_dma_address(). This makes RDS DOA with the qib driver. IB ulps should use ib_sg_dma_len() and ib_sg_dma_address

Re: [PATCH 2/2] IB/rds: suppress incompatible protocol when version is known

2012-12-26 Thread David Miller
From: Mike Marciniszyn mike.marcinis...@intel.com Date: Fri, 21 Dec 2012 13:01:54 -0500 Add an else to only print the incompatible protocol message when version hasn't been established. Signed-off-by: Mike Marciniszyn mike.marcinis...@intel.com Applied. -- To unsubscribe from this list:

Re: [FIXES for-next 0/4] mlx4_core SRIOV and Flow-Steering adjustments and fixes

2012-12-07 Thread David Miller
These changes only touch the drivers/net/ driver, why are you trying to submit them via the RDMA tree instead of the networking tree? -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH V3 1/5] cxgb4: Add T4 filter support

2012-12-03 Thread David Miller
From: Vipul Pandya vi...@chelsio.com Date: Mon, 3 Dec 2012 16:52:57 +0530 + /* + * If the new or old filter have loopback rewriteing rules then we'll + * need to free any existing Layer Two Table (L2T) entries of the old + * filter rule. The firmware will handle freeing

Re: [PATCH V2 1/5] cxgb4: Add T4 filter support

2012-11-30 Thread David Miller
I really don't understand how we're supposed to review your patches when you only post some parts of the patch series to netdev, and others not. Please do not do this. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org

Re: [PATCH V2 1/5] cxgb4: Add T4 filter support

2012-11-30 Thread David Miller
From: Roland Dreier rol...@purestorage.com Date: Fri, 30 Nov 2012 17:43:27 -0800 On Fri, Nov 30, 2012 at 8:56 AM, David Miller da...@davemloft.net wrote: I really don't understand how we're supposed to review your patches when you only post some parts of the patch series to netdev, and others

Re: [patch v4 1/2] netlink: add reference of module in netlink_dump_start

2012-10-06 Thread David Miller
From: Gao feng gaof...@cn.fujitsu.com Date: Fri, 5 Oct 2012 14:15:48 +0800 I get a panic when I use ss -a and rmmod inet_diag at the same time. it's because netlink_dump use inet_diag_dump witch function belongs to module inet_diag. I search the codes and find many modules have the same

Re: [patch v4 2/2] infiniband: pass rdma_cm module to netlink_dump_start

2012-10-06 Thread David Miller
From: Gao feng gaof...@cn.fujitsu.com Date: Fri, 5 Oct 2012 14:15:49 +0800 set netlink_dump_control.module to avoid panic. Signed-off-by: Gao feng gaof...@cn.fujitsu.com Cc: Roland Dreier rol...@kernel.org Cc: Sean Hefty sean.he...@intel.com Applied. -- To unsubscribe from this list: send

Re: [PATCH 1/26 v3] rdma/cm: define native IB address

2012-09-24 Thread David Miller
I really hope you're not going to only post this one patch of the series to netdev, and leave netdev out completely for the rest. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 2/2] RDMA/cxgb4: Update RDMA/cxgb4 due to macro definition removal in cxgb4 driver

2012-09-04 Thread David Miller
From: Vipul Pandya vi...@chelsio.com Date: Fri, 31 Aug 2012 14:54:32 +0530 cxgb4 driver removed the duplicate definitions of registers which requires update in RDMA/cxgb4 driver. Signed-off-by: Santosh Rastapur sant...@chelsio.com Signed-off-by: Vipul Pandya vi...@chelsio.com Reviewed-by:

Re: [patch net-next v2 01/15] net: introduce upper device lists

2012-08-15 Thread David Miller
From: Ben Hutchings bhutchi...@solarflare.com Date: Tue, 14 Aug 2012 23:33:44 +0100 I think we will also need to limit the depth of the device stack so we don't run out of stack space here. __netif_receive() implements a kind of tail recursion whenever a packet is passed up, but

Re: [patch net-next v2 01/15] net: introduce upper device lists

2012-08-15 Thread David Miller
From: Jiri Pirko j...@resnulli.us Date: Wed, 15 Aug 2012 09:46:12 +0200 You are probably right. I'm not sure how to handle this correctly though. Adding some hard limit number might not be correct. I would just use a hard limit of something like 8 for now, and if we need to expand this limit

Re: [PATCH RESEND net/for-next V1 1/1] IB/ipoib: break linkage to neighbouring system

2012-07-23 Thread David Miller
From: Or Gerlitz ogerl...@mellanox.com Date: Thu, 19 Jul 2012 19:15:02 +0300 -static void neigh_add_path(struct sk_buff *skb, struct neighbour *n, struct net_device *dev) +static void neigh_add_path(struct sk_buff *skb, u8 *daddr, + struct net_device *dev) Please

Re: [PATCH net/for-next V1 1/1] IB/ipoib: break linkage to neighbouring system

2012-07-19 Thread David Miller
You should CC: netdev on patches like this. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net/for-next V1 1/1] IB/ipoib: break linkage to neighbouring system

2012-07-19 Thread David Miller
From: Or Gerlitz ogerl...@mellanox.com Date: Thu, 19 Jul 2012 19:20:41 +0300 On 7/19/2012 6:24 PM, Christoph Lameter wrote: On Thu, 19 Jul 2012, Shlomo Pongartz wrote: The garbage collection and stale times follow the default ipv4/6 neigh.default.gc_yyy sysctl values, for example

  1   2   >