On 2/8/2013 12:42 AM, Vu Pham wrote:
It is known that it takes about two to three minutes before the
upstream SRP initiator fails over from a failed path to a working
path. This is not only considered longer than acceptable but is also
longer than other Linux SCSI initiators (e.g. iSCSI
On 2/18/2013 6:06 AM, David Dillow wrote:
On Fri, 2013-02-15 at 10:39 +0100, Bart Van Assche wrote:
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c
b/drivers/infiniband/ulp/srp/ib_srp.c
index 8a7eb9f..b34752d 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++
On 2/24/2013 10:09 AM, Bart Van Assche wrote:
On 02/18/13 09:11, Sagi Grimberg wrote:
On 2/18/2013 6:06 AM, David Dillow wrote:
On Fri, 2013-02-15 at 10:39 +0100, Bart Van Assche wrote:
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c
b/drivers/infiniband/ulp/srp/ib_srp.c
index 8a7eb9f
On 7/15/2013 2:06 PM, Bart Van Assche wrote:
On 14/07/2013 3:43, Sagi Grimberg wrote:
On 7/3/2013 3:58 PM, Bart Van Assche wrote:
Several InfiniBand HCA's allow to configure the completion vector
per queue pair. This allows to spread the workload created by IB
completion interrupts over
On 7/15/2013 9:23 PM, Bart Van Assche wrote:
On 15/07/2013 7:29, Sagi Grimberg wrote:
srp_daemon is a package designated for the customer to automatically
detect targets in the IB fabric. From our experience here in Mellanox,
customers/users like automatic plugplay tools.
They are reluctant
On 7/16/2013 1:58 PM, Bart Van Assche wrote:
On 16/07/2013 4:11, Sagi Grimberg wrote:
This sounds like a nice Idea, but there an inherent problem about
applications coming and going while the connections are static
(somewhat),
how can you control pinning an arbitrary application running (over
On 7/16/2013 6:11 PM, Bart Van Assche wrote:
On 14/07/2013 3:43, Sagi Grimberg wrote:
Just wrote a small patch to allow srp_daemon spread connection across
HCA's completion vectors.
Hello Sagi,
How about the following approach:
- Add support for reading the completion vector from
On 7/22/2013 2:46 PM, Bart Van Assche wrote:
On 07/18/13 15:25, Or Gerlitz wrote:
+static int iser_fast_reg_mr(struct fast_reg_descriptor *desc,
+struct iser_conn *ib_conn,
+struct iser_regd_buf *regd_buf,
+u32 offset, unsigned int data_size,
+
On 7/23/2013 2:58 PM, Bart Van Assche wrote:
On 07/22/13 15:11, Sagi Grimberg wrote:
So just to clarify the flow:
. at connection establishment allocate pool of fastreg descriptors
. upon each IOP take a fastreg descriptor from the pool
. if it is not invalidated - invalidate
On 7/28/2013 11:15 AM, Or Gerlitz wrote:
On 26/07/2013 20:15, Vu Pham wrote:
Hello Or/Sagi,
Just a minor
/**
+ * iser_create_frwr_pool - Creates pool of fast_reg descriptors
+ * for fast registration work requests.
+ * returns 0 on success, or errno code on failure
+ */
+int
On 8/14/2013 10:52 PM, Dan Carpenter wrote:
Hello Sagi Grimberg,
This is a semi-automatic email about new static checker warnings.
The patch b4e155ffbbd6: IB/iser: Generalize rdma memory
registration from Jul 28, 2013, leads to the following Smatch
complaint:
drivers/infiniband/ulp/iser
This bug was discovered by Smatch static checker ran by
Dan Carpenter. If in free_rx_descriptors rx_descs are not NULL
the iser device is definately not NULL as it was created before,
so no need to check it before dereferencing it.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off
On 8/20/2013 3:50 PM, Bart Van Assche wrote:
Certain storage configurations, e.g. a sufficiently large array of
hard disks in a RAID configuration, need a queue depth above 64 to
achieve optimal performance. Hence make the queue depth configurable.
Signed-off-by: Bart Van Assche
On 8/20/2013 8:43 PM, David Dillow wrote:
On Tue, 2013-08-20 at 17:55 +0200, Bart Van Assche wrote:
On 08/20/13 17:34, Sagi Grimberg wrote:
Question,
If srp now will allow larger queues while using a single global FMR pool
of size 1024, isn't it more likely now that in stress environment srp
Verb ib_check_sig_status
check_sig_status Verb shall check if any signature errors
are pending for a specific signature related ib_mr.
User should provide the ib_qp that executed the RDMA operation
involving the given ib_mr.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
If user requested signature enable we Initialize
relevant mlx5_ib_qp members. we mark the qp as sig_enable
we initiatlize empty sig_err_list, and we increase qp size.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/mlx5_ib.h |5 +
drivers/infiniband/hw/mlx5
, that will mean
that the created ib_mr may be attached with signature attributes
(BSF, PSVs).
Currently we only allow direct/indirect registration modes.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/main.c|2 +
drivers/infiniband/hw/mlx5/mlx5_ib.h
ib_check_sig_status and if such
exsists, get the signature error information.
In case the user will not check for signature error, i.e.
call ib_check_sig_status, it will not be allowed to use
the memory region for another signature operation
(REG_SIG_MR work request will fail).
Signed-off-by: Sagi
parameters passed by the user.
This patch also introduces some helper functions to set the BSF correctly
and determining the signature format selectors.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/qp.c | 413 +++
include
.
In the future these routines may replace current memory regions creation
routines existing today:
- ib_reg_user_mr
- ib_alloc_fast_reg_mr
- ib_get_dma_mr
- ib_dereg_mr
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/core/verbs.c | 39
Currently support only T10-DIF types of signature
handover operations (typs 1|2|3).
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/main.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/main.c
b/drivers
support in mlx5 driver.
- Implement signature handover work request in mlx5 driver.
- Implement signature error collection and handling in mlx5 driver.
Sagi Grimberg (9):
IB/core: Introduce indirect and protected memory regions
IB/core: Introduce Signature Verbs API
IB/mlx5, mlx5_core
As a preliminary step for signature feature which will
reuqire posting multiple (3) WQEs for a single WR, we
break post_send routine WQE indexing into begin and
finish routines.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband
get_umr_flags helper function might be used for types
of access modes other than ACCESS_MODE_MTT, such as
ACCESS_MODE_KLM. so remove it from helper and caller
will add it's own access mode flag.
This commit does not add/change functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
On 10/18/2013 1:51 AM, Hefty, Sean wrote:
@@ -885,6 +901,19 @@ struct ib_send_wr {
u32 rkey;
struct ib_mw_bind_info bind_info;
} bind_mw;
+ struct {
+ struct ib_sig_attrs
On 10/18/2013 1:43 AM, Hefty, Sean wrote:
This commit introduces verbs for creating memory regions
which will allow new types of memory key operations such
as indirect memory registration and protected memory
registration.
Indirect memory registration is registering several (one
of more)
On 10/21/2013 5:34 PM, Hefty, Sean wrote:
The signature handover operation is binding all the necessary
information for the HCA together: where is the data (data_mr), where is
the protection information (prot_mr), what are the signature properties
(sig_attrs).
Once this step is taken (WR is
On 10/22/2013 9:20 PM, Hefty, Sean wrote:
Would we lose anything making this a new operation for the QP, versus
trying to hook it into the existing ib_post_send call?
If I understand correctly you are suggesting making it a verb? Well this
operation is a fast-path operation - so I guess we
processing via MR radix lookup.
Sagi Grimberg (10):
IB/core: Introduce protected memory regions
IB/core: Introduce Signature Verbs API
IB/mlx5, mlx5_core: Support for create_mr and destroy_mr
IB/mlx5: Initialize mlx5_ib_qp signature related
IB/mlx5: Break wqe handling to begin finish
).
The underlying mlx5 will handle signature error completions
and will mark the relevant memory region as dirty.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/cq.c | 53 ++
drivers/infiniband/hw/mlx5/main.c|1 +
drivers/infiniband/hw
get_umr_flags helper function might be used for types
of access modes other than ACCESS_MODE_MTT, such as
ACCESS_MODE_KLM. so remove it from helper and caller
will add it's own access mode flag.
This patch does not add/change functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
As a preliminary step for signature feature which will
reuqire posting multiple (3) WQEs for a single WR, we
break post_send routine WQE indexing into begin and
finish routines.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband
If user requested signature enable we Initialize
relevant mlx5_ib_qp members. we mark the qp as sig_enable
we initiatlize empty sig_err_list, and we increase qp size.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/mlx5_ib.h |3 +++
drivers/infiniband/hw/mlx5
signature-enabled ib_mr.
This Verb is a lightwight check and is allowed to be taken
from interrupt context. Application must call this verb after
it is known that the actual data transfer has finished.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/core/verbs.c |8
Currently support only T10-DIF types of signature
handover operations (typs 1|2|3).
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/main.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/main.c
b/drivers
parameters passed by the user.
This patch also introduces some helper functions to set the BSF correctly
and determining the signature format selectors.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/qp.c | 416 +++
include
This will be useful when processing signature errors
on a specific key. The mlx5 driver will lookup the
matching mlx5 memory region structure and mark it as
dirty (contains signature errors).
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/net/ethernet/mellanox/mlx5/core/main.c
.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/main.c|2 +
drivers/infiniband/hw/mlx5/mlx5_ib.h |4 +
drivers/infiniband/hw/mlx5/mr.c | 109 ++
drivers/net/ethernet/mellanox/mlx5/core/mr.c | 64
will be applicable for a new REG_SIG_MR
work request introduced later in this patchset.
In the future these routines may replace or implement current memory
regions creation routines existing today:
- ib_reg_user_mr
- ib_alloc_fast_reg_mr
- ib_get_dma_mr
- ib_dereg_mr
Signed-off-by: Sagi Grimberg sa
On 10/28/2013 11:22 PM, Hefty, Sean wrote:
+enum ib_mr_create_flags {
+ IB_MR_SIGNATURE_EN = 1,
+};
+
+/**
+ * ib_mr_init_attr - Memory region init attributes passed to routine
+ * ib_create_mr.
+ * @max_reg_descriptors: max number of registration units that
+ * may be used
parameters passed by the user.
This patch also introduces some helper functions to set the BSF correctly
and determining the signature format selectors.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/qp.c | 416 +++
include
signature errors
are pending for a specific signature-enabled ib_mr.
This Verb is a lightwight check and is allowed to be taken
from interrupt context. Application must call this verb after
it is known that the actual data transfer has finished.
Signed-off-by: Sagi Grimberg sa
get_umr_flags helper function might be used for types
of access modes other than ACCESS_MODE_MTT, such as
ACCESS_MODE_KLM. so remove it from helper and caller
will add it's own access mode flag.
This commit does not add/change functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Currently support only T10-DIF types of signature
handover operations (typs 1|2|3).
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/main.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/main.c
b/drivers
If user requested signature enable we Initialize
relevant mlx5_ib_qp members. we mark the qp as sig_enable
we initiatlize empty sig_err_list, and we increase qp size.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/mlx5_ib.h |3 +++
drivers/infiniband/hw/mlx5
As a preliminary step for signature feature which will
reuqire posting multiple (3) WQEs for a single WR, we
break post_send routine WQE indexing into begin and
finish routines.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband
This will be useful when processing signature errors
on a specific key. The mlx5 driver will lookup the
matching mlx5 memory region structure and mark it as
dirty (contains signature errors).
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/net/ethernet/mellanox/mlx5/core/main.c
enablement.
- IB/mlx5: Changed signature error processing via MR radix lookup.
Sagi Grimberg (10):
IB/core: Introduce protected memory regions
IB/core: Introduce Signature Verbs API
IB/mlx5, mlx5_core: Support for create_mr and destroy_mr
IB/mlx5: Initialize mlx5_ib_qp signature related
IB/mlx5
, that will mean
that the created ib_mr may be attached with signature attributes
(BSF, PSVs).
Currently we only allow direct/indirect registration modes.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/main.c|2 +
drivers/infiniband/hw/mlx5/mlx5_ib.h
On 10/31/2013 2:52 PM, Jack Wang wrote:
On 10/31/2013 01:24 PM, Sagi Grimberg wrote:
Support create_mr and destroy_mr verbs.
Creating ib_mr may be done for either ib_mr that will
register regular page lists like alloc_fast_reg_mr routine,
or indirect ib_mr's that can register other (pre
On 10/31/2013 2:55 PM, Jack Wang wrote:
Hi Sagi,
I wander what's the performance overhead with this DIF support?
And is there a roadmap for support SRP/ISER and target side for DIF?
Regards,
Jack
Well, all DIF operations are fully offloaded by the HCA so we don't expect
any performance
On 11/2/2013 12:06 AM, Bart Van Assche wrote:
On 31/10/2013 5:24, Sagi Grimberg wrote:
While T10-DIF clearly defines that over the wire protection guards are
interleaved into the data stream (each 512-Byte block followed by 8-byte
guard), when in memory, the protection guards may reside
On 11/2/2013 12:06 AM, Bart Van Assche wrote:
On 31/10/2013 5:24, Sagi Grimberg wrote:
While T10-DIF clearly defines that over the wire protection guards are
interleaved into the data stream (each 512-Byte block followed by 8-byte
guard), when in memory, the protection guards may reside
On 11/1/2013 5:13 PM, Bart Van Assche wrote:
On 31/10/2013 5:24, Sagi Grimberg wrote:
+/**
+ * struct ib_sig_domain - Parameters specific for T10-DIF
+ * domain.
+ * @sig_type: specific signauture type
+ * @sig: union of all signature domain attributes that may
+ * be used to set
On 11/1/2013 7:09 PM, Bart Van Assche wrote:
On 31/10/2013 5:24, Sagi Grimberg wrote:
+/**
+ * ib_mr_init_attr - Memory region init attributes passed to routine
+ *ib_create_mr.
+ * @max_reg_descriptors: max number of registration units that
+ * may be used with UMR work requests
On 11/2/2013 12:23 AM, Bart Van Assche wrote:
On 31/10/2013 5:24, Sagi Grimberg wrote:
+ * @type3_inc_reftag: T10-DIF type 3 does not state
+ *about the reference tag, it is the user
+ *choice to increment it or not.
Can you explain this further ? Does
On 11/1/2013 8:46 PM, Bart Van Assche wrote:
On 31/10/2013 5:24, Sagi Grimberg wrote:
+/**
+ * Signature T10-DIF block-guard types
+ */
+enum ib_t10_dif_bg_type {
+IB_T10DIF_CRC,
+IB_T10DIF_CSUM
+};
In SPC-4 paragraph 4.22.4 I found that the T10-PI guard is the CRC
computed from
On 11/1/2013 5:05 PM, Bart Van Assche wrote:
On 31/10/2013 5:24, Sagi Grimberg wrote:
+static u8 bs_selector(int block_size)
+{
+switch (block_size) {
+case 512:return 0x1;
+case 520:return 0x2;
+case 4096:return 0x3;
+case 4160:return 0x4
On 11/2/2013 11:59 PM, Bart Van Assche wrote:
On 2/11/2013 12:21, Or Gerlitz wrote:
On Fri, Nov 1, 2013 at 10:37 PM, Bart Van Assche bvanass...@acm.org
wrote:
On 31/10/2013 5:24, Sagi Grimberg wrote:
This patch implements IB_WR_REG_SIG_MR posted by the user.
Baisically this WR involvs 3
On 11/3/2013 4:41 PM, Bart Van Assche wrote:
On 3/11/2013 4:15, Sagi Grimberg wrote:
On 11/1/2013 8:46 PM, Bart Van Assche wrote:
On 31/10/2013 5:24, Sagi Grimberg wrote:
+/**
+ * Signature T10-DIF block-guard types
+ */
+enum ib_t10_dif_bg_type {
+IB_T10DIF_CRC,
+IB_T10DIF_CSUM
On 11/4/2013 8:41 PM, Nicholas A. Bellinger wrote:
On Sat, 2013-11-02 at 14:57 -0700, Bart Van Assche wrote:
On 1/11/2013 18:36, Nicholas A. Bellinger wrote:
On Fri, 2013-11-01 at 08:03 -0700, Bart Van Assche wrote:
On 31/10/2013 5:24, Sagi Grimberg wrote:
In T10-DIF, when a series of 512
-enabled ib_mr.
This Verb is a lightwight check and is allowed to be taken
from interrupt context. Application must call this verb after
it is known that the actual data transfer has finished.
issue: 333508
Change-Id: I0cce750a6b77cd1eae102c5982c8c31e46237af8
Signed-off-by: Sagi Grimberg
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/qp.c | 97 --
1 files changed, 61 insertions(+), 36 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index f61e93c..15df91b 100644
Currently support only T10-DIF types of signature
handover operations (typs 1|2|3).
issue: 333508
Change-Id: I3ae2cce03a97074d56a52098b15c8bf74962aeed
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/main.c |9 +
1 files changed, 9 insertions(+), 0
for another signature operation
(REG_SIG_MR work request will fail).
issue: 333508
Change-Id: I002b12c6b685615b97c6fa29902ef06c70b11103
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/cq.c | 54 ++
drivers/infiniband/hw/mlx5/main.c
If user requested signature enable we Initialize
relevant mlx5_ib_qp members. we mark the qp as sig_enable
and we increase the effective SQ size, but still
limit the user max_send_wr to original size computed.
issue: 333508
Change-Id: I72c303f407fc8181139371d4c0a7e7e7550043e0
Signed-off-by: Sagi
selectors.
issue: 333508
Change-Id: I66843ed14cb41275071b57fbba92018fe19bf4f5
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/qp.c | 417 +++
include/linux/mlx5/device.h |4 +
include/linux/mlx5/qp.h | 61
: If4aca628d1ca88be93a2161e4a158363dcaa134b
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/qp.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index 15df91b..43f120a 100644
--- a/drivers/infiniband/hw
This will be useful when processing signature errors
on a specific key. The mlx5 driver will lookup the
matching mlx5 memory region structure and mark it as
dirty (contains signature errors).
issue: 333508
Change-Id: I04dbb746012b050d13161d134d2d05c8c333189a
Signed-off-by: Sagi Grimberg sa
enablement from create_mr.
Keep only signature enablement.
- IB/mlx5: Changed signature error processing via MR radix lookup.
Sagi Grimberg (10):
IB/core: Introduce protected memory regions
IB/core: Introduce Signature Verbs API
IB/mlx5, mlx5_core: Support for create_mr
: Id3d221a002af9a95716a44d0163ca0de1c6dbbb8
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/core/verbs.c | 39 +++
include/rdma/ib_verbs.h | 38 ++
2 files changed, 77 insertions(+), 0 deletions
On 11/14/2013 9:30 AM, Or Gerlitz wrote:
On 14/11/2013 02:19, Hefty, Sean wrote:
The patch series is around for couple of weeks already and went
through the review of Sean and Bart, with all their feedback being
applied. Also Sagi and Co enhanced krping to fully cover (and
test...) the
If user requested signature enable we Initialize
relevant mlx5_ib_qp members. we mark the qp as sig_enable
and we check if wqe_size will fit compound REG_SIG_MR work
request (UMR + 2 x SET_PSV wqes), if computed wqe_size is
smaller we align wqe_size to MLX5_SIG_WQE_SIZE.
Signed-off-by: Sagi
-registered
as well). The corresponding mlx5_ib_mr will be attached with mlx5
specific signature entities (BSF, PSVs). for non-signature
enabled regions, the resulting ib_mr is a free region applicable
for fast registration work requests.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers
for signature error, i.e.
won't call ib_check_mr_status with status check
IB_MR_CHECK_SIG_STATUS, it will not be allowed to use
the memory region for another signature operation
(REG_SIG_MR work request will fail).
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/cq.c
routines existing today:
- ib_reg_user_mr
- ib_alloc_fast_reg_mr
- ib_get_dma_mr
- ib_dereg_mr
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/core/verbs.c | 39 +++
include/rdma/ib_verbs.h | 38
that the actual data transfer has finished.
issue: 333508
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/core/verbs.c |8 ++
include/rdma/ib_verbs.h | 149 ++-
2 files changed, 156 insertions(+), 1 deletions(-)
diff --git
not
to compete with other contexts for a specific key, thus read_lock
is sufficient.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/net/ethernet/mellanox/mlx5/core/main.c |1 +
drivers/net/ethernet/mellanox/mlx5/core/mr.c | 24
include/linux/mlx5/driver.h
enablement from create_mr.
Keep only signature enablement.
- IB/mlx5: Changed signature error processing via MR radix lookup.
Sagi Grimberg (10):
IB/core: Introduce protected memory regions
IB/core: Introduce Signature Verbs API
IB/mlx5, mlx5_core: Support for create_mr and destroy_mr
Currently support only T10-DIF types of signature
handover operations (typs 1|2|3).
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/main.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/main.c
b/drivers
.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/qp.c | 443 +++
include/linux/mlx5/device.h |4 +
include/linux/mlx5/qp.h | 61 ++
3 files changed, 508 insertions(+), 0 deletions(-)
diff --git a/drivers
get_umr_flags helper function might be used for types
of access modes other than ACCESS_MODE_MTT, such as
ACCESS_MODE_KLM. so remove it from helper and caller
will add it's own access mode flag.
This commit does not add/change functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
On 1/2/2014 10:11 AM, Ilya Kalistru wrote:
Happy New Year, ladies and gentlemen!
I'm developing some sort of hardware InfiniBand server runing on
FPGA and delivering some data to PC using RDMA_WRITE operation.
I've already had Physical Link Up and Logical Link Up between my
device and PC with
On 1/8/2014 2:51 AM, Roland Dreier wrote:
On Tue, Jan 7, 2014 at 1:02 PM, Or Gerlitz or.gerl...@gmail.com wrote:
Currently there is single patch for 3.14 on your for-next branch, the
usnic driver. With 3.13 being on rc7 and likely to be released next
week, are you planning any other merges for
ccb0a907 IB/mlx5: Break wqe handling to begin finish routines
cda0569 IB/mlx5: Initialize mlx5_ib_qp signature related
33b4079 IB/mlx5, mlx5_core: Support for create_mr and destroy_mr
8b343e6 IB/core: Introduce Signature Verbs API
c1b0358 IB/core: Introduce protected memory regions
Sagi Grimberg (11
Use fast registration lingo. fast registration will
also incorporate signature/DIF registration.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert/ib_isert.c | 84 ---
drivers/infiniband/ulp/isert/ib_isert.h |8 ++--
2 files
This routine may help for protection registration as well.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert/ib_isert.c | 28
1 files changed, 12 insertions(+), 16 deletions(-)
diff --git
It is more correct to seperate connections protection domains
and dma_mr handles. protection information support requires to
do so.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert/ib_isert.c | 46 ---
drivers/infiniband/ulp/isert
replace prot_interleaved with prot_handover in se_cmd.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
include/target/target_core_base.h | 22 ++
1 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/include/target/target_core_base.h
b/include/target
This commit generalizes isert_fast_reg_mr to receive mr
and frpl instead of fr_desc to do registration. In T10-PI
we also register protection memory region so we want to
use this routine.
This commit does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers
Upon connection establishment check if network portal is T10-PI
enabled and allocate T10-PI resources if necessary, allocate
signature enabled memory regions and mark connection queue-pair
as signature enabled.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert
In case of protected transactions, we will need to check the
protection status of the transaction before sending SCSI response.
So be ready for RDMA_WRITE completions. currently we don't ask
for these completions, but for T10-PI we will.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
. This is a hook for the iscsi target layer to signal the transport
at connection establishment that this connection will carry protected
transactions.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/iscsi/iscsi_target_core.h |5 -
drivers/target/iscsi/iscsi_target_tpg.c |2 ++
2
User may enable T10-PI support per network portal group. any connection
established on top of it, will be required to serve protected transactions.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/iscsi/iscsi_target_configfs.c |6 ++
drivers/target/iscsi
This routine may be called both by fast registration
descriptors for data and for integrity buffers.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert/ib_isert.c | 52 +++
1 files changed
completion check the signature status
- if succeeded send good SCSI response
- if failed send SCSI bad response with appropriate sense buffer
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert/ib_isert.c | 376 ++-
1 files changed
On 1/11/2014 11:14 PM, Or Gerlitz wrote:
On Thu, Jan 9, 2014 at 6:40 PM, Sagi Grimberg sa...@mellanox.com wrote:
In case of protected transactions, we will need to check the
protection status of the transaction before sending SCSI response.
So be ready for RDMA_WRITE completions. currently we
On 1/11/2014 11:09 PM, Or Gerlitz wrote:
On Thu, Jan 9, 2014 at 6:40 PM, Sagi Grimberg sa...@mellanox.com wrote:
@@ -557,8 +629,14 @@ isert_connect_request(struct rdma_cm_id *cma_id, struct
rdma_cm_event *event)
goto out_mr;
}
+ if (pi_support !device
Possible double free on in-mailbox.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/mr.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
index bc27f6b..f023711 100644
Use DIF CRC INC with apptag escape (0x8) and update IP-CSUM entries.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/qp.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
1 - 100 of 1199 matches
Mail list logo
