Re: [PATCH] minimal SAS transport class

2005-08-23 Thread Hannes Reinecke
[EMAIL PROTECTED] wrote: - There are some real challenges in supporting a udev-named boot device. For the most part, it's a distro issue, which is becoming better. PS: for $10, name a 2.6 distro that uses udev out of the box for disk names and its installation. For $10 more, can it

Re: Process in D state with st driver

2005-08-23 Thread Andrew Morton
Hans-Joachim Baader [EMAIL PROTECTED] wrote: Hi, I do nightly backups on tape. Every 3 to 4 weeks a process is stuck in D state while accessing the drive: 12398 ?D 0:00 /usr/sbin/amcheck -ms daily There are no messages in the log. Only a reboot can remove

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-23 Thread Jens Axboe
On Mon, Aug 22 2005, Douglas Gilbert wrote: if (scsicmd[0] == READ_6 || scsicmd[0] == WRITE_6) { - qc-nsect = tf-nsect = scsicmd[4]; + if (scsicmd[4] == 0) { + /* + * For READ_6 and WRITE_6 (only) + *

Re: [PATCH] minimal SAS transport class

2005-08-23 Thread Douglas Gilbert
Luben Tuikov wrote: On 08/22/05 00:55, Matt Domsch wrote: On Sat, Aug 20, 2005 at 12:15:41AM -0400, [EMAIL PROTECTED] wrote: - There are some real challenges in supporting a udev-named boot device. For the most part, it's a distro issue, which is becoming better. PS: for $10, name a 2.6

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-23 Thread Douglas Gilbert
Jeff Garzik wrote: Douglas Gilbert wrote: This is a revised patch following this post: http://marc.theaimsgroup.com/?l=linux-scsim=112461881419898w=2 The plan is to add MODE SELECT SCSI command support to libata so that parameters such as WCE and DRA can be changed by a user (i.e.

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-23 Thread Douglas Gilbert
Jens Axboe wrote: On Mon, Aug 22 2005, Douglas Gilbert wrote: if (scsicmd[0] == READ_6 || scsicmd[0] == WRITE_6) { - qc-nsect = tf-nsect = scsicmd[4]; + if (scsicmd[4] == 0) { + /* + * For READ_6 and WRITE_6 (only) +

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-23 Thread Jens Axboe
On Tue, Aug 23 2005, Douglas Gilbert wrote: Jens Axboe wrote: On Mon, Aug 22 2005, Douglas Gilbert wrote: if (scsicmd[0] == READ_6 || scsicmd[0] == WRITE_6) { - qc-nsect = tf-nsect = scsicmd[4]; + if (scsicmd[4] == 0) { + /* +

[PATCH] sg.c: fix a memory leak in devices seq_file implementation

2005-08-23 Thread Jan Blunck
I know that scsi procfs is legacy code but this is a fix for a memory leak. While reading through sg.c I realized that the implementation of /proc/scsi/sg/devices with seq_file is leaking memory due to freeing the pointer returned by the next() iterator method. Since next() might return NULL or

Re: [PATCH] minimal SAS transport class

2005-08-23 Thread Patrick Mansfield
On Sat, Aug 20, 2005 at 12:15:41AM -0400, [EMAIL PROTECTED] wrote: - the target id is logical for everything but SPI For FC, target ids are typically assigned to devices on a 1st-seen-1st-assigned basis. For several reasons, there can be changes in port discovery order after link events

RE: [PATCH] minimal SAS transport class

2005-08-23 Thread James . Smart
As others stated, id is already a tag/label. You should be able to pass whatever id you want to scsi_scan_target, like the FC ID (port_id), and then we also want an abstract iterator in fc transport for the id for usage in scsi_scan.c:scsi_scan_channel. Then you can lose all the

Re: [PATCH] minimal SAS transport class

2005-08-23 Thread Stefan Richter
[EMAIL PROTECTED] wrote: As others stated, id is already a tag/label. You should be able to pass whatever id you want to scsi_scan_target, like the FC ID (port_id), [...] If the port id changes during run time, what are you to do ? [...] This approach only works as long as the transport's

Re: [PATCH] scsi: /proc/scsi/scsi patch for large number of devices

2005-08-23 Thread Christoph Hellwig
On Tue, Aug 23, 2005 at 09:40:40AM -0700, Mark Haverkamp wrote: I'm not sure if people care about /proc/scsi, but here is a patch so you can cat /proc/scsi/scsi when you have a large number of scsi devices. I have over 4000 devices configured and when I would cat /proc/scsi/scsi I would see

Re: [PATCH] scsi: /proc/scsi/scsi patch for large number of devices

2005-08-23 Thread Patrick Mansfield
On Tue, Aug 23, 2005 at 06:42:06PM +0100, Christoph Hellwig wrote: We had this before, and the answer is: don't use /proc/scsi if you have lots of device. Don't even enable the config option. We still don't have sysfs scsi devinfo support, we need to represent it as a modifiable list or such

RE: [PATCH] minimal SAS transport class

2005-08-23 Thread James . Smart
I thought by the target id is logical for everything but SPI you meant that FC enumerated the scsi_device id. Yes, I meant that. I didn't mean to address problems with persistent names, just map the scsi_device id to an FC value. True. Port ID is just a bad example. Unfortunately, there's

Megaraid and Dell PERC 4 controllers

2005-08-23 Thread Jonathan Fischer
I apologize if this is the wrong list to ask this kind of question on; I've posted on Dell's PowerEdge list and Red Hat's lists as well, but I figure the people here might know better what to try for this problem. I have 2 Dell PowerEdge 2850's, one with a PERC 4e/DC raid controller, and the

Re: [PATCH] libata: write cache and read ahead

2005-08-23 Thread Luben Tuikov
On 08/22/05 01:12, Douglas Gilbert wrote: I was surprised how much code needed changing. With MODE SELECT's issues with libata addressed various other SAT extras should be much easier to implement. That should make libata more attractive as a SAT layer for SAS LLDDs (that don't do it already

Re: [PATCH] minimal SAS transport class

2005-08-23 Thread Luben Tuikov
On 08/23/05 13:28, Stefan Richter wrote: [EMAIL PROTECTED] wrote: As others stated, id is already a tag/label. You should be able to pass whatever id you want to scsi_scan_target, like the FC ID (port_id), [...] If the port id changes during run time, what are you to do ? [...] This

Re: [PATCH] minimal SAS transport class

2005-08-23 Thread Luben Tuikov
On 08/23/05 11:42, Patrick Mansfield wrote: On Sat, Aug 20, 2005 at 12:15:41AM -0400, [EMAIL PROTECTED] wrote: - the target id is logical for everything but SPI For FC, target ids are typically assigned to devices on a 1st-seen-1st-assigned basis. For several reasons, there can be changes

[PATCH] fix klist semantics for lists which have elements removed on traversal

2005-08-23 Thread James Bottomley
The problem is that klists claim to provide semantics for safe traversal of lists which are being modified. The failure case is when traversal of a list causes element removal (a fairly common case). The issue is that although the list node is refcounted, if it is embedded in an object (which is

Re: [PATCH 2.6.12.5 1/2] lib: allow idr to be used in irq context

2005-08-23 Thread James Bottomley
On Mon, 2005-08-22 at 15:09 -0700, Andrew Morton wrote: James Bottomley [EMAIL PROTECTED] wrote: Of course, if we're going to go to all this trouble, the next question that arises naturally is why not just reuse the radix-tree code to implement idr anyway ... ? Yes, we could probably

Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2

2005-08-23 Thread Jim Ramsay
On 8/23/05, Jim Ramsay [EMAIL PROTECTED] wrote: Then I must have found an undocumented feature! I've applied this set of patches to a 2.6.11 kernel (with few problems) and ran into a bunch of scheduling while atomic errors when hotplugging a drive, culprit being probably scsi_sysfs.c where

Re: [PATCH 3/3] Add disk hotswap support to libata RESEND #2

2005-08-23 Thread Jim Ramsay
On 8/1/05, Lukasz Kosewski [EMAIL PROTECTED] wrote: Patch 03: Have sata_promise use the perfect, flawless API from the previous patch Hmmm... Flawless :) Then I must have found an undocumented feature! I've applied this set of patches to a 2.6.11 kernel (with few problems) and ran into a