[PATCH] megaraid: fix use of delayed work

2012-12-04 Thread Xiaotian Feng
megaraid use INIT_WORK to declare a hotplug_work, but cast the hotplug_work from work_struct to delayed_work and schedule_delayed_work on it. This is very dangerous, as other part of delayed_work might be kernel memories allocated by others. With commit 8852aac, schedule_delayed_work() will check

[PATCH 3/5] arcmsr: Support MSI and MSI-X

2012-12-04 Thread NickCheng
From: Nick Cheng nick.ch...@areca.com.tw Support MSI or MSI-X for whole series of RAID controllers. Meanwhile correct the register access as iowrite32/ioread32 Signed-off-by: Nick Cheng nick.ch...@areca.com.tw --- patch3 Description: Binary data

[PATCH 5/5] arcmsr: Modify ARC-1214 Inband Messages Behavior

2012-12-04 Thread NickCheng
From: Nick Cheng nick.ch...@areca.com.tw Modify ARC-1214 inband messages behavior to make up for HW seldom malfunction. Signed-off-by: Nick Cheng nick.ch...@areca.com.tw --- patch5 Description: Binary data

[PATCH 2/5] arcmsr: Support Hibernation

2012-12-04 Thread NickCheng
From: Nick Cheng nick.ch...@areca.com.tw Support hibernation for whole series of RAID controllers Signed-off-by: Nick Cheng nick.ch...@areca.com.tw --- patch2 Description: Binary data

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-12-04 Thread James Bottomley
On Mon, 2012-12-03 at 08:23 -0800, Tejun Heo wrote: Hello, James. On Mon, Dec 03, 2012 at 08:25:43AM +, James Bottomley wrote: diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index e65c62e..1756151 100644 --- a/include/scsi/scsi_device.h +++

Re: [PATCH] megaraid: fix use of delayed work

2012-12-04 Thread Tejun Heo
On Tue, Dec 04, 2012 at 07:33:54PM +0800, Xiaotian Feng wrote: megaraid use INIT_WORK to declare a hotplug_work, but cast the hotplug_work from work_struct to delayed_work and schedule_delayed_work on it. This is very dangerous, as other part of delayed_work might be kernel memories allocated

[PATCH 1/2] megaraid: fix BUG_ON() from incorrect use of delayed work

2012-12-04 Thread Tejun Heo
From c1d390d8e6128b050f0f66b1c33d390760deb3f4 Mon Sep 17 00:00:00 2001 From: Xiaotian Feng xtf...@gmail.com Date: Tue, 4 Dec 2012 19:33:54 +0800 megaraid use INIT_WORK to declare a hotplug_work, but cast the hotplug_work from work_struct to delayed_work and schedule_delayed_work on it. This is

[PATCH 2/2] workqueue: convert BUG_ON()s in __queue_delayed_work() to WARN_ON_ONCE()s

2012-12-04 Thread Tejun Heo
From 87aa1e796ff6d491b5ed4e5663e5a4e449ac513b Mon Sep 17 00:00:00 2001 From: Tejun Heo t...@kernel.org Date: Tue, 4 Dec 2012 07:40:39 -0800 8852aac25e (workqueue: mod_delayed_work_on() shouldn't queue timer on 0 delay) unexpectedly uncovered a very nasty abuse of delayed_work in megaraid - it

Re: [PATCH] megaraid: fix use of delayed work

2012-12-04 Thread Tejun Heo
Hello, again, Xiaotian. On Tue, Dec 04, 2012 at 07:39:39AM -0800, Tejun Heo wrote: Urgh... what the Didn't see that one coming. I'm gonna push this to Linus through the workqueue tree. Thanks for the fix. It seems like megaraid doesn't have any reason to use delayed_work at all. It

Re: Error handling on FC devices

2012-12-04 Thread Kipp Aldrich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/03/2012 04:52 PM, Elliott, Robert (Server Storage) wrote: Well, looking at QLogic and Emulex both emulate a bus reset with a loop over each target and invoke a target reset there. I somewhat fail to see the rationale behind it, other than

[GIT PULL] workqueue fixes for 3.7-rc8

2012-12-04 Thread Tejun Heo
Hello, Linus. So, safe fixes my ass. 8852aac (workqueue: mod_delayed_work_on() shouldn't queue timer on 0 delay) had the side-effect of performing delayed_work sanity checks even when @delay is 0, which should be fine for any sane use cases. Unfortunately, megaraid was being overly ingenious.

[PATCH 1/3] fnic: fix for trusted cos

2012-12-04 Thread Hiral Patel
Modified fnic driver to let hardware insert the COS value. Set bit in descriptor to 0 telling hardware to use its lif COS configurations to insert the COS value in the frames. Signed-off-by: Narsimhulu Musini nmus...@cisco.com Signed-off-by: Hiral Patel hiral...@cisco.com ---

[PATCH 3/3] fnic: Fix SGEs limit

2012-12-04 Thread Hiral Patel
Driver allows IOs with more SGEs than max SGEs supported by Palo. The current max SGEs supported by the fnic driver is 1024. The current register settings on Palo supports a max of 256 only. Palo would return any IO with more than 256 SGEs with an error indicating INVALID_SGLS. Fnic driver

[PATCH 2/3] fnic:fixing issues in device and firmware reset code

2012-12-04 Thread Hiral Patel
1. Handling overlapped firmware resets This fix serialize multiple firmware resets to avoid situation where fnic device fails to come up for link up event, when firmware resets are issued back to back. If there are overlapped firmware resets are issued, the firmware reset

Re: [PATCH 0/7] RESEND Add support for new IBM SAS controllers

2012-12-04 Thread Brian King
Ack patches 1-7 Acked-by: Brian King brk...@linux.vnet.ibm.com -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at

WARN_ON in ses driver on device remove

2012-12-04 Thread wenxiong
In upstream kernel, we get the warnings when rmmod the ipr module. The stack is like this: sysfs: can not remove 'enclosure_device: P1-D1 1SS6', no directory [ cut here ] WARNING: at fs/sysfs/inode.c:324 Modules linked in: autofs4 sunrpc ipt_REJECT

Re: getting I/O errors in super_written()...any ideas what would cause this?

2012-12-04 Thread Chris Friesen
On 12/03/2012 03:53 PM, Ric Wheeler wrote: On 12/03/2012 04:08 PM, Chris Friesen wrote: On 12/03/2012 02:52 PM, Ric Wheeler wrote: I jumped into this thread late - can you repost detail on the specific drive and HBA used here? In any case, it sounds like this is a better topic for the

Re: getting I/O errors in super_written()...any ideas what would cause this?

2012-12-04 Thread Ric Wheeler
On 12/04/2012 05:00 PM, Chris Friesen wrote: On 12/03/2012 03:53 PM, Ric Wheeler wrote: On 12/03/2012 04:08 PM, Chris Friesen wrote: On 12/03/2012 02:52 PM, Ric Wheeler wrote: I jumped into this thread late - can you repost detail on the specific drive and HBA used here? In any case, it