Re: Debugging scsi abort handling ?

2014-08-25 Thread Paolo Bonzini
Il 23/08/2014 16:52, Hans de Goede ha scritto: Hi All, Now that the UAS driver is no longer marked as CONFIG_BROKEN, I'm getting quite a few bug reports about issues with UAS drives. One if the issues is that there might be a number of bugs in the abort handling path, as I don't think

[PATCH v2] drivers: scsi: #define missing include guards

2014-08-25 Thread Rasmus Villemoes
The four files aha1542.h, aha1740.h, gvp11.h and mvme147.h under drivers/scsi/ contain two-thirds of an include guard, but do not #define the macro. Add those #defines. git grep says the macro names are not defined elsewhere. Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk --- For good

Re: Debugging scsi abort handling ?

2014-08-25 Thread Hans de Goede
Hi, On 08/25/2014 09:20 AM, Paolo Bonzini wrote: Il 23/08/2014 16:52, Hans de Goede ha scritto: Hi All, Now that the UAS driver is no longer marked as CONFIG_BROKEN, I'm getting quite a few bug reports about issues with UAS drives. One if the issues is that there might be a number of bugs

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-25 Thread Ching Huang
On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote: On 08/19/2014 09:17 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw Rewrite ioctl entry and its relate function. This patch fix ioctl data read/write error and change data I/O access from byte to Dword.

Re: [Xen-devel] [PATCH V5 3/5] Introduce xen-scsifront module

2014-08-25 Thread Juergen Gross
On 08/23/2014 12:25 AM, Konrad Rzeszutek Wilk wrote: --- /dev/null +++ b/drivers/scsi/xen-scsifront.c @@ -0,0 +1,1017 @@ +/* + * Xen SCSI frontend driver + * + * Copyright (c) 2008, FUJITSU Limited + * + * This program is free software; you can redistribute it and/or + * modify it under the

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-25 Thread Tomas Henzl
On 08/25/2014 07:59 PM, Ching Huang wrote: On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote: On 08/19/2014 09:17 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw Rewrite ioctl entry and its relate function. This patch fix ioctl data read/write error and change data I/O

Re: Debugging scsi abort handling ?

2014-08-25 Thread Bart Van Assche
On 08/25/14 10:47, Hans de Goede wrote: I want to see how real hardware deals with abort commands (e.g. does it only acknowledge the abort, or does it also sends a sense code for the actual command). The SCSI specs define whether a reply should be sent if a SCSI command has been aborted. From

Re: Debugging scsi abort handling ?

2014-08-25 Thread Paolo Bonzini
Il 25/08/2014 12:28, Bart Van Assche ha scritto: From SPC-4: 7.5.8 Control mode page [ ... ] A task aborted status (TAS) bit set to zero specifies that aborted commands shall be terminated by the device server without any response to the application client. A TAS bit set to one specifies

Re: Debugging scsi abort handling ?

2014-08-25 Thread Hans de Goede
Hi, On 08/25/2014 01:15 PM, Paolo Bonzini wrote: Il 25/08/2014 12:28, Bart Van Assche ha scritto: From SPC-4: 7.5.8 Control mode page [ ... ] A task aborted status (TAS) bit set to zero specifies that aborted commands shall be terminated by the device server without any response to the

Re: scsi logging future directions, was Re: [RFC PATCH -logging 00/10] scsi/constants: Output continuous error messages on trace

2014-08-25 Thread Hannes Reinecke
On 08/24/2014 10:44 PM, Christoph Hellwig wrote: On Fri, Aug 22, 2014 at 12:39:59AM +, Elliott, Robert (Server Storage) wrote: If you trigger hundreds of errors (e.g., hot remove a device during heavy IO), then all the prints to the linux serial console bog down the system, causing

Re: [PATCH] bnx2fc: do not add shared skbs to the fcoe_rx_list

2014-08-25 Thread Chad Dupuis
On Fri, 22 Aug 2014, Eddie Wai wrote: On Fri, 2014-07-25 at 10:12 +0200, Maurizio Lombardi wrote: Hi Eddie, just want to add you to the CC list. Some days ago the bnx2fc's maintainer email address has been updated, this should be the new one: qlogic-storage-upstr...@qlogic.com I tried to

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-25 Thread Tomas Henzl
On 08/25/2014 12:29 PM, Tomas Henzl wrote: On 08/25/2014 07:59 PM, Ching Huang wrote: On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote: On 08/19/2014 09:17 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw Rewrite ioctl entry and its relate function. This patch fix ioctl

Re: AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread Oliver Neukum
On Mon, 2014-08-25 at 10:58 +, Alfredo Dal Ava Junior wrote: - 1TB and 2TB: READ_CAPACITY_10 returns correct size value - 3TB and 4TB: READ_CAPACITY_10 returns size in a 2TB modulus If we fix capacity size by reporting (READ_CAPACITY_10 + MODULO_2TB), the result will be invalid when

Re: [PATCH][SCSI] scsi-mq: fix requests that use a separate CDB buffer

2014-08-25 Thread Tony Battersby
On 08/23/2014 03:09 PM, Douglas Gilbert wrote: For inclusion in 3.17 only. May want to check if blk-mq work in lk 3.16 and earlier breaks the bsg driver's capability to send SCSI cdbs that are longer than 16 bytes. I think 3.16 and earlier are OK. The problem was caused by

Re: AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread Alan Stern
On Mon, 25 Aug 2014, Oliver Neukum wrote: On Mon, 2014-08-25 at 10:58 +, Alfredo Dal Ava Junior wrote: - 1TB and 2TB: READ_CAPACITY_10 returns correct size value - 3TB and 4TB: READ_CAPACITY_10 returns size in a 2TB modulus If we fix capacity size by reporting (READ_CAPACITY_10 +

scsi-mq and 3.17rc1

2014-08-25 Thread Elliott, Robert (Server Storage)
Two scsi-mq tips: 1. Several people have been wondering how to enable scsi-mq. Add this to your kernel command line (e.g., in /boot/grub/grub.conf if using grub-1): scsi_mod.use_blk_mq=Y One way to tell it is enabled is to notice these directories being created in sysfs:

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-25 Thread Alan Stern
On Sun, 24 Aug 2014, Christoph Hellwig wrote: On Fri, Aug 22, 2014 at 01:29:32PM -0400, Alan Stern wrote: Other than this, I'm fine with the code ... you can add the acked by from me when we resolve the above question. Okay. It's true that this issue is only tangentially related to

[Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=80711 --- Comment #18 from Alan Stern st...@rowland.harvard.edu --- On Sun, 24 Aug 2014, Christoph Hellwig wrote: On Fri, Aug 22, 2014 at 01:29:32PM -0400, Alan Stern wrote: Other than this, I'm fine with the code ... you can add the acked by

Re: scsi-mq and 3.17rc1

2014-08-25 Thread Christoph Hellwig
On Mon, Aug 25, 2014 at 02:31:58PM +, Elliott, Robert (Server Storage) wrote: Two scsi-mq tips: 1. Several people have been wondering how to enable scsi-mq. Add this to your kernel command line (e.g., in /boot/grub/grub.conf if using grub-1): scsi_mod.use_blk_mq=Y Btw, I heard a

Re: Debugging scsi abort handling ?

2014-08-25 Thread James Bottomley
On Mon, 2014-08-25 at 13:39 +0200, Paolo Bonzini wrote: Il 25/08/2014 13:26, Hans de Goede ha scritto: Thanks Bart and Paolo, your insights into this are greatly appreciated. So with uas there are separate usb transaction for cmd, data in, data out and sense for each tag. At the time of

Re: [PATCH 1/3] libsas: modify SATA error handler

2014-08-25 Thread Dan Williams
Some more comments below. [..] + + pmp = sata_srst_pmp(link); + + msecs = 0; + now = jiffies; + if (time_after(deadline, now)) + msecs = jiffies_to_msecs(deadline - now); + + memset(tf, 0, sizeof(struct ata_taskfile)); + tf.ctl =

[PATCH 2/5] SES: generate KOBJ_CHANGE on enclosure attach

2014-08-25 Thread Song Liu
From: Song Liu [mailto:songliubrav...@fb.com] Sent: Monday, August 25, 2014 10:26 AM To: Song Liu Cc: Dan Williams; Hannes Reinecke Subject: [PATCH 2/5] SES: generate KOBJ_CHANGE on enclosure attach From: Dan Williams dan.j.willi...@intel.com In support of a /dev/disk/by-slot populated with

[PATCH 4/5] SES: add reliable slot attribute

2014-08-25 Thread Song Liu
From: Song Liu [mailto:songliubrav...@fb.com] Sent: Monday, August 25, 2014 10:26 AM To: Song Liu Cc: Dan Williams; Hannes Reinecke Subject: [PATCH 4/5] SES: add reliable slot attribute From: Dan Williams dan.j.willi...@intel.com The name provided by firmware is in a vendor specific format,

[PATCH 5/5] SES: Add power_status to SES enclosure component

2014-08-25 Thread Song Liu
From: Song Liu [mailto:songliubrav...@fb.com] Sent: Monday, August 25, 2014 10:26 AM To: Song Liu Cc: Hannes Reinecke Subject: [PATCH 5/5] SES: Add power_status to SES enclosure component Add power_status to SES enclosure component, so we can power on/off the HDDs behind the enclosure. Check

[PATCH 0/5] Feature enhancements for ses module

2014-08-25 Thread Song Liu
From: Song Liu [mailto:songliubrav...@fb.com] Sent: Monday, August 25, 2014 10:26 AM To: Song Liu Subject: [PATCH 0/5] Feature enhancements for ses module These patches include a few enhancements to ses module: 1: close potential race condition by at enclosure race condition 2,3,4: add

[PATCH 3/5] SES: add enclosure logical id

2014-08-25 Thread Song Liu
From: Song Liu [mailto:songliubrav...@fb.com] Sent: Monday, August 25, 2014 10:26 AM To: Song Liu Cc: Dan Williams; Hannes Reinecke Subject: [PATCH 3/5] SES: add enclosure logical id From: Dan Williams dan.j.willi...@intel.com Export the NAA logical id for the enclosure. This is optionally

Re: [PATCH] bnx2fc: fix incorrect DMA memory mapping in bnx2fc_map_sg()

2014-08-25 Thread Chad Dupuis
On Fri, 22 Aug 2014, Eddie Wai wrote: On Fri, 2014-08-22 at 20:12 +0200, Maurizio Lombardi wrote: Hi Chad, On 08/22/2014 02:08 PM, Chad Dupuis wrote: Eddie, Maurizio, Since it looks like there can be a difference in the pdev would it make sense instead to convert the unmap function to

Re: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread James Bottomley
On Mon, 2014-08-25 at 18:48 +, Alfredo Dal Ava Junior wrote: On Mon, 25 Aug 2014, Alan Stern wrote: Don't forget that lots of disks go crazy if you try to read from a nonexistent block, that is, one beyond the end of the disk. IMO, this bug cannot be worked around in any

Re: [PATCH v8 3/3] ahci_xgene: Fix the link down in first attempt for the APM X-Gene SoC AHCI SATA host controller driver.

2014-08-25 Thread Tejun Heo
On Sun, Aug 24, 2014 at 12:07:27AM +0530, Suman Tripathi wrote: This patch addresses two HW erratas as described below by retrying the COMRESET: 1. During speed negotiation, controller is not able to detect ALIGN at GEN3(6Gbps) within 54.6us and results in a timeout. This issue can be

Re: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread Alan Stern
On Mon, 25 Aug 2014, Alfredo Dal Ava Junior wrote: On Mon, 25 Aug 2014, Alan Stern wrote: Don't forget that lots of disks go crazy if you try to read from a nonexistent block, that is, one beyond the end of the disk. IMO, this bug cannot be worked around in any reasonable manner.

FW: [GIT PULL] First round of SCSI updates for the 3.15+ merge window

2014-08-25 Thread Hiral Shah (hishah)
Hey James, Is is possible to include attached patch? Regards, Hiral On 6/9/14, 8:02 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: This patch consists of the usual driver updates (qla2xxx, qla4xxx, lpfc, be2iscsi, fnic, ufs, NCR5380) The NCR5380 is the addition to maintained

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-25 Thread James Bottomley
On Mon, 2014-08-25 at 10:44 -0400, Alan Stern wrote: James, can you explain how the INQUIRY command in scsi_probe_lun() managed to work back in the days when multi-lun SCSI-2 devices were common? sdev-scsi_level doesn't get set when sdev is allocated, so it initially contains 0, so the LUN

Re: [RESEND][PATCH 09/10][SCSI]mpt2sas: Added module parameter 'unblock_io' to unblock IO's during disk addition

2014-08-25 Thread Praveen Krishnamoorthy
Let me try to answer this as I had worked on this defect in the async release. Martin This really sounds like a scenario you should be able to handle in Martin general (without special don't-be-broken module parameters). In the async release, we wanted this fix to be tried, tested and vetted by

RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread Alfredo Dal Ava Junior
On Mon, 15 Aug 2014 James Bottomley wrote: So how did the partition get on there at the correct size in the first place? Even under windows partition managers believe the disk size they get from the system if the disk is blank. The HDD can be partitioned outside the enclosure, when connected

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-25 Thread Alan Stern
On Mon, 25 Aug 2014, James Bottomley wrote: On Mon, 2014-08-25 at 10:44 -0400, Alan Stern wrote: James, can you explain how the INQUIRY command in scsi_probe_lun() managed to work back in the days when multi-lun SCSI-2 devices were common? sdev-scsi_level doesn't get set when sdev is

[Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=80711 --- Comment #19 from Alan Stern st...@rowland.harvard.edu --- On Mon, 25 Aug 2014, James Bottomley wrote: On Mon, 2014-08-25 at 10:44 -0400, Alan Stern wrote: James, can you explain how the INQUIRY command in scsi_probe_lun() managed to

RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread Alfredo Dal Ava Junior
On Mon, 25 Aug 2014 Alan Stern wrote: On Mon, 25 Aug 2014, Alfredo Dal Ava Junior wrote: That's right. I don't know why Windows behaves that way. Please look this output from diskpart (Windows): DISKPART list partition Partition ### Type Size Offset -

Re: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread Alan Stern
On Mon, 25 Aug 2014, Alfredo Dal Ava Junior wrote: Well, it is causing problems anyway... from user perspective, it's a Linux compatibility issue, as it works fine on Windows. I'm not an expert, but I'm wondering that if usb-storage could set capacity as UNDETERMINED/ Zero (or keep using the

RES: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread Alfredo Dal Ava Junior
On Mon, 25 Aug 2014 Alan Stern wrote: Part of the problem is that usb-storage has no way to know that anything strange is going on. It's normal for READ CAPACITY(16) to fail (this depend on the SCSI level), and it's normal for the READ CAPACITY(10) to report a value less than 2 TB. Really

[Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=80711 --- Comment #20 from Alan Stern st...@rowland.harvard.edu --- On Mon, 25 Aug 2014, Alan Stern wrote: On Mon, 25 Aug 2014, James Bottomley wrote: On Mon, 2014-08-25 at 10:44 -0400, Alan Stern wrote: James, can you explain how the

Re: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-25 Thread Oliver Neukum
On Mon, 2014-08-25 at 16:21 -0400, Alan Stern wrote: On Mon, 25 Aug 2014, Alfredo Dal Ava Junior wrote: Well, it is causing problems anyway... from user perspective, it's a Linux compatibility issue, as it works fine on Windows. I'm not an expert, but I'm wondering that if usb-storage

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-25 Thread James Bottomley
On Mon, 2014-08-25 at 17:19 -0400, Alan Stern wrote: On Mon, 25 Aug 2014, Alan Stern wrote: On Mon, 25 Aug 2014, James Bottomley wrote: On Mon, 2014-08-25 at 10:44 -0400, Alan Stern wrote: James, can you explain how the INQUIRY command in scsi_probe_lun() managed to work