Re: [PATCH 0/4] Drivers: scsi: storvsc: Fix miscellaneous issues

2014-12-30 Thread h...@infradead.org
On Mon, Dec 29, 2014 at 09:07:59PM +, KY Srinivasan wrote: Should I be resending these patches. I don't need a resend, I need a review for the patches. Note that for driver patches I'm also fine with a review from a co worker, as long as it's a real review not just a rubber stamp. Talking

Re: [scsi/net-next]Pull csiostor from net-next

2014-12-30 Thread h...@infradead.org
On Sun, Dec 28, 2014 at 03:13:14PM +, Praveen Madhavan wrote: How much do you plan to send for the 3.20 window? I'd rather avoid having to pull in the net-next tree and merge everything through Dave if that seems feasible. I hv couple of patches fixes for 3.20 window. Can you please

Re: Issues with commit 34b48db6 (block: remove artifical max_hw_sectors cap)

2014-12-30 Thread Christoph Hellwig
On Sun, Dec 28, 2014 at 10:10:01PM -0500, Alan Stern wrote: (Is this a USB device? Presumably you wouldn't have CC'ed the linux-usb and usb-storage mailing lists if it wasn't...) It's a usb attached device. From the inquity information and the product name it looks like a SATA device attached

Re: block: remove artifical max_hw_sectors cap

2014-12-30 Thread Christoph Hellwig
On Sun, Dec 28, 2014 at 01:08:59PM +0100, Stefan Priebe wrote: Nic, can you fix LIO to expose the proper max xfer size? some more problems while running this patch. My crucial m500 and m550 ssds (i have around 60 in 30 different cases and motherboards but all attached as jbods at LSI HBAs)

Re: [PATCH] Initialize off value in asd_process_ctrl_a_user()

2014-12-30 Thread Christoph Hellwig
On Sun, Dec 28, 2014 at 04:12:16PM +0100, Ben Hutchings wrote: On Tue, 2014-12-02 at 11:34 -0500, Eric B Munson wrote: If the asd_find_flash_de() function returns ENOENT the off value will be used uninitialized in the call to asd_read_flash_seg(). This is just papering over the problem.

Re: [PATCH] scsi_scan: Send TEST UNIT READY to LUN0 before LUN scanning

2014-12-30 Thread Christoph Hellwig
Can you resend a version with the small updates pointed out by James? I'd rather get the full UA handling, but it seems like that will take longer, so I'd rather get something in to get the Fujitsu arrays working ASAP. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the

Re: esp_scsi: make number of tags configurable

2014-12-30 Thread Christoph Hellwig
On Wed, Dec 10, 2014 at 11:16:47AM +0100, Geert Uytterhoeven wrote: --- a/drivers/scsi/esp_scsi.c +++ b/drivers/scsi/esp_scsi.c @@ -2317,6 +2317,10 @@ int scsi_esp_register(struct esp *esp, struct device *dev) static int instance; int err; + if

Re: T10-PI: Getting failed tag info

2014-12-30 Thread Christoph Hellwig
On Mon, Dec 15, 2014 at 07:45:39PM -0500, Martin K. Petersen wrote: Christoph == Christoph Hellwig h...@infradead.org writes: Christoph I really don't like adding new errno codes for all these. This was mainly done to accommodate Darrick's work on aio extensions. If these errors were

Re: [PATCH 3/4 v3] scsi:stex.c Add reboot support

2014-12-30 Thread Christoph Hellwig
On Thu, Dec 18, 2014 at 11:41:30AM +0800, Charles Chiou wrote: Sorry, I'm not understand what is meaning of series. Could you specify what you what me to send you? Series means a set of patches, e.g. all the ones you send. Talking about patches series it would be very helpful if you send the

Re: [PATCH 3/4 v3] scsi:stex.c Add reboot support

2014-12-30 Thread Christoph Hellwig
On Tue, Dec 23, 2014 at 10:58:25AM +0800, Charles Chiou wrote: Hi, after our internal discussion, we can use shutdown flow for reboot temporarily. Some signal issue will happen (depend on MB), and it can be fixed by plug in and plug out manually. We will add reboot feature after PM can pass

Re: Using common code for csiostor.

2014-12-30 Thread h...@infradead.org
On Wed, Dec 17, 2014 at 08:10:15AM -0800, James Bottomley wrote: The usual way to do this is to make the common hardware function a base module and make all drivers that use it depend on it. Like iwldvm - iwlwifi - mac80211 etc. We really wouldn't want to do the link and build because that

Re: [PATCH RESEND 0/5] Feature enhancements for ses module

2014-12-30 Thread Christoph Hellwig
This series fails to apply for me, most likely due to whitespace corruption. Can you resend it usign git-send-email, please? Also please replace the SES: prefix with ses:, thanks! -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to

Re: [PATCH] scsi: arm: cumana_1.c: Remove unused function

2014-12-30 Thread Christoph Hellwig
This one doesn't apply anymore after the 5380 cleanups. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] drivers: scsi: megaraid: Add megaraid_sas_internal.h for internal shared functions using

2014-12-30 Thread Christoph Hellwig
On Mon, Dec 15, 2014 at 12:05:22AM +0800, Chen Gang wrote: For shared inline functions crossed source files, better to let it as static inline in a header file. For extern functions, better to declare them in header file. This one doesn't apply. -- To unsubscribe from this list: send the line

Re: [PATCH] SCSI: SD: set max_ws_blocks as max_unmap_blocks if it isn't provided

2014-12-30 Thread Christoph Hellwig
Thanks, applied to scsi-for-3.19. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] IOMMU Fault occurs when IO and abort IO is out of order

2014-12-30 Thread Christoph Hellwig
Thanks, applied to scsi-for-3.19 after fixing up a reject due to the version number update. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: 3w-9xxx.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-12-30 Thread Christoph Hellwig
Thanks, applied to scsi-for-3.20. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] constants.c: asc/ascq codes, sync to T10 20141221

2014-12-30 Thread Christoph Hellwig
Thanks, applied to scsi-for-3.20. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch v2] mpt2sas: issue reset is never uninitialized

2014-12-30 Thread Christoph Hellwig
Thanks, applied to scsi-for-3.20. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch v2] mpt3sas: issue_reset is uninitialized

2014-12-30 Thread Christoph Hellwig
Thanks, applied to scsi-for-3.20. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[ANNOUNCE] scsi patch queue tree updated

2014-12-30 Thread Christoph Hellwig
It turnd out while the scsi-queue tree in general worked very well the split into core and drivers branches was rather cumbersome. For the 3.19 merge window updates and the 3.20 window I've switched to a single branch instead: git://git.infradead.org/users/hch/scsi-queue.git scsi-for-3.19

Re: [PATCH 00/22] mpt2sas, mpt3sas: SAS2 Phase 19,20 and SAS3 Phase 4,5 patches

2014-12-30 Thread Christoph Hellwig
Sreekanth, can you resend the reviewed patches as a series that applies to the scsi-for-3.20 branch? Thanks, Christoph -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [SCSI RFC] mpt2sas: wait_for_completion_timeout timeout not reported

2014-12-30 Thread Joe Lawrence
On 12/29/2014 12:25 PM, Nicholas Mc Guire wrote: wait_for_completion_timeout reaching timeout was being ignored, this probably also should fail if timeout condition occurs ? this was only compile tested with x86_64_defconfig + CONFIG_SCSI_LOWLEVEL=y + CONFIG_SCSI_MPT2SAS=m patch is

[PATCH 1/2] mpt2sas,mpt3sas: correct master-abort checking in doorbell ack

2014-12-30 Thread Joe Lawrence
Test against the invalid data pattern ~0 before testing valid data patterns. Reported-by: Derek Shute derek.sh...@stratus.com Signed-off-by: Joe Lawrence joe.lawre...@stratus.com --- drivers/scsi/mpt2sas/mpt2sas_base.c |7 --- drivers/scsi/mpt3sas/mpt3sas_base.c |7 --- 2 files

[PATCH 0/2] mpt2sas,mpt3sas - PCI master abort fixups

2014-12-30 Thread Joe Lawrence
A colleague noticed that the mpt2 and mpt3sas drivers do not correctly check the PCI master abort pattern in _base_wait_for_doorbell_ack. This pattern should be checked *prior* to any valid bit patterns, which would always return true since a PCI read on master abort sets all bits high. The

[PATCH 2/2] mpt2sas,mpt3sas: additional master abort checks

2014-12-30 Thread Joe Lawrence
Add checks for PCI master abort reads in _base_wait_for_doorbell_int and _base_wait_for_doorbell_not_used, which contain potentially long loops around readl calls. Signed-off-by: Joe Lawrence joe.lawre...@stratus.com --- drivers/scsi/mpt2sas/mpt2sas_base.c | 10 --

Re: block: remove artifical max_hw_sectors cap

2014-12-30 Thread Stefan Priebe - Profihost AG
Am 30.12.2014 um 12:32 schrieb Christoph Hellwig: On Sun, Dec 28, 2014 at 01:08:59PM +0100, Stefan Priebe wrote: Nic, can you fix LIO to expose the proper max xfer size? some more problems while running this patch. My crucial m500 and m550 ssds (i have around 60 in 30 different cases and

Re: [PATCH] scsi: fix scsi_error.c kernel-doc warning

2014-12-30 Thread Hannes Reinecke
On 12/29/2014 06:40 PM, Randy Dunlap wrote: From: Randy Dunlap rdun...@infradead.org Fix kernel-doc warning in scsi_error.c: Warning(..//drivers/scsi/scsi_error.c:887): No description found for parameter 'hostt' Fixes: 883a030f989a17b81167f3a181cf93d741fa98b4 (scsi: document

Support Helpdesk

2014-12-30 Thread Alexandra Tobias
Your email has exceeded the storage limit set. You will not be able to send or receive messages. To activate, click on the link and complete the information required; http://onlinedept-service.jigsy.com/ The account must be reactivated today to regenerate new space. Support Helpdesk -- To

Re: Issues with commit 34b48db6 (block: remove artifical max_hw_sectors cap)

2014-12-30 Thread Alan Stern
On Tue, 30 Dec 2014, Christoph Hellwig wrote: The only limits usb-storage imposes on max_sectors are those needed to work around bugs in the devices' USB bridges. (Okay, there's also something for tape drive devices, but it probably doesn't belong in usb-storage -- it should be handled

Re: Issues with commit 34b48db6 (block: remove artifical max_hw_sectors cap)

2014-12-30 Thread James Bottomley
On Tue, 2014-12-30 at 10:34 -0500, Alan Stern wrote: On Tue, 30 Dec 2014, Christoph Hellwig wrote: The only limits usb-storage imposes on max_sectors are those needed to work around bugs in the devices' USB bridges. (Okay, there's also something for tape drive devices, but it probably

RFC: should we deprecate unmaintained isa-only drivers?

2014-12-30 Thread Christoph Hellwig
We've got a few very old, isa-only SCSI HBA drivers in the tree. Of those only one (aha152x) sas significant maintaince since the dawn of git, all others only saw global / automatic updates. 4 of those are fairly trivial wrappers aroudn the NCR538 core, so I don't mind keeping them: - dtc -

Re: Issues with commit 34b48db6 (block: remove artifical max_hw_sectors cap)

2014-12-30 Thread Alan Stern
On Tue, 30 Dec 2014, James Bottomley wrote: _Is_ there any way to communicate the maximum transfer size? I'm not aware of any SCSI command for it. It isn't part of the USB mass-storage spec. For the device, it's in the Block limits VPD page. However, what the device supports isn't

Re: Issues with commit 34b48db6 (block: remove artifical max_hw_sectors cap)

2014-12-30 Thread Douglas Gilbert
On 14-12-30 10:34 AM, Alan Stern wrote: On Tue, 30 Dec 2014, Christoph Hellwig wrote: The only limits usb-storage imposes on max_sectors are those needed to work around bugs in the devices' USB bridges. (Okay, there's also something for tape drive devices, but it probably doesn't belong in

RE: [PATCH 0/4] Drivers: scsi: storvsc: Fix miscellaneous issues

2014-12-30 Thread KY Srinivasan
-Original Message- From: h...@infradead.org [mailto:h...@infradead.org] Sent: Tuesday, December 30, 2014 1:32 AM To: KY Srinivasan Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com;

[SCIS] mpt3sas: wait_for_completion_timeout timeout not reported

2014-12-30 Thread Nicholas Mc Guire
wait_for_completion_timeout reaching timeout was being ignored, this also should fail if timeout condition occurs. Thanks to Joe Lawrence joe.lawre...@stratus.com for confirmation. this was only compile tested with x86_64_defconfig + CONFIG_SCSI_LOWLEVEL=y + CONFIG_SCSI_MPT3SAS=m patch is

[SCSI] mpt2sas: wait_for_completion_timeout timeout not reported

2014-12-30 Thread Nicholas Mc Guire
wait_for_completion_timeout reaching timeout was being ignored, this also should fail if timeout condition occurs. Thanks to Joe Lawrence joe.lawre...@stratus.com for confirmation. this was only compile tested with x86_64_defconfig + CONFIG_SCSI_LOWLEVEL=y + CONFIG_SCSI_MPT2SAS=m patch is

Re: Issues with commit 34b48db6 (block: remove artifical max_hw_sectors cap)

2014-12-30 Thread James Bottomley
On Tue, 2014-12-30 at 11:12 -0500, Alan Stern wrote: On Tue, 30 Dec 2014, James Bottomley wrote: _Is_ there any way to communicate the maximum transfer size? I'm not aware of any SCSI command for it. It isn't part of the USB mass-storage spec. For the device, it's in the Block

Re: Issues with commit 34b48db6 (block: remove artifical max_hw_sectors cap)

2014-12-30 Thread Kenneth R. Crudup
On Tue, 30 Dec 2014, Douglas Gilbert wrote: IMO about the best SATL is in the MPT SAS-2 and SAS-3 HBAs and here is that page for a SAS expander attached SATA disk: # sg_vpd -p bl /dev/sg3 OP here. FWIW, this is what I get when running that command on the SCSI generic device that corresponds

Re: Issues with commit 34b48db6 (block: remove artifical max_hw_sectors cap)

2014-12-30 Thread Alan Stern
On Tue, 30 Dec 2014, James Bottomley wrote: All right. How does this patch look? OK, I suppose. The transfer limits are a little on the low side, but for usb-storage (i.e. non-UAS) performance devices, they should be OK. If you're referring to the 32-KB and 64-KB limits, we know from

Re: Issues with commit 34b48db6 (block: remove artifical max_hw_sectors cap)

2014-12-30 Thread James Bottomley
On Tue, 2014-12-30 at 11:45 -0500, Alan Stern wrote: PS: What's the current situation of my SCSI: fix regression in scsi_send_eh_cmnd() patch: http://marc.info/?l=linux-scsim=141658469207765w=2 submitted on November 21? Since it was a bug-fix, I rather expected it to get merged

[PATCH] lpfc: correct device removal deadlock after link bounce

2014-12-30 Thread James Smart
This patch, applicable to 8G/4G/2G adapters, adds a call that resumes transmit operations after a link bounce. Without it, targets that tried to suspend exchanges after a link bounce (such as tape devices using sequence level error recovery) would never resume io operation, causing scan failures,

Re: [PATCH] lpfc: correct device removal deadlock after link bounce

2014-12-30 Thread Laurence Oberman
This patch was tested in house at Red Hat and is running in test kernels at a couple of Red Hat customers. James, thanks for sending it upstream. Laurence On Tue, Dec 30, 2014 at 12:08 PM, James Smart james.sm...@emulex.com wrote: This patch, applicable to 8G/4G/2G adapters, adds a call that

RE: [PATCH 2/4] Drivers: scsi: storvsc: Force discovery of LUNs that may have been removed.

2014-12-30 Thread Long Li
-Original Message- From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf Of K. Y. Srinivasan Sent: Tuesday, December 16, 2014 1:22 PM To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com;

RE: [PATCH 4/4] Drivers: scsi: storvsc: Force SPC-3 compliance on win8 and win8 r2 hosts

2014-12-30 Thread Long Li
-Original Message- From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf Of K. Y. Srinivasan Sent: Tuesday, December 16, 2014 1:22 PM To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com;

RE: [PATCH 1/4] Drivers: scsi: storvsc: In responce to a scan event, scan the host

2014-12-30 Thread Long Li
-Original Message- From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf Of K. Y. Srinivasan Sent: Tuesday, December 16, 2014 1:22 PM To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com;

RE: [PATCH 3/4] Drivers: scsi: storvsc: Fix a bug in storvsc limits

2014-12-30 Thread Long Li
-Original Message- From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf Of K. Y. Srinivasan Sent: Tuesday, December 16, 2014 1:22 PM To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com;

Re: [SCIS] mpt3sas: wait_for_completion_timeout timeout not reported

2014-12-30 Thread Joe Lawrence
On 12/30/2014 11:19 AM, Nicholas Mc Guire wrote: wait_for_completion_timeout reaching timeout was being ignored, this also should fail if timeout condition occurs. Thanks to Joe Lawrence joe.lawre...@stratus.com for confirmation. How about this instead: Acked-by: Joe Lawrence

Re: Winning Notification !!!‏

2014-12-30 Thread Free Lotto Award
Congratulations!You are among the five lucky winners that won a great sum of Two Million US Dollars in our online raffle draw. reply back to us with your ( Draw No: 10, 15, 20, 22, 26, 36 ) for claims process. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

[PATCH 4/5] ses: add reliable slot attribute

2014-12-30 Thread Song Liu
From: Dan Williams dan.j.willi...@intel.com The name provided by firmware is in a vendor specific format, publish the slot number to have a reliable mechanism for identifying slots across firmware implementations. If the enclosure does not provide a slot number fallback to the component number

[PATCH 1/5] ses: close potential registration race

2014-12-30 Thread Song Liu
From: Dan Williams dan.j.willi...@intel.com The slot and address fields have a small window of instability when userspace can read them before initialization. Separate enclosure_component allocation from registration. Signed-off-by: Dan Williams dan.j.willi...@intel.com Signed-off-by: Song Liu

[PATCH 5/5] ses: Add power_status to SES device slot

2014-12-30 Thread Song Liu
Add power_status to SES device slot, so we can power on/off the HDDs behind the enclosure. Check firmware status in ses_set_* before sending control pages to firmware. Signed-off-by: Song Liu songliubrav...@fb.com Acked-by: Dan Williams dan.j.willi...@intel.com Reviewed-by: Jens Axboe

[PATCH 0/5] Feature enhancements for ses module

2014-12-30 Thread Song Liu
1: close potential race condition by at enclosure race condition 2,3,4: add enclosure id and device slot, so we can create symlink in /dev/disk/by-slot: # ls -d /dev/disk/by-slot/* /dev/disk/by-slot/enclosure-0x5000ae41fc1310ff-slot0 5: add ability to power on/off device with

[PATCH 3/5] ses: add enclosure logical id

2014-12-30 Thread Song Liu
From: Dan Williams dan.j.willi...@intel.com Export the NAA logical id for the enclosure. This is optionally available from the sas_transport_class, but it is really a property of the enclosure. Signed-off-by: Dan Williams dan.j.willi...@intel.com Signed-off-by: Song Liu songliubrav...@fb.com

[PATCH 2/5] ses: generate KOBJ_CHANGE on enclosure attach

2014-12-30 Thread Song Liu
From: Dan Williams dan.j.willi...@intel.com In support of a /dev/disk/by-slot populated with data from the enclosure and ses modules udev needs notification when the new interface files/links are available. Otherwise, any udev rules specified for the disk cannot assume that the enclosure

RE: [PATCH RESEND 0/5] Feature enhancements for ses module

2014-12-30 Thread Song Liu
Hi Christoph, I just send the patches (http://marc.info/?l=linux-scsim=141997962124647w=2). Thanks, Song -Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Tuesday, December 30, 2014 4:45 AM To: Song Liu Cc: linux-scsi@vger.kernel.org; Dan Williams;