Re: [PATCH 01/17] lpfc: Fix FCF Infinite loop in lpfc_sli4_fcf_rr_next_index_get.

On 12/17/2015 12:11 AM, James Smart wrote: Fix FCF Infinite loop in lpfc_sli4_fcf_rr_next_index_get. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 8 ++-- 1 file changed, 6

Re: [PATCH 03/17] lpfc: Added throttle logging support.

On 12/17/2015 12:11 AM, James Smart wrote: Implemented a throttle on error logging. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 5 +++ drivers/scsi/lpfc/lpfc_attr.c| 18

Re: [PATCH 04/17] lpfc: Fix RegLogin failed error seen on Lancer FC during port bounce

On 12/17/2015 12:11 AM, James Smart wrote: Fix RegLogin failed error seen on Lancer FC during port bounce Fix the statemachine and ref counting. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c

Re: Note to driver maintainers

On Wed, Dec 16, 2015 at 07:32:28PM -0500, Martin K. Petersen wrote: > > When somebody posts a patch to a piece of code you maintain it is your > responsibility to respond to it. That's what being a maintainer means. > > There are a ton of trivial/Coccinelle fixes posted that nobody has done >

Re: [PATCH 05/17] lpfc: Fix driver crash when module parameter lpfc_fcp_io_channel set to 16

On 12/17/2015 12:11 AM, James Smart wrote: Fix driver crash when module parameter lpfc_fcp_io_channel set to 16 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 9 ++--- 1 file changed, 6

Re: [PATCH 06/17] lpfc: Fix crash in fcp command completion path.

On 12/17/2015 12:11 AM, James Smart wrote: Fix crash in fcp command completion path. Missed null check. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 4 ++-- 1 file changed, 2

Re: [RFC PATCH] lpfc: Add lockdep assertions

On 12/17/2015 09:49 AM, Johannes Thumshirn wrote: On Wed, Dec 16, 2015 at 03:22:50PM -0800, James Smart wrote: Johannes, Thank you for the time and effort on the patch. At this time, as it doesn't functionally change anything, I did not include the patch. I will consider it if we see

Re: [PATCH 02/17] lpfc: Fix the FLOGI discovery logic to comply with T11 standards

On 12/17/2015 12:11 AM, James Smart wrote: Fix the FLOGI discovery logic to comply with T11 standards We weren't properly setting fabric parameters, such as R_A_TOV and E_D_TOV, when we registered the vfi object in default configs and pt2pt configs. Revise to now pass service params with the

Re: [PATCH 08/17] lpfc: Fix RDP Speed reporting.

On 12/17/2015 12:11 AM, James Smart wrote: Fix RDP Speed reporting. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff

Re: [PATCH 07/17] lpfc: Modularize and cleanup FDMI code in driver

On 12/17/2015 12:11 AM, James Smart wrote: Modularize, cleanup, add comments - for FDMI code in driver Note: I don't like the comments with leading # - but as we have a lot if present, I'm deferring to handle it in one big fix later. Signed-off-by: Dick Kennedy

Re: [PATCH 09/17] lpfc: Fix RDP ACC being too long.

On 12/17/2015 12:12 AM, James Smart wrote: Fix RDP ACC being too long. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [PATCH 16/17] lpfc: Use kzalloc instead of kmalloc

On 12/17/2015 12:12 AM, James Smart wrote: From: Punit Vara This patch is to the lpfc_els.c which resolves following warning reported by coccicheck: WARNING: kzalloc should be used for rdp_context, instead of kmalloc/memset Signed-off-by: Punit Vara

Re: [PATCH 15/17] lpfc: Delete unnecessary checks before the function call "mempool_destroy"

On 12/17/2015 12:12 AM, James Smart wrote: From: Markus Elfring The mempool_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle

Re: [PATCH 14/17] lpfc: Add logging for misconfigured optics.

On 12/17/2015 12:12 AM, James Smart wrote: Add logging for misconfigured optics acqe reported by fw. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hw4.h | 51

Re: [PATCH 10/17] lpfc: Make write check error processing more resilient

On 12/17/2015 12:12 AM, James Smart wrote: Make write check error processing more resilient. Checks to catch writes that fw reports weren't fully complete yet SCSI status indicated fine needed correction. Signed-off-by: Dick Kennedy Signed-off-by: James Smart

Re: [PATCH 11/17] lpfc: Use new FDMI speed definitions for 10G, 25G and 40G FCoE.

On 12/17/2015 12:12 AM, James Smart wrote: Use new FDMI speed definitions for 10G, 25G and 40G FCoE. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c| 2 +- drivers/scsi/lpfc/lpfc_ct.c

Re: [PATCH 12/17] lpfc: Fix mbox reuse in PLOGI completion

On 12/17/2015 12:12 AM, James Smart wrote: Fix mbox reuse in PLOGI completion. Moved allocations so that buffer properly init'd. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nportdisc.c | 31

Re: [PATCH 13/17] lpfc: Fix external loopback failure.

On 12/17/2015 12:12 AM, James Smart wrote: Fix external loopback failure. Rx sequence reassembly was incorrect. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 15 +-- 1 file

Re: [PATCH 17/17] lpfc: Update version to 11.0.0.10 for upstream patch set

On 12/17/2015 12:12 AM, James Smart wrote: Update version to 11.0.0.10 for upstream patch set Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [RFC PATCH] lpfc: Add lockdep assertions

On Wed, Dec 16, 2015 at 03:22:50PM -0800, James Smart wrote: > Johannes, > > Thank you for the time and effort on the patch. At this time, as it doesn't > functionally change anything, I did not include the patch. I will consider > it if we see additional issues it can help resolve. As I already

Re: [PATCH 1/3] scsi_debug: Increase the reported optimal transfer length

On Wed, 2015-12-16 at 17:53 -0500, Martin K. Petersen wrote: > The OPTIMAL TRANSFER LENGTH reported by scsi_debug is 64 blocks which > translates to 32KB with the default logical block size. That's much > lower than what real storage devices typically report (256KB to 1MB). > > Bump the optimal

Re: [PATCH 2/3] sd: Reject optimal transfer length smaller than page size

On Wed, 2015-12-16 at 17:53 -0500, Martin K. Petersen wrote: > Eryu Guan reported that loading scsi_debug would fail. This turned out > to be caused by scsi_debug reporting an optimal I/O size of 32KB which > is smaller than the 64KB page size on the PowerPC system in question. > > Add a check to

Re: [PATCH 3/3] block: Export max_dev_sectors_kb in sysfs

On Wed, 2015-12-16 at 17:53 -0500, Martin K. Petersen wrote: > Some storage devices report a maximum transfer length which indicates > the maximum size of an I/O request that the device can process. This > limit is enforced in combination with the controller's max_hw_sectors > and DMA constraints

Re: [PATCH 08/17] lpfc: Fix RDP Speed reporting.

On Thursday, December 17, 2015 07:47:46 AM James Smart wrote: > See patch 11/17 for the 32G additions > Right. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de+49 911 74053 688 SUSE LINUX Products GmbH,

Re: [PATCH 14/17] lpfc: Add logging for misconfigured optics.

On 12/17/2015 12:38 AM, Hannes Reinecke wrote: On 12/17/2015 12:12 AM, James Smart wrote: Why isn't this special cased anymore? Is it now supported by all HBAs? Yes - if and when/where an async event is generated by the adapter is in the fw. The special casing wasn't needed in the first

Re: [patch] qla2xxx: fix a timeout loop

> "Dan" == Dan Carpenter writes: Dan> The qlogic devs asked me to redo this patch but you have already Dan> applied it. Should I resend or redo it on top of the earlier Dan> patch. (James's tree was rebaseable for a day after a patch was Dan> "applied".) I

Re: [PATCH 03/17] lpfc: Added throttle logging support.

The real issue is when extended logging is turned on, which is not there by default, then it definitely can become a problem. I don't doubt other drivers hit it too. I can understand solving this generically and I'm sure there's much better people than I to solve the issue at the kernel

Re: [PATCH 11/17] lpfc: Use new FDMI speed definitions for 10G, 25G and 40G FCoE.

On 12/17/2015 12:32 AM, Hannes Reinecke wrote: Ah. So here is the missing 32G speed. Should be moved into the 'Fix RDP Speed reporting' patch, no? which of these 2 patches is not that meaningful. -- james -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the

Re: [PATCH 14/17] lpfc: Add logging for misconfigured optics.

On Thursday, December 17, 2015 07:51:36 AM James Smart wrote: > On 12/17/2015 12:38 AM, Hannes Reinecke wrote: > > On 12/17/2015 12:12 AM, James Smart wrote: > > > > Why isn't this special cased anymore? Is it now supported by all HBAs? > > Yes - if and when/where an async event is generated by

Re: [PATCH 11/17] lpfc: Use new FDMI speed definitions for 10G, 25G and 40G FCoE.

On Thursday, December 17, 2015 08:03:21 AM James Smart wrote: > On 12/17/2015 12:32 AM, Hannes Reinecke wrote: > > Ah. So here is the missing 32G speed. > > > > Should be moved into the 'Fix RDP Speed reporting' patch, no? > > which of these 2 patches is not that meaningful. > Yeah, and not

Re: [PATCH 08/17] lpfc: Fix RDP Speed reporting.

See patch 11/17 for the 32G additions -- james s On 12/17/2015 12:25 AM, Hannes Reinecke wrote: What happened to 32G? Has development ceased on that? Cheers, Hannes -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Patch size problem

Hi, I have a patch ready to send which contains a new UFS driver, but the problem is that the patch size is ~200K and my company' email security blocks it. Is it possible to send the driver in a tarball? Thanks, Joao -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

On 12/14/2015 05:55 PM, Martin K. Petersen wrote: >> "Hannes" == Hannes Reinecke writes: > >>> I'm not opposed to having the module option if others (Martin?) feel >>> they need it, but generally I think it's better to keep things as >>> simple as possible. So, unless there

[PATCH v2 14/16] qla2xxx: Set all queues to 4k

From: Quinn Tran set ATIO/Request/Response Queues and Default number of outstanding command to 4k. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h |3 ++-

[PATCH v2 09/16] qla2xxx: Remove dependency on hardware_lock to reduce lock contention.

From: Quinn Tran Sessions management (add, deleted, modify) currently are serialized through the hardware_lock. Hardware_lock is a high traffic lock. This lock is accessed by both the transmit & receive sides. Sessions management is now moved off to another lock call

[PATCH v2 16/16] qla2xxx: Check for online flag instead of active reset when transmitting responses

From: Dilip Kumar Uppugandla Driver has following initialization sequence for Target mode 1. Driver initialization starts 2. ISP Abort is scheduled when the target is enabled. qla2xxx [:04:00.0]-4807:25: ISP abort scheduled qla2xxx [:04:00.0]-00af:25: Performing

[PATCH v2 15/16] qla2xxx: Add bulk send for atio & ctio completion paths.

From: Quinn Tran At high traffic, the work queue can become a bottle neck. Instead of putting each command on the work queue as 1 work element, the fix would daisy chain a list of commands that came from FW/interrupt under 1 work element to reduce lock contention.

[PATCH v2 11/16] qla2xxx: Add selective command queuing

From: Quinn Tran queue work element to specific process lessen cache miss Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_isr.c |2 +-

[PATCH v2 07/16] qla2xxx: Wait for all conflicts before ack'ing PLOGI

From: Alexei Potashnik Until now ack'ing of a new PLOGI has only been delayed if there was an existing session for the same WWN. Ack was released when the session deletion completed. If there was another WWN session with the same fc_id/loop_id pair (aka "conflicting

[PATCH v2 12/16] qla2xxx: Move atioq to a different lock to reduce lock contention

From: Quinn Tran 99% of the time the ATIOQ has SCSI command. The other 1% of time is something else. Most of the time this interrupt does not need to hold the hardware_lock. We're moving the ATIO interrupt thread to a different lock to reduce lock contention.

[PATCH v2 10/16] qla2xxx: Add irq affinity notification

From: Quinn Tran Register to receive notification of when irq setting change occured. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h|6 +++

[PATCH v2 13/16] qla2xxx: Disable ZIO at start time.

From: Quinn Tran Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git

[PATCH v2 08/16] qla2xxx: Replace QLA_TGT_STATE_ABORTED with a bit.

From: Quinn Tran Replace QLA_TGT_STATE_ABORTED state with a bit because the current state of the command is lost when an abort is requested by upper layer. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani

[PATCH v2 06/16] qla2xxx: Delete session if initiator is gone from FW

From: Alexei Potashnik 1. Initiator A is logged in with fc_id(1)/loop_id(1) 2. Initiator A re-logs in with fc_id(2)/loop_id(2) 3. Part of old session deletion async logoout for 1/1 is queued 4. Initiator B logs in with fc_id(1)/loop_id(1), starts passing data and

Re: [PATCH 1/6] cxlflash: Fix to escalate LINK_RESET also on port 1

On 12/14/2015 11:30 AM, Matthew R. Ochs wrote: Acked-by: Matthew R. Ochs Reviewed-by: Uma Krishnan -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 2/6] cxlflash: Fix to avoid virtual LUN failover failure

On 12/10/2015 4:53 PM, Uma Krishnan wrote: From: "Matthew R. Ochs" Applications which use virtual LUN's that are backed by a physical LUN over both adapter ports may experience an I/O failure in the event of a link loss (e.g. cable pull). Virtual LUNs may be

Re: [PATCH 15/17] lpfc: Delete unnecessary checks before the function call "mempool_destroy"

James Smart wrote: > From: Markus Elfring > > The mempool_destroy() function tests whether its argument is NULL > and then returns immediately. Thus the test around the calls is not needed. > > This issue was detected by using the Coccinelle software. > >

NMI watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [kworker/1:1:29]

I got the following lockup on openSUSEs 4.4.0-rc5-2.g1e923a3-default kernel while unloading the lpfc module: [ 444.088002] NMI watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [kworker/1:1:29] [ 444.088002] Modules linked in: lpfc(-) qla2x00tgt(O) qla2xxx_scst(O) scst_vdisk(O)

Re: [PATCH 5/6] cxlflash: Resolve oops in wait_port_offline

On 12/10/2015 4:54 PM, Uma Krishnan wrote: From: Manoj Kumar If an async error interrupt is generated, and the error requires the FC link to be reset, it cannot be performed in the interrupt context. So a work element is scheduled to complete the link reset in a

Re: Patch size problem

Hi Joao, On Fri, Dec 18, 2015 at 3:04 AM, Joao Pinto wrote: > Hi, > I have a patch ready to send which contains a new UFS driver, but the problem > is > that the patch size is ~200K and my company' email security blocks it. > Is it possible to send the driver in a

RE: [PATCH] megaraid:Make various functions static in megaraid_sas_fusion.c

> -Original Message- > From: Nicholas Krause [mailto:xerofo...@gmail.com] > Sent: Monday, July 06, 2015 10:06 PM > To: kashyap.de...@avagotech.com > Cc: sumit.sax...@avagotech.com; uday.ling...@avagotech.com; > jbottom...@odin.com; megaraidlinux@avagotech.com; linux- >

RE: [PATCH] megaraid:Make the function megasas_alloc_cmd_fusion static

> -int > +static int > megasas_alloc_cmds_fusion(struct megasas_instance *instance) { > int i, j, count; Good catch. Let's not include patch to avoid further confusion on series of acked patch which are not making significant functional difference. NACK as not making any functional

Re: [PATCH 16/17] lpfc: Use kzalloc instead of kmalloc

James Smart wrote: > From: Punit Vara > > This patch is to the lpfc_els.c which resolves following warning > reported by coccicheck: > > WARNING: kzalloc should be used for rdp_context, instead of > kmalloc/memset > > Signed-off-by: Punit Vara >

Reviews, please

There are not a whole lot of working days left before the 4.5 merge window opens... Driver updates needing full reviews: https://patchwork.kernel.org/bundle/mkp/be2iscsi/ https://patchwork.kernel.org/bundle/mkp/qla2xxx/ lpfc looks to be in decent shape but another set of eyes

Re: [patch] qla2xxx: fix a timeout loop

On Wed, Dec 16, 2015 at 05:50:17PM -0500, Martin K. Petersen wrote: > > "Dan" == Dan Carpenter writes: > > Dan> After the loop we test for "if (!retries) " as a failure, but > Dan> actually the post-op here will end with retries set to -1. I have > Dan> fixed this

[PATCH v2 00/16] qla2xxx: Patches for target-pending branch

Hi Nic, Please apply this series to target-pending at your earliest convenience. changes from v1 -> v2 o Added Reviewed-by tag for reviewed patches. o Dropped following patches for rework. - qla2xxx: Change check_stop_free to always return 1 - qla2xxx: Fix interaction issue between qla2xxx

[PATCH v2 05/16] qla2xxx: Added interface to send explicit LOGO.

This patch adds interface to send explicit LOGO explicit LOGO using using ELS commands from driver. Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_attr.c | 36 +++

[PATCH v2 03/16] qla2xxx: Enable Target counters in DebugFS.

Following counters are added in target mode to help debugging efforts. Target Counters qla_core_sbt_cmd = 0 qla_core_ret_sta_ctio = 0 qla_core_ret_ctio = 0 core_qla_que_buf = 0 core_qla_snd_status = 0 core_qla_free_cmd = 0 num alloc iocb failed = 0 num term exchange sent = 0 num Q full sent = 0

[PATCH v2 01/16] qla2xxx: Enable Extended Logins support

This patch enables Extended Logins support in Qlogic ISP. To enable extended login with Qlogic ISP24XX/25XX/26XX, set module parameter ql2xexlogins to any non-zero number. This will alow ISP firmware to store port database structure information of remote login sessions to host memory provided by

[PATCH v2 02/16] qla2xxx: Enable Exchange offload support.

This patch enables Exchange offload support in Qlogic ISP. To enable exchange offload with Qlogic ISP24XX/25XX/26XX, set module parameter ql2xexchoffld to any non-zero number. This will alow ISP firmware to store exchange data structures used by firmware to host memory provided by driver. ISP

[PATCH v2 04/16] qla2xxx: Add FW resource count in DebugFS.

From: Quinn Tran DebugFS now will show fw_resource_count node. FW Resource count Original TGT exchg count[0] current TGT exchg count[0] original Initiator Exchange count[2048] Current Initiator Exchange count[2048] Original IOCB count[2078] Current IOCB count[2067] MAX