Re: [PATCH] 53c700: fix BUG on untagged commands

On Tue, 2016-06-14 at 08:05 -0700, Christoph Hellwig wrote: > Looks fine: > > Acked-by: Christoph Hellwig > > But it should really go together with something like this: Well, we need the simplest fix to backport, which is why I sent what I did. > --- > From

Re: [PATCH v4 0/8] Replay Protected Memory Block (RPMB) subsystem

On Tue, Jun 14, 2016 at 2:05 PM, Winkler, Tomas wrote: wrote: > Few storage technology such is EMMC, UFS, and NVMe support RPMB >hardware partition with common protocol and frame layout. > The RPMB partition cannot be accessed via standard block layer,

Re: block: don't check request size in blk_cloned_rq_check_limits()

> "Mike" == Mike Snitzer writes: >> Oh, this happens during failover? Are you sure it's not because DM is >> temporarily resetting the queue limits? max_sectors is going to be a >> single page in that case. I just discussed a backport regression in >> this department with

Re: block: don't check request size in blk_cloned_rq_check_limits()

On Tue, Jun 14 2016 at 9:39pm -0400, Martin K. Petersen wrote: > > "Hannes" == Hannes Reinecke writes: > > Hannes> Well, the primary issue is that 'blk_cloned_rq_check_limits()' > Hannes> doesn't check for BLOCK_PC, > > Yes it does. It calls

Re: [PATCH v3] storvsc: use small sg_tablesize on x86

> "Olaf" == Olaf Hering writes: Olaf> On Thu, Jun 09, James Bottomley wrote: >> On Thu, 2016-06-09 at 18:25 +0200, Olaf Hering wrote: >> > Reducing the sg_tablesize allows booting of 32bit kernels in VMs, > >> after > commit be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 ("scsi: >>

Re: [PATCH] 53c700: fix BUG on untagged commands

> "Christoph" == Christoph Hellwig writes: Christoph> But it should really go together with something like this: I completely agree with your patch but it's more of a cleanup. I'll put it in 4.8 once James' fix hits. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] 53c700: fix BUG on untagged commands

> "James" == James Bottomley writes: James> The untagged command case in the 53c700 driver has been broken James> since host wide tags were enabled because the replaced James> scsi_find_tag() function had a special case for the tag value James> SCSI_NO_TAG to

Re: [PATCH v2] scsi_debug: fix sleep in invalid context

> "Doug" == Douglas Gilbert writes: Doug> In this post: Doug> http://www.spinics.net/lists/linux-scsi/msg97124.html the author Doug> shows some kernel infrastructure complaining about a sleep in an Doug> invalid context. Remove offending call to vmalloc(). Instead of

Re: block: don't check request size in blk_cloned_rq_check_limits()

> "Hannes" == Hannes Reinecke writes: Hannes> Well, the primary issue is that 'blk_cloned_rq_check_limits()' Hannes> doesn't check for BLOCK_PC, Yes it does. It calls blk_rq_get_max_sectors() which has an explicit check for this: static inline unsigned int

Re: [PATCHv2] libfc: Update rport reference counting

> "Hannes" == Hannes Reinecke writes: Hannes> Originally libfc would just be initializing the refcount to '1', Hannes> and using the disc_mutex to synchronize if and when the final Hannes> put should be happening. This has a race condition as the mutex Hannes> might be

RE: [PATCH v4 0/8] Replay Protected Memory Block (RPMB) subsystem

>>> wrote: >>> > Few storage technology such is EMMC, UFS, and NVMe support RPMB >>> >hardware partition with common protocol and frame layout. >>> > The RPMB partition cannot be accessed via standard block layer, but >>> >by a set of specific commands: WRITE, READ, GET_WRITE_COUNTER, and >>>

Re: [PATCH] 53c700: fix BUG on untagged commands

On 14.06.2016 17:05, Christoph Hellwig wrote: > Looks fine: > > Acked-by: Christoph Hellwig > > But it should really go together with something like this: > > --- > From e54d1462ae244db3189a8b69018bc5f3e3d3b468 Mon Sep 17 00:00:00 2001 > From: Christoph Hellwig >

Re: [PATCH] 53c700: fix BUG on untagged commands

Looks fine: Acked-by: Christoph Hellwig But it should really go together with something like this: --- >From e54d1462ae244db3189a8b69018bc5f3e3d3b468 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Tue, 14 Jun 2016 17:04:10 +0200 Subject: scsi: move

Re: [RFC-v2 00/11] nvmet: Add support for multi-tenant configfs

On Tue, Jun 14, 2016 at 04:35:35AM +, Nicholas A. Bellinger wrote: > Comments..? Still no good reason for doing anything like this. On a conceptual level: The NVMe target is front end implementing a simple protocol to export block devices to a remove host. The SCSI target is larger front

Re: [PATCH v4] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

On Tue, Jun 14, 2016 at 10:46:09AM +0200, Bart Van Assche wrote: > All what's needed is something like the (untested) patch below. As one > can see no new function pointers have been added to target_core_fabric_ops. > All that has been added are a few new data members. With the patch below >

Re: mpt3sas: memory allocation for firmware upgrade DMA memory question

On Thu, May 26, 2016 at 03:46:58PM +0530, Chaitra Basappa wrote: > Johannes, > Could you please let us know which application is being used for firmware > upgrade ?? Whether it is your own customized application or LSI provided > applications? > > Also our application use single contiguous

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

On Mon, Jun 13, 2016 at 11:23:52PM -0700, Nicholas A. Bellinger wrote: > AFAICT, the problem with this improvement is that it's not stable > material, which means that Canonical would have to carry this separately > beyond linux-4.4.y, in order to support ibmvscsi-tgt. So who cares? If they have

Re: [PATCH] 53c700: fix BUG on untagged commands

On Mon, 2016-06-13 at 22:00 -0700, James Bottomley wrote: > The untagged command case in the 53c700 driver has been broken since > host wide tags were enabled because the replaced scsi_find_tag() > function had a special case for the tag value SCSI_NO_TAG to retrieve > sdev->current_cmnd. The

Re: [PATCHv2] libfc: Update rport reference counting

On Tue, May 24, 2016 at 08:11:58AM +0200, Hannes Reinecke wrote: > Originally libfc would just be initializing the refcount to '1', > and using the disc_mutex to synchronize if and when the final put > should be happening. > This has a race condition as the mutex might be delayed, causing > other

Re: [PATCH v4] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

On 06/14/2016 08:35 AM, Nicholas A. Bellinger wrote: > On Fri, 2016-06-10 at 12:05 -0700, Bart Van Assche wrote: >> On 06/09/2016 02:26 PM, Bryant G. Ly wrote: >>> +/** >>> + * ibmvscsis_modify_std_inquiry() - Modify STD Inquiry >>> + * >>> + * This function modifies the inquiry data prior to

[v3 PATCH 1/2] scsi:stex.c Support Pegasus 3 product

From: Charles Pegasus series is a RAID support product by using Thunderbolt technology. The newest product, Pegasus 3 is support Thunderbolt 3 technology with another chip. 1.Change driver version. 2.Add Pegasus 3 VID, DID and define it's device address.

[v3 PATCH 2/2] scsi:stex.c Add S6 support

From: Charles 1.Add reboot notifier and register it in stex_probe for all supported device. 2.For all supported device in restart flow, we get a callback from notifier and set S6flag for stex_shutdown & stex_hba_stop to send restart command to FW. Signed-off-by:

Re: [PATCH v4] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

On 06/09/2016 11:26 PM, Bryant G. Ly wrote: This driver is a pick up of the old IBM VIO scsi Target Driver that was started by Nick and Fujita 2-4 years ago. http://comments.gmane.org/gmane.linux.scsi/90119 What kernel version is this patch based on? It doesn't apply cleanly on top of kernel

Re: [v2 PATCH 1/2] scsi:stex.c Support Pegasus 3 product

Hi, [auto build test WARNING on scsi/for-next] [also build test WARNING on v4.7-rc3 next-20160614] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Charles-Chiou/scsi-stex-c-Support-Pegasus-3

Re: [v2 PATCH 1/2] scsi:stex.c Support Pegasus 3 product

-product/20160614-142621 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: x86_64-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 Note

Re: [PATCH] 53c700: fix BUG on untagged commands

On Mon, Jun 13, 2016 at 10:00:07PM -0700, James Bottomley wrote: > The untagged command case in the 53c700 driver has been broken since > host wide tags were enabled because the replaced scsi_find_tag() > function had a special case for the tag value SCSI_NO_TAG to retrieve > sdev->current_cmnd.

Re: Partitions not detected with firewire - 36 bytes offset - PL-3507

(sent again from another email because rejected from linux-scsi) Thanks for your detailed answer Le mardi 7 juin 2016 15:15:54, vous avez écrit : > One example would be that userland sends another INQUIRY request. Which > would be perfectly standards conforming but is highly dangerous for >

Re: [PATCH] nvmet/rdma: fix ptr_ret.cocci warnings

On Tue, 2016-06-14 at 13:25 +0800, kbuild test robot wrote: > drivers/nvme/target/rdma.c:1441:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by: Fengguang Wu

Re: [v2 PATCH 1/2] scsi:stex.c Support Pegasus 3 product

-product/20160614-142621 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: sparc64-allmodconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp

Re: [PATCH v4] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

On Fri, 2016-06-10 at 12:05 -0700, Bart Van Assche wrote: > On 06/09/2016 02:26 PM, Bryant G. Ly wrote: > > drivers/scsi/Kconfig | 27 +- > > drivers/scsi/Makefile|2 +- > > drivers/scsi/ibmvscsi/Makefile |4 + > >

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

On Fri, 2016-06-10 at 12:03 -0700, Bart Van Assche wrote: > On 05/24/2016 01:00 PM, Bryant G Ly wrote: > > Quoting Bart Van Assche : > >> On 05/24/2016 06:52 AM, Bryant G. Ly wrote: > >>> +static uint64_t ibmvscsis_unpack_lun(const uint8_t *lun, int len) > >>> +{ > >>>

[v2 PATCH 2/2] scsi:stex.c Add S6 support

From: Charles 1.Add reboot notifier and register it in stex_probe for all supported device. 2.For all supported device in restart flow, we get a callback from notifier and set S6flag for stex_shutdown & stex_hba_stop to send restart command to FW. Signed-off-by:

[v2 PATCH 1/2] scsi:stex.c Support Pegasus 3 product

From: Charles Pegasus series is a RAID support product by using Thunderbolt technology. The newest product, Pegasus 3 is support Thunderbolt 3 technology with another chip. 1.Change driver version. 2.Add Pegasus 3 VID, DID and define it's device address.