> Since f44ac12f1dcc, BG enablement is tracked with the
> LPFC_SLI3_BG_ENABLED bit, which is set in lpfc_get_cfgparam before
> lpfc_sli_config_sli_port() is called. The bit shouldn't be cleared
> before checking the feature.
James, please review.
Thanks!
--
Martin K. Petersen Oracle
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/bnx2i/bnx2i_hwi.c: In function 'bnx2i_process_ofld_cmpl':
> drivers/scsi/bnx2i/bnx2i_hwi.c:2430:6: warning:
> variable 'cid_num' set but not used [-Wunused-but-set-variable]
>
> It never used since commit
>
Christoph/Thomas: Please review. Varun has solicited feedback on this a
few times already.
Thanks!
> If number of interrupt vectors are more than num_online_cpus() then
> pci_alloc_irq_vectors_affinity() assigns cpumask based on
> num_possible_cpus() to the remaining vectors because of this
>
On 2018/11/22 11:15, Martin K. Petersen wrote:
>
> YueHaibing,
>
>> From: Yue Haibing
>>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_flogi_req':
>> drivers/scsi/libfc/fc_rport.c:866:18: warning:
>> variable 'disc' set but
Christoph,
> aha1542 is one of the last users of the legacy isa_*_to_bus APIs, which
> also isn't portable enough. Convert it to the proper DMA mapping API.
Applied to 4.21/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Shivasharan,
> This patch adds support for MegaRAID Aero controller PCI IDs.
> Throw a message when a Configurable secure type controller is
> encountered.
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Sreekanth,
> Display below warning message only up on detection of
> Configurable secure type controllers.
>
> "HBA is in Configurable Secure mode"
>
Please put a "---" separator before patch change log or any commentary
that shouldn't end up in the commit description. Fixed it up.
> v2
YueHaibing,
> From: Yue Haibing
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_flogi_req':
> drivers/scsi/libfc/fc_rport.c:866:18: warning:
> variable 'disc' set but not used [-Wunused-but-set-variable]
>
> It no used any more
David,
> The new emulate_pr backstore attribute allows for Persistent Reservation
> and SCSI2 RESERVE/RELEASE support to be completely disabled. This can be
> useful for scenarios such as:
> - Ensuring ATS (Compare & Write) usage on recent VMware ESXi initiators.
> - Allowing clustered (e.g.
On 2018/11/22 0:37, Mike Christie wrote:
On 11/20/2018 11:37 PM, Xiubo Li wrote:
[...]
-is_running = list_empty(>cmdr_queue_entry);
+is_running = test_bit(TCMU_CMD_BIT_INFLIGHT, >flags);
se_cmd = cmd->se_cmd;
if (is_running) {
@@ -1289,7 +1319,6 @@ static int
On Wed, Nov 14, 2018 at 10:17:01AM -0800, Sagi Grimberg wrote:
> If for some reason we failed to query the mr status, we need to make sure
> to provide sufficient information for an ambiguous error (guard error on
> sector 0).
>
> Fixes: 0a7a08ad6f5f ("IB/iser: Implement check_protection")
> Cc:
On Wed, 21 Nov 2018, Christoph Hellwig wrote:
> Hi all,
>
> you in the To list maintain or wrote SCSI drivers that set the
> DISABLE_CLUSTERING flag, which basically disable merges of any
> bio segments. We already have the actual max_segment size limit
> to say which length a segment should
Christoph,
for Atari SCSI, commands can only be merged if the physical addresses
of all buffers are contiguous (limitation of the Falcon DMA engine).
Documentation/scsi/scsi_mid_low_api.tx does not spell out whether that
is the case.
Atari SCSI disables scatter/gather, so if that's sufficient to
Hi Steffen,
Sorry about the delay. Travel got in the way.
>> BDI_CAP_STABLE_WRITES should take care of this. What's the configuration
>> that fails?
>
> Apologies, if the commit description sounds unfair. I did not mean to
> blame anyone. It's just the collection of issues we saw in distros
On 11/20/2018 11:37 PM, Xiubo Li wrote:
> [...]
>>> -is_running = list_empty(>cmdr_queue_entry);
>>> +is_running = test_bit(TCMU_CMD_BIT_INFLIGHT, >flags);
>>> se_cmd = cmd->se_cmd;
>>> if (is_running) {
>>> @@ -1289,7 +1319,6 @@ static int tcmu_check_expired_cmd(int id, void
Hi all,
you in the To list maintain or wrote SCSI drivers that set the
DISABLE_CLUSTERING flag, which basically disable merges of any
bio segments. We already have the actual max_segment size limit
to say which length a segment should have, independent of merged
or originally created, so this
From: Manish Rangankar
The kernel panic was observed after switch side perturbation,
BUG: unable to handle kernel NULL pointer dereference at (null)
IP: [] strcmp+0x20/0x40
PGD 0 Oops: [#1] SMP
CPU: 8 PID: 647 Comm: kworker/8:1 Tainted: GW OE
Default packet size is 0x400.
For jumbo packets set to 0x2400.
Signed-off-by: Nilesh Javali
---
drivers/scsi/qedi/qedi.h | 1 -
drivers/scsi/qedi/qedi_main.c | 13 +
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/qedi/qedi.h
Signed-off-by: Nilesh Javali
---
drivers/scsi/qedi/qedi_version.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qedi/qedi_version.h b/drivers/scsi/qedi/qedi_version.h
index 8a0e523..41bcbba 100644
--- a/drivers/scsi/qedi/qedi_version.h
+++
From: Manish Rangankar
1. Removed logic to update HW producer index in interrupt context.
2. Update HW producer index after UIO ring and buffer gets initialized.
Signed-off-by: Manish Rangankar
---
drivers/scsi/qedi/qedi_main.c | 31 +++
1 file changed, 19
The driver load on some systems failed with error,
[0004:01:00.5]:[qedi_request_msix_irq:2524]:8: request_irq failed.
Allocate the IRQs based on MSIX count obtained from qed module
instead of number of queues.
Signed-off-by: Nilesh Javali
---
drivers/scsi/qedi/qedi_main.c | 2 +-
1 file
From: Manish Rangankar
Add packet filter to avoid unnecessary packet processing in iscsiuio.
Signed-off-by: Manish Rangankar
---
drivers/scsi/qedi/qedi_main.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/scsi/qedi/qedi_main.c
Use QEDI_PAGE_SIZE for enablement of module on systems with 64K page size.
Signed-off-by: Nilesh Javali
---
drivers/scsi/qedi/qedi_main.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index
Fix trivial spelling mistake within macro definition.
Signed-off-by: Nilesh Javali
---
drivers/scsi/qedi/qedi.h | 4 ++--
drivers/scsi/qedi/qedi_main.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi.h
index
Remove redundant macro definition.
Signed-off-by: Nilesh Javali
---
drivers/scsi/qedi/qedi.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi.h
index a6f96b3..e966855 100644
--- a/drivers/scsi/qedi/qedi.h
+++ b/drivers/scsi/qedi/qedi.h
@@
Martin,
Please consider below patch set for next 'scsi-fixes' submission.
Thanks,
Nilesh
Manish Rangankar (3):
qedi: Check for session online before getting iSCSI TLV data.
qedi: Add packet filter in light L2 Rx path.
qedi: Move LL2 producer index processing in BH.
Nilesh Javali (6):
Looks good,
Reviewed-by: Christoph Hellwig
27 matches
Mail list logo