Re: [PATCH v4] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-06-15 Thread Bryant G. Ly
On 6/14/16, 9:57 AM, "Christoph Hellwig" wrote: >On Tue, Jun 14, 2016 at 10:46:09AM +0200, Bart Van Assche wrote: >> All what's needed is something like the (untested) patch below. As one >> can see no new function pointers have been added to target_core_fabric_ops. >> All

Re: [PATCH v4] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-06-15 Thread Bryant G. Ly
On 6/14/16, 3:46 AM, "Bart Van Assche" wrote: >On 06/14/2016 08:35 AM, Nicholas A. Bellinger wrote: >> On Fri, 2016-06-10 at 12:05 -0700, Bart Van Assche wrote: >>> On 06/09/2016 02:26 PM, Bryant G. Ly wrote: +/** + * ibmvscsis_modify_std_inquiry() - Modify

Re: [PATCH v4] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-06-15 Thread Bryant G. Ly
On 6/14/16, 3:09 AM, "Bart Van Assche" wrote: >On 06/09/2016 11:26 PM, Bryant G. Ly wrote: >> This driver is a pick up of the old IBM VIO scsi Target Driver >> that was started by Nick and Fujita 2-4 years ago. >> http://comments.gmane.org/gmane.linux.scsi/90119 >

Re: [PATCH v4] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-06-14 Thread Christoph Hellwig
On Tue, Jun 14, 2016 at 10:46:09AM +0200, Bart Van Assche wrote: > All what's needed is something like the (untested) patch below. As one > can see no new function pointers have been added to target_core_fabric_ops. > All that has been added are a few new data members. With the patch below >

Re: [PATCH v4] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-06-14 Thread Bart Van Assche
On 06/14/2016 08:35 AM, Nicholas A. Bellinger wrote: > On Fri, 2016-06-10 at 12:05 -0700, Bart Van Assche wrote: >> On 06/09/2016 02:26 PM, Bryant G. Ly wrote: >>> +/** >>> + * ibmvscsis_modify_std_inquiry() - Modify STD Inquiry >>> + * >>> + * This function modifies the inquiry data prior to

Re: [PATCH v4] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-06-14 Thread Bart Van Assche
On 06/09/2016 11:26 PM, Bryant G. Ly wrote: This driver is a pick up of the old IBM VIO scsi Target Driver that was started by Nick and Fujita 2-4 years ago. http://comments.gmane.org/gmane.linux.scsi/90119 What kernel version is this patch based on? It doesn't apply cleanly on top of kernel

Re: [PATCH v4] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-06-14 Thread Nicholas A. Bellinger
On Fri, 2016-06-10 at 12:05 -0700, Bart Van Assche wrote: > On 06/09/2016 02:26 PM, Bryant G. Ly wrote: > > drivers/scsi/Kconfig | 27 +- > > drivers/scsi/Makefile|2 +- > > drivers/scsi/ibmvscsi/Makefile |4 + > >

Re: [PATCH v4] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-06-10 Thread Bart Van Assche
On 06/09/2016 02:26 PM, Bryant G. Ly wrote: drivers/scsi/Kconfig | 27 +- drivers/scsi/Makefile|2 +- drivers/scsi/ibmvscsi/Makefile |4 + drivers/scsi/ibmvscsi/ibmvscsi_tgt.c | 4184 ++