Re: [RFC] FC transport: Disable LUN scanning from low level driver

2007-08-21 Thread Christof Schmitt
James, thanks for the feedback. On Mon, Aug 20, 2007 at 09:07:23PM -0400, James Smart wrote: I'd prefer a flag/bit in the fc template to indicate no scanning by the transport. Thus, it's up to the driver to call __scsi_add_device, or perform the appropriate scans... I attached a new patch

Re: [RFC] FC transport: Disable LUN scanning from low level driver

2007-08-21 Thread James Smart
Nit (but preferred) : change no_target_scan to disable_target_scan. Otherwise, patch is good. Christof Schmitt wrote: I attached a new patch that adds a flag to the fc template. So far, it is untested. What is the better approach? Avoid scanning with the flag being 1 or use the 1 to enable

Re: [RFC] FC transport: Disable LUN scanning from low level driver

2007-08-21 Thread Christof Schmitt
On Tue, Aug 21, 2007 at 09:03:17AM -0400, James Smart wrote: Nit (but preferred) : change no_target_scan to disable_target_scan. Otherwise, patch is good. Ok. I will send the fixed version in a separate mail. Yep. However, I don't agree with Hannes in this case. Given that the firmware is

[RFC] FC transport: Disable LUN scanning from low level driver

2007-08-20 Thread Christof Schmitt
The FC transport class calls scsi_scan_target with the SCAN_WILD_CARD flag to automatically scan for logical units. zfcp, on the other hand, only uses the units that are configured via the zfcp sysfs interface. The main reason for this, is that the adapter behind zfcp supports adapter sharing

Re: [RFC] FC transport: Disable LUN scanning from low level driver

2007-08-20 Thread James Smart
I'd prefer a flag/bit in the fc template to indicate no scanning by the transport. Thus, it's up to the driver to call __scsi_add_device, or perform the appropriate scans... Note: this doesn't stop the problem in absolute. as long as there's scan interfaces via sysfs, any tool/admin could