Hi Bart,
On Wed, 28 Nov 2018 08:36:19 -0800, Bart Van Assche wrote:
> Maybe I'm missing something, but why is zeroing of unused bytes in these
> functions
> necessary? Would the following be correct if all strings in struct t10_wwn
> would be
> '\0'-terminated?
Your patch looks good to me.
On Wed, 2018-11-28 at 17:28 +0100, David Disseldorp wrote:
> On Wed, 28 Nov 2018 08:08:30 -0800, Bart Van Assche wrote:
>
> > > Just a follow up here. I think it's safer to retain strncpy() in this
> > > function for the purpose of zero filling. scsi_dump_inquiry() and
> > >
On Wed, 28 Nov 2018 08:08:30 -0800, Bart Van Assche wrote:
> > Just a follow up here. I think it's safer to retain strncpy() in this
> > function for the purpose of zero filling. scsi_dump_inquiry() and
> > target_stat_lu_vend_show() walk the entire length of the t10_wwn.vendor
> > buffer.
>
>
On Wed, 2018-11-28 at 16:37 +0100, David Disseldorp wrote:
> On Tue, 20 Nov 2018 19:00:57 +0100, David Disseldorp wrote:
>
> > > > + strncpy(buf, page, sizeof(buf));
> > >
> > > Isn't strncpy() deprecated? How about using strlcpy() instead?
> >
> > Will change to use strlcpy in the
On Tue, 20 Nov 2018 19:00:57 +0100, David Disseldorp wrote:
> > > + strncpy(buf, page, sizeof(buf));
> >
> > Isn't strncpy() deprecated? How about using strlcpy() instead?
>
> Will change to use strlcpy in the next round.
Just a follow up here. I think it's safer to retain strncpy() in
On Tue, 2018-11-27 at 15:04 -0800, Bart Van Assche wrote:
> Hi Martin,
>
> The two patches in this series make the qla2xxx driver source code
> easier
> to read without changing the driver functionality. Please consider
> these
> patches for kernel v4.21.
>
> Thanks,
>
> Bart.
>
> Bart Van
On Mon, Nov 26, 2018 at 08:46:39PM +1100, Finn Thain wrote:
> On Mon, 26 Nov 2018, Christoph Hellwig wrote:
>
> > On Thu, Nov 22, 2018 at 09:02:13AM +1100, Finn Thain wrote:
> > > > you in the To list maintain or wrote SCSI drivers that set the
> > > > DISABLE_CLUSTERING flag, which basically
On 11/12/2018 12:58 AM, Martin Wilck wrote:
Since f44ac12f1dcc, BG enablement is tracked with the
LPFC_SLI3_BG_ENABLED bit, which is set in lpfc_get_cfgparam
before lpfc_sli_config_sli_port() is called. The bit
shouldn't be cleared before checking the feature.
Based on problem analysis by
Hello,
My name is ms. Reem Al-Hashimi. The UAE minister of state for international
cooparation. I got your contact from an email database from your country. I
have a financial transaction i would like to discuss with you. Please reply to
reem2...@daum.net, for more details if you are
On Mon, 26 Nov 2018, Christoph Hellwig wrote:
> On Thu, Nov 22, 2018 at 09:02:13AM +1100, Finn Thain wrote:
> > > you in the To list maintain or wrote SCSI drivers that set the
> > > DISABLE_CLUSTERING flag, which basically disable merges of any
> > > bio segments. We already have the actual
Am 26.11.2018 um 20:50 schrieb Christoph Hellwig:
On Thu, Nov 22, 2018 at 10:11:33AM +1300, Michael Schmitz wrote:
Christoph,
for Atari SCSI, commands can only be merged if the physical addresses
of all buffers are contiguous (limitation of the Falcon DMA engine).
On Thu, Nov 22, 2018 at 10:11:33AM +1300, Michael Schmitz wrote:
> Christoph,
> for Atari SCSI, commands can only be merged if the physical addresses
> of all buffers are contiguous (limitation of the Falcon DMA engine).
> Documentation/scsi/scsi_mid_low_api.tx does not spell out whether that
> is
On Thu, Nov 22, 2018 at 09:02:13AM +1100, Finn Thain wrote:
> > you in the To list maintain or wrote SCSI drivers that set the
> > DISABLE_CLUSTERING flag, which basically disable merges of any
> > bio segments. We already have the actual max_segment size limit
> > to say which length a segment
On Fri, Nov 23, 2018 at 09:09:49AM +0100, Juergen Gross wrote:
> On 21/11/2018 10:41, Christoph Hellwig wrote:
> > Hi all,
> >
> > you in the To list maintain or wrote SCSI drivers that set the
> > DISABLE_CLUSTERING flag, which basically disable merges of any
> > bio segments. We already have
On Fri, Nov 23, 2018 at 06:36:13PM +0100, David Disseldorp wrote:
> iscsi_target_mod is the only LIO fabric where fabric_ops.name differs
> from the fabric_ops.fabric_name string.
> fabric_ops.name is used when matching target/$fabric ConfigFS create
> paths, so rename it .fabric_alias and
Looks good,
Reviewed-by: Christoph Hellwig
On Fri, Nov 23, 2018 at 06:36:11PM +0100, David Disseldorp wrote:
> On write, the pi_prot_format configfs attribute invokes the device
> format_prot() callback if present. Read dumps the contents of
> se_dev_attrib.pi_prot_format , which is always zero.
> Make the configfs attribute write-only,
On 11/20/18 2:37 AM, Nilesh Javali wrote:
> From: Manish Rangankar
>
> Add packet filter to avoid unnecessary packet processing in iscsiuio.
>
> Signed-off-by: Manish Rangankar
> ---
> drivers/scsi/qedi/qedi_main.c | 24
> 1 file changed, 24 insertions(+)
>
> diff
On 11/20/18 2:37 AM, Nilesh Javali wrote:
> From: Manish Rangankar
>
> The kernel panic was observed after switch side perturbation,
>
> BUG: unable to handle kernel NULL pointer dereference at (null)
> IP: [] strcmp+0x20/0x40
> PGD 0 Oops: [#1] SMP
> CPU: 8 PID: 647 Comm:
On 11/20/18 2:37 AM, Nilesh Javali wrote:
> The driver load on some systems failed with error,
> [0004:01:00.5]:[qedi_request_msix_irq:2524]:8: request_irq failed.
>
> Allocate the IRQs based on MSIX count obtained from qed module
> instead of number of queues.
>
> Signed-off-by: Nilesh Javali
On 11/20/18 2:37 AM, Nilesh Javali wrote:
> Use QEDI_PAGE_SIZE for enablement of module on systems with 64K page size.
>
> Signed-off-by: Nilesh Javali
> ---
> drivers/scsi/qedi/qedi_main.c | 16 +---
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git
On 11/20/18 2:37 AM, Nilesh Javali wrote:
> Remove redundant macro definition.
>
> Signed-off-by: Nilesh Javali
> ---
> drivers/scsi/qedi/qedi.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi.h
> index a6f96b3..e966855 100644
> ---
On 11/20/18 2:37 AM, Nilesh Javali wrote:
> Fix trivial spelling mistake within macro definition.
>
> Signed-off-by: Nilesh Javali
> ---
> drivers/scsi/qedi/qedi.h | 4 ++--
> drivers/scsi/qedi/qedi_main.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
Linus,
> That should be last resort, what the SCSI people want is noble,
> and they did a tremendous (impressive) work by hiding all the ATA drives
> behind SCSI emulation with libata, so they want me to keep up
> that tradition by also making the temperature reading behave
> "as if it was a
On Fri, 23 Nov 2018 11:22:08 +0100, David Disseldorp wrote:
> > > Both fabric_ops.get_fabric_name() and fabric_ops.name are user facing,
> > > with the former being used for PR/ALUA state and the latter for configFS
> > > (config/target/$name), so we unfortunately need to keep both strings
> > >
On 11/23/18 12:18 AM, Linus Walleij wrote:
On Thu, Nov 22, 2018 at 9:00 PM Guenter Roeck wrote:
Can you possibly extract this as pure hwmon driver outside scsi control ?
I'll be happy to accept it as standalone hwmon driver.
That should be last resort, what the SCSI people want is noble,
On Thu, 22 Nov 2018 23:19:10 -0800, Christoph Hellwig wrote:
> On Thu, Nov 22, 2018 at 03:16:23PM +0100, David Disseldorp wrote:
> > All fabrics return a const string. In all cases *except* iSCSI the
> > get_fabric_name() string matches fabric_ops.name.
> >
> > Both fabric_ops.get_fabric_name()
On Thu, Nov 22, 2018 at 9:00 PM Guenter Roeck wrote:
> Can you possibly extract this as pure hwmon driver outside scsi control ?
> I'll be happy to accept it as standalone hwmon driver.
That should be last resort, what the SCSI people want is noble,
and they did a tremendous (impressive) work
On 21/11/2018 10:41, Christoph Hellwig wrote:
> Hi all,
>
> you in the To list maintain or wrote SCSI drivers that set the
> DISABLE_CLUSTERING flag, which basically disable merges of any
> bio segments. We already have the actual max_segment size limit
> to say which length a segment should
On Thu, Nov 22, 2018 at 03:16:23PM +0100, David Disseldorp wrote:
> All fabrics return a const string. In all cases *except* iSCSI the
> get_fabric_name() string matches fabric_ops.name.
>
> Both fabric_ops.get_fabric_name() and fabric_ops.name are user facing,
> with the former being used for
[-cc]
Hi Linus,
On 11/22/18 5:49 AM, Linus Walleij wrote:
[ ... ]
(It's
also worth noting that HDD temperature sensors are notoriously
unreliable).
I am sorry if you think that D-Link does bad engineering, what I
am trying to achieve is upstream support for this device, without
any
On 11/16/2018 12:22 PM, Hannes Reinecke wrote:
On 11/8/18 3:44 PM, Steffen Maier wrote:
would now
suppress helpful -Wswitch compiler warnings when building with W=1
But then again, only with W=1 we would notice unhandled enum cases.
that's the only caveat
Without the default cases and a
Hi Martin,
On 11/21/2018 07:13 PM, Martin K. Petersen wrote:
Sorry about the delay. Travel got in the way.
No problem.
BDI_CAP_STABLE_WRITES should take care of this. What's the configuration
that fails?
Apologies, if the commit description sounds unfair. I did not mean to
blame anyone.
> Since f44ac12f1dcc, BG enablement is tracked with the
> LPFC_SLI3_BG_ENABLED bit, which is set in lpfc_get_cfgparam before
> lpfc_sli_config_sli_port() is called. The bit shouldn't be cleared
> before checking the feature.
James, please review.
Thanks!
--
Martin K. Petersen Oracle
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/bnx2i/bnx2i_hwi.c: In function 'bnx2i_process_ofld_cmpl':
> drivers/scsi/bnx2i/bnx2i_hwi.c:2430:6: warning:
> variable 'cid_num' set but not used [-Wunused-but-set-variable]
>
> It never used since commit
>
Christoph/Thomas: Please review. Varun has solicited feedback on this a
few times already.
Thanks!
> If number of interrupt vectors are more than num_online_cpus() then
> pci_alloc_irq_vectors_affinity() assigns cpumask based on
> num_possible_cpus() to the remaining vectors because of this
>
On 2018/11/22 11:15, Martin K. Petersen wrote:
>
> YueHaibing,
>
>> From: Yue Haibing
>>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_flogi_req':
>> drivers/scsi/libfc/fc_rport.c:866:18: warning:
>> variable 'disc' set but
Christoph,
> aha1542 is one of the last users of the legacy isa_*_to_bus APIs, which
> also isn't portable enough. Convert it to the proper DMA mapping API.
Applied to 4.21/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Shivasharan,
> This patch adds support for MegaRAID Aero controller PCI IDs.
> Throw a message when a Configurable secure type controller is
> encountered.
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Sreekanth,
> Display below warning message only up on detection of
> Configurable secure type controllers.
>
> "HBA is in Configurable Secure mode"
>
Please put a "---" separator before patch change log or any commentary
that shouldn't end up in the commit description. Fixed it up.
> v2
YueHaibing,
> From: Yue Haibing
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_flogi_req':
> drivers/scsi/libfc/fc_rport.c:866:18: warning:
> variable 'disc' set but not used [-Wunused-but-set-variable]
>
> It no used any more
David,
> The new emulate_pr backstore attribute allows for Persistent Reservation
> and SCSI2 RESERVE/RELEASE support to be completely disabled. This can be
> useful for scenarios such as:
> - Ensuring ATS (Compare & Write) usage on recent VMware ESXi initiators.
> - Allowing clustered (e.g.
On 2018/11/22 0:37, Mike Christie wrote:
On 11/20/2018 11:37 PM, Xiubo Li wrote:
[...]
-is_running = list_empty(>cmdr_queue_entry);
+is_running = test_bit(TCMU_CMD_BIT_INFLIGHT, >flags);
se_cmd = cmd->se_cmd;
if (is_running) {
@@ -1289,7 +1319,6 @@ static int
On Wed, Nov 14, 2018 at 10:17:01AM -0800, Sagi Grimberg wrote:
> If for some reason we failed to query the mr status, we need to make sure
> to provide sufficient information for an ambiguous error (guard error on
> sector 0).
>
> Fixes: 0a7a08ad6f5f ("IB/iser: Implement check_protection")
> Cc:
On Wed, 21 Nov 2018, Christoph Hellwig wrote:
> Hi all,
>
> you in the To list maintain or wrote SCSI drivers that set the
> DISABLE_CLUSTERING flag, which basically disable merges of any
> bio segments. We already have the actual max_segment size limit
> to say which length a segment should
Christoph,
for Atari SCSI, commands can only be merged if the physical addresses
of all buffers are contiguous (limitation of the Falcon DMA engine).
Documentation/scsi/scsi_mid_low_api.tx does not spell out whether that
is the case.
Atari SCSI disables scatter/gather, so if that's sufficient to
Hi Steffen,
Sorry about the delay. Travel got in the way.
>> BDI_CAP_STABLE_WRITES should take care of this. What's the configuration
>> that fails?
>
> Apologies, if the commit description sounds unfair. I did not mean to
> blame anyone. It's just the collection of issues we saw in distros
On 11/20/2018 11:37 PM, Xiubo Li wrote:
> [...]
>>> -is_running = list_empty(>cmdr_queue_entry);
>>> +is_running = test_bit(TCMU_CMD_BIT_INFLIGHT, >flags);
>>> se_cmd = cmd->se_cmd;
>>> if (is_running) {
>>> @@ -1289,7 +1319,6 @@ static int tcmu_check_expired_cmd(int id, void
Looks good,
Reviewed-by: Christoph Hellwig
On 2018/11/21 11:19, Mike Christie wrote:
On 10/17/2018 02:54 AM, xiu...@redhat.com wrote:
From: Xiubo Li
[...]
diff --git a/drivers/target/target_core_user.c
b/drivers/target/target_core_user.c
index 9cd404a..00ed7bb 100644
--- a/drivers/target/target_core_user.c
+++
On 11/07/2018 07:11 AM, David Disseldorp wrote:
> The new emulate_pr backstore attribute allows for Persistent Reservation
> and SCSI2 RESERVE/RELEASE support to be completely disabled. This can be
> useful for scenarios such as:
> - Ensuring ATS (Compare & Write) usage on recent VMware ESXi
On 10/17/2018 02:54 AM, xiu...@redhat.com wrote:
> From: Xiubo Li
>
> Currently there has one cmd timeout timer and one qfull timer for
> each udev, and whenever there has any new coming cmd it will update
> the cmd timer or qfull timer. And for some corner case the timers
> are always working
Hi Manish,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on v4.20-rc3 next-20181120]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
On Tue, 2018-11-20 at 19:00 +0100, David Disseldorp wrote:
> I tend to agree that it's dangerous, but chose to stay somewhat
> consistent with the other t10_wwn strings that are treated as though
> they may not be NULL terminated.
>
> If you're in favour adding an extra terminator byte here, then
On Tue, 20 Nov 2018 09:24:39 -0800, Bart Van Assche wrote:
> On Mon, 2018-11-19 at 22:06 +0100, David Disseldorp wrote:
> > /*
> > + * STANDARD and VPD page 0x80 T10 Vendor Identification
> > + */
> > +static ssize_t target_wwn_vendor_id_show(struct config_item *item,
> > + char *page)
On Tue, 20 Nov 2018 08:49:24 -0800, Christoph Hellwig wrote:
> This could use a little more explanation, the code doesn't just
> add a little if but also changes the existing case. Also where
> can't it be null currently?
I'll add an explanation in the next round. This patch shouldn't cause
any
On Mon, 2018-11-19 at 22:06 +0100, David Disseldorp wrote:
> /*
> + * STANDARD and VPD page 0x80 T10 Vendor Identification
> + */
> +static ssize_t target_wwn_vendor_id_show(struct config_item *item,
> + char *page)
> +{
> + return sprintf(page, "T10 Vendor Identification: %."
> +
On Mon, 2018-11-19 at 22:06 +0100, David Disseldorp wrote:
> diff --git a/drivers/target/target_core_spc.c
> b/drivers/target/target_core_spc.c
> index f459118bc11b..c37dd36ec77d 100644
> --- a/drivers/target/target_core_spc.c
> +++ b/drivers/target/target_core_spc.c
> @@ -108,12 +108,17 @@
This could use a little more explanation, the code doesn't just
add a little if but also changes the existing case. Also where
can't it be null currently?
Looks good,
Reviewed-by: Christoph Hellwig
On 10/31/2018 9:40 AM, Himanshu Madhani wrote:
Signed-off-by: Himanshu Madhani
---
Reviewed-by: James Smart
-- james
On 10/31/2018 9:40 AM, Himanshu Madhani wrote:
From: Anil Gurumurthy
This patch adds SysFS node for NVMe Target configuration
Signed-off-by: Anil Gurumurthy
Signed-off-by: Himanshu Madhani
---
looks good to me.
Reviewed-by: James Smart
-- james
On 10/31/2018 9:40 AM, Himanshu Madhani wrote:
From: Anil Gurumurthy
This patch Adds following code in the driver to
support FC-NVMe Target
- Updated ql2xenablenvme to allow FC-NVMe Target operation
- Added Link Service Request handling for NVMe Target
- Added passthru IOCB for LS4 request
a couple more comments
On 10/31/2018 9:40 AM, Himanshu Madhani wrote:
+/*
+ * qla_nvmet_handle_abts
+ * Handle an abort from the initiator
+ * Invoke nvmet_fc_rcv_fcp_abort to pass the abts to the nvmet
+ */
+int qla_nvmet_handle_abts(struct scsi_qla_host *vha,
+ struct
On 10/31/2018 9:40 AM, Himanshu Madhani wrote:
From: Anil Gurumurthy
This patch adds files to enable NVMe Target Support
Signed-off-by: Anil Gurumurthy
Signed-off-by: Giridhar Malavali
Signed-off-by: Darren Trapp
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_nvmet.c |
On 10/31/2018 9:40 AM, Himanshu Madhani wrote:
From: Anil Gurumurthy
This patch provides link service pass through feature handling
in the driver. This feature is implemented mainly by the firmware
and the same implementation is handled in the driver via an
IOCB interface.
Signed-off-by:
On Mon, Nov 19, 2018 at 12:58:15AM -0800, Christoph Hellwig wrote:
> > index 5d83a162d03b..c1d5e4e36125 100644
> > --- a/drivers/scsi/scsi_lib.c
> > +++ b/drivers/scsi/scsi_lib.c
> > @@ -1635,8 +1635,11 @@ static blk_status_t scsi_mq_prep_fn(struct request
> > *req)
> >
> > static void
On 11/19/18 1:58 AM, Christoph Hellwig wrote:
>> index 5d83a162d03b..c1d5e4e36125 100644
>> --- a/drivers/scsi/scsi_lib.c
>> +++ b/drivers/scsi/scsi_lib.c
>> @@ -1635,8 +1635,11 @@ static blk_status_t scsi_mq_prep_fn(struct request
>> *req)
>>
>> static void scsi_mq_done(struct scsi_cmnd *cmd)
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org
> On Behalf Of Christoph Hellwig
> Sent: Sunday, November 11, 2018 3:32 PM
> To: ax...@kernel.dk; martin.peter...@oracle.com; o...@electrozaur.com
> Cc: Johannes Thumshirn ; Benjamin Block
> ; linux-scsi@vger.kernel.org;
> On Sun, Nov 11, 2018 at 02:32:08PM +0100, Christoph Hellwig wrote:
> > Move all actual functionality into helpers, just leaving the dispatch
> > in this function.
> >
> > Signed-off-by: Christoph Hellwig
> > ---
> > block/bsg.c | 158
>
Ping, did anyone get a chance to look at this one?
Cheers, David
don't you use 'default:' here?
I had it with default case in the first place.
Then I happened to see this and changed it:
https://lkml.org/lkml/2018/10/4/935
Re: [PATCH RESEND] drbd: avoid clang warning about pointless
switch statement
> There is nothing wrong with the code, and adding '
On 11/9/18 6:47 PM, Shivasharan S wrote:
This patch adds support for MegaRAID Aero controller PCI IDs.
Throw a message when a Configurable secure type controller is
encountered.
Signed-off-by: Shivasharan S
---
Changes in v2:
Change dev_warn to dev_info.
drivers/scsi/megaraid/megaraid_sas.h
Hi Mike
On Tue, 30 Oct 2018 10:54:07 -0500, Mike Christie wrote:
> >> This patchset removes a couple of unused error stat counters and a
> >> redundant cumulative counter.
> >> I've tagged this patchset RFC, as it may be considered a kernel<->user
> >> (configfs) API change.
> >
> > Ping, any
On 11/16/2018 12:13 PM, Hannes Reinecke wrote:
On 11/8/18 3:44 PM, Steffen Maier wrote:
The CDB is just a part inside of FCP_CMND, see zfcp_fc_scsi_to_fcp().
While at it, fix the device driver reaction: adapter not LUN shutdown.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
se in the first place.
Then I happened to see this and changed it:
https://lkml.org/lkml/2018/10/4/935
Re: [PATCH RESEND] drbd: avoid clang warning about pointless switch
statement
> There is nothing wrong with the code, and adding 'default:' labels
> in the right place is e
On 11/8/18 3:44 PM, Steffen Maier wrote:
This was introduced with v2.6.27 commit 287ac01acf22 ("[SCSI] zfcp: Cleanup
code in zfcp_erp.c") but would now suppress helpful -Wswitch compiler
warnings when building with W=1 such as the following forced example:
drivers/s390/scsi/zfcp_erp.c: In
On 11/8/18 3:44 PM, Steffen Maier wrote:
This was introduced with v4.18 commit 8c3d20aada70 ("scsi: zfcp: fix
missing REC trigger trace for all objects in ERP_FAILED") but would now
suppress helpful -Wswitch compiler warnings when building with W=1 such as
the following forced example:
On 11/8/18 3:44 PM, Steffen Maier wrote:
For some reason the already existing substring "fall through" in the
comment is not sufficient for GCC to silence -Wimplicit-fallthrough.
CC [M] drivers/s390/scsi/zfcp_erp.o
drivers/s390/scsi/zfcp_erp.c: In function 'zfcp_erp_lun_strategy':
On 11/8/18 3:44 PM, Steffen Maier wrote:
While at it also improve some copy kdoc mistakes.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_dbf.c | 13 -
drivers/s390/scsi/zfcp_erp.c | 6 +++---
drivers/s390/scsi/zfcp_fc.c | 2 +-
On 11/8/18 3:44 PM, Steffen Maier wrote:
Improve whatever the following simple invocation reported:
$ ./scripts/kernel-doc -none drivers/s390/scsi/*.h
While at it, improve some related kdoc,
including struct zfcp_fsf_ct_els in zfcp_fsf.h.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin
On 11/8/18 3:44 PM, Steffen Maier wrote:
zfcp: : LUN 0x0 on port 0x5005076. ...
zfcp: : LUN 0x1 on port 0x5005076. ...
should be
zfcp: : LUN 0x on port 0x5005076. ...
zfcp: : LUN 0x0001 on port 0x5005076.
On 11/8/18 3:44 PM, Steffen Maier wrote:
With that instead of just "int" it becomes clear which functions return
this type and which ones also accept it as argument they just pass through
in some cases or modify in other cases.
v2.6.27 commit 287ac01acf22 ("[SCSI] zfcp: Cleanup code in
On 11/8/18 3:44 PM, Steffen Maier wrote:
Use the already defined enum for this purpose to get at least some build
checking (even though an enum is type equivalent to an int in C).
v2.6.27 commit 287ac01acf22 ("[SCSI] zfcp: Cleanup code in zfcp_erp.c")
introduced the enum which was cpp defines
On 11/8/18 3:44 PM, Steffen Maier wrote:
_erp_action.action ==> _erp_action.type
While at it, make use of the already defined enum for this purpose
to get at least some build checking (even though an enum is type equivalent
to an int in C). v2.6.27 commit 287ac01acf22 ("[SCSI] zfcp: Cleanup
On 11/8/18 3:44 PM, Steffen Maier wrote:
v2.6.30 commit 5ffd51a5e495 ("[SCSI] zfcp: replace current ERP logging
with a more convenient version") changed trace record distinguishing from a
numerical ID to a 7 character string called "trace tag". While starting to
use function arguments with
On 11/8/18 3:44 PM, Steffen Maier wrote:
zfcp_erp_thread_setup() update complements v2.6.32 commit 347c6a965dc1
("[SCSI] zfcp: Use kthread API for zfcp erp thread").
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_erp.c | 2 +-
1 file changed, 1
On 11/8/18 3:44 PM, Steffen Maier wrote:
The CDB is just a part inside of FCP_CMND, see zfcp_fc_scsi_to_fcp().
While at it, fix the device driver reaction: adapter not LUN shutdown.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_fsf.c | 7 ++-
1
On 11/8/18 3:44 PM, Steffen Maier wrote:
There is no point for double bookkeeping especially just for tracing.
The trace can take it from the QTCB which always exists for non-SRB
responses traced with zfcp_dbf_hba_fsf_res().
As a side effect, this removes an alignment hole and reduces the
size
On 11/8/18 3:44 PM, Steffen Maier wrote:
Status read buffers (SRBs, unsolicited notifications) never use a QTCB
[zfcp_fsf_req_create()]. zfcp_fsf_req_send() already uses this to
distinguish SRBs from other FSF request types. We can re-use this method
in zfcp_fsf_req_complete(). Introduce
On 11/8/18 3:44 PM, Steffen Maier wrote:
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_def.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h
index 31b3e2bb3b42..572debf2f528 100644
---
On 11/8/18 3:44 PM, Steffen Maier wrote:
In contrast to struct fsf_qual_latency_info, the ones here are not FSF
but software defined zfcp-internal.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_def.h | 14 +++---
drivers/s390/scsi/zfcp_fsf.c |
On 11/8/18 3:44 PM, Steffen Maier wrote:
Have structures just before the structures that use them
(without disrupting sequences of using structures such as
zfcp_unit and zfcp_scsi_dev):
- zfcp_adapter_mempool embedded in zfcp_adapter,
- zfcp_latenc... embedded in zfcp_scsi_dev.
Signed-off-by:
On 11/8/18 3:44 PM, Steffen Maier wrote:
v2.6.10 history commit 4062e12b2ba2 ("[PATCH] s390: zfcp act enhancements")
extended this mask by one nibble with the introduction of
ZFCP_STATUS_COMMON_ACCESS_DENIED == 0x0080 for ACT
(access control table).
Signed-off-by: Steffen Maier
On 11/8/18 3:44 PM, Steffen Maier wrote:
Also clarify namespace prefix for the timeout used for FSF requests
on behalf of SCSI error recovery: It is zfcp_fsf_ not zfcp_scsi_.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_def.h | 6 --
On 11/8/18 3:44 PM, Steffen Maier wrote:
While struct zfcp_adapter contains a pointer to zfcp_reqlist,
the pointer field does not need to know the structure or even a prototype.
The prototype was introduced with v2.6.34 commit b6bd2fb92a7b ("[SCSI]
zfcp: Move FSF request tracking code to new
On 11/8/18 3:44 PM, Steffen Maier wrote:
Since commit 663e0890e31c ("[SCSI] zfcp: remove access control tables
interface") these helper functions are only used for auto port scan in
zfcp_fc.c. Also change them to the corresponding namespace prefix.
This is a small cleanup for the miscellaneous
On 11/8/18 3:44 PM, Steffen Maier wrote:
From: zhong jiang
mempool_destroy has taken null pointer check into account. so remove the
redundant check.
Signed-off-by: zhong jiang
Acked-by: Benjamin Block
[ma...@linux.ibm.com: depends on v4.3 4e3ca3e033d1 ("mm/mempool: allow NULL `pool'
On 11/12/18 9:58 AM, Martin Wilck wrote:
Since f44ac12f1dcc, BG enablement is tracked with the
LPFC_SLI3_BG_ENABLED bit, which is set in lpfc_get_cfgparam
before lpfc_sli_config_sli_port() is called. The bit
shouldn't be cleared before checking the feature.
Based on problem analysis by David
Looks good,
Reviewed-by: Johannes Thumshirn
101 - 200 of 39577 matches
Mail list logo
