[RFC] scsi: generate uevent for SCSI sense code

This patch adds capability for SCSI layer to generate uevent for SCSI sense code. The feature is gated by CONFIG_SCSI_SENSE_UEVENT. We can configure which sense keys generate uevent for each device through sysfs entry sense_event_filter. For example, the following enables uevent for MEDIUM_ERROR

[RFC] generate uevent for SCSI sense code

This change is to follow up our discussion on event log for media management during LSF/MM 2017. Please kindly let me know your thoughts on this. Thanks, Song Song Liu (1): scsi: generate uevent for SCSI sense code drivers/scsi/Kconfig | 14 +++ drivers/scsi/scsi_error.c |

[PATCH V2 31/36] smartpqi: make ioaccel references consistent

From: Kevin Barnett - make all references to RAID bypass consistent throughout driver. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH V2 36/36] smartpqi: bump driver version

From: Kevin Barnett Reviewed-by: Scott Benesh Reviewed-by: Gerry Morong Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH V2 35/36] smartpqi: remove writeq/readq function definitions

From: Corentin Labbe Instead of rewriting write/readq, use existing functions Reviewed-by: Scott Benesh Signed-off-by: Corentin Labbe Signed-off-by: Kevin Barnett Signed-off-by: Don

[PATCH V2 32/36] smartpqi: add raid level show

From: Kevin Barnett Display the RAID level via sysfs Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c | 30

[PATCH V2 33/36] smartpqi: cleanup list initialization

From: Kevin Barnett Better initialization of linked list heads. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH V2 34/36] smartpqi: add module parameters

From: Kevin Barnett Add module parameters to disable heartbeat support and to disable shutting down the controller when a controller is taken offline. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett

[PATCH V2 30/36] smartpqi: enhance device add and remove messages

From: Kevin Barnett Improved formatting of information displayed when devices are added/removed from the system. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace

[PATCH V2 29/36] smartpqi: update timeout on admin commands

From: Kevin Barnett Increase the timeout on admin commands from 3 seconds to 60 seconds and added a check for controller crash in the loop where the driver polls for admin command completion. Reviewed-by: Scott Benesh Signed-off-by: Kevin

[PATCH V2 28/36] smartpqi: map more raid errors to SCSI errors

From: Kevin Barnett enhance mapping of RAID path errors to Linux SCSI host error codes. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH V2 25/36] smartpqi: update device offline

From: Kevin Barnett - Improve handling of offline devices. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c

[PATCH V2 27/36] smartpqi: cleanup controller branding

From: Kevin Barnett - Improve controller branding support. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |

[PATCH V2 26/36] smartpqi: update rescan worker

From: Kevin Barnett improve support for taking controller offline. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH V2 24/36] smartpqi: correct aio error path

From: Kevin Barnett set the internal flag that causes I/O to be sent down the RAID path when the AIO path is disabled Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace

[PATCH V2 18/36] smartpqi: update copyright

From: Kevin Barnett Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi.h |2 +-

[PATCH V2 16/36] smartpqi: add new PCI device IDs

From: Kevin Barnett Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c | 134 +++-- 1

[PATCH V2 23/36] smartpqi: add lockup action

From: Kevin Barnett add support for actions to take when controller goes offline. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH V2 20/36] smartpqi: change return value for LUN reset operations

From: Kevin Barnett change return value for controller offline to be consistent with the rest of the driver. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace

[PATCH V2 21/36] smartpqi: enhance kdump

From: Kevin Barnett constrain resource usage during kdump to avoid kdump failures Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH V2 19/36] smartpqi: add ptraid support

From: Kevin Barnett add support for PTRAID devices Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi.h |8 --

[PATCH V2 17/36] smartpqi: cleanup messages

From: Kevin Barnett - improve some error messages. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c | 41

[PATCH V2 22/36] smartpqi: remove qdepth calculations for logical volumes

From: Kevin Barnett make the queue depth for LVs the same as the maximum I/Os supported by the controller Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace

[PATCH V2 15/36] smartpqi: minor driver cleanup

From: Kevin Barnett - remove debug code that is no longer necessary. - Some WARN_ON checks were removed because the driver continues to function when the conditions are met. - remove a MACRO that is no longer used. - remove unnecessary multi-line statements.

[PATCH V2 14/36] smartpqi: correct BMIC identify physical drive

From: Kevin Barnett correct the BMIC Identify Physical Device structure - missing 2 fields Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH V2 13/36] smartpqi: eliminate redundant error messages

From: Kevin Barnett eliminate redundant error message during initialization if the controller has crashed. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace

[PATCH V2 12/36] smartpqi: make pdev pointer names consistent

From: Kevin Barnett make all variable names for pointers to struct pci_dev consistent throughout the driver. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace

[PATCH V2 11/36] smartpqi: add pqi_wait_for_completion_io

From: Kevin Barnett Add check for controller lockup during waits for synchronous controller commands. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH V2 10/36] smartpqi: correct bdma hw bug

From: Kevin Barnett add workaround for BDMA hardware bug that can cause hw to read up to 12 SGL elements (192 bytes) beyond the last element in the list. This fix avoids IOMMU violations Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett

[PATCH V2 08/36] smartpqi: add suspend and resume support

From: Kevin Barnett add support for ACPI S3 (suspend) and S4 (hibernate) system power states. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH V2 04/36] smartpqi: add in controller checkpoint for controller lockups.

From: Kevin Barnett tell smartpqi controller to generate a checkpoint for rare lockup conditions. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Signed-off-by: Kevin Barnett

[PATCH V2 07/36] smartpqi: enhance resets

From: Kevin Barnett - Block all I/O targeted at LUN reset device. - Wait until all I/O targeted at LUN reset device has been consumed by the controller. - Issue LUN reset request. - Wait until all outstanding I/Os and LUN reset completion have been received by the

[PATCH V2 06/36] smartpqi: add supporting events

From: Kevin Barnett Only register for controller events that driver supports cleanup event handling. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH V2 03/36] smartpqi: set pci completion timeout

From: Kevin Barnett add support for setting PCIe completion timeout. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Signed-off-by: Kevin Barnett Signed-off-by: Don Brace

[PATCH V2 05/36] smartpqi: ensure controller is in SIS mode at init

From: Kevin Barnett put in SIS mode during initialization. support kexec/kdump Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Signed-off-by: Kevin Barnett Signed-off-by: Don Brace

[PATCH V2 09/36] smartpqi: add heartbeat check

From: Kevin Barnett check for controller lockups Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi.h | 60

[PATCH V2 02/36] smartpqi: cleanup interrupt management

From: Kevin Barnett minor cleanup of interrupt initialization and tear-down. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Signed-off-by: Kevin Barnett Signed-off-by: Don Brace

[PATCH V2 01/36] smartpqi: correct remove scsi devices

From: Kevin Barnett correct a problem caused by holding a spinlock during device deletion. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Signed-off-by: Kevin Barnett

[PATCH V2 00/36] smartpqi updates

These patches are based on Linus's tree The changes are: - correct remove SCSI devices - Remove spin-lock - cleanup interrupt management - minor cleanup to align with in-house driver - set PCI completion timeout - add in controller checkpoint for controller lockups. - helps debug

[GIT PULL] first round of SCSI updates for the 4.11+ merge window

This update includes the usual round of major driver updates (hisi_sas, ufs, fnic, cxlflash, be2iscsi, ipr, stex). There's also the usual amount of cosmetic and spelling stuff. The major thing you should be aware of is that there's a clash between a char dev change in the char-misc tree (adding

Re: [PATCH] scsi: lpfc: double lock typo in lpfc_ns_rsp()

On 5/3/2017 2:22 PM, Dan Carpenter wrote: There is a double lock bug here so this will deadlock instead of unlocking. Fixes: 1c5b12f76301 ("Fix implicit logo and RSCN handling for NVMET") Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/lpfc/lpfc_ct.c

[PATCH] scsi: qedf: Cleanup the type of io_log->op

We store sc_cmd->cmnd[0] which is an unsigned char in io_log->op so this should also be unsigned char. The other thing is that this is displayed in the debugfs: seq_printf(s, "0x%02x:", io_log->op); Smatch complains that the formatting won't work for negative values so changing it to

[PATCH] scsi: lpfc: double lock typo in lpfc_ns_rsp()

There is a double lock bug here so this will deadlock instead of unlocking. Fixes: 1c5b12f76301 ("Fix implicit logo and RSCN handling for NVMET") Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c index

[bug report] scsi: lpfc: NVME Initiator: Merge into FC discovery

Hello James Smart, This is a semi-automatic email about new static checker warnings. The patch a0f2d3ef374f: "scsi: lpfc: NVME Initiator: Merge into FC discovery" from Feb 12, 2017, leads to the following Smatch complaint: drivers/scsi/lpfc/lpfc_ct.c:982 lpfc_cmpl_ct_cmd_gft_id()

RE: [PATCH 20/37] smartpqi: add ptraid support

> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@sandisk.com] > Sent: Tuesday, April 25, 2017 3:13 PM > To: h...@infradead.org; Viswas G ; Gerry > Morong ; Mahesh Rajashekhara > ;

RE: [PATCH 18/37] smartpqi: cleanup messages

> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Bart Van Assche > Sent: Tuesday, April 25, 2017 3:11 PM > To: h...@infradead.org; Viswas G ; Gerry > Morong ; Mahesh

RE: [PATCH 16/37] smartpqi: minor driver cleanup

> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@sandisk.com] > Sent: Tuesday, April 25, 2017 3:10 PM > To: h...@infradead.org; Viswas G ; Gerry > Morong ; Mahesh Rajashekhara > ;

[PATCH] scsi: qedf: properly update arguments position in function call

Properly update the position of the arguments in function call. Addresses-Coverity-ID: 1402010 Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/qedf/qedf_els.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_els.c

RE: [PATCH 12/37] smartpqi: change functions to inline

> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@sandisk.com] > Sent: Tuesday, April 25, 2017 3:08 PM > To: h...@infradead.org; Viswas G ; Gerry > Morong ; Mahesh Rajashekhara > ;

RE: [PATCH 08/37] smartpqi: add suspend and resume support

> -Original Message- > On Tue, 2017-04-25 at 14:46 -0500, Don Brace wrote: > > +static int pqi_device_wait_for_pending_io(struct pqi_ctrl_info *ctrl_info, > > + struct pqi_scsi_dev *device) > > +{ > > + while (atomic_read(>scsi_cmds_outstanding)) { > > +

RE: [PATCH 07/37] smartpqi: enhance resets

> -Original Message- > On Tue, 2017-04-25 at 14:46 -0500, Don Brace wrote: > > @@ -4655,23 +4860,46 @@ static int pqi_device_reset(struct pqi_ctrl_info > *ctrl_info, > > static int pqi_eh_device_reset_handler(struct scsi_cmnd *scmd) > > { > > int rc; > > + struct Scsi_Host

Re: [PATCH v2] ibmvscsis: Do not send aborted task response

On 5/3/17 11:38 AM, Bryant G. Ly wrote: Hi Nick, On 5/2/17 10:43 PM, Nicholas A. Bellinger wrote: On Tue, 2017-05-02 at 13:54 -0500, Bryant G. Ly wrote: The driver is sending a response to the actual scsi op that was aborted by an abort task TM, while LIO is sending a response to the abort

Re: [scsi-qedf] question about parameter ordering

On Wed, 3 May 2017, 2:36pm, Randy Dunlap wrote: > On 05/03/17 11:29, Chad Dupuis wrote: > > > > On Wed, 3 May 2017, 1:58pm, Gustavo A. R. Silva wrote: > > > >> > >> Hello everybody, > >> > >> While looking into Coverity ID 1402011 I ran into the following piece of > >> code > >> at

Re: [scsi-qedf] question about parameter ordering

On 05/03/17 11:29, Chad Dupuis wrote: > > On Wed, 3 May 2017, 1:58pm, Gustavo A. R. Silva wrote: > >> >> Hello everybody, >> >> While looking into Coverity ID 1402011 I ran into the following piece of code >> at drivers/scsi/qedf/qedf_io.c:2057: >> >> /* Fill FC header */ >> fc_hdr =

Re: [scsi-qedf] question about parameter ordering

Hi Chad, Quoting Chad Dupuis : On Wed, 3 May 2017, 1:58pm, Gustavo A. R. Silva wrote: Hello everybody, While looking into Coverity ID 1402011 I ran into the following piece of code at drivers/scsi/qedf/qedf_io.c:2057: /* Fill FC header */ fc_hdr =

Re: [scsi-qedf] question about parameter ordering

On Wed, 3 May 2017, 1:58pm, Gustavo A. R. Silva wrote: > > Hello everybody, > > While looking into Coverity ID 1402011 I ran into the following piece of code > at drivers/scsi/qedf/qedf_io.c:2057: > > /* Fill FC header */ > fc_hdr = &(tm_req->req_fc_hdr); > sid = fcport->sid; > did =

Re: [PATCH] sd: Ignore sync cache failures when not supported

On Thu, 2017-03-16 at 17:48 +0100, Thierry Escande wrote: > -static int sd_sync_cache(struct scsi_disk *sdkp) > +static int sd_sync_cache(struct scsi_disk *sdkp, int *sense_key) > { > int retries, res; > struct scsi_device *sdp = sdkp->device; Hello Thierry, Both in the SCSI spec

[scsi-qedf] question about parameter ordering

Hello everybody, While looking into Coverity ID 1402011 I ran into the following piece of code at drivers/scsi/qedf/qedf_io.c:2057: /* Fill FC header */ fc_hdr = &(tm_req->req_fc_hdr); sid = fcport->sid; did = fcport->rdata->ids.port_id; __fc_fill_fc_hdr(fc_hdr, FC_RCTL_DD_UNSOL_CMD, sid,

Re: [PATCH RFC] scsi: wait sd probing in manual scan

On Fri, 2017-04-28 at 15:48 +0800, Peng Tao wrote: > We have a guest init programe trying to mount a device after doing scsi host > scan > at boot time. Occasionally it fails to find the device when mounting. After > digging > a bit, it seems the root cause is sd async_schedule probing. > >

[PATCH v2] Avoid that scsi_exit_rq() triggers a use-after-free

Dereferencing shost from scsi_exit_rq() is not safe because the SCSI host may already have been freed when scsi_exit_rq() is called. Increasing the shost reference count in scsi_init_rq() and dropping that reference in scsi_exit_rq() is nontrivial since scsi_host_dev_release() may sleep and since

Re: [PATCH, RFC] MAINTAINERS: update OSD entries

On Wed, May 3, 2017 at 1:08 PM, Boaz Harrosh wrote: > > On 05/02/2017 02:33 PM, Jeff Layton wrote: > > On Tue, 2017-05-02 at 09:57 +0200, Christoph Hellwig wrote: > >> The open-osd domain doesn't exist anymore, and mails to the list lead > >> to really annoying bounced that

Re: [PATCH v2] ibmvscsis: Do not send aborted task response

Hi Nick, On 5/2/17 10:43 PM, Nicholas A. Bellinger wrote: On Tue, 2017-05-02 at 13:54 -0500, Bryant G. Ly wrote: The driver is sending a response to the actual scsi op that was aborted by an abort task TM, while LIO is sending a response to the abort task TM. ibmvscsis_tgt does not send the

[PATCH] scsi: pmcraid: remove redundant check to see if request_size is less than zero

From: Colin Ian King The 2nd check to see if request_size is less than zero is redundant because the first check takes error exit path on this condition. So, since it is redundant, remove it. Detected by CoverityScan, CID#146149 ("Logically Dead Code") Signed-off-by:

Re: [PATCH] Avoid that scsi_exit_rq() triggers a use-after-free

On Wed, 2017-05-03 at 09:54 +0200, Jan Kara wrote: > Hum, since this didn't quite work out, how about storing that one bit of > information that scsi_exit_rq() needs from shost inside scsi_cmnd during > scsi_init_rq()? Hello Jan, All what's missing from the patch I posted is a

Re: [PATCH] Avoid that scsi_exit_rq() triggers a use-after-free

On Tue, 2017-05-02 at 17:00 -0600, Scott Bauer wrote: > I've applied this on-top of Jens' For-Linus and re-ran the test. I get the > following scheduling > while atomic BUG() splat: > > [ 35.753764] BUG: scheduling while atomic: swapper/0/0/0x0100 > [ 35.754333] [ ... ] > [ 35.765844]

RE: [PATCH 05/37] smartpqi: ensure controller is in SIS mode at init

> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@sandisk.com] > Sent: Tuesday, April 25, 2017 2:58 PM > To: h...@infradead.org; Viswas G ; Gerry > Morong ; Mahesh Rajashekhara > ;

RE: [PATCH 02/37] smartpqi: cleanup interrupt management

> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@sandisk.com] > Sent: Tuesday, April 25, 2017 2:55 PM > To: h...@infradead.org; Viswas G ; Gerry > Morong ; Mahesh Rajashekhara > ;

Re: [PATCH 25/27] block: remove the discard_zeroes_data flag

On Tue, May 02 2017 at 11:33pm -0400, Nicholas A. Bellinger wrote: > On Tue, 2017-05-02 at 09:23 +0200, h...@lst.de wrote: > > On Tue, May 02, 2017 at 12:16:13AM -0700, Nicholas A. Bellinger wrote: > > > Or, another options is use bdev_write_zeroes_sectors() to determine

Re: [PATCH, RFC] MAINTAINERS: update OSD entries

On 05/02/2017 02:33 PM, Jeff Layton wrote: > On Tue, 2017-05-02 at 09:57 +0200, Christoph Hellwig wrote: >> The open-osd domain doesn't exist anymore, and mails to the list lead >> to really annoying bounced that repeat every day. >> >> Also the primarydata address for Benny bounces, and while I

Re: [PATCH] Avoid that scsi_exit_rq() triggers a use-after-free

On Tue 02-05-17 10:43:30, Bart Van Assche wrote: > This patch fixes the following KASAN complaint: > > == > BUG: KASAN: use-after-free in scsi_exit_rq+0xf3/0x120 at addr 8802b7fedf00 > Read of size 1 by task rcuos/5/53 > CPU: 7

Re:

With profound love in my heart, I Kindly Oblige your interest to very important proposal.. It is Truly Divine and require your utmost attention.. S hlubokou láskou v mém srdci, Laskave jsem prinutit svuj zájem k návrhu .. Je velmi duležité, skutecne Divine a vyžadují vaši nejvyšší

[PATCH 1/3] target: Fix compare_and_write_callback handling for non GOOD status

From: Nicholas Bellinger Following the bugfix for handling non SAM_STAT_GOOD COMPARE_AND_WRITE status during COMMIT phase in commit 9b2792c3da1, the same bug exists for the READ phase as well. This would manifest first as a lost SCSI response, and eventual hung task during

[PATCH 3/3] target: Don't force session reset if queue_depth does not change

From: Nicholas Bellinger Keeping in the idempotent nature of target_core_fabric_configfs.c, if a queue_depth value is set and it's the same as the existing value, don't attempt to force session reinstatement. Reported-by: Raghu Krishnamurthy Cc: Raghu

[PATCH 2/3] iscsi-target: Set session_fall_back_to_erl0 when forcing reinstatement

From: Nicholas Bellinger While testing modification of per se_node_acl queue_depth forcing session reinstatement via lio_target_nacl_cmdsn_depth_store() -> core_tpg_set_initiator_node_queue_depth(), a hung task bug triggered when changing cmdsn_depth invoked session

[PATCH 0/3] target: Fixes for v4.12-rc1

From: Nicholas Bellinger Hi all, Here are a couple of fixes from the last weeks testing while continuing longevity and scale out workloads on v4.x target code. This series contains three patches. The first is to address a COMPARE_AND_WRITE se_cmd reference leak where the